ncore 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fc0cd2d836140813317acebb7edd9b8adabf96c3
-  data.tar.gz: ae9dec97a381f7ec33f6787b392a279e93fd8802
+  metadata.gz: ef94f6b1037f27d30294786117a465ad2f884c18
+  data.tar.gz: 105361f8d4f0cc2639078bc48053d20ddaa6e9f1
 SHA512:
-  metadata.gz: 7391569e6594e7e37ad20360c7da20a5ca1383712ddc14ff075c2e486d9d9ccb920a2af87430557eb63b7b01d048380e19fc8352e1466f9bf8f4c9bb82f57a01
-  data.tar.gz: e1989c0fdd27354b892245adc38aefb3f75a664e7bc81e5d038b449287eb221fcd8b2a44f83755b33cab82969f5f3f0879530f0e4a0b8e3feb3965789add2c60
+  metadata.gz: 14c748af57d663dcf4b7881e1ed6cda3df04105310a3858095e853bc7be8f5b1cd9016ec5c10f498b1de0736f3b501658947ed490f906c219461938378266d0a
+  data.tar.gz: 311dee415e76cbb165e19114502b47124b1c5c9d8cc819ca8998e9b8d59cafe8efd2c4cf3bf52a1e6336950f036e22d412907198f90580e736891d1a73d97ac2

data/lib/ncore/associations.rb

@@ -20,8 +20,6 @@ module NCore
       class_eval <<-M2, __FILE__, __LINE__+1
         def find_#{assoc.singularize}(aid, params={})
           raise UnsavedObjectError unless id
-          ## #{assoc}.detect{|o| o.id == aid} || raise(RecordNotFound)
-          # @attribs[:#{assoc}].detect{|o| o.id == aid} || #{klass}.find(aid, {#{key}: id}, api_creds)
           #{klass}.find(aid, {#{key}: id}.reverse_merge(params), api_creds)
         end
       M2
@@ -38,6 +36,8 @@ module NCore
           obj = find_#{assoc.singularize}(aid)
           obj.update(params)
           obj
+          # raise UnsavedObjectError unless id
+          # #{klass}.update(aid, {#{key}: id}.reverse_merge(params), api_creds)
         end
       M4
       class_eval <<-M5, __FILE__, __LINE__+1
@@ -52,8 +52,52 @@ module NCore
           obj.save!(params)
         end
       M6
+      # will always return the object; check .errors? or .valid? to see how it went
+      class_eval <<-M7, __FILE__, __LINE__+1
+        def delete_#{assoc.singularize}(aid, params={})
+          obj = find_#{assoc.singularize}(aid)
+          obj.delete(params)
+          obj
+          # raise UnsavedObjectError unless id
+          # #{klass}.delete(aid, {#{key}: id}.reverse_merge(params), api_creds)
+        end
+      M7
+      class_eval <<-M8, __FILE__, __LINE__+1
+        def delete_#{assoc.singularize}!(aid, params={})
+          raise UnsavedObjectError unless id
+          #{klass}.delete!(aid, {#{key}: id}.reverse_merge(params), api_creds)
+        end
+      M8
     end
 
+    # def embeds_many(assoc)
+    #   assoc = assoc.to_s
+    #   class_eval <<-M1, __FILE__, __LINE__+1
+    #     def #{assoc}(params={})
+    #       @attribs[:#{assoc}] ||= []
+    #     end
+    #   M1
+    #   class_eval <<-M2, __FILE__, __LINE__+1
+    #     def find_#{assoc.singularize}(aid)
+    #       #{assoc}.detect{|o| o.id == aid} || raise(RecordNotFound)
+    #     end
+    #   M2
+    # 
+    #   # appease activerecord:
+    #   class_eval <<-M3, __FILE__, __LINE__+1
+    #     def #{assoc}_attributes=(v)
+    #       v = v.values if v.is_a?(Hash)
+    #       if v.is_a?(Array)
+    #         v.each{|o| o['object'] ||= '#{assoc.singularize}' if o.is_a?(Hash) }
+    #         @attribs[:#{assoc}] = self.class.interpret_type(v, api_creds)
+    #       else
+    #         @attribs[:#{assoc}] = v
+    #       end
+    #     end
+    #     alias :#{assoc}= :#{assoc}_attributes=
+    #   M3
+    # end
+
     def belongs_to(assoc, klass=nil)
       assoc = assoc.to_s
       klass ||= "#{module_name}::#{assoc.camelize}"
@@ -61,6 +105,7 @@ module NCore
         attr :#{assoc}_id
         def #{assoc}(params={})
           return nil unless #{assoc}_id
+#          @attribs[:#{assoc}] ||= #{klass}.find(#{assoc}_id, params, api_creds)
           if params.empty?
             # only cache unfiltered, default api call
             @attribs[:#{assoc}] ||= #{klass}.find(#{assoc}_id, {}, api_creds)

data/lib/ncore/base.rb

@@ -28,7 +28,7 @@ module NCore
     end
 
     def url
-      "#{self.class.url}/#{CGI.escape id||'-'}"
+      "#{self.class.url}/#{CGI.escape((id||'-').to_s)}"
     end
 
   end

data/lib/ncore/client.rb

@@ -200,7 +200,9 @@ module NCore
           raise parent::AccessDenied, "Access denied; check your API credentials and permissions."
         when 404
           raise parent::RecordNotFound
-        when 422
+        # when 409
+        #   raise parent::Conflict
+        when 422, 409 # todo: is this really universally true (check both AR + PS)
           # pass through
         when 429
           raise parent::RateLimited

data/lib/ncore/configuration.rb

@@ -48,8 +48,13 @@ module NCore
 
         mattr_accessor :logger
         self.logger = Logger.new(STDOUT)
+        # self.logger.level = Logger::DEBUG
       end
 
+      # def credentials=(v)
+      #   super v.with_indifferent_access
+      # end
+
     end
 
   end

data/lib/ncore/methods/delete.rb

@@ -3,10 +3,17 @@ module NCore
     extend ActiveSupport::Concern
 
     module ClassMethods
-      def delete(id, params={}, api_creds=nil)
+      def delete!(id, params={}, api_creds=nil)
         obj = new({id: id}, api_creds)
         obj.delete(params) || raise(parent::RecordInvalid, obj)
       end
+
+      # always returns a new object; check .errors? or .valid? to see how it went
+      def delete(id, params={}, api_creds=nil)
+        obj = new({id: id}, api_creds)
+        obj.delete(params)
+        obj
+      end
     end
 
     def delete(params={})

data/lib/ncore/methods/update.rb

@@ -8,9 +8,11 @@ module NCore
         obj.save!(attribs)
       end
 
+      # always returns a new object; check .errors? or .valid? to see how it went
       def update(id, attribs, api_creds=nil)
         obj = new({id: id}, api_creds)
         obj.save(attribs)
+        obj
       end
     end
 

data/lib/ncore/version.rb

@@ -1,3 +1,3 @@
 module NCore
-  VERSION = '1.1.0'
+  VERSION = '1.2.0'
 end

data/ncore.gemspec

@@ -7,10 +7,12 @@ Gem::Specification.new do |spec|
   spec.name          = "ncore"
   spec.version       = NCore::VERSION
   spec.authors       = ["thomas morgan"]
-  spec.email         = ["tm@notioneer.com"]
+  spec.email         = ["hello@notioneer.com"]
   spec.description   = %q{NCore - Ruby gem useful for building REST API clients}
   spec.summary       = %q{NCore - Gem for building REST API clients}
+  # spec.homepage      = "https://github.com/notioneer/ncore-ruby"
   spec.homepage      = 'http://notioneer.com/'
+  # spec.homepage      = 'https://authrocket.com/'
   spec.license       = "MIT"
 
   spec.files         = `git ls-files`.split($/)

metadata

@@ -1,99 +1,99 @@
 --- !ruby/object:Gem::Specification
 name: ncore
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - thomas morgan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-09 00:00:00.000000000 Z
+date: 2015-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '5.0'
 - !ruby/object:Gem::Dependency
   name: excon
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.32'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.32'
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.7'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: NCore - Ruby gem useful for building REST API clients
 email:
-- tm@notioneer.com
+- hello@notioneer.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - LICENSE
 - README.md
@@ -141,17 +141,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.6
+rubygems_version: 2.4.3
 signing_key: 
 specification_version: 4
 summary: NCore - Gem for building REST API clients