nbp_exchange 0.0.3 → 0.0.4

data/spec/nbp_exchange/currency_spec.rb

@@ -3,32 +3,30 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 module NbpExchange
   describe Currency do
 
-    let!(:currency){Currency.new(CURRENCY_SYMBOL)}
+    let!(:currency){ Currency.new(CURRENCY_SYMBOL) }
 
     describe "#name" do
       it "shoud have name" do
-        currency.name.should == "Euro"
+        expect(currency.name).to eq "Euro"
       end
     end
 
     describe "#rate" do
       context "When rate exists" do
-        let(:expected){Rate.new(currency, EXCHANGE_DATE, 4.4146)}
+        let(:expected){ Rate.new(currency, EXCHANGE_DATE, 4.4146) }
 
         it "should return average rate for given date" do
           r = currency.rate(EXCHANGE_DATE)
-          r.average_exchange_rate.should == expected.average_exchange_rate
+          expect(r.average_exchange_rate).to eq expected.average_exchange_rate
         end
       end
 
       context "when rate doesn't exists for this date" do
-
         it "should raise error" do
-          lambda {
-            r = currency.rate("2001-01-01")
-          }.should raise_error(NbpExchange::NoXMLForThisDate)
+          expect {
+            currency.rate("2001-01-01")
+          }.to raise_error(NbpExchange::NoXMLForThisDate)
         end
-
       end
     end
   end

data/spec/nbp_exchange/currency_xml_spec.rb

@@ -4,22 +4,34 @@ module NbpExchange
   describe CurrencyXml do
 
     let(:xml){ CurrencyXml.new(EXCHANGE_DATE)}
+    let(:file_path) { File.expand_path('../../fixtures/xml_names_list.txt', __FILE__) }
+    let(:xml_names_list) { File.read(file_path) }
 
-    describe "#xml_name" do
+    before do
+      expect(xml).to receive(:xml_names_list).and_return(xml_names_list)
+    end
 
-      it "should return proper name for the date" do
-        xml.xml_name.should == "11a212.xml"
+    describe "#xml_name" do
+      context "when date is #{EXCHANGE_DATE}" do
+        it "should return proper name for the date" do
+          expect(xml.xml_name).to eq "11a212.xml"
+        end
       end
 
+      context "when there is no xml for that date" do
+        it 'raises exception' do
+          xml.date = Date.new(2012,9,1)
+
+          expect { xml.xml_name }.to raise_error(NoXMLForThisDate)
+        end
+      end
     end
 
     describe "open_xml" do
-
       it "should return tabla_kursow" do
         file = xml.open_xml
-        file[/tabela_kursow/i].should == "tabela_kursow"
+        expect(file[/tabela_kursow/i]).to eq "tabela_kursow"
       end
-
     end
   end
 end

data/spec/nbp_exchange/integration_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+describe 'Currency rate' do
+
+  describe 'averate_exchange_rate' do
+    let(:currency) { NbpExchange::Currency.new(CURRENCY_SYMBOL) }
+
+    context 'when date after 2012-09-26' do
+      let(:date) { Date.parse("2012-10-19") }
+
+      it 'returns rate for given date' do
+        expect(currency.rate(date).average_exchange_rate).to eq 4.1103
+      end
+    end
+
+    context 'date before 2012-09-26' do
+      let(:date) { Date.parse("2012-09-25") }
+
+      it 'returns rate for given date' do
+        expect(currency.rate(date).average_exchange_rate).to eq 4.1475
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,19 +1,8 @@
 require "rspec"
-#require 'fakeweb'
-#require 'vcr'
 require 'nbp_exchange'
 require 'date'
 
-#FakeWeb.allow_net_connect = false
-
-#VCR.config do |c|
-  #c.cassette_library_dir     = 'spec/cassettes'
-  #c.stub_with                  :fakeweb
-  #c.default_cassette_options = { :record => :once }
-#end
-
 RSpec.configure do |config|
-  #config.extend VCR::RSpec::Macros
 end
 
 CURRENCY_SYMBOL = 'eur'

metadata

@@ -1,62 +1,45 @@
 --- !ruby/object:Gem::Specification
 name: nbp_exchange
 version: !ruby/object:Gem::Version
-  version: 0.0.3
-  prerelease: 
+  version: 0.0.4
 platform: ruby
 authors:
 - Michal Wrobel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-05 00:00:00.000000000Z
+date: 2014-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &70290708337720 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70290708337720
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: &70290708337240 !ruby/object:Gem::Requirement
-    none: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: *70290708337240
 - !ruby/object:Gem::Dependency
-  name: vcr
-  requirement: &70290708336820 !ruby/object:Gem::Requirement
-    none: false
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.1'
   type: :development
   prerelease: false
-  version_requirements: *70290708336820
-- !ruby/object:Gem::Dependency
-  name: fakeweb
-  requirement: &70290708336400 !ruby/object:Gem::Requirement
-    none: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: *70290708336400
-description: ! 'Get average exchange rate for PLN polski zloty from specific date.
-  This lib wraps http://rss.nbp.pl/kursy/xml2/2011/a/dir.aspx site. '
+        version: '3.1'
+description: 'Get average exchange rate for PLN polski zloty from specific date. This
+  lib wraps http://rss.nbp.pl/kursy/xml2/2011/a/dir.aspx site. '
 email:
 - sparrovv@gmail.com
 executables: []
@@ -64,6 +47,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - README.md
 - Rakefile
@@ -74,39 +58,37 @@ files:
 - lib/nbp_exchange/rate.rb
 - lib/nbp_exchange/version.rb
 - nbp_exchange.gemspec
-- spec/cassettes/xml.yml
+- spec/fixtures/xml_names_list.txt
 - spec/nbp_exchange/currency_spec.rb
 - spec/nbp_exchange/currency_xml_spec.rb
-- spec/nbp_exchange/rate_spec.rb
+- spec/nbp_exchange/integration_spec.rb
 - spec/spec_helper.rb
 homepage: ''
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: nbp_exchange
-rubygems_version: 1.8.10
+rubygems_version: 2.0.14
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: NBP average exchange rates for PLN
 test_files:
-- spec/cassettes/xml.yml
+- spec/fixtures/xml_names_list.txt
 - spec/nbp_exchange/currency_spec.rb
 - spec/nbp_exchange/currency_xml_spec.rb
-- spec/nbp_exchange/rate_spec.rb
+- spec/nbp_exchange/integration_spec.rb
 - spec/spec_helper.rb
-has_rdoc: 

data/spec/nbp_exchange/rate_spec.rb

@@ -1,15 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-module NbpExchange
-
-  describe Rate do
-    let(:currency){Currency.new(CURRENCY_SYMBOL)}
-    let(:rate){Rate.new(currency, EXCHANGE_DATE, 12)}
-
-    describe ".parse" do
-      it "should parse rate from xml object" do
-      end
-    end
-
-  end
-end