nba 0.0.3 → 0.1.1

data/spec/game_spec.rb

@@ -0,0 +1,40 @@
+require 'spec_helper'
+
+describe NBA::Game, '.all' do
+  before :all do
+    @date = '20140104'
+  end
+
+  subject { described_class.scoreboard(@date) }
+
+  context 'with timeout' do
+    before do
+      stub_request(:get, 'http://scores.espn.go.com/nba/scoreboard').with(:query => {:date => @date}).to_timeout
+    end
+
+    it 'does not raise an exception' do
+      expect { subject }.not_to raise_exception
+    end
+  end
+
+  context 'without connection' do
+    before do
+      stub_request(:get, 'http://scores.espn.go.com/nba/scoreboard').with(:query => {:date => @date}).to_raise(SocketError)
+    end
+
+    it 'does not raise an exception' do
+      expect { subject }.not_to raise_exception
+    end
+  end
+
+  context 'with no route to host' do
+    before do
+      stub_request(:get, 'http://scores.espn.go.com/nba/scoreboard').with(:query => {:date => @date}).to_raise(Errno::EHOSTUNREACH)
+    end
+
+    it 'does not raise an exception' do
+      expect { subject }.not_to raise_exception
+    end
+  end
+end
+

data/spec/spec_helper.rb

@@ -17,7 +17,7 @@ RSpec.configure do |config|
 end
 
 def fixture_path
-  File.expand_path('../../cache', __FILE__)
+  File.expand_path('../fixtures/', __FILE__)
 end
 
 def fixture(file)

data/spec/team_spec.rb

@@ -0,0 +1,93 @@
+require 'spec_helper'
+
+describe NBA::Team, '.all' do
+  subject { described_class.all }
+
+  context 'with connection' do
+    before do
+      stub_request(:get, 'https://www.googleapis.com/freebase/v1/mqlread').with(:query => {:query => described_class.mql_query}).to_return(:body => fixture('teams.json'))
+    end
+
+    after do
+      described_class.reset
+    end
+
+    it 'there are thirty teams' do
+      expect(subject.size).to eq 30
+    end
+
+    it 'teams are sorted alphabetically, by name' do
+      expect(subject).to eq subject.sort_by(&:name)
+    end
+
+    it 'every team has a founding year' do
+      subject.each do |team|
+        expect(team.founded).to be_between(1870, 2008), "got: #{team.founded} for #{team.name}"
+      end
+    end
+
+    it 'every player has a one- or two-digit number' do
+      subject.each do |team|
+        team.players.each do |player|
+          expect(player.number).to be_between(0, 99), "got: #{player.number} for #{player.name}"
+        end
+      end
+    end
+
+    it 'every player has at least one position' do
+      subject.each do |team|
+        team.players.each do |player|
+          pending 'Some players do not have a position' # Delonte West
+          expect(player.positions.size).to be >= 1, "got: #{player.positions.size} for #{player.name}"
+        end
+      end
+    end
+
+    it 'every player has a starting year' do
+      subject.each do |team|
+        team.players.each do |player|
+          pending 'Some players do not have a starting year' # 0 for Ivan Johnson
+          expect(player.from).to be >= 1995, "got: #{player.from} for #{player.name}"
+        end
+      end
+    end
+
+    it 'every player is active' do
+      subject.each do |team|
+        team.players.each do |player|
+          expect(player.to).to eq('Present'), "got: #{player.to} for #{player.name}"
+        end
+      end
+    end
+
+    context 'with timeout' do
+      before do
+        stub_request(:get, 'https://www.googleapis.com/freebase/v1/mqlread').with(:query => {:query => described_class.mql_query}).to_timeout
+      end
+
+      it 'does not raise an exception' do
+        expect { subject }.not_to raise_exception
+      end
+    end
+  end
+
+  context 'without connection' do
+    before do
+      stub_request(:get, 'https://www.googleapis.com/freebase/v1/mqlread').with(:query => {:query => described_class.mql_query}).to_raise(SocketError)
+    end
+
+    it 'does not raise an exception' do
+      expect { subject }.not_to raise_exception
+    end
+  end
+
+  context 'with no route to host' do
+    before do
+      stub_request(:get, 'https://www.googleapis.com/freebase/v1/mqlread').with(:query => {:query => described_class.mql_query}).to_raise(Errno::EHOSTUNREACH)
+    end
+
+    it 'does not raise an exception' do
+      expect { subject }.not_to raise_exception
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nba
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.1.1
 platform: ruby
 authors:
 - Larry Lv
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-03 00:00:00.000000000 Z
+date: 2014-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -72,6 +72,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.6.1
+- !ruby/object:Gem::Dependency
+  name: thor
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.18.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.18.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -90,7 +104,8 @@ description: NBA.rb is a Ruby library for retrieving NBA League games, schedules
   teams and players.
 email:
 - larrylv1990@gmail.com
-executables: []
+executables:
+- nba
 extensions: []
 extra_rdoc_files: []
 files:
@@ -100,18 +115,23 @@ files:
 - LICENSE.md
 - README.md
 - Rakefile
+- bin/nba
 - cache/teams.json
 - lib/faraday_middleware/scrape_game.rb
 - lib/nba.rb
+- lib/nba/cli.rb
 - lib/nba/game.rb
 - lib/nba/player.rb
 - lib/nba/request.rb
 - lib/nba/team.rb
 - lib/nba/version.rb
 - nba.gemspec
-- spec/nba_spec.rb
+- spec/fixtures/games.html
+- spec/fixtures/teams.json
+- spec/game_spec.rb
 - spec/spec_helper.rb
-homepage: ''
+- spec/team_spec.rb
+homepage: https://github.com/larrylv/nba
 licenses:
 - MIT
 metadata: {}
@@ -137,5 +157,8 @@ specification_version: 4
 summary: NBA.rb is a Ruby library for retrieving NBA League games, schedules, teams
   and players.
 test_files:
-- spec/nba_spec.rb
+- spec/fixtures/games.html
+- spec/fixtures/teams.json
+- spec/game_spec.rb
 - spec/spec_helper.rb
+- spec/team_spec.rb

data/spec/nba_spec.rb

@@ -1,73 +0,0 @@
-require 'spec_helper'
-
-describe NBA::Team, '.all' do
-  context 'with connection' do
-    before do
-      stub_request(:get, 'https://www.googleapis.com/freebase/v1/mqlread').with(:query => {:query => NBA::Team.mql_query}).to_return(:body => fixture('teams.json'))
-    end
-
-    after do
-      NBA::Team.reset
-    end
-
-    it 'requests the correct resource' do
-      NBA::Team.all
-      expect(a_request(:get, 'https://www.googleapis.com/freebase/v1/mqlread').with(:query => {:query => NBA::Team.mql_query})).to have_been_made
-    end
-
-    it 'returns the correct team results' do
-      teams = NBA::Team.all
-      expect(teams.first.name).to eq 'Atlanta Hawks'
-    end
-
-    it 'returns the correct player results' do
-      teams = NBA::Team.all
-      expect(teams.first.players.first.name).to_not be_nil
-    end
-  end
-
-  context 'with timeout' do
-    before do
-      stub_request(:get, 'https://www.googleapis.com/freebase/v1/mqlread').with(:query => {:query => NBA::Team.mql_query}).to_timeout
-    end
-
-    after do
-      NBA::Team.reset
-    end
-
-    it 'returns the correct results' do
-      teams = NBA::Team.all
-      expect(teams.first.name).to eq 'Atlanta Hawks'
-    end
-  end
-
-  context 'without connection' do
-    before do
-      stub_request(:get, 'https://www.googleapis.com/freebase/v1/mqlread').with(:query => {:query => NBA::Team.mql_query}).to_raise(SocketError)
-    end
-
-    after do
-      NBA::Team.reset
-    end
-
-    it 'returns the correct results' do
-      teams = NBA::Team.all
-      expect(teams.first.name).to eq 'Atlanta Hawks'
-    end
-  end
-
-  context 'with no route to host' do
-    before do
-      stub_request(:get, 'https://www.googleapis.com/freebase/v1/mqlread').with(:query => {:query => NBA::Team.mql_query}).to_raise(Errno::EHOSTUNREACH)
-    end
-
-    after do
-      NBA::Team.reset
-    end
-
-    it 'returns the correct results' do
-      teams = NBA::Team.all
-      expect(teams.first.name).to eq 'Atlanta Hawks'
-    end
-  end
-end