nba 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: df9d2fe716c4ede28aef31797e0c7eba8c5fd70c
-  data.tar.gz: c266a5f37c748af1899a7a788a2813e060c80e65
+  metadata.gz: 91a5381ea2ab0af2822bd27dbe4d0e12ec4514c7
+  data.tar.gz: b90e24f82c2e1dd024b59c2299a32e8afc46597e
 SHA512:
-  metadata.gz: a4dd5d24e74908f0fde6611df602e7f75e90b525a5b16798e9919aac4562722689546a146255a09ed647607bce6c9bfe970e780af4ba586fe0993464a899d785
-  data.tar.gz: f89dd1ceda82481c893663e21336bdf5511f022086b47100f246ff979fa56813c545fbe98bbaf95f4afa63369580846d76a1edbb3f09e6fbfa281e3127a47e8c
+  metadata.gz: 63791f32a033ad8bcf725c38bbc3150453bbd2669a974edcd02679980087de0fd5f6b3e6c6b14a2c8fa9587b02f93398e293048f6355047aca09f76cc0bede73
+  data.tar.gz: f4f92cc7eaac36c0bfa2c8d09e670500d1f0289924867e88ee480575ad904e7f7db8437609003dec0e51077e740a94fad0a3c012a279598bc70e617ec0bc866d

data/.gitignore

@@ -15,3 +15,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+.rspec

data/.travis.yml

@@ -0,0 +1,27 @@
+before_install:
+  - gem update bundler
+  - bundle --version
+  - gem update --system 2.1.11
+  - gem --version
+bundler_args: --without development
+language: ruby
+rvm:
+  - 1.8.7
+  - 1.9.2
+  - 1.9.3
+  - 2.0.0
+  - 2.1.0
+  - rbx
+  - ruby-head
+matrix:
+  include:
+    - rvm: jruby-18mode
+      env: JRUBY_OPTS="$JRUBY_OPTS --debug"
+    - rvm: jruby-19mode
+      env: JRUBY_OPTS="$JRUBY_OPTS --debug"
+    - rvm: jruby-head
+      env: JRUBY_OPTS="$JRUBY_OPTS --debug"
+  allow_failures:
+    - rvm: jruby-head
+    - rvm: ruby-head
+  fast_finish: true

data/Gemfile

@@ -1,5 +1,7 @@
 source 'https://rubygems.org'
 
+gem 'rake'
+
 group :development do
   gem 'pry'
   gem 'pry-rescue'
@@ -9,5 +11,13 @@ group :development do
   end
 end
 
+group :test do
+  gem 'rspec', '>= 2.11'
+  gem 'webmock'
+end
+
+gem 'jruby-openssl', :platforms => :jruby
+gem 'rubysl', '~> 2.0', :platform => :rbx
+
 # Specify your gem's dependencies in nba.gemspec
 gemspec

data/README.md

@@ -1,8 +1,17 @@
 # NBA.rb
 
+[![Gem Version](https://badge.fury.io/rb/nba.png)][gem]
+[![Build Status](https://secure.travis-ci.org/larrylv/nba.png?branch=master)][travis]
+
+[gem]: https://rubygems.org/gems/nba
+[travis]: https://travis-ci.org/larrylv/nba
+
 NBA.rb is a Ruby library for retrieving NBA League players, teams and divisions.
 
-Insipred by @sferik's [MLB](https://github.com/sferik/mlb).
+Insipred by [@sferik][sferik]'s [MLB.rb][mlb].
+
+[sferik]: https://github.com/sferik
+[mlb]: https://github.com/sferik/mlb
 
 ## Installation
     gem install nba
@@ -17,9 +26,58 @@ Insipred by @sferik's [MLB](https://github.com/sferik/mlb).
     >> NBA::Team.all.first.players.first.number    # => 15
     >> NBA::Team.all.first.players.first.position  # => ["Forward-center"]
 
+## Supported Ruby Versions
+This library aims to support and is [tested against][travis] the following Ruby
+implementations:
+
+* Ruby 1.8.7
+* Ruby 1.9.2
+* Ruby 1.9.3
+* Ruby 2.0.0
+* Ruby 2.1.0
+* [Rubinius][]
+* [JRuby][]
+
+[rubinius]: http://rubini.us/
+[jruby]: http://jruby.org/
+
+If something doesn't work on one of these interpreters, it's a bug.
+
+This library may inadvertently work (or seem to work) on other Ruby
+implementations, however support will only be provided for the versions listed
+above.
+
+If you would like this library to support another Ruby version, you may
+volunteer to be a maintainer. Being a maintainer entails making sure all tests
+run and pass on that implementation. When something breaks on your
+implementation, you will be responsible for providing patches in a timely
+fashion. If critical issues for a particular implementation exist at the time
+of a major release, support for that Ruby version may be dropped.
+
+## Colophon
+NBA was built with the following tools:
+
+* [Bundler][]
+* [Freebase][]
+* [Faraday][]
+* [Markdown][]
+* [RSpec][]
+* [vim][]
+* [WebMock][]
+
+[bundler]: http://gembundler.com/
+[freebase]: http://www.freebase.com/
+[faraday]: https://github.com/technoweenie/faraday
+[markdown]: http://daringfireball.net/projects/markdown/
+[rspec]: http://relishapp.com/rspec/
+[vim]: http://www.vim.org/
+[webmock]: https://github.com/bblimke/webmock
+
+And, special thanks to [@sfeirk][sferik]!
+
 ## Contributing
 
-1. Fork it ( http://github.com/<my-github-username>/nba/fork )
+1. Fork it ( http://github.com/larrylv/nba/fork )
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)

data/Rakefile

@@ -1 +1,19 @@
 require "bundler/gem_tasks"
+
+require 'rspec/core/rake_task'
+RSpec::Core::RakeTask.new(:spec)
+
+task :test => :spec
+
+namespace :cache do
+  require 'nba'
+  desc 'Update the teams file cache'
+  task :update do
+    doc = NBA::Team.results_from_freebase(true)
+    File.open('cache/teams.json', 'w') do |file|
+      file.write(doc.body)
+    end
+  end
+end
+
+task :default => [:spec]

data/lib/nba/player.rb

@@ -10,17 +10,15 @@ module NBA
 
     # Returns an array of Player objects given a team roster
     def self.all_from_roster(players)
-      players.map do |player|
-        next if player['to'] != nil
-
+      players.select{ |player| player['to'].nil? }.map do |player|
         new(
           :name     => player['player'],
           :number   => player['number'],
           :position => player['position'],
           :from     => player['from'],
-          :to       => player['to']
+          :to       => "Present"
         )
-      end.compact
+      end
     end
   end
 end

data/lib/nba/team.rb

@@ -1,5 +1,4 @@
 require 'faraday'
-require 'multi_json'
 
 module NBA
   class Team
@@ -19,7 +18,7 @@ module NBA
       # connection error, in which case read from a fixture file
       @all ||= begin
         results_to_team(results_from_freebase)
-      rescue Faraday::Error::ConnectionFailed, Faraday::Error::TimeoutError
+      rescue Errno::EHOSTUNREACH, Faraday::Error::ConnectionFailed, Faraday::Error::TimeoutError
         results_to_team(results_from_cache)
       end
     end
@@ -85,7 +84,8 @@ module NBA
             "player":   null,
             "from":     null,
             "to":       null,
-            "position": []
+            "position": [],
+            "sort": "player"
           }],
           "sort":          "name",
           "type":          "/basketball/basketball_team",

data/lib/nba/version.rb

@@ -1,3 +1,3 @@
 module Nba
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/nba.gemspec

@@ -20,8 +20,7 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency 'faraday', ['~> 0.8', '< 0.10']
   spec.add_runtime_dependency 'faraday_middleware', '~> 0.9'
-  spec.add_runtime_dependency 'multi_json', '~> 1.8'
+  spec.add_dependency 'json', '~> 1.8'
 
   spec.add_development_dependency "bundler", "~> 1.5"
-  spec.add_development_dependency "rake"
 end

data/spec/nba_spec.rb

@@ -0,0 +1,73 @@
+require 'spec_helper'
+
+describe NBA::Team, '.all' do
+  context 'with connection' do
+    before do
+      stub_request(:get, 'https://www.googleapis.com/freebase/v1/mqlread').with(:query => {:query => NBA::Team.mql_query}).to_return(:body => fixture('teams.json'))
+    end
+
+    after do
+      NBA::Team.reset
+    end
+
+    it 'requests the correct resource' do
+      NBA::Team.all
+      expect(a_request(:get, 'https://www.googleapis.com/freebase/v1/mqlread').with(:query => {:query => NBA::Team.mql_query})).to have_been_made
+    end
+
+    it 'returns the correct team results' do
+      teams = NBA::Team.all
+      expect(teams.first.name).to eq 'Atlanta Hawks'
+    end
+
+    it 'returns the correct player results' do
+      teams = NBA::Team.all
+      expect(teams.first.players.first.name).to eq 'Al Horford'
+    end
+  end
+
+  context 'with timeout' do
+    before do
+      stub_request(:get, 'https://www.googleapis.com/freebase/v1/mqlread').with(:query => {:query => NBA::Team.mql_query}).to_timeout
+    end
+
+    after do
+      NBA::Team.reset
+    end
+
+    it 'returns the correct results' do
+      teams = NBA::Team.all
+      expect(teams.first.name).to eq 'Atlanta Hawks'
+    end
+  end
+
+  context 'without connection' do
+    before do
+      stub_request(:get, 'https://www.googleapis.com/freebase/v1/mqlread').with(:query => {:query => NBA::Team.mql_query}).to_raise(SocketError)
+    end
+
+    after do
+      NBA::Team.reset
+    end
+
+    it 'returns the correct results' do
+      teams = NBA::Team.all
+      expect(teams.first.name).to eq 'Atlanta Hawks'
+    end
+  end
+
+  context 'with no route to host' do
+    before do
+      stub_request(:get, 'https://www.googleapis.com/freebase/v1/mqlread').with(:query => {:query => NBA::Team.mql_query}).to_raise(Errno::EHOSTUNREACH)
+    end
+
+    after do
+      NBA::Team.reset
+    end
+
+    it 'returns the correct results' do
+      teams = NBA::Team.all
+      expect(teams.first.name).to eq 'Atlanta Hawks'
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,25 @@
+require 'nba'
+require 'rspec'
+require 'webmock/rspec'
+
+WebMock.disable_net_connect!
+
+RSpec.configure do |config|
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
+
+  config.treat_symbols_as_metadata_keys_with_true_values = true
+  config.run_all_when_everything_filtered = true
+  config.filter_run :focus
+
+  config.order = 'random'
+end
+
+def fixture_path
+  File.expand_path('../../cache', __FILE__)
+end
+
+def fixture(file)
+  File.new(fixture_path + '/' + file)
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nba
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Larry Lv
@@ -45,7 +45,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.9'
 - !ruby/object:Gem::Dependency
-  name: multi_json
+  name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -72,20 +72,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: NBA.rb is a Ruby library for retrieving NBA League players, teams and
   divisions
 email:
@@ -95,6 +81,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".travis.yml"
 - Gemfile
 - LICENSE.md
 - LICENSE.txt
@@ -107,6 +94,8 @@ files:
 - lib/nba/team.rb
 - lib/nba/version.rb
 - nba.gemspec
+- spec/nba_spec.rb
+- spec/spec_helper.rb
 homepage: ''
 licenses:
 - MIT
@@ -131,4 +120,6 @@ rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: NBA.rb is a Ruby library for retrieving NBA League players, teams and divisions
-test_files: []
+test_files:
+- spec/nba_spec.rb
+- spec/spec_helper.rb