nayyar 0.1.0 → 0.2.0

data/lib/nayyar/district.rb

@@ -1,122 +1,130 @@
+# frozen_string_literal: true
+
+# Represents a District in Myanmar
 class Nayyar::District
-	attr_reader :data
-
-	@@districts = nil
-	@@state_index = {}
-
-	@@attributes = [
-		:pcode,
-		:name
-	]
-
-	def initialize(data)
-		@data = data
-	end
-
-	# define getters
-	@@attributes.each do |attr|
-		define_method attr do
-			@data[attr]
-		end
-	end
-
-	# allow the values to be retrieved as an array
-	def [](key)
-		if @@attributes.include? key
-			@data[key]
-		elsif :state == key.to_sym
-			state
-		end
-	end
-
-	def state
-		Nayyar::State.find_by_pcode(@data[:state])
-	end
-
-	def townships
-		Nayyar::Township.of_district(self)
-	end
-
-	class << self
-		INDICES = %w(pcode)
-
-		def all
-			self.districts
-		end
-
-		def of_state(state)
-			state_pcode = state.pcode
-			districts = self.districts
-			@@state_index[state_pcode].map do |index|
-				districts[index]
-			end
-		end
-
-		def find_by(query)
-			key = get_key(query)
-			(index = send("#{key}_index".to_sym).index(query[key])) && districts[index]
-		end
-
-		def find_by!(query)
-			if district = find_by(query)
-				district
-			else
-				key = get_key(query)
-				raise Nayyar::DistrictNotFound.new("Cannot find State with given #{key}: #{query[key]}")
-			end
-		end
-
-		INDICES.each do |index|
-	  	define_method("find_by_#{index}") do |query|
-	  		find_by(index.to_sym => query)
-	  	end
-	  	define_method("find_by_#{index}!") do |query|
-	  		find_by!(index.to_sym => query)
-	  	end
-	  end
-
-		protected
-			def districts
-	    	unless @@districts
-					require "yaml"
-	    		data = YAML.load_file(File.join(File.dirname(__FILE__), '..', 'data', 'districts.yml'))
-	    		indices = INDICES.inject({}) { |memo, index| memo.merge index => [] }
-	    		i = 0
-	    		@@districts= data.map do |district_row|
-	    			state_pcode = district_row[:state]
-	    			district = new(district_row)
-	    			INDICES.each do |index|
-	    				indices[index] << district.send(index)
-	    			end
-	    			@@state_index[state_pcode] ||= []
-	    			@@state_index[state_pcode] << i
-	    			i += 1
-		    		district
-	    		end
-
-	    		INDICES.each do |index|
-	    			class_variable_set("@@#{index}_index", indices[index])
-	    		end
-	    	end
-	    	@@districts
-			end
-
-	    ## define private methods for internal use of indexed array
-	    INDICES.each do |index|
-		    define_method("#{index}_index") do
-		    	districts
-		    	class_variable_get("@@#{index}_index")
-		    end
-	    end
-
-	    ## return the index for query given to find_by/find_by! method
-		  def get_key(data)
-		    keys = data.keys
-		    if keys.length != 1 || INDICES.none? { |key| key.to_sym == keys.first.to_sym }
-		      raise ArgumentError.new("`find_by` accepts only one of #{INDICES.join(" or ")} as argument. none provided")
-		    end
-		    keys.first
-		  end
-	end
+  attr_reader :data
+
+  @districts = nil
+  @state_index = {}
+
+  ATTRIBUTES = %i[
+    pcode
+    name
+    my_name
+  ].freeze
+
+  INDICES = %w[pcode].freeze
+
+  def initialize(data)
+    @data = data
+  end
+
+  # define getters
+  ATTRIBUTES.each do |attr|
+    define_method attr do
+      @data[attr]
+    end
+  end
+
+  # allow the values to be retrieved as an array
+  def [](key)
+    if ATTRIBUTES.include? key
+      @data[key]
+    elsif key.to_sym == :state
+      state
+    end
+  end
+
+  def state
+    Nayyar::State.find_by_pcode(@data[:state])
+  end
+
+  def townships
+    Nayyar::Township.of_district(self)
+  end
+
+  class << self
+    def all
+      districts
+    end
+
+    def of_state(state)
+      state_pcode = state.pcode
+      districts = self.districts
+      @state_index[state_pcode].map do |index|
+        districts[index]
+      end
+    end
+
+    def find_by(query)
+      key = get_key(query)
+      (index = send("#{key}_index".to_sym).index(query[key])) && districts[index]
+    end
+
+    def find_by!(query)
+      if (district = find_by(query))
+        district
+      else
+        key = get_key(query)
+        raise Nayyar::DistrictNotFound, "Cannot find State with given #{key}: #{query[key]}"
+      end
+    end
+
+    INDICES.each do |index|
+      define_method("find_by_#{index}") do |query|
+        find_by(index.to_sym => query)
+      end
+      define_method("find_by_#{index}!") do |query|
+        find_by!(index.to_sym => query)
+      end
+    end
+
+    protected
+
+    def districts
+      unless @districts
+        indices = INDICES.inject({}) { |memo, index| memo.merge index => [] }
+        @districts = data.each_with_index.map do |district_data, i|
+          new(district_data).tap { |district| build_indices(indices, district, district_data[:state], i) }
+        end
+
+        INDICES.each do |index|
+          class_variable_set("@@#{index}_index", indices[index]) # rubocop:disable Style/ClassVars
+        end
+      end
+      @districts
+    end
+
+    def data
+      YAML.load_file(File.join(File.dirname(__FILE__), '..', 'data', 'districts.yml'))
+    end
+
+    def build_indices(indices, district, state_pcode, reference_index)
+      INDICES.each do |index|
+        indices[index] << district.send(index)
+      end
+      @state_index[state_pcode] ||= []
+      @state_index[state_pcode] << reference_index
+    end
+
+    ## define private methods for internal use of indexed array
+    INDICES.each do |index|
+      define_method("#{index}_index") do
+        districts
+        class_variable_get("@@#{index}_index")
+      end
+    end
+
+    ## return the index for query given to find_by/find_by! method
+    def get_key(data)
+      keys = data.keys
+      if keys.length != 1 || INDICES.none? { |key| key.to_sym == keys.first.to_sym }
+        raise ArgumentError, "`find_by` accepts only one of #{INDICES.join(' or ')} as argument. none provided"
+      end
+
+      keys.first
+    end
+  end
 end
-class Nayyar::DistrictNotFound < StandardError; end;
+
+class Nayyar::DistrictNotFound < StandardError; end

data/lib/nayyar/state.rb

@@ -1,107 +1,111 @@
+# frozen_string_literal: true
+
+# Represents a State in Myanmar
 class Nayyar::State
-	attr_reader :data
+  attr_reader :data
 
-  @@states = nil
-  @@pcode_index = []
-  @@iso_index = []
-  @@alpha3_index = []
+  @states = nil
+  @pcode_index = []
+  @iso_index = []
+  @alpha3_index = []
 
-	attributes = [
-		:pcode,
-		:iso,
-		:alpha3,
-		:name
-	]
+  ATTRIBUTES = %i[
+    pcode
+    iso
+    alpha3
+    name
+    my_name
+  ].freeze
 
-	def initialize(data)
-		@data = data
-	end
+  INDICES = %w[pcode iso alpha3].freeze
 
+  def initialize(data)
+    @data = data
+  end
 
-	# define getters
-	attributes.each do |attr|
-		define_method attr do
-			@data[attr]
-		end
-	end
+  # define getters
+  ATTRIBUTES.each do |attr|
+    define_method attr do
+      @data[attr]
+    end
+  end
 
-	# allow the values to be retrieved as an array
-	def [](key)
-		@data[key]
-	end
+  # allow the values to be retrieved as an array
+  def [](key)
+    @data[key]
+  end
 
   def districts
-  	Nayyar::District.of_state self
+    Nayyar::District.of_state self
   end
 
-
-	class << self
-	  INDICES = %w(pcode iso alpha3)
-
-		def all
-			states
-		end
-
-	  def find_by(query)
-	    key = get_key(query)
-	    (index = send("#{key}_index".to_sym).index(query[key])) && states[index]
-	  end
-
-	  def find_by!(query)
-	    if state = find_by(query)
-	      state
-	    else
-	      key = get_key(query)
-	      raise Nayyar::StateNotFound.new("Cannot find State with given #{key}: #{query[key]}")
-	    end
-	  end
-
-	  INDICES.each do |index|
-	  	define_method("find_by_#{index}") do |query|
-	  		find_by(index.to_sym => query)
-	  	end
-	  	define_method("find_by_#{index}!") do |query|
-	  		find_by!(index.to_sym => query)
-	  	end
-	  end
-
-
-	  protected
-	    def states
-	    	unless @@states
-					require "yaml"
-	    		data = YAML.load_file(File.join(File.dirname(__FILE__), '..', 'data', 'states.yml'))
-	    		indices = INDICES.inject({}) { |memo, index| memo.merge index => [] }
-	    		@@states = data.map do |state|
-	    			state = new(state)
-	    			INDICES.each do |index|
-	    				indices[index] << state.send(index)
-	    			end
-	    			state
-	    		end
-	    		INDICES.each do |index|
-	    			class_variable_set("@@#{index}_index", indices[index])
-	    		end
-	    	end
-	    	@@states
-	    end
-
-	    ## define private methods for internal use of indexed array
-	    INDICES.each do |index|
-		    define_method("#{index}_index") do
-		    	states
-		    	class_variable_get("@@#{index}_index")
-		    end
-	    end
-
-	    ## return the index for query given to find_by/find_by! method
-		  def get_key(data)
-		    keys = data.keys
-		    if keys.length != 1 || INDICES.none? { |key| key.to_sym == keys.first.to_sym }
-		      raise ArgumentError.new("`find_by` accepts only one of #{INDICES.join(" or ")} as argument. None provided")
-		    end
-		    keys.first
-		  end
-	end
+  class << self
+    def all
+      states
+    end
+
+    def find_by(query)
+      key = get_key(query)
+      (index = send("#{key}_index".to_sym).index(query[key])) && states[index]
+    end
+
+    def find_by!(query)
+      if (state = find_by(query))
+        state
+      else
+        key = get_key(query)
+        raise Nayyar::StateNotFound, "Cannot find State with given #{key}: #{query[key]}"
+      end
+    end
+
+    INDICES.each do |index|
+      define_method("find_by_#{index}") do |query|
+        find_by(index.to_sym => query)
+      end
+      define_method("find_by_#{index}!") do |query|
+        find_by!(index.to_sym => query)
+      end
+    end
+
+    protected
+
+    def states
+      unless @states
+        indices = INDICES.inject({}) { |memo, index| memo.merge index => [] }
+        @states = data.map do |state_data|
+          new(state_data).tap { |state| build_indices(indices, state) }
+        end
+        INDICES.each { |index| class_variable_set(:"@@#{index}_index", indices[index]) } # rubocop:disable Style/ClassVars
+      end
+      @states
+    end
+
+    def data
+      YAML.load_file(File.join(File.dirname(__FILE__), '..', 'data', 'states.yml'))
+    end
+
+    def build_indices(indices, state)
+      INDICES.each { |index| indices[index] << state.send(index) }
+    end
+
+    ## define private methods for internal use of indexed array
+    INDICES.each do |index|
+      define_method("#{index}_index") do
+        states
+        class_variable_get(:"@@#{index}_index")
+      end
+    end
+
+    ## return the index for query given to find_by/find_by! method
+    def get_key(data)
+      keys = data.keys
+      if keys.length != 1 || INDICES.none? { |key| key.to_sym == keys.first.to_sym }
+        raise ArgumentError, "`find_by` accepts only one of #{INDICES.join(' or ')} as argument. None provided"
+      end
+
+      keys.first
+    end
+  end
 end
-class Nayyar::StateNotFound < StandardError; end;
+
+class Nayyar::StateNotFound < StandardError; end