navtastic 0.0.1 → 0.1.0

data/spec/navtastic/menu_spec.rb

@@ -46,7 +46,7 @@ RSpec.describe Navtastic::Menu do
       expect(menu.item("Test")).to eq menu.items.last
     end
 
-    context "with 1 argument" do
+    context "with only a name" do
       before { menu.item name }
 
       let(:name) { "Test" }
@@ -61,7 +61,7 @@ RSpec.describe Navtastic::Menu do
       end
     end
 
-    context "with 2 arguments" do
+    context "with a name and a url" do
       before { menu.item name, url }
 
       let(:name) { "Test" }
@@ -77,12 +77,74 @@ RSpec.describe Navtastic::Menu do
       end
     end
 
+    context "with a name, url and options" do
+      before { menu.item name, url, options }
+
+      let(:name) { "Test" }
+      let(:url) { "/url" }
+      let(:options) { { class: 'test' } }
+
+      let(:item) { menu.items.last }
+
+      it "sets the name" do
+        expect(item.name).to eq name
+      end
+
+      it "sets the url" do
+        expect(item.url).to eq url
+      end
+
+      it "sets the options" do
+        expect(item.options).to eq options
+      end
+    end
+
+    context "with a name and options" do
+      before { menu.item name, options }
+
+      let(:name) { "Test" }
+      let(:options) { { class: 'test' } }
+
+      let(:item) { menu.items.last }
+
+      it "sets the name" do
+        expect(item.name).to eq name
+      end
+
+      it "leaves the url empty" do
+        expect(item.url).to eq nil
+      end
+
+      it "sets the options" do
+        expect(item.options).to eq options
+      end
+    end
+
     context "when the item has a submenu" do
       let(:item) { menu.items.first }
 
-      it "adds the menu to the itme" do
+      it "adds the menu to the item" do
         expect(item.submenu).not_to eq nil
       end
+
+      it "the submenu has no base_url" do
+        expect(item.submenu.base_url).to eq nil
+      end
+    end
+
+    context "with the base_url option" do
+      subject(:menu) do
+        menu = described_class.new
+        menu.item "Settings", '/settings', base_url: true do |submenu|
+        end
+        menu
+      end
+
+      let(:submenu) { menu.items.first.submenu }
+
+      it "makes the item url the base_url of the submenu" do
+        expect(submenu.base_url).to eq '/settings'
+      end
     end
   end
 
@@ -109,6 +171,14 @@ RSpec.describe Navtastic::Menu do
     it "returns nil when the url doesn't exist" do
       expect(menu['/foo']).to be nil
     end
+
+    context "when the menu has a base url" do
+      before { menu.config.base_url = '/admin' }
+
+      it "adds it in front of every url" do
+        expect(menu['/admin/about'].name).to eql 'About'
+      end
+    end
   end
 
   describe '#current_item' do
@@ -200,4 +270,38 @@ RSpec.describe Navtastic::Menu do
       end
     end
   end
+
+  describe '#base_url' do
+    subject(:url) { menu.base_url }
+
+    let(:menu) { described_class.new }
+
+    context "when the menu has no base_url" do
+      it { is_expected.to eq nil }
+    end
+
+    context "when the menu has a base_url" do
+      before { menu.config.base_url = '/admin' }
+
+      it "returns that base url" do
+        expect(url).to eq '/admin'
+      end
+    end
+
+    context "when a base url has been defined globally and on both menus" do
+      before do
+        set_configuration base_url: '/admin'
+        menu.config.base_url = '/settings'
+        submenu.config.base_url = '/general'
+      end
+
+      subject(:url) { submenu.base_url }
+
+      let(:submenu) { described_class.new menu }
+
+      it "combines all base urls together" do
+        expect(url).to eq '/admin/settings/general'
+      end
+    end
+  end
 end

data/spec/navtastic/renderer/simple_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+RSpec.describe Navtastic::Renderer::Simple do
+  describe '.render' do
+    subject(:renderer) { described_class.render menu }
+
+    let(:current_url) { '/' }
+    let(:menu) do
+      menu = Navtastic::Menu.new
+      menu.item "Home", '/'
+      menu.current_url = current_url
+      menu
+    end
+
+    it "returns an instance of Navtastic::Renderer::Simple" do
+      expect(renderer).to be_a described_class
+    end
+  end
+end

data/spec/navtastic/renderer_spec.rb

@@ -1,19 +1,61 @@
 require 'spec_helper'
 
 RSpec.describe Navtastic::Renderer do
-  describe '.render' do
-    subject(:renderer) { described_class.render menu }
+  describe '#menu_inside_container?' do
+    # Create a test rendered that chooses menu position fro  options hash
+    class MenuInsideRenderer < described_class
+      def menu_inside_container?(_item)
+        options[:inside]
+      end
+    end
+
+    subject(:renderer) { MenuInsideRenderer.render(menu, inside: inside) }
 
-    let(:current_url) { '/' }
     let(:menu) do
       menu = Navtastic::Menu.new
-      menu.item "Home", '/'
-      menu.current_url = current_url
+      menu.item "First" do |submenu|
+        submenu.item "Second"
+      end
       menu
     end
 
-    it "returns an instance of Navtastic::Renderer" do
-      expect(renderer).to be_a described_class
+    context "when it returns true" do
+      let(:inside) { true }
+
+      it "renders the submenu inside the item container" do
+        expect(renderer.find_by_tag('li').first.children.count).to eq 2
+      end
+    end
+
+    context "when it returns false" do
+      let(:inside) { false }
+
+      it "renders the submenu after the item container" do
+        expect(renderer.find_by_tag('li').first.children.count).to eq 1
+      end
+    end
+  end
+
+  describe '#render_item' do
+    context "when an item has custom classes as an option" do
+      subject(:output) { described_class.render(menu) }
+
+      let(:menu) do
+        menu = Navtastic::Menu.new
+        menu.item "a", '/a', class: 'class_a'
+        menu.item "b", '/b', content_class: 'class_b'
+        menu
+      end
+
+      it "adds custom classes to the item container" do
+        first_item = output.find_by_tag('li').first
+        expect(first_item.class_list).to include 'class_a'
+      end
+
+      it "adds custom classes to the item content" do
+        last_item = output.find_by_tag('li').last
+        expect(last_item.children.first.class_list).to include 'class_b'
+      end
     end
   end
 end

data/spec/navtastic_spec.rb

@@ -37,16 +37,53 @@ RSpec.describe Navtastic do
   describe '.render' do
     before { define_menu }
 
-    subject(:renderer) { described_class.render(menu_name, '/') }
+    subject(:render) { described_class.render(menu_name, '/', params) }
+
+    let(:params) { {} }
 
     context "when the menu was found" do
-      specify { expect(renderer).to be_a Navtastic::Renderer }
+      specify { expect(render).to be_a described_class.configuration.renderer }
     end
 
     context "when the menu was not found" do
-      subject(:renderer) { described_class.render("foo", '/') }
+      subject(:render) { described_class.render("foo", '/') }
+
+      specify { expect { render }.to raise_error KeyError }
+    end
+
+    context "when the renderer was updated in the configuration" do
+      let(:mock_renderer) { class_double(Navtastic::Renderer::Simple) }
+
+      before { set_configuration renderer: mock_renderer }
+
+      it "calls `.render` on the class in the configuration" do
+        allow(mock_renderer).to receive :render
+        render
+        expect(mock_renderer)
+          .to have_received(:render).with(Navtastic::Menu, Hash)
+      end
+    end
+
+    context "when rendering options have been set in the configuration" do
+      before { set_configuration renderer_options: { foo: :bar } }
 
-      specify { expect { renderer }.to raise_error KeyError }
+      it "passes the options to the renderer" do
+        expect(render.options).to eq(foo: :bar)
+      end
+    end
+
+    context "when params contains a renderer key" do
+      before { set_configuration renderer_options: { foo: :bar } }
+
+      let(:params) { { renderer: { foo: :foo, key: :value } } }
+
+      it "passes the options to the renderer" do
+        expect(render.options[:key]).to eq :value
+      end
+
+      it "merges them with the globally configured settings" do
+        expect(render.options[:foo]).to eq :foo
+      end
     end
   end
 end

data/spec/spec_helper.rb

@@ -25,7 +25,8 @@ Bundler.setup
 require 'navtastic'
 require 'pp'
 
-require 'support/navtastic_store'
+require 'support/navtastic_helpers'
+require 'support/navtastic_reset'
 
 RSpec.configure do |config|
   # rspec-expectations config goes here. You can use an alternate

data/spec/support/navtastic_helpers.rb

@@ -0,0 +1,17 @@
+# Helpers that are used when testing
+module NavtasticHelpers
+  # Update the current configuration
+  #
+  # @param options [Hash] configuration settings to override
+  def set_configuration(options)
+    Navtastic.configure do |configuration|
+      options.each do |key, value|
+        configuration.send("#{key}=", value)
+      end
+    end
+  end
+end
+
+RSpec.configure do |c|
+  c.include NavtasticHelpers
+end

data/spec/support/{navtastic_store.rb → navtastic_reset.rb}

@@ -1,6 +1,7 @@
-# Remove all stored menus before every test
+# Remove all stored menus and reset configuration before every test
 RSpec.configure do |config|
   config.before(:each) do
     Navtastic.instance_variable_get(:@menu_store).clear
+    Navtastic.reset_configuration
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: navtastic
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Aram Visser
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-21 00:00:00.000000000 Z
+date: 2017-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: arbre
@@ -111,21 +111,35 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- docs/bulma_headers_preview.png
+- docs/foundation_styles_preview.png
 - lib/navtastic.rb
+- lib/navtastic/configuration.rb
 - lib/navtastic/item.rb
 - lib/navtastic/menu.rb
 - lib/navtastic/renderer.rb
+- lib/navtastic/renderer/bootstrap4.rb
+- lib/navtastic/renderer/bulma.rb
+- lib/navtastic/renderer/foundation6.rb
+- lib/navtastic/renderer/simple.rb
 - lib/navtastic/version.rb
 - navtastic.gemspec
 - spec/demo/index.rhtml
+- spec/demo/renderer/bootstrap4.rhtml
+- spec/demo/renderer/bulma.rhtml
+- spec/demo/renderer/foundation6.rhtml
+- spec/demo/renderer/simple.rhtml
 - spec/demo/server.rb
+- spec/navtastic/configuration_spec.rb
 - spec/navtastic/item_spec.rb
 - spec/navtastic/menu_spec.rb
+- spec/navtastic/renderer/simple_spec.rb
 - spec/navtastic/renderer_spec.rb
 - spec/navtastic_spec.rb
 - spec/spec_helper.rb
 - spec/support/matchers/current_item.rb
-- spec/support/navtastic_store.rb
+- spec/support/navtastic_helpers.rb
+- spec/support/navtastic_reset.rb
 homepage: http://github.com/aramvisser/navtastic
 licenses:
 - MIT
@@ -152,11 +166,18 @@ specification_version: 4
 summary: Define and render complex navigation menus
 test_files:
 - spec/demo/index.rhtml
+- spec/demo/renderer/bootstrap4.rhtml
+- spec/demo/renderer/bulma.rhtml
+- spec/demo/renderer/foundation6.rhtml
+- spec/demo/renderer/simple.rhtml
 - spec/demo/server.rb
+- spec/navtastic/configuration_spec.rb
 - spec/navtastic/item_spec.rb
 - spec/navtastic/menu_spec.rb
+- spec/navtastic/renderer/simple_spec.rb
 - spec/navtastic/renderer_spec.rb
 - spec/navtastic_spec.rb
 - spec/spec_helper.rb
 - spec/support/matchers/current_item.rb
-- spec/support/navtastic_store.rb
+- spec/support/navtastic_helpers.rb
+- spec/support/navtastic_reset.rb