navigable 1.1.0 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a9a68f7f5e2ac4de908f84bdf0ead1bcddf8b07117a05cdf21ce228aad4609fb
-  data.tar.gz: 1031b1dcc22fc53c37d9c2dde8049941e4aca4a9b975d4646242c8bc50dbc880
+  metadata.gz: 97471cde6b2f3d8127d70152b824662e1d62694d5c7630d05c06d5767b0fb5c7
+  data.tar.gz: b3bbd91964cacf1d7929419d268e6af3631a625d6ec4af7eca47741649bd4577
 SHA512:
-  metadata.gz: 718b7b78861540d93c40df11f422a62fe11fd5c55dc1e007df7c556d4a1105201b177f7b804e775c6f5e0d4e58429b96ac35881b8016cc2aa79cc062c43f5d5e
-  data.tar.gz: 9fe59b3b53a9dcf2653ccd34b1ae15449ebb0af35e6ae12eef9c1637f9e197f7df5a3bbe4f5f3118a185cd79eaf18871ef5d577a296d5979166b13c8d3b5c0b7
+  metadata.gz: 6587cf7816236fb7f68cfc7f8793ebd6c14a8684687409ef656769e93cc149e47bec147a7f2083eda4470db0c35c1bd069051a895ae5664db9cc670270f29f98
+  data.tar.gz: b3f81adf0992c20e928eae72e4c0911401c83ded05f2b21c92f09242948020d5f2866be96d7c622f0ded6daeb37c1cb75c3442687283513392b49368d3f19560

data/README.md

@@ -32,22 +32,13 @@ A simple, highly-performant, Rack-based router.
 **[Navigable Server][server]** *(coming soon)*<br>
 A Rack-based server for building Ruby and Navigable web applications.
 
-</td>
-</tr>
-<tr height="140">
-<td width="130"><img alt="Telescope" src="https://raw.githubusercontent.com/first-try-software/navigable/main/assets/telescope.png"></td>
-<td>
-
-**Navigable API** *(coming soon)*<br>
-An extension of Navigable Server for building restful JSON APIs.
-
 </td>
 </tr>
 <tr height="140">
 <td width="130"><img alt="Map" src="https://raw.githubusercontent.com/first-try-software/navigable/main/assets/map.png"></td>
 <td>
 
-**Navigable GraphQL** *(coming soon)*<br>
+**[Navigable GraphQL][graphql]** *(coming soon)*<br>
 An extension of Navigable Server for building GraphQL APIs.
 
 </td>
@@ -195,12 +186,6 @@ Or install it yourself as:
 
     $ gem install navigable
 
-## Development
-
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
-
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
-
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/first-try-software/navigable.
@@ -222,4 +207,5 @@ Everyone interacting in the Navigable project's codebases, issue trackers, chat
 [wiki]: https://github.com/first-try-software/navigable/wiki
 [navigable]: https://github.com/first-try-software/navigable
 [router]: https://github.com/first-try-software/navigable-router
-[server]: https://github.com/first-try-software/navigable-server
+[server]: https://github.com/first-try-software/navigable-server
+[graphql]: https://github.com/first-try-software/navigable-graphql

data/lib/navigable.rb

@@ -1,5 +1,6 @@
 # frozen-string-literal: true
 
+require 'concurrent'
 require 'manufacturable'
 
 require 'navigable/version'

data/lib/navigable/command.rb

@@ -4,30 +4,35 @@ require 'navigable/observable'
 
 module Navigable
   module Command
+    class NotFoundError < StandardError; end
+
     TYPE = :__command__
     EXECUTE_NOT_IMPLEMENTED_MESSAGE = 'Class must implement `execute` method.'
 
     def self.extended(base)
       base.extend(Manufacturable::Item)
+      base.extend(ClassMethods)
       base.include(Observable)
+      base.include(InstanceMethods)
+    end
 
-      base.instance_eval do
-        def corresponds_to(key)
-          super(key, TYPE)
-        end
+    module ClassMethods
+      def corresponds_to(key)
+        super(key, TYPE)
       end
+    end
 
-      base.class_eval do
-        attr_reader :params, :observers
+    module InstanceMethods
+      attr_reader :params, :observers, :resolver
 
-        def inject(params: {}, observers: [])
-          @params = params
-          @observers = observers
-        end
+      def inject(params: {}, observers: [], resolver: NullResolver.new)
+        @params = params
+        @observers = observers
+        @resolver = resolver
+      end
 
-        def execute
-          raise NotImplementedError.new(EXECUTE_NOT_IMPLEMENTED_MESSAGE)
-        end
+      def execute
+        raise NotImplementedError.new(EXECUTE_NOT_IMPLEMENTED_MESSAGE)
       end
     end
   end

data/lib/navigable/dispatcher.rb

@@ -1,12 +1,12 @@
 # frozen-string-literal: true
 
-require 'navigable/basic_resolver'
+require 'navigable/null_resolver'
 require 'navigable/observer'
 require 'navigable/command'
 
 module Navigable
   class Dispatcher
-    def self.dispatch(key, params: {}, resolver: BasicResolver.new)
+    def self.dispatch(key, params: {}, resolver: NullResolver.new)
       self.new(key, params: params, resolver: resolver).dispatch
     end
 
@@ -25,11 +25,15 @@ module Navigable
     end
 
     def observers
-      Manufacturable.build_all(Observer::TYPE, key) { |observer| observer.inject(params: params) }.push(resolver)
+      Manufacturable.build_all(Observer::TYPE, key) { |observer| observer.inject(params: params) }
     end
 
     def command
-      Manufacturable.build_one(Command::TYPE, key) { |command| command.inject(params: params, observers: observers) }
+      build_command.tap { |command| raise Navigable::Command::NotFoundError unless command }
+    end
+
+    def build_command
+      Manufacturable.build_one(Command::TYPE, key) { |command| command.inject(params: params, observers: observers, resolver: resolver) }
     end
   end
 end

data/lib/navigable/executor.rb

@@ -0,0 +1,9 @@
+# frozen-string-literal: true
+
+module Navigable
+  class Executor
+    def self.execute(&block)
+      ENV['CONCURRENT_OBSERVERS'] ? Concurrent.global_io_executor.post(&block) : block.call
+    end
+  end
+end

data/lib/navigable/null_resolver.rb

@@ -0,0 +1,19 @@
+# frozen-string-literal: true
+
+require 'navigable/resolver'
+
+module Navigable
+  class NullResolver
+    extend Navigable::Resolver
+
+    def resolve
+      @result
+    end
+
+    ObserverMap::METHODS.values.each do |observer_method|
+      define_method(observer_method) do |result|
+        @result = result
+      end
+    end
+  end
+end

data/lib/navigable/observable.rb

@@ -1,39 +1,29 @@
 # frozen-string-literal: true
 
+require 'navigable/observer_map'
+require 'navigable/executor'
+
 module Navigable
   module Observable
     OBSERVERS_NOT_IMPLEMENTED_MESSAGE = 'Class must implement `observers` method.'
+    RESOLVER_NOT_IMPLEMENTED_MESSAGE = 'Class must implement `resolver` method.'
 
     def observers
       raise NotImplementedError.new(OBSERVERS_NOT_IMPLEMENTED_MESSAGE)
     end
 
-    def successfully(*args)
-      observers.each { |observer| observer.on_success(*args) }
-    end
-
-    def failed_to_validate(*args)
-      observers.each { |observer| observer.on_failure_to_validate(*args) }
-    end
-
-    def failed_to_find(*args)
-      observers.each { |observer| observer.on_failure_to_find(*args) }
+    def resolver
+      raise NotImplementedError.new(RESOLVER_NOT_IMPLEMENTED_MESSAGE)
     end
 
-    def failed_to_create(*args)
-      observers.each { |observer| observer.on_failure_to_create(*args) }
-    end
-
-    def failed_to_update(*args)
-      observers.each { |observer| observer.on_failure_to_update(*args) }
-    end
-
-    def failed_to_delete(*args)
-      observers.each { |observer| observer.on_failure_to_delete(*args) }
-    end
+    ObserverMap::METHODS.each_pair do |observable_method, observer_method|
+      define_method(observable_method) do |*args|
+        observers.each do |observer|
+          Navigable::Executor.execute { observer.send(observer_method, *args) }
+        end
 
-    def failed(*args)
-      observers.each { |observer| observer.on_failure(*args) }
+        resolver.send(observer_method, *args)
+      end
     end
   end
 end

data/lib/navigable/observer.rb

@@ -8,28 +8,30 @@ module Navigable
 
     def self.extended(base)
       base.extend(Manufacturable::Item)
+      base.extend(ClassMethods)
       base.include(ObserverInterface)
+      base.include(InstanceMethods)
+    end
 
-      base.instance_eval do
-        def observes_all_commands
-          corresponds_to_all(TYPE)
-        end
+    module ClassMethods
+      def observes_all_commands
+        corresponds_to_all(TYPE)
+      end
 
-        def observes(key)
-          corresponds_to(key, TYPE)
-        end
+      def observes(key)
+        corresponds_to(key, TYPE)
       end
+    end
 
-      base.class_eval do
-        attr_reader :params
+    module InstanceMethods
+      attr_reader :params
 
-        def inject(params: {})
-          @params = params
-        end
+      def inject(params: {})
+        @params = params
+      end
 
-        def observed_command_key
-          manufacturable_item_key
-        end
+      def observed_command_key
+        manufacturable_item_key
       end
     end
   end

data/lib/navigable/observer_interface.rb

@@ -1,13 +1,11 @@
 # frozen-string-literal: true
 
+require 'navigable/observer_map'
+
 module Navigable
   module ObserverInterface
-    def on_success(*args, **kwargs); end
-    def on_failure_to_validate(*args, **kwargs); end
-    def on_failure_to_find(*args, **kwargs); end
-    def on_failure_to_create(*args, **kwargs); end
-    def on_failure_to_update(*args, **kwargs); end
-    def on_failure_to_delete(*args, **kwargs); end
-    def on_failure(*args, **kwargs); end
+    ObserverMap::METHODS.values.each do |observer_method|
+      define_method(observer_method) { |*args| }
+    end
   end
 end

data/lib/navigable/observer_map.rb

@@ -0,0 +1,16 @@
+# frozen-string-literal: true
+
+module Navigable
+  class ObserverMap
+    METHODS = {
+      successfully: :on_success,
+      successfully_created: :on_creation,
+      failed_to_validate: :on_failure_to_validate,
+      failed_to_find: :on_failure_to_find,
+      failed_to_create: :on_failure_to_create,
+      failed_to_update: :on_failure_to_update,
+      failed_to_delete: :on_failure_to_delete,
+      failed: :on_failure
+    }.freeze
+  end
+end

data/lib/navigable/resolver.rb

@@ -4,14 +4,29 @@ require 'navigable/observer_interface'
 
 module Navigable
   module Resolver
-    RESOLVE_NOT_IMPLEMENTED_MESSAGE = 'Class must implement `resolve` method.'
+    TYPE = :__resolver__
+    RESOLVE_NOT_IMPLEMENTED_MESSAGE = 'Resolver classes must implement a `resolve` method.'
 
     def self.extended(base)
+      base.extend(Manufacturable::Item)
+      base.extend(ClassMethods)
       base.include(ObserverInterface)
-      base.class_eval do
-        def resolve
-          raise NotImplementedError.new(RESOLVE_NOT_IMPLEMENTED_MESSAGE)
-        end
+      base.include(InstanceMethods)
+    end
+
+    module ClassMethods
+      def default_resolver
+        default_manufacturable(TYPE)
+      end
+
+      def resolves(key)
+        corresponds_to(key, TYPE)
+      end
+    end
+
+    module InstanceMethods
+      def resolve
+        raise NotImplementedError.new(RESOLVE_NOT_IMPLEMENTED_MESSAGE)
       end
     end
   end

data/lib/navigable/version.rb

@@ -1,5 +1,5 @@
 # frozen-string-literal: true
 
 module Navigable
-  VERSION = "1.1.0"
+  VERSION = "1.5.1"
 end

data/navigable.gemspec

@@ -24,6 +24,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
+  spec.add_dependency "concurrent-ruby", "~> 1.1.7"
   spec.add_dependency "manufacturable", "~> 1.5"
 
   spec.add_development_dependency "bundler", "~> 2.0"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: navigable
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.5.1
 platform: ruby
 authors:
 - Alan Ridlehoover
@@ -9,8 +9,22 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-09-24 00:00:00.000000000 Z
+date: 2020-12-23 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: concurrent-ruby
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.1.7
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.1.7
 - !ruby/object:Gem::Dependency
   name: manufacturable
   requirement: !ruby/object:Gem::Requirement
@@ -108,7 +122,6 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
-- ".ruby-version"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -118,12 +131,14 @@ files:
 - bin/console
 - bin/setup
 - lib/navigable.rb
-- lib/navigable/basic_resolver.rb
 - lib/navigable/command.rb
 - lib/navigable/dispatcher.rb
+- lib/navigable/executor.rb
+- lib/navigable/null_resolver.rb
 - lib/navigable/observable.rb
 - lib/navigable/observer.rb
 - lib/navigable/observer_interface.rb
+- lib/navigable/observer_map.rb
 - lib/navigable/resolver.rb
 - lib/navigable/version.rb
 - navigable.gemspec

data/.ruby-version

@@ -1 +0,0 @@
-2.7.1

data/lib/navigable/basic_resolver.rb

@@ -1,24 +0,0 @@
-# frozen-string-literal: true
-
-require 'navigable/resolver'
-
-module Navigable
-  class BasicResolver
-    extend Navigable::Resolver
-
-    def resolve
-      @result
-    end
-
-    def on_success(result)
-      @result = result
-    end
-
-    alias_method :on_failure_to_validate, :on_success
-    alias_method :on_failure_to_find, :on_success
-    alias_method :on_failure_to_create, :on_success
-    alias_method :on_failure_to_update, :on_success
-    alias_method :on_failure_to_delete, :on_success
-    alias_method :on_failure, :on_success
-  end
-end