naver_map 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6a724b1f72f20a69a97bf0c48a036295f645bc7a
-  data.tar.gz: b726dc5c4b9e6ea09ded0000b6ddc79655b2a4c5
+  metadata.gz: afdfc7a5a1c1dbd88bda59862f7afb7c25724087
+  data.tar.gz: 7503892882aecec83cc212212473b755393bea83
 SHA512:
-  metadata.gz: 47de6a80a54b38fde23377f3351e9e82642bab4c4e3d33442424fd667ebba0ec6647e18dd3cdb6ae8e73cc842d4818d27b1ad57876af51cbe5efb4da54715ca9
-  data.tar.gz: c5c12621213183080e3d2ab202835459ccfa064253eedfc9f7c278557d8ef65becf9b43fbe1c800df57f53ffd7ad67de7a6c2739dac720d873bf541b1f3a5c02
+  metadata.gz: caee5dc6fd52514ee2e8d00429440c8f3585756376e304c4997901099d5324d32dfe8ef7540a252302db3b021cc93f83a6a93b3d8dde34f48f766cdf5a17f12a
+  data.tar.gz: 0273f0d9089a467644fc4b7508fdff5cde17d704df18039e508bb42184b23ebbf882f1b8ff8413a4203d076145c4c9d5549e17bdc297fec594563aadd96a6d64

data/.gitignore

@@ -103,3 +103,9 @@ icon.png
 # ctags
 tags
 .tags
+
+# Vim swap file
+*.swp
+
+# byebug history
+.byebug_history

data/CHANGELOG.md

@@ -1,14 +1,17 @@
-* 0.1.0
-    * 첫 버전
-    * 주소를 좌표로 변환 시켜주는 기능 추가
-* 0.1.1
-    * gemspec에 누락된 홈페이지 정보 추가
+* 0.2.3
+    * invalid key에 대한 에러 메시지 추가
+* 0.2.2
+    * 결과값이 1개일시 array로 반환 안함
+    * gemspec dependency warning 해결
+* 0.2.1
+    * dependency 정리
+    * travis 코드 정리
 * 0.2.0
     * travis 연동 및 minitest로 TDD 구현
     * 좌표를 주소로 변환 시켜주는 기능 추가
     * 소스 리펙토링
-* 0.2.1
-    * dependency 정리
-    * travis 코드 정리
-* 0.2.2
-    * 결과값이 1개일시 array로 반환 안함
+* 0.1.1
+    * gemspec에 누락된 홈페이지 정보 추가
+* 0.1.0
+    * 첫 버전
+    * 주소를 좌표로 변환 시켜주는 기능 추가

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    naver_map (0.2.1)
+    naver_map (0.2.2)
       rest-client (~> 2.0, >= 2.0.0)
 
 GEM

data/lib/invalid_keys_error.rb

@@ -0,0 +1,11 @@
+class InvalidKeysError < StandardError
+  def initialize(client_id, client_secret)
+    message = """
+    Wrong API keys
+    Given Client ID: #{client_id} (Must be 20 characters of String)
+    Given Client Secret: #{client_secret} (Must be 10 characters of String)
+    """
+
+    puts message
+  end
+end

data/lib/naver_map/version.rb

@@ -1,3 +1,3 @@
 class NaverMap
-  VERSION = '0.2.2'
+  VERSION = '0.2.3'
 end

data/lib/naver_map.rb

@@ -1,6 +1,7 @@
-require 'naver_map/version'
 require 'rest-client'
 require 'json'
+require_relative './naver_map/version'
+require_relative './invalid_keys_error'
 
 class NaverMap
   attr_reader :client_id, :client_secret
@@ -11,6 +12,8 @@ class NaverMap
   def initialize(client_id, client_secret)
     @client_id = client_id
     @client_secret = client_secret
+
+    validate!
   end
 
   def address_to_coordinates(address)
@@ -29,6 +32,15 @@ class NaverMap
 
   private
 
+  def validate!
+    raise InvalidKeysError.new(client_id, client_secret) unless valid_keys?
+  end
+
+  def valid_keys?
+    client_id.is_a?(String) && client_id.length == 20 &&
+      client_secret.is_a?(String) && client_secret.length == 10
+  end
+
   def request_to_naver(url, *params)
     RestClient.get(url, params: { query: params.join(',') },
                    'X-Naver-Client-Id': client_id,
@@ -38,17 +50,23 @@ class NaverMap
   def query(url, *params)
     request_to_naver(url, params)
   rescue RestClient::ExceptionWithResponse => err
-    err.response.body
+    err.response
   end
 
-  def get_result(body)
-    JSON.parse(body, symbolize_names: true)[:result]
+  def render_json(body)
+    JSON.parse(body, symbolize_names: true)
   end
 
   def extract_result(content, result_type)
-    result = get_result(content)[:items]
+    result_json  = render_json(content)
+
+    if result_json[:result]
+      result_items = result_json[:result][:items]
 
-    return result.first[result_type] unless result.size > 1
-    result.map { |element| element[result_type] }
+      return result_items.first[result_type] unless result_items.size > 1
+      result_items.map { |item| item[result_type] }
+    else
+      result_json
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: naver_map
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Penguin
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-11-09 00:00:00.000000000 Z
+date: 2016-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -106,6 +106,7 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
+- lib/invalid_keys_error.rb
 - lib/naver_map.rb
 - lib/naver_map/version.rb
 - naver_map.gemspec