nationbuilder-rb 1.5.0 → 1.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c5dbf155a35ce3dc4e6e6a589a2e21ee3cc72c8a
-  data.tar.gz: fa021eae289bd54ce766f9830c8209d9945fbf86
+  metadata.gz: 14a29218206ac57d5dfab65c415aa96556baafab
+  data.tar.gz: 458e780eab970154448bf04728c91f8013074bd2
 SHA512:
-  metadata.gz: 2c52251b51f1f8e525d18bfd7bf3875a480a525a32176441c6770bbe300ac5e532aa5d84aecb0cdacb2dde1f6aca278482f74a99c797b8877183e985e9d7f7df
-  data.tar.gz: 5391541f46bc04bad1e0e7eab1332094b52c917f3d2b7c4d30a4bca22aca0591b8c770e9266c52fa03e3445e92e9c2c48a7165a9ccb3189ec292dcb9a4e0de33
+  metadata.gz: e6ee8bea7f26f66286e207800beb8b9e86e206ee0fdc7c92d281319246f20f19d57594cd6639639f8e7065a2c2473df5a66898a1d2f0bf0c17810d07f8e1108f
+  data.tar.gz: 50712c5c46c8da59efafb3313a7bfbef67d6524b869d1f70a39bfee91cf62ddc3bb4744aa305620f7c1efeb1dfb48f2e98f55b71e6b40177929c0e2d36a3caaa

data/CHANGELOG.md

@@ -1,5 +1,9 @@
+# 1.6.0
+- [#40] Remove appending `status_code` to the parsed response and ensure
+  the `response` for the last request is always accessible via the client
+
 # 1.5.0
-- [#31] Allow for a user provided HTTPClient 
+- [#31] Allow for a user provided HTTPClient
 
 # 1.4.3
 - [#34] Fix `Content-Type` header check

data/lib/nationbuilder/client.rb

@@ -76,14 +76,13 @@ class NationBuilder::Client
   end
 
   def perform_request_with_retries(method, url, request_args)
-    raw_response = nil
     parsed_response = nil
     exception_to_reraise = nil
 
     (@retries + 1).times do |i|
       begin
-        raw_response = @http_client.send(method, url, request_args)
-        parsed_response = parse_response_body(raw_response)
+        set_response(@http_client.send(method, url, request_args))
+        parsed_response = parse_response_body(response)
       rescue NationBuilder::RateLimitedError => e
         exception_to_reraise = e
         Kernel.sleep(RETRY_DELAY * 2**i)
@@ -96,11 +95,8 @@ class NationBuilder::Client
     end
 
     # If the retry cycle ended with an error, reraise it
-    if exception_to_reraise
-      raise exception_to_reraise
-    end
+    raise exception_to_reraise if exception_to_reraise
 
-    set_response(raw_response)
     parsed_response
   end
 
@@ -133,7 +129,7 @@ class NationBuilder::Client
       return true
     end
 
-    parsed_body(response.body).merge('status_code' => response.code)
+    parsed_body(response.body)
   end
 
   def print_all_descriptions

data/lib/nationbuilder/version.rb

@@ -1,5 +1,5 @@
 module NationBuilder
 
-  VERSION = '1.5.0'.freeze
+  VERSION = '1.6.0'.freeze
 
 end

data/nationbuilder-rb.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["David Huie", "Alexandre Schmitt"]
-  s.date = "2016-12-06"
+  s.date = "2017-03-27"
   s.description = "A Ruby client to the NationBuilder API"
   s.email = "schmitt@nationbuilder.com"
   s.executables = ["nbdoc"]

data/spec/lib/nationbuilder/client_spec.rb

@@ -63,7 +63,7 @@ describe NationBuilder::Client do
     it 'should handle a parametered GET' do
       VCR.use_cassette('parametered_get') do
         response = client.call(:basic_pages, :index, site_slug: 'organizeralexandreschmitt', limit: 11)
-        expect(response['status_code']).to eq(200)
+        expect(client.response.status).to eq(200)
         response['results'].each do |result|
           expect(result['site_slug']).to eq('organizeralexandreschmitt')
         end
@@ -83,10 +83,21 @@ describe NationBuilder::Client do
         client.call(:people, :create, params)
       end
 
-      expect(response['status_code']).to eq(201)
+      expect(client.response.status).to eq(201)
       expect(response['person']['first_name']).to eq('Bob')
     end
 
+    context 'errored request' do
+      it 'sets the response on the client' do
+        VCR.use_cassette('errored_get') do
+          expect do
+            client.call(:people, :show, id: 0)
+          end.to raise_error(NationBuilder::ClientError)
+          expect(client.response.status).to eq(404)
+        end
+      end
+    end
+
     context 'fire_webhooks' do
 
       it 'should disable webhooks' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nationbuilder-rb
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.6.0
 platform: ruby
 authors:
 - David Huie
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-06 00:00:00.000000000 Z
+date: 2017-03-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient
@@ -188,7 +188,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: A Ruby client to the NationBuilder API