nasl-pedant 0.0.9 → 0.1.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YTMwZjIxMTcwYzEzYTEyNGVmNWU5OTg1MmY2YWMyZjJmYjFiYjNhMg==
+    MzAxNGZlNTBhZWE1ODNkNTYyNjgxZmYxM2Y2NGNkYTgyMjhjMDY0ZQ==
   data.tar.gz: !binary |-
-    MzNmOGUwY2E5NDFjZjgzZDg3ZGM1YzNhMDY4NjkzN2I0OGE1OWIxZA==
+    ODlhZTc4MGMxMjdlZGYzYzBiYWY4NDYzMzUzNGNmMGNlODU2ZDhlOQ==
 SHA512:
   metadata.gz: !binary |-
-    M2M4MzkzMmJhYjJkZTYzM2VjODVmNjM4ODMzMjM0OGNiMTg3MWJlZWNkMDEx
-    MDVjYThiMjRjZGQ2ZDJjM2YzMGUxMTMyNDNlMGEzZjRkZDQwZDU3Y2I5ZWQ2
-    MTA5NzU2NjIxNDY5MGZhYWEzOWViOTRkYmZmNTQ1OTA3ZmVlODM=
+    N2E5MGRlNzE4MTk0ZWM1ODU2NTMwYWVlZTRlYjEwMDBjMDViM2ZjMjhiMTJh
+    YTQzYTRhODE1NTQwNzJhOWI2ZWY5MzUxZjJkNmZkMjQwNTZkOTc5ODMwZDE4
+    ZTYwMzUzOGE2ZTI5ODE3YTg1NmIzMjc1MGMzNzZkMjBlYTQzMzc=
   data.tar.gz: !binary |-
-    MzMwN2Q3YjliZWE1YjIzNGUxNThkYThiMWI4Y2MyZDYyM2M5MGQ5ZTc1NTkx
-    YzYwNmY5Y2M5OTQ5OTU4MTBkOGQ3ZmZkZDU3NTc4MTZjYmJlMTVlNGNmMGY0
-    YzVmOTliMDQ3NTkyZWMzNDlmZGIyOGM3ZDVkNmY1NDkxOGRmZTI=
+    ZGE5MDdjNGNmMjk0ZjI2YWVkNzViY2U2MzU4MGQ4NTdkN2YyNjk0OWJmYzE0
+    N2ZjOWY0ZTVhZDgxOGRlYmFkNmJiN2Y4MDMwMjY1MjM3YmVlMDI1ZmUxOTE0
+    MzA5MjkzMTM3YjlmZDUzN2Q5MTNlOWE3N2FjMzI2NzFhOGZhYmY=

data/lib/pedant/checks/arity_of_builtins.rb

@@ -0,0 +1,99 @@
+################################################################################
+# Copyright (c) 2015, Tenable Network Security
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+require 'set'
+
+module Pedant
+  class CheckArityOfBuiltins < Check
+    @@anon_arity_of_one = Set.new [
+      "isnull",
+      "usleep",
+      "sleep",
+      "keys",
+      "max_index",
+      "typeof",
+      "defined_func",
+      "bn_dec2raw",
+      "bn_raw2dec",
+      "bn_hex2raw",
+      "bn_raw2hex",
+      "bn_sqr",
+      "fread",
+      "unlink",
+      "readdir",
+      "mkdir",
+      "rmdir",
+      "SHA",
+      "SHA1",
+      "SHA224",
+      "SHA256",
+      "SHA384",
+      "SHA512",
+      "RIPEMD160",
+      "MD2",
+      "MD4",
+      "MD5",
+      "get_kb_item",
+      "get_kb_list",
+      "get_global_kb_item",
+      "get_global_kb_list",
+    ]
+
+    def self.requires
+      super + [:trees]
+    end
+
+    def check(file, tree)
+      tree.all(:Call).each do |call|
+        next unless @@anon_arity_of_one.include? call.name.ident.name
+        next unless call.name.indexes == []
+        next unless call.args.length != 1 or call.args.first.type != :anonymous
+
+        fail
+        report(:error, "The builtin function '#{call.name.ident.name}' takes a single anonymous argument.")
+
+        # Pick the right thing to highlight.
+        if call.args.length == 0
+          report(:error, call.context(call))
+        elsif call.args.first.type != :anonymous
+          report(:error, call.args[0].context(call))
+        elsif call.args.length > 1
+          report(:error, call.args[1].context(call))
+        else
+          raise "hello"
+        end
+      end
+    end
+
+    def run
+      # This check will pass by default.
+      pass
+
+      # Run this check on the tree from every file.
+      @kb[:trees].each { |file, tree| check(file, tree) }
+    end
+  end
+end

data/lib/pedant/checks/nonsense_comparison.rb

@@ -0,0 +1,92 @@
+################################################################################
+# Copyright (c) 2015, Tenable Network Security
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+require 'set'
+
+module Pedant
+  class CheckNonsenseComparison < Check
+    def self.requires
+      super + [:trees]
+    end
+
+    def check(file, tree)
+      literals = Set.new [
+        Nasl::Array,
+        Nasl::List,
+        Nasl::Integer,
+        Nasl::String,
+        Nasl::Ip
+      ]
+
+      comparisons = Set.new [ "==", "!=", "=~", "!~", "><", ">!<", "<", ">", "<=", ">=" ]
+
+      # isnull() with a literal (never FALSE).
+      tree.all(:Call).each do |call|
+        next if call.name.ident.name != "isnull"
+        next if call.name.indexes != []
+        next if call.args.length != 1
+        next if not literals.include? call.args.first.expr.class
+        fail
+        report(:error, "isnull() is called with a literal, which can never be FALSE.")
+        report(:error, call.args.first.context(call))
+      end
+
+      # Comparing a literal to another literal (either TRUE or FALSE, but pointless).
+      tree.all(:Expression).each do |expr|
+        next if not literals.include? expr.lhs.class
+        next if not literals.include? expr.rhs.class
+        next if not comparisons.include? expr.op.to_s
+        fail
+        report(:error, "Comparing two literals is always TRUE or FALSE.")
+        report(:error, expr.op.context(expr))
+      end
+
+      # Comparing something against itself.
+      tree.all(:Expression).each do |expr|
+        next if not comparisons.include? expr.op.to_s
+        next if not expr.lhs.is_a? Nasl::Lvalue
+        next if not expr.rhs.is_a? Nasl::Lvalue
+        # Compare the XML representations of the two Lvalues.
+        # Handles integer keys nicely, so these two are the same: a[0x01] == a[1]
+        xmls = [:lhs, :rhs].map do |side|
+          expr.send(side).to_xml(Builder::XmlMarkup.new)
+        end
+        next if xmls[0] != xmls[1]
+        fail
+        report(:error, "Comparing two identical Lvalues. This will always be TRUE.")
+        report(:error, expr.op.context(expr))
+      end
+    end
+
+    def run
+      # This check will pass by default.
+      pass
+
+      # Run this check on the tree from every file.
+      @kb[:trees].each { |file, tree| check(file, tree) }
+    end
+  end
+end

data/lib/pedant/checks/uses_octal_integers.rb

@@ -0,0 +1,61 @@
+################################################################################
+# Copyright (c) 2015, Tenable Network Security
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+module Pedant
+  class CheckUsesOctalIntegers < Check
+    def self.requires
+      super + [:trees]
+    end
+
+    def check(file, tree)
+      tree.all(:Integer).select { |i| i.tokens.first.type == :INT_OCT }.each do |i|
+        next if i.value == 0 # Lots of plugins use '00' or '0000', which is ok.
+        warn
+        report(:warn, "NASL integers beginning with '0' with all digits between 0-7 are octal.")
+        report(:warn, "This integer will have decimal value '#{i.value}'.")
+        report(:warn, i.context(i))
+      end
+
+      tree.all(:Integer).select { |i| i.tokens.first.type == :INT_DEC }.each do |i|
+        next if i.value == 0 # Lots of plugins use '00' or '0000', which is ok.
+        next if not i.tokens.first.body =~ /^0[0-9]/
+        warn
+        report(:warn, "This integer appears to be octal, but will be interpreted as decimal.")
+        report(:warn, "NASL integers beginning with '0' with all digits between 0-7 are octal.")
+        report(:warn, "Remove the leading '0' to make it clear this integer should be decimal.")
+        report(:warn, i.context(i))
+      end
+    end
+
+    def run
+      # This check will pass by default.
+      pass
+
+      # Run this check on the tree from every file.
+      @kb[:trees].each { |file, tree| check(file, tree) }
+    end
+  end
+end

data/lib/pedant/version.rb

@@ -1,3 +1,3 @@
 module Pedant
-  VERSION = '0.0.9'
+  VERSION = '0.1.0'
 end

data/test/unit/checks/test_arity_of_builtins.rb

@@ -0,0 +1,85 @@
+################################################################################
+# Copyright (c) 2015, Tenable Network Security
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+class TestArityOfBuiltins < Test::Unit::TestCase
+  include Pedant::Test
+
+  def test_none
+    check(
+      :pass,
+      :CheckConditionalContainsAssignment,
+      %q||
+    )
+  end
+
+  def test_correct
+    check(
+      :pass,
+      :CheckArityOfBuiltins,
+      %q|get_kb_item("hello");|
+    )
+  end
+
+  def test_no_args
+    check(
+      :fail,
+      :CheckArityOfBuiltins,
+      %q|get_kb_item();|
+    )
+  end
+
+  def test_named
+    check(
+      :fail,
+      :CheckArityOfBuiltins,
+      %q|get_kb_item(key:"hello");|
+    )
+  end
+
+  def test_two_anon
+    check(
+      :fail,
+      :CheckArityOfBuiltins,
+      %q|get_kb_item("service/", port);|
+    )
+  end
+
+  def test_three_anon
+    check(
+      :fail,
+      :CheckArityOfBuiltins,
+      %q|get_kb_item("hello/", port, "/property");|
+    )
+  end
+
+  def test_one_anon_one_named
+    check(
+      :fail,
+      :CheckArityOfBuiltins,
+      %q|get_kb_item("hello/", index:index);|
+    )
+  end
+end

data/test/unit/checks/test_nonsense_comparison.rb

@@ -0,0 +1,157 @@
+################################################################################
+# Copyright (c) 2015, Tenable Network Security
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+class TestNonsenseComparison < Test::Unit::TestCase
+  include Pedant::Test
+
+  def test_none
+    check(
+      :pass,
+      :CheckNonsenseComparison,
+      %q||
+    )
+  end
+
+  def test_isnull_call
+    check(
+      :pass,
+      :CheckNonsenseComparison,
+      %q|isnull(recv());|
+    )
+  end
+
+  def test_isnull_identifier
+    check(
+      :pass,
+      :CheckNonsenseComparison,
+      %q|isnull(some_variable);|
+    )
+  end
+
+  def test_isnull_literal_string
+    check(
+      :fail,
+      :CheckNonsenseComparison,
+      %q|isnull("hello");|
+    )
+  end
+
+  def test_isnull_literal_string
+    check(
+      :fail,
+      :CheckNonsenseComparison,
+      %q|isnull(6);|
+    )
+  end
+
+  def test_literal_comparison_eq
+    check(
+      :fail,
+      :CheckNonsenseComparison,
+      %q|if ("hello" == 5) {};|
+    )
+  end
+
+  def test_literal_comparison_substr
+    check(
+      :fail,
+      :CheckNonsenseComparison,
+      %q|if ("he" >< "hello") {};|
+    )
+  end
+
+  def test_literal_comparison_regex
+    check(
+      :fail,
+      :CheckNonsenseComparison,
+      %q|if ("name" =~ "pedant") {};|
+    )
+  end
+
+  def test_different_simple
+    check(
+      :pass,
+      :CheckNonsenseComparison,
+      %q|if (a == b) {};|
+    )
+  end
+
+  def test_same_simple
+    check(
+      :fail,
+      :CheckNonsenseComparison,
+      %q|if (a == a) {};|
+    )
+  end
+
+  def test_different_indexes
+    check(
+      :pass,
+      :CheckNonsenseComparison,
+      %q|if (a[1] == a[2]) {};|
+    )
+  end
+
+  def test_same_indexes
+    check(
+      :fail,
+      :CheckNonsenseComparison,
+      %q|if (a[1] == a[1]) {};|
+    )
+  end
+
+  def test_same_indexes_with_different_base
+    check(
+      :fail,
+      :CheckNonsenseComparison,
+      %q|if (a[1] == a[0x01]) {};|
+    )
+  end
+
+  def test_multiple_index_types
+    check(
+      :fail,
+      :CheckNonsenseComparison,
+      %q|if (a[1]["hello"][b] == a[1]["hello"][b]) {};|
+    )
+  end
+
+  def test_indexes_with_other_lvalues
+    check(
+      :fail,
+      :CheckNonsenseComparison,
+      %q|if (a[1]["hello"][b.hello["woo"].yay] == a[1]["hello"][b.hello["woo"].yay]) {};|
+    )
+  end
+
+  def test_calls
+    check(
+      :pass,
+      :CheckNonsenseComparison,
+      %q|if (a[1] == a[0x01]()) {};|
+    )
+  end
+end

data/test/unit/checks/test_uses_octal_integers.rb

@@ -0,0 +1,85 @@
+################################################################################
+# Copyright (c) 2015, Tenable Network Security
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+class TestUsesOctalIntegers < Test::Unit::TestCase
+  include Pedant::Test
+
+  def test_none
+    check(
+      :pass,
+      :CheckUsesOctalIntegers,
+      %q||
+    )
+  end
+
+  def test_octal_literal_integer
+    check(
+      :warn,
+      :CheckUsesOctalIntegers,
+      %q|if (a = 057) { exit(); }|
+    )
+  end
+
+  def test_nearly_octal_integer
+    check(
+      :warn,
+      :CheckUsesOctalIntegers,
+      %q|if (a = 099) { exit(); }|
+    )
+  end
+
+  def test_octal_all_zeroes_short
+    check(
+      :pass,
+      :CheckUsesOctalIntegers,
+      %q|if (a = 00) { exit(); }|
+    )
+  end
+
+  def test_octal_all_zeroes_longer
+    check(
+      :pass,
+      :CheckUsesOctalIntegers,
+      %q|if (a = 000000) { exit(); }|
+    )
+  end
+
+  def test_decimal_literal
+    check(
+      :pass,
+      :CheckUsesOctalIntegers,
+      %q|if (a = 10) { exit(); }|
+    )
+  end
+
+  def test_hexadecimal_literal
+    check(
+      :pass,
+      :CheckUsesOctalIntegers,
+      %q|if (a = 0x10) { exit(); }|
+    )
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nasl-pedant
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.1.0
 platform: ruby
 authors:
 - Mak Kolybabi
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-23 00:00:00.000000000 Z
+date: 2015-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -77,6 +77,7 @@ files:
 - bin/pedant
 - lib/pedant.rb
 - lib/pedant/check.rb
+- lib/pedant/checks/arity_of_builtins.rb
 - lib/pedant/checks/conditional_contains_assignment.rb
 - lib/pedant/checks/conditional_or_loop_is_empty.rb
 - lib/pedant/checks/confusing_variable_names.rb
@@ -90,6 +91,7 @@ files:
 - lib/pedant/checks/files_parse_without_errors.rb
 - lib/pedant/checks/flipped_operands_on_match_or_substring.rb
 - lib/pedant/checks/local_variable_unused.rb
+- lib/pedant/checks/nonsense_comparison.rb
 - lib/pedant/checks/parse_test_code.rb
 - lib/pedant/checks/plugin_type_not_specified.rb
 - lib/pedant/checks/script_category.rb
@@ -97,6 +99,7 @@ files:
 - lib/pedant/checks/script_id.rb
 - lib/pedant/checks/script_name.rb
 - lib/pedant/checks/script_summary.rb
+- lib/pedant/checks/uses_octal_integers.rb
 - lib/pedant/cli.rb
 - lib/pedant/command.rb
 - lib/pedant/commands/check.rb
@@ -106,6 +109,7 @@ files:
 - lib/pedant/version.rb
 - pedant.gemspec
 - test/test_helper.rb
+- test/unit/checks/test_arity_of_builtins.rb
 - test/unit/checks/test_conditional_contains_assignment.rb
 - test/unit/checks/test_conditional_or_loop_is_empty.rb
 - test/unit/checks/test_confusing_variable_names.rb
@@ -117,8 +121,10 @@ files:
 - test/unit/checks/test_ends_with_newline.rb
 - test/unit/checks/test_equality_with_regex.rb
 - test/unit/checks/test_flipped_operands_on_match_or_substring.rb
+- test/unit/checks/test_nonsense_comparison.rb
 - test/unit/checks/test_plugin_type_not_specified.rb
 - test/unit/checks/test_script_family_not_specified.rb
+- test/unit/checks/test_uses_octal_integers.rb
 homepage: http://github.com/tenable/pedant
 licenses:
 - BSD
@@ -145,6 +151,7 @@ specification_version: 4
 summary: A framework for the Nessus Attack Scripting Language.
 test_files:
 - test/test_helper.rb
+- test/unit/checks/test_arity_of_builtins.rb
 - test/unit/checks/test_conditional_contains_assignment.rb
 - test/unit/checks/test_conditional_or_loop_is_empty.rb
 - test/unit/checks/test_confusing_variable_names.rb
@@ -156,5 +163,7 @@ test_files:
 - test/unit/checks/test_ends_with_newline.rb
 - test/unit/checks/test_equality_with_regex.rb
 - test/unit/checks/test_flipped_operands_on_match_or_substring.rb
+- test/unit/checks/test_nonsense_comparison.rb
 - test/unit/checks/test_plugin_type_not_specified.rb
 - test/unit/checks/test_script_family_not_specified.rb
+- test/unit/checks/test_uses_octal_integers.rb