nasl-pedant 0.0.2 → 0.0.3

data/Rakefile

@@ -1,8 +1,20 @@
+$LOAD_PATH.unshift File.expand_path("../lib", __FILE__)
+
 require 'bundler/gem_tasks'
+require 'rake'
+require 'rake/clean'
 require 'rake/testtask'
 
 Rake::TestTask.new do |t|
   t.libs << 'test'
-  t.test_files = FileList['test/**/test*.rb']
-  t.verbose = true
+  t.test_files = FileList['test/**/test_*.rb']
 end
+
+desc "Produce a fully-functional application."
+task :compile => :test
+
+task :build => :compile do
+  system "gem build pedant.gemspec"
+end
+
+task :default => :compile

data/lib/pedant/checks/plugin_type_not_specified.rb

@@ -1,5 +1,5 @@
 ################################################################################
-# Copyright (c) 2011, Mak Kolybabi
+# Copyright (c) 2011-2012, Mak Kolybabi
 # All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
@@ -52,7 +52,7 @@ module Pedant
         next if !arg.is_a? Nasl::String
 
         # Ensure that the plugin type is valid.
-        unless ['combined', 'local', 'remote'].include? arg.text
+        unless ['combined', 'local', 'reputation', 'remote', 'settings', 'thirdparty'].include? arg.text
           report(:info, "Plugin is of unknown type #{arg.text}:\n#{arg.context(node)}")
           return fail
         end

data/lib/pedant/checks/script_family_not_specified.rb

@@ -0,0 +1,87 @@
+################################################################################
+# Copyright (c) 2012, Mak Kolybabi
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+module Pedant
+  class CheckScriptFamilyNotSpecified < Check
+    def self.requires
+      super + [:main, :trees]
+    end
+
+    def run
+      # This check only applies to plugins.
+      return skip unless @kb[:main].extname == '.nasl'
+
+      args = []
+
+      tree = @kb[:trees][@kb[:main]]
+
+      tree.all(:Call).each do |node|
+        next unless node.name.name == 'script_family'
+        next if node.args.empty?
+        next unless node.args.first.expr.is_a? Nasl::String
+
+        # Pull out argument
+        arg = node.args.first.expr
+
+        # Ensure that the script family is valid.
+        unless ["AIX Local Security Checks", "Backdoors", "Brute force attacks",
+          "CentOS Local Security Checks", "CGI abuses", "CISCO", "Databases",
+          "Debian Local Security Checks", "Default Unix Accounts",
+          "Denial of Service", "DNS", "Fedora Local Security Checks",
+          "Finger abuses", "Firewalls", "FTP", "Gain a shell remotely",
+          "General", "Gentoo Local Security Checks", "HP-UX Local Security Checks",
+          "MacOS X Local Security Checks", "Mandriva Local Security Checks",
+          "Misc.", "Netware", "Peer-To-Peer File Sharing", "Port scanners",
+          "Red Hat Local Security Checks", "RPC", "SCADA", "Service detection",
+          "Settings", "Slackware Local Security Checks", "SMTP problems",
+          "SNMP", "Solaris Local Security Checks", "SuSE Local Security Checks",
+          "Ubuntu Local Security Checks", "VMware ESX Local Security Checks",
+          "Web Servers", "Windows"].include? arg.text
+
+          report(:info, "Plugin belongs to unknown #{arg.text}:\n#{arg.context(node)}")
+          return fail
+        end
+
+        args << [arg, node]
+      end
+
+      case args.length
+      when 0
+        report(:error, "Plugin does not specify a script_family.")
+        fail
+      when 1
+        arg = args.first[0]
+        call = args.first[1]
+        report(:info, "Plugin belongs to script family #{arg.text}:\n#{arg.context(call)}")
+        pass
+      else
+        report(:error, "Plugin specifies multiple script family's.")
+        args.each { |arg, call| report(:error, arg.context(call)) }
+        fail
+      end
+    end
+  end
+end

data/lib/pedant/test.rb

@@ -40,6 +40,10 @@ module Pedant
       Check.initialize!
     end
 
+    def setup
+      Check.initialize!
+    end
+
     def check(result, cls, code)
       # Create a knowledge base.
       kb = KnowledgeBase.new(:test_mode)

data/lib/pedant/version.rb

@@ -1,3 +1,3 @@
 module Pedant
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/pedant.gemspec

@@ -1,25 +1,27 @@
 # -*- encoding: utf-8 -*-
 $:.push File.expand_path('../lib', __FILE__)
+
 require 'pedant/version'
 
 Gem::Specification.new do |s|
   s.name        = 'nasl-pedant'
   s.version     = Pedant::VERSION
+  s.license     = 'BSD'
+  s.homepage    = 'http://github.com/tenable/pedant'
+  s.summary     = 'A static analysis framework for the Nessus Attack Scripting Language.'
+
   s.authors     = ['Mak Kolybabi']
   s.email       = ['mak@kolybabi.com']
-  s.homepage    = 'http://github.com/mogigoma/pedant'
-  s.summary     = %q{A static analysis framework for the Nessus Attack Scripting Language.}
 
   s.rubyforge_project = 'nasl-pedant'
 
   s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
+  s.test_files    = `git ls-files -- test/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ['lib']
 
   s.add_development_dependency 'rake'
-  s.add_development_dependency 'minitest'
 
   s.add_runtime_dependency 'rainbow'
-  s.add_runtime_dependency 'nasl', '>= 0.0.4'
+  s.add_runtime_dependency 'nasl', '>= 0.0.7'
 end

data/test/unit/checks/{plugin_type_not_specified.rb → test_plugin_type_not_specified.rb}

@@ -1,5 +1,5 @@
 ################################################################################
-# Copyright (c) 2011, Mak Kolybabi
+# Copyright (c) 2011-2012, Mak Kolybabi
 # All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
@@ -53,7 +53,7 @@ class TestPluginTypeNotSpecified < Test::Unit::TestCase
   end
 
   def test_valid
-    ['combined', 'local', 'remote'].each do |type|
+    ['combined', 'local', 'reputation', 'remote', 'settings', 'thirdparty'].each do |type|
       check(
         :pass,
         :CheckPluginTypeNotSpecified,

data/test/unit/checks/test_script_family_not_specified.rb

@@ -0,0 +1,86 @@
+################################################################################
+# Copyright (c) 2012, Mak Kolybabi
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+class TestScriptFamilyNotSpecified < Test::Unit::TestCase
+  include Pedant::Test
+
+  def test_none
+    check(
+      :fail,
+      :CheckScriptFamilyNotSpecified,
+      %q||
+    )
+  end
+
+  def test_one
+    check(
+      :pass,
+      :CheckScriptFamilyNotSpecified,
+      %q|script_family("Windows");|
+    )
+  end
+
+  def test_many
+    check(
+      :fail,
+      :CheckScriptFamilyNotSpecified,
+      %q|script_family("Windows");| +
+      %q|script_family("FTP");|
+    )
+  end
+
+  def test_valid
+    [
+      "AIX Local Security Checks", "Backdoors", "Brute force attacks",
+      "CentOS Local Security Checks", "CGI abuses", "CISCO", "Databases",
+      "Debian Local Security Checks", "Default Unix Accounts",
+      "Denial of Service", "DNS", "Fedora Local Security Checks",
+      "Finger abuses", "Firewalls", "FTP", "Gain a shell remotely",
+      "General", "Gentoo Local Security Checks", "HP-UX Local Security Checks",
+      "MacOS X Local Security Checks", "Mandriva Local Security Checks",
+      "Misc.", "Netware", "Peer-To-Peer File Sharing", "Port scanners",
+      "Red Hat Local Security Checks", "RPC", "SCADA", "Service detection",
+      "Settings", "Slackware Local Security Checks", "SMTP problems",
+      "SNMP", "Solaris Local Security Checks", "SuSE Local Security Checks",
+      "Ubuntu Local Security Checks", "VMware ESX Local Security Checks",
+      "Web Servers", "Windows"
+    ].each do |type|
+      check(
+        :pass,
+        :CheckScriptFamilyNotSpecified,
+        %Q|script_family("#{type}");|
+      )
+    end
+  end
+
+  def test_invalid
+    check(
+      :fail,
+      :CheckScriptFamilyNotSpecified,
+      %q|script_family("foo bar");|
+    )
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nasl-pedant
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-01-26 00:00:00.000000000Z
+date: 2012-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &17202279320 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,21 +21,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *17202279320
-- !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: &17202278900 !ruby/object:Gem::Requirement
+  version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: *17202278900
 - !ruby/object:Gem::Dependency
   name: rainbow
-  requirement: &17202278380 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,18 +37,28 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *17202278380
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: nasl
-  requirement: &17202277820 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.0.4
+        version: 0.0.7
   type: :runtime
   prerelease: false
-  version_requirements: *17202277820
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.0.7
 description: 
 email:
 - mak@kolybabi.com
@@ -79,6 +83,7 @@ files:
 - lib/pedant/checks/files_parse_without_error.rb
 - lib/pedant/checks/parse_test_code.rb
 - lib/pedant/checks/plugin_type_not_specified.rb
+- lib/pedant/checks/script_family_not_specified.rb
 - lib/pedant/cli.rb
 - lib/pedant/command.rb
 - lib/pedant/commands/check.rb
@@ -88,16 +93,18 @@ files:
 - lib/pedant/version.rb
 - pedant.gemspec
 - test/test_helper.rb
-- test/unit/checks/conditional_or_loop_is_empty.rb
-- test/unit/checks/contains_ip_address_literals.rb
-- test/unit/checks/contains_no_carriage_returns.rb
-- test/unit/checks/contains_no_tabs.rb
-- test/unit/checks/contains_registration_section.rb
-- test/unit/checks/contains_unreachable_code.rb
-- test/unit/checks/ends_with_newline.rb
-- test/unit/checks/plugin_type_not_specified.rb
-homepage: http://github.com/mogigoma/pedant
-licenses: []
+- test/unit/checks/test_conditional_or_loop_is_empty.rb
+- test/unit/checks/test_contains_ip_address_literals.rb
+- test/unit/checks/test_contains_no_carriage_returns.rb
+- test/unit/checks/test_contains_no_tabs.rb
+- test/unit/checks/test_contains_registration_section.rb
+- test/unit/checks/test_contains_unreachable_code.rb
+- test/unit/checks/test_ends_with_newline.rb
+- test/unit/checks/test_plugin_type_not_specified.rb
+- test/unit/checks/test_script_family_not_specified.rb
+homepage: http://github.com/tenable/pedant
+licenses:
+- BSD
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -108,16 +115,32 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -4147162296377566136
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -4147162296377566136
 requirements: []
 rubyforge_project: nasl-pedant
-rubygems_version: 1.8.10
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: A static analysis framework for the Nessus Attack Scripting Language.
-test_files: []
+test_files:
+- test/test_helper.rb
+- test/unit/checks/test_conditional_or_loop_is_empty.rb
+- test/unit/checks/test_contains_ip_address_literals.rb
+- test/unit/checks/test_contains_no_carriage_returns.rb
+- test/unit/checks/test_contains_no_tabs.rb
+- test/unit/checks/test_contains_registration_section.rb
+- test/unit/checks/test_contains_unreachable_code.rb
+- test/unit/checks/test_ends_with_newline.rb
+- test/unit/checks/test_plugin_type_not_specified.rb
+- test/unit/checks/test_script_family_not_specified.rb