nasl-pedant 0.0.1

data/.gitignore

@@ -0,0 +1,10 @@
+# Ruby gems files.
+*.gem
+.bundle
+Gemfile.lock
+pkg/*
+
+# Editor scratch files.
+\#*
+*~
+*.swp

data/Gemfile

@@ -0,0 +1,4 @@
+source 'http://rubygems.org'
+
+# Specify your gem's dependencies in pedant.gemspec
+gemspec

data/Rakefile

@@ -0,0 +1,8 @@
+require 'bundler/gem_tasks'
+require 'rake/testtask'
+
+Rake::TestTask.new do |t|
+  t.libs << 'test'
+  t.test_files = FileList['test/**/test*.rb']
+  t.verbose = true
+end

data/bin/pedant

@@ -0,0 +1,33 @@
+#!/usr/bin/env ruby
+
+################################################################################
+# Copyright (c) 2011, Mak Kolybabi
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+$LOAD_PATH.unshift(File.expand_path('../../lib', __FILE__))
+
+require 'pedant'
+
+Pedant::Cli.run

data/lib/pedant/check.rb

@@ -0,0 +1,135 @@
+################################################################################
+# Copyright (c) 2011, Mak Kolybabi
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+module Pedant
+  class Check
+    attr_reader :result
+
+    @@statuses = {
+      :died => 'DIED'.color(:red),
+      :fail => 'FAIL'.color(:red),
+      :pass => 'PASS'.color(:green),
+      :skip => 'SKIP'.color(:green),
+      :warn => 'WARN'.color(:yellow),
+      :void => 'VOID'.color(:magenta)
+    }
+
+    @@levels = [:error, :warn, :info]
+
+    def self.initialize!
+      Dir.glob(Pedant.lib + 'pedant/checks/*.rb').each { |f| load(f) }
+    end
+
+    def initialize(kb)
+      @report = []
+      @result = :void
+
+      @kb = kb
+
+      # Run all the dependencies for this check if we're in test mode.
+      return unless @kb[:test_mode]
+      self.class.depends.each do |cls|
+        chk = cls.new(@kb)
+        chk.run
+      end
+    end
+
+    def self.all
+      (@_all ||= [])
+    end
+
+    def self.inherited(cls)
+      all << cls
+    end
+
+    def self.provides
+      return []
+    end
+
+    def self.requires
+      return []
+    end
+
+    def self.ready?(kb)
+      self.requires.reduce(true) do |stat, req|
+        stat && kb.has_key?(req)
+      end
+    end
+
+    def self.depends
+      keys = self.requires
+
+      Check.all.reject do |cls|
+        (cls.provides & keys).empty?
+      end
+    end
+
+    def report(level, text=nil)
+      if !text.nil?
+        @report << [level, text]
+        return
+      end
+
+      # Convert level from symbol to an array index.
+      level = @@levels.index(level) if level.is_a?(Symbol)
+
+      # Format all components of a report at or below the specified level.
+      msg = @report.select { |l, t| @@levels.index(l) <= level }.map { |l, t| t }.join("\n")
+      msg << "\n" unless msg.empty?
+
+      # Format the check's result.
+      msg = "[#{@@statuses[@result]}] #{self.name}\n#{msg}"
+
+      return msg
+    end
+
+    def name
+      # Mangle the classes name to be more user-friendly.
+      self.class.name.gsub(/.*::/, '').gsub(/^Check/, '').gsub(/([A-Z][^A-Z]*)/, ' \1').strip
+    end
+
+    def fail
+      @result = :fail
+    end
+
+    def fatal
+      report(:error, "This is a fatal error.")
+      @result = :died
+    end
+
+    def pass
+      @result = :pass
+    end
+
+    def skip
+      @result = :skip
+    end
+
+    def warn
+      @result = :warn
+    end
+  end
+end

data/lib/pedant/checks/conditional_or_loop_is_empty.rb

@@ -0,0 +1,70 @@
+################################################################################
+# Copyright (c) 2011, Mak Kolybabi
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+module Pedant
+  class CheckConditionalOrLoopIsEmpty < Check
+    def self.requires
+      super + [:trees]
+    end
+
+    def check(file, tree)
+      # All of the loops have a body attribute, so they can be checked together.
+      [:For, :Foreach, :Repeat, :While].each do |cls|
+        tree.all(cls).each do |node|
+          next unless node.body.is_a? Nasl::Empty
+
+          fail
+
+          report(:error, "#{cls} loop in #{file} has an empty statement as its body.")
+        end
+      end
+
+      # An If statement may has two branches, each of which need to be checked.
+      # This will not cause false positives on If statements without else
+      # clauses, because those branches will be nil.
+      tree.all(:If).each do |node|
+        [:true, :false].each do |name|
+          branch = node.send(name)
+
+          next if branch.nil?
+          next unless branch.is_a? Nasl::Empty
+
+          fail
+
+          report(:error, "If statement in #{file} has an empty statement as #{name} branch.")
+        end
+      end
+    end
+
+    def run
+      # This check will pass by default.
+      pass
+
+      # Run this check on the tree from every file.
+      @kb[:trees].each { |file, tree| check(file, tree) }
+    end
+  end
+end

data/lib/pedant/checks/contains_ip_address_literals.rb

@@ -0,0 +1,49 @@
+################################################################################
+# Copyright (c) 2011, Mak Kolybabi
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+module Pedant
+  class CheckContainsIpAddressLiterals < Check
+    def self.requires
+      super + [:trees]
+    end
+
+    def check(file, tree)
+      return if tree.all(:Ip).empty?
+
+      warn
+      report(:warn, "IP address literals were found in #{file}.")
+      tree.all(:Ip).each { |ip| report(:warn, ip.context) }
+    end
+
+    def run
+      # This check will pass by default.
+      pass
+
+      # Run this check on the tree of every file.
+      @kb[:trees].each { |file, tree| check(file, tree) }
+    end
+  end
+end

data/lib/pedant/checks/contains_no_carriage_returns.rb

@@ -0,0 +1,48 @@
+################################################################################
+# Copyright (c) 2011, Mak Kolybabi
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+module Pedant
+  class CheckContainsNoCarriageReturns < Check
+    def self.requires
+      super + [:codes]
+    end
+
+    def check(file, code)
+      return unless code =~ /\r/
+
+      report(:warn, "Carriage returns were found in #{file}.")
+      warn
+    end
+
+    def run
+      # This check will pass by default.
+      pass
+
+      # Run this check on the code in every file.
+      @kb[:codes].each { |file, code| check(file, code) }
+    end
+  end
+end

data/lib/pedant/checks/contains_no_tabs.rb

@@ -0,0 +1,48 @@
+################################################################################
+# Copyright (c) 2011, Mak Kolybabi
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+module Pedant
+  class CheckContainsNoTabs < Check
+    def self.requires
+      super + [:codes]
+    end
+
+    def check(file, code)
+      return unless code =~ /\t/
+
+      report(:warn, "Tabs were found in #{file}.")
+      warn
+    end
+
+    def run
+      # This check will pass by default.
+      pass
+
+      # Run this check on the code in every file.
+      @kb[:codes].each { |file, code| check(file, code) }
+    end
+  end
+end

data/lib/pedant/checks/contains_registration_section.rb

@@ -0,0 +1,107 @@
+################################################################################
+# Copyright (c) 2011, Mak Kolybabi
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+module Pedant
+  class CheckContainsRegistrationSection < Check
+    def self.requires
+      super + [:main, :trees]
+    end
+
+    def run
+      # This check only applies to plugins.
+      return skip unless @kb[:main].extname == '.nasl'
+
+      # This check will pass by default.
+      pass
+
+      tree = @kb[:trees][@kb[:main]]
+
+      # Find the registration If statement.
+      regs = tree.all(:If).select do |node|
+        (node.cond.is_a?(Nasl::Lvalue) && node.cond.ident.name == 'description')
+      end
+
+      # Ensure there's a registration section.
+      if regs.empty?
+        report(:error, "No registration section was found.")
+        report(:error, "This will cause the plugin to be run twice in both Nessus interface and nasl with the -M flag.")
+        return fail
+      end
+
+      # Ensure that there is only one registration section.
+      unless regs.length == 1
+        report(:error, "Multiple registration sections were found.")
+        regs.each { |reg| report(:error, reg.context) }
+        return fail
+      end
+
+      # Ensure that the registration section is a block.
+      reg = regs.first
+      branch = reg.true
+      unless branch.is_a? Nasl::Block
+        report(:error, "The registration section is a #{branch.class.name}, but a Block was expected.")
+        report(:error, branch.context(reg))
+        return fail
+      end
+
+      # Ensure that the registration section is not empty.
+      if branch.body.empty?
+        report(:error, "The registration section is empty.")
+        report(:error, branch.context(reg))
+        return fail
+      end
+
+      # Ensure that the description section ends with a call to exit.
+      statement = branch.body.last
+      unless statement.is_a? Nasl::Call
+        report(:error, "The registration section ends with a #{statement.class.name}, not a Call as expected.")
+        report(:error, statement.context(reg))
+        return fail
+      end
+
+      unless statement.name.name == 'exit'
+        report(:error, "The registration section ends with a call to #{statement.name.name}, not exit as expected.")
+        report(:error, statement.context(reg))
+        return fail
+      end
+
+      # Ensure that the call to exit is a success without a message.
+      args = statement.args
+      if args.empty?
+        report(:error, "The registration ends with a call to exit with no arguments.")
+        report(:error, statement.context)
+        return fail
+      end
+
+      arg = args.first
+      if args.length != 1 || arg.type != :anonymous || !arg.expr.is_a?(Nasl::Integer) || arg.expr.value != 0
+        report(:error, "The registration section does not end with a call to exit(0).")
+        report(:error, arg.context(statement))
+        return fail
+      end
+    end
+  end
+end

data/lib/pedant/checks/contains_unreachable_code.rb

@@ -0,0 +1,68 @@
+################################################################################
+# Copyright (c) 2011, Mak Kolybabi
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+module Pedant
+  class CheckContainsUnreachableCode < Check
+    def self.requires
+      super + [:trees]
+    end
+
+    def check(file, tree)
+      def check_statements(file, list)
+        list.each do |node|
+          # Check if the Node is capable of jumping out of the Block, without
+          # resuming where it left off (i.e., Call). The exception is exit(),
+          # which is a builtin Function that terminates execution.
+          if node.is_a?(Nasl::Break) || node.is_a?(Nasl::Continue) || node.is_a?(Nasl::Return) || (node.is_a?(Nasl::Call) && node.name.name == 'exit')
+            # If this is not the final node in the list, then there is
+            # absolutely no way for the later nodes to be accessed.
+            if node != list.last
+              report(:error, "#{file} contains unreachable code.")
+              return fail
+            end
+          end
+        end
+      end
+
+      # Unreachable statements occur only when there are sequential lists of
+      # instructions. In layers deeper than the outermost level of indentation,
+      # this only occurs in Blocks.
+      tree.all(:Block).each { |blk| check_statements(file, blk.body) }
+
+      # The main body of a file is not a Block, so it must be considered
+      # separately.
+      check_statements(file, tree)
+    end
+
+    def run
+      # This check will pass by default.
+      pass
+
+      # Run this check on the tree from every file.
+      @kb[:trees].each { |file, tree| check(file, tree) }
+    end
+  end
+end

data/lib/pedant/checks/ends_with_newline.rb

@@ -0,0 +1,49 @@
+################################################################################
+# Copyright (c) 2011, Mak Kolybabi
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1. Redistributions of source code must retain the above copyright notice, this
+#    list of conditions and the following disclaimer.
+#
+# 2. Redistributions in binary form must reproduce the above copyright notice,
+#    this list of conditions and the following disclaimer in the documentation
+#    and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+################################################################################
+
+module Pedant
+  class CheckEndsWithNewline < Check
+    def self.requires
+      super + [:codes]
+    end
+
+    def check(file, code)
+      return if code[-1] == "\n"
+
+      warn
+
+      report(:warn, "#{file} does not end with a newline.")
+    end
+
+    def run
+      # This check will pass by default.
+      pass
+
+      # Run this check on the code in every file.
+      @kb[:codes].each { |file, code| check(file, code) }
+    end
+  end
+end