nasa_apod 1.0.4 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6b58e0774136c271bb04189fc74ba690eda54a07
-  data.tar.gz: 6ceb8c4d189a9138d0f6e6dbd142484227c743a6
+  metadata.gz: accbff5d6943a6ea3766fa8bab9fb0d962009748
+  data.tar.gz: a282c0cfd0fa47d784d19fc1c6ae39d2eb463415
 SHA512:
-  metadata.gz: 1fe2d863ca222cf546afff323901452673c1b7b7db485b0f8195ea9da8e86633c0ab0a46a8d589e878b1421ae6ea6f26a6842ded7e5c6aa8210a254cbe0dbc3c
-  data.tar.gz: c72daf331f6868705d1b189092fd62e03cae682cc30b1b2b99dbdc622e1b409207af770847065809366d85761a8378fddf5d93e37bbac3800d11226104dc18fb
+  metadata.gz: dcd7cef972eda3045c1beb7c42f02ec75dc381d546f0a9a75cdb80ce84d8009e305afb43557635664a80064453e92b79757dfb68ce37fec77cf8377f2e4aff87
+  data.tar.gz: e094aba6a476ac7b077c9856d25a19aeb44ab64d7cc50cc874af29e6b5f3fd3d5cd1a54b5d05a1c36bf88e34fef417f9c049391ace9a675bbf90d9508b9b4afa

data/README.md

@@ -39,13 +39,6 @@ result = client.search
 result.explanation #=> "This big, bright, beautiful spiral galaxy is Messier 64..."
 ```
 
-Get concept tags with result
-```
-result = client.search(concept_tags: true) 
-result.concepts #=> ["Sun","Sunspot","Light",...],
-```
-Note: Not all posts have concept tags.
-
 Get image URL:
 
 ```

data/lib/nasa_apod/client.rb

@@ -1,34 +1,25 @@
 module NasaApod
- 
+
   DEFAULT_URL = 'https://api.nasa.gov/planetary/apod'
-  
+
   class Client
-    attr_reader :api_key, :date, :concept_tags, :hd
+    attr_reader :api_key, :date, :hd
 
     def date=(date)
       @date = parse_date(date)
     end
 
-    def concept_tags=(concept_tags)
-      if concept_tags.nil? || concept_tags.blank?
-        @concept_tags = false
-      else
-        @concept_tags = concept_tags
-      end
-    end
-
     def hd=(hd)
-      if hd.nil? || hd.blank?
-        @hd = false
-      else
-        @hd = hd
-      end
+      @hd = if hd.nil? || hd.blank?
+              false
+            else
+              hd
+            end
     end
-    
-    def initialize(options={})
-      @api_key = options[:api_key] || "DEMO_KEY"
+
+    def initialize(options = {})
+      @api_key = options[:api_key] || 'DEMO_KEY'
       self.date = options[:date]
-      self.concept_tags = options[:concept_tags]
       self.hd = options[:hd]
     end
 
@@ -39,34 +30,34 @@ module NasaApod
     # @image_permissions http://apod.nasa.gov/apod/lib/about_apod.html#srapply
     # @authentication optional NASA api key https://api.nasa.gov/index.html#apply-for-an-api-key
     # @option options [String] :api_key Optional. Uses DEMO_KEY as default.
-    # @option options [String] :date Optional. Returns the APOD results for the given date. Date should be formatted as YYYY-MM-DD. Defaults as today.
-    # @option options [Boolean] :concept_tags Optional. Returns an array of concept tags if available. Defaults to False.
+    # @option options [String] :date Optional. Returns the APOD results for
+    # the given date. Date should be formatted as YYYY-MM-DD. Defaults as today.
     # @return [NasaApod::SearchResults] Return APOD post for a specified date.
-    def search(options={})
+    def search(options = {})
       self.date = options[:date] || date
-      @concept_tags = options[:concept_tags] || concept_tags
       @hd = options[:hd] || hd
-      response = HTTParty.get(DEFAULT_URL, { query: attributes })
+      response = HTTParty.get(DEFAULT_URL, query: attributes)
       handle_response(response)
     end
 
-    def random_post(options={})
-      date = rand(Date.parse("1995-06-16")..Date.today)
-      search(date: date)
+    def random_post(options = {})
+      date = rand(Date.parse('1995-06-16')..Date.today)
+      options[:date] = date
+      search(options)
     end
 
-    alias_method :wormhole, :random_post
+    alias wormhole random_post
 
     def attributes
-      instance_variables.each_with_object(Hash.new) do  |var,hash| 
-        hash[var.to_s.delete("@")] = instance_variable_get(var)
+      instance_variables.each_with_object({}) do |var, hash|
+        hash[var.to_s.delete('@')] = instance_variable_get(var)
       end
     end
 
     private
 
     def handle_response(response)
-      if response["error"].nil?
+      if response['error'].nil?
         NasaApod::SearchResults.new(response)
       else
         NasaApod::Error.new(response)
@@ -74,11 +65,12 @@ module NasaApod
     end
 
     def parse_date(date)
-      if date.is_a?(Time)
-        date.strftime("%Y-%m-%d")
-      elsif date.is_a?(Date)
+      case date
+      when Time
+        date.strftime('%Y-%m-%d')
+      when Date
         date.to_s
-      elsif date.is_a?(String)
+      when String
         date
       else
         Date.today.to_s

data/lib/nasa_apod/search_results.rb

@@ -1,10 +1,9 @@
 module NasaApod
  
   class SearchResults
-    attr_accessor :concepts, :url, :media_type, :title, :explanation, :hd_url, :date, :copyright
+    attr_accessor :url, :media_type, :title, :explanation, :hd_url, :date, :copyright
 
     def initialize(attributes={})
-      @concepts = attributes["concepts"]
       @url = attributes["url"]
       @media_type = attributes["media_type"]
       @explanation = attributes["explanation"] 

data/lib/nasa_apod/version.rb

@@ -1,3 +1,3 @@
 module NasaApod
-  VERSION = "1.0.4"
+  VERSION = "1.1.0"
 end

data/spec/nasa_apod_spec.rb

@@ -10,10 +10,6 @@ module NasaApod
         expect(client.api_key).to eq("DEMO_KEY")
       end
 
-      it 'concept_tags defaults to false' do
-        expect(client.concept_tags).to eq(false)
-      end
-
       it 'date defaults to a string of today' do
         expect(client.date).to eq(Date.today.to_s)
       end
@@ -76,7 +72,6 @@ module NasaApod
     describe '#initialize' do
       let(:result) { SearchResults.new(attributes) }
       let(:attributes) {{"url" =>  "test_url",
-                        "concepts" =>  ["test_concept1","test_concept2"],
                         "media_type" =>  "JPG",
                         "title" =>  "Test title",
                         "explanation" => "Test explanation",

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nasa_apod
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.1.0
 platform: ruby
 authors:
 - Gabe Dominguez
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-15 00:00:00.000000000 Z
+date: 2016-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -106,7 +106,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Ruby wrapper for NASA's Astronomy Picture of the Day API