nasa_apod 0.0.4 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 80116fac324bec440f2d77aaf2798d18a795cc0b
-  data.tar.gz: 7382f49e368db218cc3eaac3b93223fb84ee1d85
+  metadata.gz: 5ea7b208e0dd92004f98e370d5399bf23d2e57a5
+  data.tar.gz: 690ece5803322f2ef7926e52343c0a0baf33c47d
 SHA512:
-  metadata.gz: 2d68bcc2520d84a5af85a85b9ade6e2f0112a2495f71ade138569f1896e6fb396ff4d3f7a0ba2fcf06c3360b32a5d5b04efc6b894dfa2a223b65eafdf5a178b1
-  data.tar.gz: 77a72031791b5f5e491bec74b29c16ec9fd9433b217fa86e4c77686e114033d29f1e614a58e3f4d1998d1b33d7bf64017a047f2c9499608dd1dbbf917c4bfd57
+  metadata.gz: 7cd9d7f855881d2892b102211d4b5d55cf571f1c0d9a27ba0b51749988eabb89f7df1518ffeb98ffa6d055c1756b94953829be238f82780394c1e3584682212b
+  data.tar.gz: f0d41d988873268f7db03ad52864a0573259cbd1cf32568b2b3c0416ffe948dc3cba4097ae08384a4bbe4403d7f52e32fc4031069c8b0bfca1999db5467a4ed6

data/README.md

@@ -27,7 +27,7 @@ result
 
 Get concept tags with result
 ```
-result = client.search(list_concepts: true) 
+result = client.search(concept_tags: true) 
 result.concepts #=> ["Sun","Sunspot","Light",...],
 ```
 Note: Not all posts have concept tags.

data/lib/nasa_apod/client.rb

@@ -3,17 +3,17 @@ module NasaApod
   DEFAULT_URL = 'https://api.nasa.gov/planetary/apod'
   
   class Client
-    attr_reader :api_key, :date, :list_concepts, :hd
+    attr_reader :api_key, :date, :concept_tags, :hd
 
     def date=(date)
       @date = parse_date(date)
     end
 
-    def list_concepts=(list_concepts)
-      if list_concepts.nil? || list_concepts.blank?
-        @list_concepts = false
+    def concept_tags=(concept_tags)
+      if concept_tags.nil? || concept_tags.blank?
+        @concept_tags = false
       else
-        @list_concepts = list_concepts
+        @concept_tags = concept_tags
       end
     end
 
@@ -28,7 +28,7 @@ module NasaApod
     def initialize(options={})
       @api_key = options[:api_key] || "DEMO_KEY"
       self.date = options[:date]
-      self.list_concepts = options[:list_concepts]
+      self.concept_tags = options[:concept_tags]
       self.hd = options[:hd]
     end
 
@@ -44,19 +44,25 @@ module NasaApod
     # @return [NasaApod::SearchResults] Return APOD post for a specified date.
     def search(options={})
       self.date = options[:date] || date
-      @list_concepts = options[:list_concepts] || list_concepts
+      @concept_tags = options[:concept_tags] || concept_tags
       @hd = options[:hd] || hd
-      response = HTTParty.get("https://api.nasa.gov/planetary/apod?api_key=#{api_key}&date=#{date}&concept_tags=#{list_concepts}&hd=#{hd}")
+      response = HTTParty.get(DEFAULT_URL, { query: attributes })
       handle_response(response)
     end
 
     def random_post(options={})
       date = rand(Date.parse("1995-06-16")..Date.today)
-      search(:date => date)
+      search(date: date)
     end
 
     alias_method :wormhole, :random_post
 
+    def attributes
+      instance_variables.each_with_object(Hash.new) do  |var,hash| 
+        hash[var.to_s.delete("@")] = instance_variable_get(var)
+      end
+    end
+
     private
 
     def handle_response(response)
@@ -67,14 +73,6 @@ module NasaApod
       end
     end
 
-    def write_attrs(attributes)
-      @concepts = attributes["concepts"]
-      @url = attributes["url"]
-      @media_type = attributes["media_type"]
-      @explanation = attributes["explanation"] 
-      @title = attributes["title"]
-    end
-
     def parse_date(date)
       if date.is_a?(Time)
         date.strftime("%Y-%m-%d")

data/lib/nasa_apod/version.rb

@@ -1,3 +1,3 @@
 module NasaApod
-  VERSION = "0.0.4"
+  VERSION = "0.0.6"
 end

data/nasa_apod.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["gabe.p.dominguez@gmail.com"]
   spec.summary       = %q{Ruby wrapper for NASA's Astronomy Picture of the Day API}
   spec.description   = %q{A Ruby gem for consuming the NASA Astronomy Picture of the Day API. }
-  spec.homepage      = ""
+  spec.homepage      = "https://github.com/gdomingu/nasa_apod"
   spec.license       = "MIT"
 
   spec.files         = `git ls-files -z`.split("\x0")
@@ -19,8 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 1.6"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency 'rspec'
-  spec.add_development_dependency 'httparty'
-
+  spec.add_development_dependency "rake", "~> 10.1"
+  spec.add_development_dependency 'rspec', "~> 3.3"
+  spec.add_development_dependency 'httparty', "~> 0.13"
 end

data/spec/nasa_apod_spec.rb

@@ -10,8 +10,8 @@ module NasaApod
         expect(client.api_key).to eq("DEMO_KEY")
       end
 
-      it 'list_concepts defaults to false' do
-        expect(client.list_concepts).to eq(false)
+      it 'concept_tags defaults to false' do
+        expect(client.concept_tags).to eq(false)
       end
 
       it 'date defaults to a string of today' do
@@ -51,6 +51,16 @@ module NasaApod
       end
     end
 
+    describe '#attributes' do
+      let(:client) { Client.new }
+
+      it 'returns a hash of attributes' do
+        attributes = client.attributes 
+        expect(attributes.class).to eq(Hash)
+        expect(attributes['api_key']).to eq('DEMO_KEY')
+      end
+    end
+
   end
 
   describe SearchResults do

data/spec/spec_helper.rb

@@ -1 +1 @@
-require 'nasa_apod'
+require 'nasa_apod'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nasa_apod
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.6
 platform: ruby
 authors:
 - Gabe Dominguez
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-01 00:00:00.000000000 Z
+date: 2016-04-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,44 +28,44 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.1'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.3'
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.13'
 description: 'A Ruby gem for consuming the NASA Astronomy Picture of the Day API. '
 email:
 - gabe.p.dominguez@gmail.com
@@ -86,7 +86,7 @@ files:
 - nasa_apod.gemspec
 - spec/nasa_apod_spec.rb
 - spec/spec_helper.rb
-homepage: ''
+homepage: https://github.com/gdomingu/nasa_apod
 licenses:
 - MIT
 metadata: {}
@@ -106,7 +106,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.6.2
 signing_key: 
 specification_version: 4
 summary: Ruby wrapper for NASA's Astronomy Picture of the Day API