nas-yahoo_stock 1.0.1 → 1.0.2

data/History.txt

@@ -36,4 +36,26 @@
 === 1.0.1 2009-09-10
 
 * 1 addition:
-  * adds feature to retreive historical stock data
+  * adds feature to retreive historical stock data
+
+=== 1.0.2 2009-10-04
+Major changes in the public API. Check the README.rdoc file and individual classes for more information
+
+* 8 addition:
+  * adds YahooStock::Interface::History
+  * adds YahooStock::Interface::Quote
+  * adds YahooStock::Interface::ScripSymbol
+  * adds YahooStock::Result as a superclass for all formatter classes
+  * adds array format, Result::ArrayFormat, to generate results as an array
+  * adds hash format, Result::ArrayFormat, to generate results as key value pairs
+  * adds base class as parent for public facing classes
+  * adds observers to check when it is required to send request to yahoo again to get fresh data
+
+* 7 changes:
+  * changes YahooStock::Interface to be the main interface class. Other interface classes will inherit from this
+  * changes YahooStock::ScripSymbol to use YahooStock::Interface::ScripSymbol
+  * removes all history interface logic from YahooStock::History and uses YahooStock::Interface::History
+  * changes YahooStock::Quote, YahooStock::History, YahooStock::ScripSymbol to extend from YahooStock::Base
+  * sorts url parameters before sending request to yahoo
+  * YahooInterface::Quote#realtime, extended, and standard methods should return self to allow calling different format output method calls
+  * do not discard any empty values when finding scrip symbol options for a company as this interferes with different format options

data/Manifest.txt

@@ -2,12 +2,28 @@ History.txt
 Manifest.txt
 README.rdoc
 Rakefile
-lib/yahoo_stock.rb
-lib/yahoo_stock/quote.rb
+lib/yahoo_stock/base.rb
+lib/yahoo_stock/history.rb
 lib/yahoo_stock/interface.rb
+lib/yahoo_stock/interface/history.rb
+lib/yahoo_stock/interface/quote.rb
+lib/yahoo_stock/interface/scrip_symbol.rb
+lib/yahoo_stock/quote.rb
+lib/yahoo_stock/result.rb
+lib/yahoo_stock/result/array_format.rb
+lib/yahoo_stock/result/hash_format.rb
 lib/yahoo_stock/scrip_symbol.rb
-lib/yahoo_stock/history.rb
+lib/yahoo_stock.rb
 spec/spec_helper.rb
+spec/yahoo_stock/base_spec.rb
+spec/yahoo_stock/interface_spec.rb
+spec/yahoo_stock/interface/history_spec.rb
+spec/yahoo_stock/interface/quote_spec.rb
+spec/yahoo_stock/interface/scrip_symbol_spec.rb
 spec/yahoo_stock/quote_spec.rb
-spec/yahoo_stock/scrip_symbol_spec.rb
 spec/yahoo_stock/history_spec.rb
+spec/yahoo_stock/result_spec.rb
+spec/yahoo_stock/result/array_format_spec.rb
+spec/yahoo_stock/result/hash_format_spec.rb
+spec/yahoo_stock/scrip_symbol_spec.rb
+

data/README.rdoc

@@ -7,7 +7,7 @@
 Provides an interface to yahoo finance to get stock related data. For instance, latest trade related data, volume, 50 day moving average, market cap, etc, virtually any thing that yahoo finance provides.
 
 If you don't know the stock / scrip symbol of the company then you can find that out by using the YahooStock::ScripSymbol class. The methods are mentioned in the Usage section below. For instance, YHOO for yahoo, GOOG for google, etc. 
-The kind of parameters can be passed can be found after initializing the 
+The kind of parameters to be passed can be found after initializing the 
 YahooStock::Quote object and passing valid_parameters message, example is given below in the USAGE section.
 
 == USAGE:
@@ -40,22 +40,78 @@ quote.add_symbols('MSFT', 'AAPL')
 
 quote.remove_symbols('MSFT', 'AAPL')
 
-* To get data for all stocks
+* To find data for all stocks, this will give a string containing all values
 
-quote.get
+quote.results
+
+	to return an array instead of a string use:
+
+	quote.results(:to_array).output
+	
+	to return a hash, use:
+	
+	quote.results(:to_hash).output
+	
+	to store results in a file, use:
+	
+	quote.results.store('filename')
 
 * To find out the stock symbol for a company
   
-YahooStock::ScripSymbol.print_options('Yahoo', 'Company1', 'Company3')
+symbol = YahooStock::ScripSymbol.new('Yahoo')
+
+* To find all symbols for that company, this will give a string containing all values
+
+symbol.results
+
+	to return an array instead of a string use:
+
+	symbol.results(:to_array).output
+	
+	to return a hash, use:
+	
+	symbol.results(:to_hash).output
+	
+	to store results in a file, use:
+	
+	symbol.results.store('filename')
+
+* To find symbols for multiple companies
+
+symbols = YahooStock::ScripSymbol.results('Yahoo', 'Company1', 'Company3')
 
-* To store the output in a file
+* to get the result in a string
 
-YahooStock::ScripSymbol.save_options_to_file('path/to/filename','Yahoo', 'Company1', 'Company3')
+symbols.output
+
+* to store output in a file
+
+symbols.store('filename')
+
+* To find historical data for a stock
+
+  history = YahooStock::History.new(:stock_symbols => 'yhoo', :start_date => Date.today-20, end_date => Date.today -2)
+  
+  	to return an array instead of a string use:
+
+	history.results(:to_array).output
+	
+	to return a hash, use:
+	
+	history.results(:to_hash).output
+	
+	to store results in a file, use:
+	
+	history.results.store('filename')
 
 == INSTALL:
 
 gem sources -a http://gems.github.com
 
+OR 
+
+gem sources -a http://gemcutter.org
+
 sudo gem install nas-yahoo_stock
 
 == TESTS:

data/lib/yahoo_stock/base.rb

@@ -0,0 +1,37 @@
+# YahooStock::Base class to find and output results.
+module YahooStock
+  
+  class Base
+    
+    def initialize(interface)
+      @interface = interface
+    end
+    
+    # Uses the values method of the interface used to show results .
+    def find
+      @interface.values
+    end
+    
+    # Method takes one parameter type or a block
+    # type uses the existing format classes namespaced in Result::ClassName.output
+    # e.g. * results :to_array
+    #      * results {YourSpecialFormat.method_name}
+    # to store
+    def results(type=nil, &block)
+      if block_given?
+        yield
+      else
+        return YahooStock::Result.new(find) if !type || type.to_s.empty?
+        format_type = type.to_s.sub(/^to_/,'').strip
+        return YahooStock::Result.const_get("#{format_type.capitalize}Format").new(find){data_attributes}
+      end
+    end
+    
+    # Abstract method
+    def data_attributes
+      raise 'Abstract method called. Use the subclass data_attributes method'
+    end
+    
+  end
+  
+end

data/lib/yahoo_stock/history.rb

@@ -1,184 +1,30 @@
-=begin
-
-base url = http://ichart.finance.yahoo.com/table.csv
-
-params:
- s=stock symbol
- a=month-1
- b=date
- c=year
- d=month-1
- e=date
- f=year
- g=d or w or m
- ignore=.csv
-
-=end
-require 'net/http'
 module YahooStock
-  class History
+  class History < Base
     
     class HistoryError < RuntimeError; end
     
-    attr_reader :stock_symbol, :start_date, :end_date, :interval
-    
     def initialize(options)
       unless options.is_a?(Hash)
         raise HistoryError, 'A hash of start_date, end_date and stock_symbol is expected as parameters'
       end
-      validate_keys(options)
-      
-      @stock_symbol = options[:stock_symbol]
-      @start_date   = options[:start_date]
-      @end_date     = options[:end_date]
-      @interval     = options[:interval].nil? ? :daily : options[:interval].to_sym
-      
-      validate_interval_values(options[:interval]) if options[:interval]
-      validate_stock_symbol(options)
-      validate_start_date(options)
-      validate_end_date(options)
-      validate_history_range
-      @base_url = "http://ichart.finance.yahoo.com/table.csv"
-    end
-    
-    def stock_symbol=(stock_symbol)
-      validate_stock_symbol_attribute(stock_symbol)
-      @stock_symbol = stock_symbol
-    end
-    
-    def start_date=(start_date)
-      validate_start_date_type(start_date)
-      validate_history_range(start_date)
-      @start_date = start_date
-    end
-    
-    def end_date=(end_date)
-      validate_end_date_type(end_date)
-      validate_history_range(start_date, end_date)
-      @end_date = end_date
-    end
-    
-    def interval=(interval)
-      validate_interval_values(interval)
-      @interval = interval
-    end
-    
-    def send_request
-      if stock_symbol.nil? || start_date.nil? || end_date.nil?
-        raise HistoryError, 'Cannot send request unless all parameters, ie stock_symbol, start and end date are present'
-      end
-      if !(start_date.is_a?(Date) || end_date.is_a?(Date))
-        raise HistoryError, 'Start and end date should be of type Date'
-      end
-      response = Net::HTTP.get_response(URI.parse(uri))
-      if response.code == '200'
-        return response.body
-      else
-        raise "No historical data found for the stock symbol: #{stock_symbol}"
-      end
-    end
-    
-    # Return an array of hashes with latest date first
-    # Each array element contains a hash of date, volume traded, opening, closing, high and low prices
-    def results
-      values = send_request.split(/\n/)
-      headers, daily_data = values.partition{|h| h==values[0]}
-      headings = headers.first.split(',')
-      data = []
-      daily_data.each do |datum|
-        daily_values = {}
-        datum.split(',').each_with_index do |item, i|
-          daily_values[headings[i]] = item
-        end
-        data << daily_values
-      end
-      data
-    end
-    
-    private
-    
-    def uri
-      frequency = case interval
-                    when :daily   : 'd'
-                    when :weekly  : 'w'
-                    when :monthly : 'm'
-                  end
-      start_date_param = "a=#{sprintf("%02d", start_date.month-1)}&b=#{start_date.day}&c=#{start_date.year}"
-      end_date_param = "d=#{sprintf("%02d", end_date.month-1)}&e=#{end_date.day}&f=#{end_date.year}"
-      params="s=#{stock_symbol}&#{start_date_param}&#{end_date_param}&g=#{frequency}&ignore=.csv"
-      "#{@base_url}?#{params}"
-    end
-    
-    def validate_interval_values(interval_value=interval)
-      valid_values = [:daily, :weekly, :monthly]
-      unless valid_values.include?(interval_value)
-        raise HistoryError, "Allowed values for interval are #{valid_values.join(', ')}"
-      end
-    end
-    
-    def validate_stock_symbol(options)
-      unless options.keys.include?(:stock_symbol)
-        raise HistoryError, ':stock_symbol key is not present in the parameter hash'
-      end
-      validate_stock_symbol_attribute
-    end
-    
-    def validate_stock_symbol_attribute(symbol=stock_symbol)
-      if symbol.nil? || symbol.empty?
-        raise HistoryError, ':stock_symbol value cannot be nil or blank'
-      end
-    end
-    
-    def validate_start_date(options)
-      validate_date_options(:start_date, options)
-      validate_start_date_type
-    end
-    
-    def validate_end_date(options)
-      validate_date_options(:end_date, options)
-      validate_end_date_type
-    end
-    
-    def validate_history_range(s_date = start_date, e_date = end_date)
-      if s_date >= Date.today
-        raise HistoryError, "Start date must be in the past"
-      end
-      if e_date >= Date.today
-        raise HistoryError, "End date must be in the past"
-      end
-      if e_date < s_date
-        raise HistoryError, "End date must be greater than the start date"
-      end
+      @interface = YahooStock::Interface::History.new(options)
     end
     
-    def validate_end_date_type(e_date=end_date)
-      unless e_date.is_a?(Date)
-        raise HistoryError, "End date must be of type Date"
-      end
+    def find
+      @find_values = super()
+      @find_values.sub(/Date.*\s/,'') if @find_values
     end
     
-    def validate_start_date_type(s_date=start_date)
-      unless s_date.is_a?(Date)
-        raise HistoryError, "Start date must be of type Date"
-      end
-    end
-    
-    def validate_date_options(date_type, options)
-      unless options.keys.include?(date_type)
-        raise HistoryError, ":#{date_type} key is not present in the parameter hash"
-      end
-      
-      if options[date_type].nil? || options[date_type].to_s.empty?
-        raise HistoryError, ":#{date_type} value cannot be blank"
-      end
+    def values_with_header
+      @interface.values
     end
     
-    def validate_keys(options)
-      valid_keys   = [:stock_symbol, :start_date, :end_date, :interval]
-      invalid_keys = []
-      options.keys.each{|key| invalid_keys << key unless valid_keys.include?(key) }
-      unless invalid_keys.length.zero?
-        raise HistoryError, "An invalid key '#{invalid_keys.join(',')}' is passed in the parameters. Allowed keys are #{valid_keys.join(', ')}"
+    def data_attributes
+      return unless values_with_header
+      data_attributes = /Date.*\s/.match(values_with_header)
+      unless data_attributes.nil?
+        @data_attributes = data_attributes[0].sub(/\s*$/,'').split(',')
+        @data_attributes.map &:strip
       end
     end
     

data/lib/yahoo_stock/interface/history.rb

@@ -0,0 +1,186 @@
+=begin
+params:
+ s=stock symbol
+ a=month-1
+ b=date
+ c=year
+ d=month-1
+ e=date
+ f=year
+ g=d or w or m
+ ignore=.csv
+
+=end
+
+module YahooStock
+   # ==DESCRIPTION:
+   # 
+   # Class to generate the right url and interface with yahoo to get history of a stock
+   #
+  class Interface::History < Interface
+
+    class HistoryError < RuntimeError ; end
+    
+    attr_reader :stock_symbol, :start_date, :end_date, :interval
+    
+    # The options parameter expects a hash with 4 key value pairs
+    #
+    # :stock_symbol => 'goog', :start_date => Date.today-30,
+    # :end_date => Date.today-10, :interval => :weekly
+    #
+    # The interval option accepts :daily, :monthly and :weekly values
+    #
+    # The interval key is optional, if not used then by default uses :daily
+    #
+    # and provides daily history for the specified date range
+    #
+    def initialize(options)
+      @base_url = BASE_URLS[:history]
+      validate_keys(options)
+      
+      @stock_symbol = options[:stock_symbol]
+      @start_date   = options[:start_date]
+      @end_date     = options[:end_date]
+      @interval     = options[:interval].nil? ? :daily : options[:interval].to_sym
+      
+      validate_interval_values(options[:interval]) if options[:interval]
+      validate_stock_symbol(options)
+      validate_start_date(options)
+      validate_end_date(options)
+      validate_history_range
+    end
+    
+    # Make sure that stock symbol is not nil or an empty string before setting it
+    def stock_symbol=(stock_symbol)
+      validate_stock_symbol_attribute(stock_symbol)
+      @stock_symbol = stock_symbol
+    end
+    
+    # Before setting start date
+    #   - Make sure that it is of type date
+    #   - Make sure that it is before the end date
+    def start_date=(start_date)
+      validate_start_date_type(start_date)
+      validate_history_range(start_date)
+      @start_date = start_date
+    end
+    
+    # Before setting end date
+    #   - Make sure that it is of type date
+    #   - Make sure that it is after the start date
+    def end_date=(end_date)
+      validate_end_date_type(end_date)
+      validate_history_range(start_date, end_date)
+      @end_date = end_date
+    end
+    
+    # Set interval to specify whether daily, weekly or monthly histroy required
+    def interval=(interval)
+      validate_interval_values(interval)
+      @interval = interval
+    end
+    
+    # Generate full uri with the help of uri method of the superclass
+    def uri
+      frequency = case interval
+                    when :daily   : 'd'
+                    when :weekly  : 'w'
+                    when :monthly : 'm'
+                  end
+      @uri_parameters = {:a => sprintf("%02d", start_date.month-1), :b => start_date.day, 
+                         :c => start_date.year, :d => sprintf("%02d", end_date.month-1),
+                         :e => end_date.day, :f => end_date.year, :s => stock_symbol,
+                         :g => frequency, :ignore => '.csv'}
+      super()  
+    end
+
+    # Get uri content with the help of get method of the super class
+    def get
+      if stock_symbol.nil? || start_date.nil? || end_date.nil?
+        raise HistoryError, 'Cannot send request unless all parameters, ie stock_symbol, start and end date are present'
+      end
+      if !(start_date.is_a?(Date) || end_date.is_a?(Date))
+        raise HistoryError, 'Start and end date should be of type Date'
+      end
+      uri
+      super()
+    end
+    
+    private
+    
+    def validate_interval_values(interval_value=interval)
+      valid_values = [:daily, :weekly, :monthly]
+      unless valid_values.include?(interval_value)
+        raise HistoryError, "Allowed values for interval are #{valid_values.join(', ')}"
+      end
+    end
+    
+    def validate_stock_symbol(options)
+      unless options.keys.include?(:stock_symbol)
+        raise HistoryError, ':stock_symbol key is not present in the parameter hash'
+      end
+      validate_stock_symbol_attribute
+    end
+    
+    def validate_stock_symbol_attribute(symbol=stock_symbol)
+      if symbol.nil? || symbol.empty?
+        raise HistoryError, ':stock_symbol value cannot be nil or blank'
+      end
+    end
+    
+    def validate_start_date(options)
+      validate_date_options(:start_date, options)
+      validate_start_date_type
+    end
+    
+    def validate_end_date(options)
+      validate_date_options(:end_date, options)
+      validate_end_date_type
+    end
+    
+    def validate_history_range(s_date = start_date, e_date = end_date)
+      if s_date >= Date.today
+        raise HistoryError, "Start date must be in the past"
+      end
+      if e_date >= Date.today
+        raise HistoryError, "End date must be in the past"
+      end
+      if e_date < s_date
+        raise HistoryError, "End date must be greater than the start date"
+      end
+    end
+    
+    def validate_end_date_type(e_date=end_date)
+      unless e_date.is_a?(Date)
+        raise HistoryError, "End date must be of type Date"
+      end
+    end
+    
+    def validate_start_date_type(s_date=start_date)
+      unless s_date.is_a?(Date)
+        raise HistoryError, "Start date must be of type Date"
+      end
+    end
+    
+    def validate_date_options(date_type, options)
+      unless options.keys.include?(date_type)
+        raise HistoryError, ":#{date_type} key is not present in the parameter hash"
+      end
+      
+      if options[date_type].nil? || options[date_type].to_s.empty?
+        raise HistoryError, ":#{date_type} value cannot be blank"
+      end
+    end
+    
+    def validate_keys(options)
+      valid_keys   = [:stock_symbol, :start_date, :end_date, :interval]
+      invalid_keys = []
+      options.keys.each{|key| invalid_keys << key unless valid_keys.include?(key) }
+      unless invalid_keys.length.zero?
+        raise HistoryError, "An invalid key '#{invalid_keys.join(',')}' is passed in the parameters. Allowed keys are #{valid_keys.join(', ')}"
+      end
+    end
+    
+  end
+  
+end