nanoc 4.8.9 → 4.8.10

data/spec/nanoc/base/views/{item_rep_collection_view_spec.rb → support/item_rep_collection_view_examples.rb}

@@ -94,7 +94,7 @@ shared_examples 'an item rep collection view' do
       let(:name) { 'foo' }
 
       it 'raises' do
-        expect { subject }.to raise_error(ArgumentError, 'expected ItemRepCollectionView#[] to be called with a symbol')
+        expect { subject }.to raise_error(ArgumentError, 'expected BasicItemRepCollectionView#[] to be called with a symbol')
       end
     end
 
@@ -102,7 +102,7 @@ shared_examples 'an item rep collection view' do
       let(:name) { 0 }
 
       it 'raises' do
-        expect { subject }.to raise_error(ArgumentError, 'expected ItemRepCollectionView#[] to be called with a symbol (you likely want `.reps[:default]` rather than `.reps[0]`)')
+        expect { subject }.to raise_error(ArgumentError, 'expected BasicItemRepCollectionView#[] to be called with a symbol (you likely want `.reps[:default]` rather than `.reps[0]`)')
       end
     end
   end
@@ -114,7 +114,7 @@ shared_examples 'an item rep collection view' do
       let(:name) { :donkey }
 
       it 'raises' do
-        expect { subject }.to raise_error(Nanoc::ItemRepCollectionView::NoSuchItemRepError)
+        expect { subject }.to raise_error(Nanoc::BasicItemRepCollectionView::NoSuchItemRepError)
       end
     end
 
@@ -138,8 +138,3 @@ shared_examples 'an item rep collection view' do
     it { is_expected.to eql('<' + described_class.name + '>') }
   end
 end
-
-describe Nanoc::ItemRepCollectionView do
-  it_behaves_like 'an item rep collection view'
-  let(:expected_view_class) { Nanoc::ItemRepView }
-end

data/spec/nanoc/base/views/{item_rep_view_spec.rb → support/item_rep_view_examples.rb}

@@ -1,18 +1,18 @@
 # frozen_string_literal: true
 
-describe Nanoc::ItemRepView do
+shared_examples 'an item rep view' do
+  # needs expected_item_view_class
+
   let(:view_context) do
-    Nanoc::ViewContext.new(
-      reps: reps,
-      items: items,
-      dependency_tracker: dependency_tracker,
+    Nanoc::ViewContextForCompilation.new(
+      reps:                Nanoc::Int::ItemRepRepo.new,
+      items:               Nanoc::Int::ItemCollection.new(config),
+      dependency_tracker:  dependency_tracker,
       compilation_context: compilation_context,
-      snapshot_repo: snapshot_repo,
+      snapshot_repo:       snapshot_repo,
     )
   end
 
-  let(:reps) { double(:reps) }
-  let(:items) { double(:items) }
   let(:compilation_context) { double(:compilation_context) }
   let(:snapshot_repo) { Nanoc::Int::SnapshotRepo.new }
 
@@ -211,49 +211,6 @@ describe Nanoc::ItemRepView do
     end
   end
 
-  describe '#compiled_content' do
-    subject { view.compiled_content }
-
-    let(:view) { described_class.new(rep, view_context) }
-
-    let(:rep) do
-      Nanoc::Int::ItemRep.new(item, :default).tap do |ir|
-        ir.compiled = true
-        ir.snapshot_defs = [
-          Nanoc::Int::SnapshotDef.new(:last, binary: false),
-        ]
-      end
-    end
-
-    let(:item) do
-      Nanoc::Int::Item.new('content', {}, '/asdf.md')
-    end
-
-    before do
-      snapshot_repo.set(rep, :last, Nanoc::Int::TextualContent.new('Hallo'))
-    end
-
-    it 'creates a dependency' do
-      expect { subject }
-        .to change { dependency_store.objects_causing_outdatedness_of(base_item) }
-        .from([])
-        .to([item])
-    end
-
-    it 'creates a dependency with the right props' do
-      subject
-      dep = dependency_store.dependencies_causing_outdatedness_of(base_item)[0]
-
-      expect(dep.props.compiled_content?).to eq(true)
-
-      expect(dep.props.raw_content?).to eq(false)
-      expect(dep.props.attributes?).to eq(false)
-      expect(dep.props.path?).to eq(false)
-    end
-
-    it { should eq('Hallo') }
-  end
-
   describe '#path' do
     subject { view.path }
 
@@ -289,64 +246,6 @@ describe Nanoc::ItemRepView do
     it { should eq('/about/') }
   end
 
-  describe '#raw_path' do
-    subject { Fiber.new { view.raw_path }.resume }
-
-    let(:view) { described_class.new(rep, view_context) }
-
-    let(:rep) do
-      Nanoc::Int::ItemRep.new(item, :default).tap do |ir|
-        ir.raw_paths = {
-          last: ['output/about/index.html'],
-        }
-      end
-    end
-
-    let(:item) do
-      Nanoc::Int::Item.new('content', {}, '/asdf.md')
-    end
-
-    context 'rep is not compiled' do
-      it 'creates a dependency' do
-        expect { subject }.to change { dependency_store.objects_causing_outdatedness_of(base_item) }.from([]).to([item])
-      end
-
-      it 'creates a dependency with the right props' do
-        subject
-        dep = dependency_store.dependencies_causing_outdatedness_of(base_item)[0]
-
-        expect(dep.props.compiled_content?).to eq(true)
-
-        expect(dep.props.raw_content?).to eq(false)
-        expect(dep.props.attributes?).to eq(false)
-        expect(dep.props.path?).to eq(false)
-      end
-
-      it { should be_a(Nanoc::Int::Errors::UnmetDependency) }
-    end
-
-    context 'rep is compiled' do
-      before { rep.compiled = true }
-
-      it 'creates a dependency' do
-        expect { subject }.to change { dependency_store.objects_causing_outdatedness_of(base_item) }.from([]).to([item])
-      end
-
-      it 'creates a dependency with the right props' do
-        subject
-        dep = dependency_store.dependencies_causing_outdatedness_of(base_item)[0]
-
-        expect(dep.props.compiled_content?).to eq(true)
-
-        expect(dep.props.raw_content?).to eq(false)
-        expect(dep.props.attributes?).to eq(false)
-        expect(dep.props.path?).to eq(false)
-      end
-
-      it { should eq('output/about/index.html') }
-    end
-  end
-
   describe '#binary?' do
     let(:item_rep) { Nanoc::Int::ItemRep.new(item, :jacques) }
     let(:item) { Nanoc::Int::Item.new('asdf', {}, '/foo') }
@@ -389,7 +288,7 @@ describe Nanoc::ItemRepView do
     subject { view.item }
 
     it 'returns an item view' do
-      expect(subject).to be_a(Nanoc::ItemWithRepsView)
+      expect(subject).to be_a(expected_item_view_class)
     end
 
     it 'returns an item view with the right context' do
@@ -404,6 +303,6 @@ describe Nanoc::ItemRepView do
 
     subject { view.inspect }
 
-    it { is_expected.to eql('<Nanoc::ItemRepView item.identifier=/foo name=jacques>') }
+    it { is_expected.to eql('<' + described_class.to_s + ' item.identifier=/foo name=jacques>') }
   end
 end

data/spec/nanoc/base/views/{mutable_document_view_spec.rb → support/mutable_document_view_examples.rb}

@@ -4,17 +4,18 @@ shared_examples 'a mutable document view' do
   let(:view) { described_class.new(document, view_context) }
 
   let(:view_context) do
-    Nanoc::ViewContext.new(
-      reps: double(:reps),
-      items: double(:items),
-      dependency_tracker: dependency_tracker,
+    Nanoc::ViewContextForCompilation.new(
+      reps:                Nanoc::Int::ItemRepRepo.new,
+      items:               Nanoc::Int::ItemCollection.new(config),
+      dependency_tracker:  dependency_tracker,
       compilation_context: double(:compilation_context),
-      snapshot_repo: snapshot_repo,
+      snapshot_repo:       snapshot_repo,
     )
   end
 
   let(:dependency_tracker) { Nanoc::Int::DependencyTracker.new(double(:dependency_store)) }
   let(:snapshot_repo) { double(:snapshot_repo) }
+  let(:config) { Nanoc::Int::Configuration.new }
 
   describe '#raw_content=' do
     let(:document) { entity_class.new('content', {}, '/asdf') }
@@ -73,7 +74,7 @@ shared_examples 'a mutable document view' do
     end
 
     it 'disallows item views' do
-      item = Nanoc::ItemWithRepsView.new(Nanoc::Int::Item.new('content', {}, '/foo.md'), nil)
+      item = Nanoc::CompilationItemView.new(Nanoc::Int::Item.new('content', {}, '/foo.md'), nil)
       expect { view[:item] = item }.to raise_error(Nanoc::MutableDocumentViewMixin::DisallowedAttributeValueError)
     end
 

data/spec/nanoc/base/views/{mutable_identifiable_collection_view_spec.rb → support/mutable_identifiable_collection_view_examples.rb}

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-shared_examples 'a mutable identifiable collection' do
+shared_examples 'a mutable identifiable collection view' do
   let(:view) { described_class.new(wrapped, view_context) }
 
   let(:view_context) { double(:view_context) }

data/spec/nanoc/cli/commands/compile/abstract_spec.rb

@@ -0,0 +1,80 @@
+# frozen_string_literal: true
+
+describe Nanoc::CLI::Commands::CompileListeners::Abstract do
+  subject { klass.new }
+
+  context 'abstract class' do
+    let(:klass) { described_class }
+
+    it 'errors on starting' do
+      expect { subject.start }.to raise_error(NotImplementedError)
+    end
+
+    it 'stops silently' do
+      subject.stop
+    end
+  end
+
+  context 'concrete subclass' do
+    let(:klass) do
+      Class.new(described_class) do
+        attr_reader :started
+        attr_reader :stopped
+
+        def initialize
+          @started = false
+          @stopped = false
+        end
+
+        def start
+          @started = true
+        end
+
+        def stop
+          @stopped = true
+        end
+      end
+    end
+
+    it 'starts' do
+      subject.start
+      expect(subject.started).to be
+    end
+
+    it 'stops' do
+      subject.start
+      subject.stop
+      expect(subject.stopped).to be
+    end
+
+    it 'starts safely' do
+      subject.start_safely
+      expect(subject.started).to be
+    end
+
+    it 'stops safely' do
+      subject.start_safely
+      subject.stop_safely
+      expect(subject.stopped).to be
+    end
+  end
+
+  context 'listener that does not start or stop properly' do
+    let(:klass) do
+      Class.new(described_class) do
+        def start
+          raise 'boom'
+        end
+
+        def stop
+          raise 'boom'
+        end
+      end
+    end
+
+    it 'raises on start, but not stop' do
+      expect { subject.start_safely }.to raise_error(RuntimeError)
+      expect { subject.stop_safely }.not_to raise_error
+    end
+  end
+end

data/spec/nanoc/cli/commands/compile_spec.rb

@@ -1,66 +1,45 @@
 # frozen_string_literal: true
 
-describe Nanoc::CLI::Commands::CompileListeners::Abstract do
-  let(:klass) do
-    Class.new(described_class) do
-      attr_reader :started
-      attr_reader :stopped
+describe Nanoc::CLI::Commands::Compile, site: true, stdio: true do
+  describe '#run' do
+    example do
+      test_listener_class = Class.new(::Nanoc::CLI::Commands::CompileListeners::Abstract) do
+        def start
+          @started = true
+        end
 
-      def initialize
-        @started = false
-        @stopped = false
-      end
+        def stop
+          @stopped = true
+        end
 
-      def start
-        @started = true
-      end
+        def started?
+          @started
+        end
 
-      def stop
-        @stopped = true
+        def stopped?
+          @stopped
+        end
       end
-    end
-  end
-
-  subject { klass.new }
 
-  it 'starts' do
-    subject.start
-    expect(subject.started).to be
-  end
+      expect(Nanoc::CLI::Commands::CompileListeners::Aggregate)
+        .to receive(:default_listener_classes)
+        .and_return([test_listener_class])
 
-  it 'stops' do
-    subject.start
-    subject.stop
-    expect(subject.stopped).to be
-  end
+      listener = test_listener_class.new
 
-  it 'starts safely' do
-    subject.start_safely
-    expect(subject.started).to be
-  end
+      expect(test_listener_class)
+        .to receive(:new)
+        .and_return(listener)
 
-  it 'stops safely' do
-    subject.start_safely
-    subject.stop_safely
-    expect(subject.stopped).to be
-  end
+      options = {}
+      arguments = []
+      cmd = nil
+      cmd_runner = Nanoc::CLI::Commands::Compile.new(options, arguments, cmd)
 
-  context 'listener that does not start or stop properly' do
-    let(:klass) do
-      Class.new(described_class) do
-        def start
-          raise 'boom'
-        end
-
-        def stop
-          raise 'boom'
-        end
-      end
-    end
+      cmd_runner.run
 
-    it 'raises on start, but not stop' do
-      expect { subject.start_safely }.to raise_error(RuntimeError)
-      expect { subject.stop_safely }.not_to raise_error
+      expect(listener).to be_started
+      expect(listener).to be_stopped
     end
   end
 end

data/spec/nanoc/cli/commands/show_data_spec.rb

@@ -153,11 +153,7 @@ describe Nanoc::CLI::Commands::ShowData, stdio: true do
   end
 
   describe '#print_item_rep_outdatedness' do
-    subject { runner.send(:print_item_rep_outdatedness, items, compiler) }
-
-    before do
-      runner.instance_variable_set(:@site, site)
-    end
+    subject { runner.send(:print_item_rep_outdatedness, items, outdatedness_checker, reps) }
 
     let(:runner) do
       described_class.new(options, arguments, command)
@@ -186,7 +182,6 @@ describe Nanoc::CLI::Commands::ShowData, stdio: true do
     let(:item_rep_dog)   { Nanoc::Int::ItemRep.new(item_dog, :default) }
 
     let(:site) { double(:site) }
-    let(:compiler) { double(:compiler) }
     let(:outdatedness_checker) { double(:outdatedness_checker) }
 
     let(:reps) do
@@ -196,14 +191,6 @@ describe Nanoc::CLI::Commands::ShowData, stdio: true do
       }
     end
 
-    before do
-      allow(runner).to receive(:site).and_return(site)
-      allow(site).to receive(:compiler).and_return(compiler)
-      allow(compiler).to receive(:create_outdatedness_checker).and_return(outdatedness_checker)
-      allow(compiler).to receive(:reps).and_return(reps)
-      allow(compiler).to receive(:calculate_checksums)
-    end
-
     context 'not outdated' do
       before do
         allow(outdatedness_checker).to receive(:outdatedness_reasons_for).with(item_rep_about).and_return([])
@@ -248,7 +235,7 @@ describe Nanoc::CLI::Commands::ShowData, stdio: true do
   end
 
   describe '#print_layouts' do
-    subject { runner.send(:print_layouts, layouts, compiler) }
+    subject { runner.send(:print_layouts, layouts, outdatedness_checker) }
 
     let(:runner) do
       described_class.new(options, arguments, command)
@@ -267,16 +254,8 @@ describe Nanoc::CLI::Commands::ShowData, stdio: true do
     let(:layout) { Nanoc::Int::Layout.new('stuff', {}, '/default.erb') }
 
     let(:site) { double(:site) }
-    let(:compiler) { double(:compiler) }
     let(:outdatedness_checker) { double(:outdatedness_checker) }
 
-    before do
-      allow(runner).to receive(:site).and_return(site)
-      allow(site).to receive(:compiler).and_return(compiler)
-      allow(compiler).to receive(:create_outdatedness_checker).and_return(outdatedness_checker)
-      allow(compiler).to receive(:calculate_checksums)
-    end
-
     context 'not outdated' do
       before do
         allow(outdatedness_checker).to receive(:outdatedness_reasons_for).with(layout).and_return([])