namo 0.32.5 → 0.32.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fca34f0fc6464ae1bbb80a5df45f40b63c496369b7cfbc6b32090e26bf0938f3
-  data.tar.gz: f156784556a7fcd2a28cef6f44178e0c4b115617cd5e64f173cfb42ca768fb53
+  metadata.gz: 43fba45fc148a057ec113497f43f689b027e68c76f323f49d4590de48e7942e5
+  data.tar.gz: '02397331f3d30d460b63a0e2e1441d5820f4ca3134b25a73ba54d86fc4eaa9a6'
 SHA512:
-  metadata.gz: e47d75b0e5a23a4f131de7d8d3865dc27ad74ef91a2e87cb7c8d36a2c127784a11cf1b767978ec54b6fabf48c99f25f9a09839e229d3abd36f3851d801549257
-  data.tar.gz: c1f4a2ae0e3946c4c02e1f4d643b18666214224b58602ffd9185410f7e66ea949d96a1521582f98b095b9cf7b703f665014e8e42f43ed7ef65a4647da3b8efc5
+  metadata.gz: a26014811ea6c61e0e25c746d5f77314971554292823ddbd1ed6bca43406de1754a477b336c68d9767f534eab04717b7fc22ea434efdaadd5f4f786e2aac1ca8
+  data.tar.gz: 234bacaeb9d7daa7fb05bf70036aa90ac6599270dc1d868966ceb06d75bfc1defd41ed6e21329e93e3236911075fe81424ee196c0c3e1aa662c252f1be390ea0

data/README.md

@@ -1295,6 +1295,8 @@ prices.group_by(:value_score)
 
 This gives a single inversion law over the whole namespace — `namo.group_by(d).as_detail(d) == namo[*namo.data_dimensions, d]` for any `d`, with the exact-original round-trip being the data-dimension instance of it. A nil-valued group produces a nil-named member, holding its rows and round-tripping like any other.
 
+`group_by` takes a dimension and no block. The block form `Enumerable#group_by` teaches is not implemented — the groups a computed key makes would have no dimension to round-trip through on `as_detail` — and it says so when called; partitioning by a computed key drops to Ruby, where `prices.entries.group_by{|row| row[:symbol]}` returns the `{key => [Row]}` hash `Enumerable#group_by` always returned.
+
 ## Name
 
 Namo: nam(ed) (dimensi)o(ns). A companion to Numo (numeric arrays for Ruby). And in Aussie culture 'o' gets added to the end of names.

data/lib/Namo/Enumerable.rb

@@ -69,7 +69,16 @@ class Namo
       ]
     end
 
-    def group_by(dimension)
+    # The block form is the call Enumerable#group_by makes, and it is not
+    # implemented: the groups a computed key makes have no dimension to
+    # round-trip through on as_detail.  The raise says so and names the way to
+    # partition by one, where Ruby's arity error said only that the count was
+    # wrong; a call with no dimension at all gets its own sentence.
+    def group_by(dimension = nil)
+      if block_given?
+        raise ArgumentError, 'the block form of group_by is not implemented; entries.group_by{|row| ...} partitions by a computed key'
+      end
+      raise ArgumentError, 'group_by needs a dimension' if dimension.nil?
       collection = Collection.new
       source = derived_dimensions.include?(dimension) ? self[*data_dimensions, dimension] : self
       members = (

data/lib/Namo/VERSION.rb

@@ -2,5 +2,5 @@
 # Namo::VERSION
 
 class Namo
-  VERSION = '0.32.5'
+  VERSION = '0.32.6'
 end

data/test/namo_test.rb

@@ -3234,6 +3234,18 @@ describe Namo do
       end
     end
 
+    context "the boundary of the call" do
+      it "raises informatively on the block form, which is not implemented" do
+        error = _(proc{prices.group_by{|row| row[:symbol]}}).must_raise ArgumentError
+        _(error.message).must_match(/entries\.group_by/)
+      end
+
+      it "raises informatively with no dimension at all" do
+        error = _(proc{prices.group_by}).must_raise ArgumentError
+        _(error.message).must_match(/dimension/)
+      end
+    end
+
     context "single-pass assembly" do
       # Collection#<< rebuilds @data = detail.data over all members-so-far on every
       # append, so appending one member per group re-materialised the data g times

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: namo
 version: !ruby/object:Gem::Version
-  version: 0.32.5
+  version: 0.32.6
 platform: ruby
 authors:
 - thoran