namba 1.0.0.1 → 1.0.1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    namba (0.0.1)
+    namba (1.0.0.1)
       multi_json
 
 GEM

data/lib/namba/api_methods.rb

@@ -4,19 +4,19 @@ require 'multi_json'
 module Namba
   module APIMethods
     def get_user_info name = self.username
-      get_responce_from "http://api.namba.#{self.locale}/getUserInfo.php?username=" + name
+      get_response_from "http://api.namba.#{self.locale}/getUserInfo.php?username=" + name
     end
 
     def get_user_video name = self.username
-      get_responce_from "http://api.namba.#{self.locale}/getVideo.php?username=" + name
+      get_response_from "http://api.namba.#{self.locale}/getVideo.php?username=" + name
     end
 
     def get_user_photo name = self.username
-      get_responce_from "http://api.namba.#{self.locale}/getPhoto.php?username=" + name
+      get_response_from "http://api.namba.#{self.locale}/getPhoto.php?username=" + name
     end
 
     def get_friends_list name = self.username
-      get_responce_from "http://api.namba.#{self.locale}/friends.php?username=" + name
+      get_response_from "http://api.namba.#{self.locale}/friends.php?username=" + name
     end
 
     def set_status text
@@ -37,13 +37,15 @@ module Namba
 
 private
 
-    def get_responce_from url
+    def get_response_from url
       response = Net::HTTP.get_response(URI.parse(url))
+      raise InvalidResponseError, "Invalid response from service" unless response.code == "200"
       MultiJson.decode(response.body)
     end
 
     def post_data_to url, params = { :username => self.username, :password => self.password }
       response = Net::HTTP.post_form(URI.parse(url), params)
+      raise InvalidResponseError, "Invalid response from service" unless response.code == "200"
       MultiJson.decode(response.body)
     end
   end

data/lib/namba/error.rb

@@ -1,4 +1,4 @@
 module Namba
-  class ConfigurationError < StandardError
-  end
+  class ConfigurationError < StandardError; end
+  class InvalidResponseError < StandardError; end
 end

data/lib/namba/version.rb

@@ -1,3 +1,3 @@
 module Namba
-  VERSION = "1.0.0.1"
+  VERSION = "1.0.1"
 end

data/spec/namba/namba_spec.rb

@@ -42,4 +42,18 @@ describe Namba do
       end 
     }.should raise_error(Namba::ConfigurationError, "Available locales are only 'kg' and 'kz'")
   end
+  
+  it "should raise Invalid Response Error when status code is not 200" do
+    Namba.configure do |config|
+      config.username = "name"
+      config.password = "secret"
+      config.locale = :kz
+    end
+
+    n = Namba.new()
+    
+    expect {
+      n.send(:get_response_from, "http://api.namba.#{n.locale}/404")
+    }.should raise_error(Namba::InvalidResponseError, "Invalid response from service")
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: namba
 version: !ruby/object:Gem::Version
-  version: 1.0.0.1
+  version: 1.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -10,11 +10,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-15 00:00:00.000000000 Z
+date: 2012-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &84280090 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +22,15 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *84280090
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &84238420 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -33,10 +38,15 @@ dependencies:
         version: 2.7.0
   type: :development
   prerelease: false
-  version_requirements: *84238420
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.7.0
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &84236540 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +54,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *84236540
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &84234790 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,10 +70,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *84234790
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rack-test
-  requirement: &84230950 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,7 +86,12 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *84230950
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Ruby wrapper for Namba API
 email:
 - sergey.kishenin@gmail.com
@@ -113,7 +138,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.10
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Ruby wrapper for Namba API