naive_bayes 0.0.1 → 0.0.2

data/VERSION

@@ -1 +1 @@
-0.0.1
+0.0.2

data/lib/naive_bayes.rb

@@ -43,7 +43,6 @@ class NaiveBayes
       @features_count[klass][feature] += 1
     end
     @klass_count[klass] += 1
-    save
   end
   
   #P(Class | Item) = P(Item | Class) * P(Class)
@@ -55,28 +54,26 @@ class NaiveBayes
     scores.sort {|a,b| b[1] <=> a[1]}[0]
   end
   
-  private
-  
   def save
-    if @db_filepath
-      File.open(@db_filepath, "w+") do |f|
-        f.write(Marshal.dump(self))
-      end
+    raise "You haven't set a db_filpath, I dont know where to save" if @db_filepath.nil?
+    File.open(@db_filepath, "w+") do |f|
+      f.write(Marshal.dump(self))
     end
   end
   
+  private
+    
   # P(Item | Class)
   def prob_of_item_given_a_class(features, klass)
     a = features.inject(1.0) do |sum, feature|
       prob = prob_of_feature_given_a_class(feature, klass)
-      prob = assumed_probability if prob == 0
       sum *= prob
     end
   end
   
   # P(Feature | Class)
   def prob_of_feature_given_a_class(feature, klass)
-    return 0.5 if @klass_count[klass] == 0
+    return assumed_probability if @klass_count[klass] == 0
     @features_count[klass][feature] / @klass_count[klass]
   end
   

data/naive_bayes.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{naive_bayes}
-  s.version = "0.0.1"
+  s.version = "0.0.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["reddavis"]
-  s.date = %q{2010-01-05}
+  s.date = %q{2010-03-11}
   s.description = %q{Simple straight forward Naive Bayes classifier implementation}
   s.email = %q{reddavis@gmail.com}
   s.extra_rdoc_files = [

data/spec/db/naive.nb

@@ -1 +1 @@
-o:NaiveBayes	:@klass_count{:	spamf1:hamf1:@db_filepath"D/Users/reddavis/Documents/projects/naive_bayes/spec/db/naive.nb:@features_count{;}"	wordf1"badf1f0;}"wef1"badf1@:
+o:NaiveBayes	:@features_count{:	spam}I"bad:

data/spec/naive_bayes_spec.rb

@@ -14,16 +14,26 @@ describe "NaiveBayes" do
     end
   end
   
-  describe "Save" do
-    before do
-      @classifier = NaiveBayes.new(:spam, :ham)
-      @classifier.db_filepath = db_filepath
+  describe "Saving the NB" do
+    describe "DB filepath has been set" do
+      before do
+        @classifier = NaiveBayes.new(:spam, :ham)
+        @classifier.db_filepath = db_filepath
+      end
+    
+      it "should save to the filepath provided" do
+        FileUtils.rm(db_filepath, :force => true)
+        @classifier.save
+        File.exists?(db_filepath).should be_true
+      end
     end
     
-    it "should save to the filepath provided" do
-      FileUtils.rm(db_filepath, :force => true)
-      @classifier.train(:spam, 'bad')
-      File.exists?(db_filepath).should be_true
+    describe "DB filepath has no been set" do
+      it "should raise an error" do
+        lambda do  
+          NaiveBayes.new(:spam, :ham).save
+        end.should raise_error
+      end
     end
   end
   
@@ -33,6 +43,7 @@ describe "NaiveBayes" do
       classifier.db_filepath = db_filepath
       classifier.train(:spam, 'bad', 'word')
       classifier.train(:ham, 'we', 'bad')
+      classifier.save
     end
     
     it "should return 0.5" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: naive_bayes
 version: !ruby/object:Gem::Version 
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors: 
 - reddavis
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-01-05 00:00:00 +00:00
+date: 2010-03-11 00:00:00 +00:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency