nagira 0.3.3 → 0.4.0

data/spec/01_data_format/03_api_spec.rb

@@ -3,12 +3,12 @@ require 'spec_helper'
 #
 # Test resonse to /_api GET
 #
-describe Nagira do 
+describe Nagira do
 
   set :environment, ENV['RACK_ENV'] || :test
 
   include Rack::Test::Methods
-  
+
   def app
     @app ||= Nagira
   end
@@ -16,30 +16,30 @@ describe Nagira do
 
 
   context "API data" do
-    before :all do 
+    before :all do
       get "/_api.json"
       @data = JSON.parse last_response.body
     end
 
-    it "should be array" do 
-      @data.should be_a_kind_of Hash
+    it "should be array" do
+      expect(@data).to be_a_kind_of Hash
     end
 
     METHODS = %w{ GET PUT POST DELETE}
 
-    context "routes" do 
-      
+    context "routes" do
+
       METHODS.each do |method|
-        
-        context method do 
+
+        context method do
           it "routes should be an Array" do
-            @data[method].should be_a_kind_of Array if @data[method]
+            expect(@data[method]).to be_a_kind_of Array if @data[method]
           end
-          
+
           it "should star with slash" do
             if @data[method]
               @data[method].each do |path|
-                path.should =~ /^\//
+                expect(path).to match( /^\//)
               end
             end
           end

data/spec/get/comments_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 
-shared_examples_for :comment_data do 
+shared_examples_for :comment_data do
 
   let(:data) { JSON.parse(last_response.body) }
 
@@ -14,44 +14,44 @@ shared_examples_for :comment_data do
     end
   end
 
-  it { should be_a_kind_of Hash }
-  it { should have_key 'comment_id' }
-  it { should have_key 'comment_data' }
-  it { should have_key 'author' }  
+  it { expect(subject).to be_a_kind_of Hash }
+  it { expect(subject).to have_key 'comment_id' }
+  it { expect(subject).to have_key 'comment_data' }
+  it { expect(subject).to have_key 'author' }
 
 end
 
 
-describe Nagira do 
-  
+describe Nagira do
+
   set :environment, ENV['RACK_ENV'] || :test
   include Rack::Test::Methods
-  def app 
+  def app
     @app ||= Nagira
   end
-  
+
   before :all do
     get "/_status/_list.json"
     @host = JSON.parse(last_response.body).first
   end
 
-  context "/_status/:host/_hostcomments" do 
+  context "/_status/:host/_hostcomments" do
     before {  get "/_status/#{@host}/_hostcomments.json" }
-    it_should_behave_like :comment_data    
+    it_should_behave_like :comment_data
   end
 
 
-  context "/_status/:host/_servicecomments" do 
+  context "/_status/:host/_servicecomments" do
     before { get "/_status/#{@host}/_servicecomments.json" }
 
     it_should_behave_like :comment_data
 
     let (:data) {  JSON.parse(last_response.body).values.first.first }
-    it { data.should have_key 'service_description' }
-    it { data.should have_key 'host_name' }
+    it { expect(data).to have_key 'service_description' }
+    it { expect(data).to have_key 'host_name' }
 
   end
 
 
-    
+
 end

data/spec/get/endpoints_spec.rb

@@ -4,12 +4,12 @@ require 'spec_helper'
 # Specs for implemetned API endpoints. Only check response: OK or 404.
 #
 
-shared_examples_for :fail_on_random_url do |base|  
+shared_examples_for :fail_on_random_url do |base|
   RANDOM.each do |url|
     ep = "#{base}/#{url}"
     it "fails on '#{ep}' string" do
       get ep
-      last_response.status.should be 404
+      expect(last_response.status).to be 404
     end
   end
 end
@@ -22,44 +22,45 @@ shared_examples_for :respond_to_valid_url do |base, urls, custom_regex|
       ep = "#{base}/#{url}"
       it "responds to #{ep}" do
         get ep
-        last_response.should be_ok
+        expect(last_response).to be_ok
       end
     end
     when nil
       ep = "#{base}"
       it "responds to #{ep}" do
         get ep
-        last_response.should be_ok
+        expect(last_response).to be_ok
       end
   end
 end
 
 shared_examples_for :fail_on_bad_url do |url|
   before {  get url }
-  it "fails on #{url}" do 
-    last_response.status.should be 404
+  it "fails on #{url}" do
+    expect(last_response.status).to eq 404
   end
 end
 
-describe Nagira do 
-  
+describe Nagira do
+
   set :environment, :test       # This should run only in test mode as it uses hardcoded host names
   include Rack::Test::Methods
-  def app 
+  def app
     @app ||= Nagira
   end
-  
+
   context "API endpoints" do
-    
-    host   = IMPLEMENTED[:hosts].first 
+
+    host   = IMPLEMENTED[:hosts].first
+    hostgroup = 'all'
     spaces = "host%20with%20space"
 
 
-    context :top do 
+    context :top do
       it_should_behave_like :respond_to_valid_url,  '', IMPLEMENTED[:top]
       it_should_behave_like :fail_on_random_url,    ''
     end
-      
+
 
     context "/_status" do
       it_should_behave_like :respond_to_valid_url,  "/_status", IMPLEMENTED[:hosts]
@@ -81,7 +82,7 @@ describe Nagira do
       end
     end                         # /_status/:host
 
-    context "/_status/:host/_services" do 
+    context "/_status/:host/_services" do
       it_should_behave_like :respond_to_valid_url,  "/_status/#{host}/_services"
       it_should_behave_like :respond_to_valid_url,  "/_status/#{host}/_services", ["SSH", "PING"]
 
@@ -92,12 +93,26 @@ describe Nagira do
 
 
     context "custom hostname regex - host with spaces" do
-        
-      it { pending "Need to figure out how to change hostname regex on the fly" }
+
+      it { pending "Need to figure out how to change hostname regex on the fly"; fail }
         #it_should_behave_like :respond_to_valid_url,  "/_status/#{spaces}", nil, '\w[(%20)\w\-\.]+'
         #it_should_behave_like :respond_to_valid_url,  "/_status/#{spaces}/_services"
     end                         # custom hostname regex
-    
+
+    context "Hostgroups" do
+
+      context "/_status/_hostgroups/:hostgroup" do
+        it_should_behave_like :respond_to_valid_url,  "/_status/_hostgroup/#{hostgroup}"
+      end
+
+      context "/_status/_hostgroups/:hostgroup/_service" do
+        it_should_behave_like :respond_to_valid_url,  "/_status/_hostgroup/#{hostgroup}/_service"
+      end
+      context "/_status/_hostgroups/:hostgroup/_host" do
+        it_should_behave_like :respond_to_valid_url,  "/_status/_hostgroup/#{hostgroup}/_host"
+      end
+    end                         # Hostgroup
+
   end                           # API endpoints
-    
+
 end

data/spec/get/hostgroup.rb

@@ -0,0 +1,79 @@
+require 'spec_helper'
+describe Nagira do
+
+  set :environment, ENV['RACK_ENV'] || :test
+  include Rack::Test::Methods
+  def app
+    @app ||= Nagira
+  end
+
+  before :all do
+    get "/_objects/hostgroup/_list.json"
+    @hostgroup = JSON.parse(last_response.body).first
+
+    get "/_objects/host/_list.json"
+    @hosts = JSON.parse(last_response.body).sort
+
+  end
+
+  context  "/_status/_hostgroup/@hostgroup " do
+
+    before do
+      get "/_status/_hostgroup/#{ @hostgroup }"
+      @data = JSON.parse(last_response.body)
+    end
+
+    it "returns hostgroup Hash" do
+      expect(@data).to be_a_kind_of Hash
+    end
+
+    it "hostgroup Hash should contain all hosts" do
+      expect(@data.keys.sort).to eq @hosts
+    end
+
+    it "host data should have both host and service status" do
+      expect(@data['viy'].keys).to eq ['hoststatus', 'servicestatus']
+    end
+
+  end
+
+
+  context  "/_status/_hostgroup/@hostgroup/_host" do
+
+    before do
+      get "/_status/_hostgroup/#{ @hostgroup }/_host"
+      @data = JSON.parse(last_response.body)
+    end
+
+    it "returns Hash" do
+      expect(@data).to be_a_kind_of Hash
+    end
+
+    it "host data should have host status attributes" do
+      expect(@data['viy'].keys).to include 'host_name', 'check_command' ,'check_interval'
+    end
+
+  end
+
+  context  "/_status/_hostgroup/@hostgroup/_service" do
+
+    before do
+      get "/_status/_hostgroup/#{ @hostgroup }/_service"
+      @data = JSON.parse(last_response.body)
+    end
+
+    it "returns Hash" do
+      expect(@data).to be_a_kind_of Hash
+    end
+
+    it "service data should contain service names" do
+      expect(@data['viy'].keys).to include 'SSH', 'PING'
+    end
+
+    it "service data should contain service attributes" do
+      expect(@data['viy']['SSH']).to include 'host_name', 'service_description'
+    end
+
+  end
+
+end

data/spec/get/hosts_spec.rb

@@ -1,29 +1,29 @@
 require 'spec_helper'
 
-describe Nagira do 
-  
+describe Nagira do
+
   set :environment, ENV['RACK_ENV'] || :test
   include Rack::Test::Methods
-  def app 
+  def app
     @app ||= Nagira
   end
-  
-  context "/_hosts" do 
 
-    before :each do 
+  context "/_hosts" do
+
+    before :each do
       get "/_status/_list"
       @data = JSON.parse(last_response.body)
     end
 
     it "return hosts list " do
-        @data.should be_a_kind_of Array
+        expect(@data).to be_a_kind_of Array
     end
 
-    it "hostname is a string" do 
-      @data.first.should be_a_kind_of String
+    it "hostname is a string" do
+      expect(@data.first).to be_a_kind_of String
     end
 
   end
 
-    
+
 end

data/spec/get/services_spec.rb

@@ -4,30 +4,30 @@ require 'spec_helper'
 #
 # Endpoint checks (i.e. check HTTP success) are in  endpoints_spec.rb
 
-describe Nagira do 
-  
+describe Nagira do
+
   set :environment, ENV['RACK_ENV'] || :test
   include Rack::Test::Methods
-  def app 
+  def app
     @app ||= Nagira
   end
-  
+
   before :all do
     get "/_status/_list.json"
     @host = JSON.parse(last_response.body).first
   end
 
-  context "/_hosts/:host/_services" do 
+  context "/_hosts/:host/_services" do
 
-    before :each do 
+    before :each do
       get "/_status/#{@host}/_services"
       @data = JSON.parse(last_response.body)
     end
 
     it "return services list " do
-        @data.should be_a_kind_of Hash
+        expect(@data).to be_a_kind_of Hash
     end
   end
 
-    
+
 end

data/spec/put/host_spec.rb

@@ -2,25 +2,25 @@ require 'spec_helper'
 require_relative 'support'
 require 'pp'
 
-describe Nagira do 
-  
+describe Nagira do
+
   set :environment, :test       #  This is potentially desctructive test, run only in  test mode
   include Rack::Test::Methods
-  def app 
+  def app
     @app ||= Nagira
   end
 
-  before :all do 
+  before :all do
     get "/_status/_list.json"
     @host = JSON.parse(last_response.body).first
   end
 
   let (:content_type) {  {'Content-Type' => 'application/json'} }
   let (:host) { @host }
-  let (:input) { 
+  let (:input) {
     {
-      "status_code" => 0, 
-      "plugin_output" => "Plugin said: Bla" 
+      "status_code" => 0,
+      "plugin_output" => "Plugin said: Bla"
     }
   }
 
@@ -29,13 +29,13 @@ describe Nagira do
   #
 
   context "/_status" do
-    it { pending "Not implemented" }
+    it { pending "Not implemented"; fail }
   end                           # ----------- "/_status" do
 
   context "/_status/:host_name" do
     let (:url) { "/_status/#{host}"}
 
-    before (:each) do 
+    before (:each) do
       put url, input.to_json, content_type
     end
 
@@ -45,13 +45,13 @@ describe Nagira do
       input.keys.each do |key|
         (inp = input.dup).delete key
         put url, inp.to_json, content_type
-        last_response.status.should eq 400
+        expect(last_response.status).to eq 400
       end
     end
 
     context "/_host_status/:host_name" do
-      it { pending "Not implemented" }
-    end                         # ----------- "/_host_status/:host_name" 
+      it { pending "Not implemented" ; fail }
+    end                         # ----------- "/_host_status/:host_name"
 
 
   end                           #  ----------- /_status/:host