nagios-zfs 0.1.0 → 0.1.1

data/lib/nagios/zfs/version.rb

@@ -1,5 +1,5 @@
 module Nagios
   module ZFS
-    VERSION = '0.1.0'
+    VERSION = '0.1.1'
   end
 end

data/lib/nagios/zfs/zpool_plugin.rb

@@ -5,7 +5,8 @@ module Nagios
 
       option :zpool,
         :short => '-p ZPOOL_NAME',
-        :long  => '--pool ZPOOL_NAME'
+        :long  => '--pool ZPOOL_NAME',
+        :required => true
 
       option :critical,
         :short => '-c CRITICAL_CAPACITY',

data/spec/nagios/zfs/zpool_plugin_spec.rb

@@ -4,12 +4,20 @@ module Nagios
   module ZFS
     describe ZpoolPlugin do
       let(:plugin) { ZpoolPlugin.new }
-      let(:argv)   { [] }
+      let(:argv)   { %w(--pool tank) }
 
       before do
         ZpoolPlugin.any_instance.stub(:argv).and_return(argv)
       end
 
+      context 'without required arguments' do
+        let(:argv) { [] }
+
+        it 'raises an error without pool name' do
+          expect { plugin }.to raise_error(SystemExit)
+        end
+      end
+
       describe '#critical?' do
         it 'returns true when capacity is critical' do
           plugin.should_receive(:critical_capacity?).and_return(true)
@@ -104,18 +112,17 @@ module Nagios
 
       describe '#config' do
         %w(-p --pool).each do |opt|
-          name = 'tank'
-          context "with #{opt} #{name}" do
-            let(:argv) { [opt, name] }
+          context "with #{opt}" do
+            before { argv << opt << 'tank' }
 
-            it { expect(plugin.config[:zpool]).to eq(name) }
+            it { expect(plugin.config[:zpool]).to eq('tank') }
           end
         end
 
         %w(-c --critical).each do |opt|
           threshold = 42
-          context "with #{opt} #{threshold}" do
-            let(:argv) { [opt, threshold.to_s] }
+          context "with #{opt}" do
+            before { argv << opt << threshold.to_s }
 
             it { expect(plugin.config[:critical]).to eq(threshold) }
           end
@@ -123,8 +130,8 @@ module Nagios
 
         %w(-w --warning).each do |opt|
           threshold = 42
-          context "with #{opt} #{threshold}" do
-            let(:argv) { [opt, threshold.to_s] }
+          context "with #{opt}" do
+            before { argv << opt << threshold.to_s }
 
             it { expect(plugin.config[:warning]).to eq(threshold) }
           end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nagios-zfs
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-02 00:00:00.000000000 Z
+date: 2013-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nagiosplugin
@@ -182,7 +182,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 4578558176594243719
+      hash: -2614810607798314703
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -191,13 +191,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 4578558176594243719
+      hash: -2614810607798314703
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
-summary: nagios-zfs-0.1.0
+summary: nagios-zfs-0.1.1
 test_files:
 - features/check_zpool_capacity.feature
 - features/step_definitions/dev_steps.rb