nacha 0.1.5 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0c263ac1b849fc88d62de1fa8e01fc3e7afbe5277c9ec96bb8317f00a587ce46
-  data.tar.gz: b194ada2fd9a5075279e6dd316f34dfec6ba263554920f2d72460174cd9e938c
+  metadata.gz: 8375798ff41c91e7a14ae4ebbf1442f7ceaf83ae7f61c81b1b88c87fd2ca4760
+  data.tar.gz: b35fa722059c4eab240896141868eb27cd2b17c5c17539b5281a5d2a71ccfb07
 SHA512:
-  metadata.gz: 48818fd3a324f8def81109f5306331c864564d32502a1cf0e98cf2656cf966eab29a7ce6442c176b7c493570fa54c1119e181b7d2a917170a71fd9df1d17299f
-  data.tar.gz: ea4ad06ae76ff311a856c3c24fb448c9f190d51806d039269984b7bf66fed21965b0e071b2c9864a19dc63da6a36ecd5bc8d9204db40a6d1ec470ac9a582f669
+  metadata.gz: f5bd9637030e63e90ca54b3203a09341badba050d4b9351063e2ea6c2da743ecbf33539280e1b7fc03b44a93bfa90fb644ace1cd895a98ee473e7925ca0b0454
+  data.tar.gz: 49b0621426a2609b6f65b4385f159cd053cfd9e7dc6e294850b1bcf7b1c7c723f771d2487e494a9dee0c704c4d572e35f5441c8391ddf2b78460d4c7f2a55b77

data/CHANGELOG.md

@@ -7,6 +7,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.1.7] - 2025-06-23
+
+- Better parsing.  Nacha::Record::FileControl had issues parsing if the reserved
+  part of the record was stripped off.   Since the reserved part of the record is
+  all spaces, it can safely be missing.
+
+
+## [0.1.6] - 2025-06-20
+
+- Better code coverage
+
+- fixed an issue with jruby running tests
+
+- Bump version to 0.1.6
+
+
 ## [0.1.5] - 2025-06-18
 
 ### Fixed

data/lib/nacha/ach_date.rb

@@ -36,7 +36,7 @@ class Nacha::AchDate < Date
     # This works because `Date.new` is designed to be effectively `allocate.initialize`.
     super(year, month, day)
 
-  rescue ArgumentError => e
+  rescue TypeError, ArgumentError => e
     # Catch errors that might arise from strptime or invalid date components
     raise ArgumentError, "Invalid date format for Nacha::AchDate: #{args.inspect}. Original error: #{e.message}"
   end

data/lib/nacha/numeric.rb

@@ -5,14 +5,12 @@ class Nacha::Numeric
   end
 
   def to_i
-    if @value
-      if @value.is_a?(String) && @value.match(/\A *\z/)
-        @value # blank strings should return as blank
-      else
-        @value.to_i
-      end
+    return 0 if @value.nil?
+
+    if @value.is_a?(String) && @value.match(/\A *\z/)
+      @value # blank strings should return as blank
     else
-      self
+      @value.to_i
     end
   end
 

data/lib/nacha/parser.rb

@@ -4,7 +4,8 @@ require 'nacha'
 require 'nacha/parser_context'
 
 class Nacha::Parser
-  DEFAULT_RECORD_TYPES = ['Nacha::Record::FileHeader'].freeze
+  DEFAULT_RECORD_TYPES = ['Nacha::Record::FileHeader',
+                         'Nacha::Record::Filler'].freeze
 
   attr_reader :context
 

data/lib/nacha/parser_context.rb

@@ -11,7 +11,7 @@ class Nacha::ParserContext
   attr_accessor :previous_record
   attr_reader :validated
 
-  def initialize (opts = {})
+  def initialize(opts = {})
     @file_name = opts[:file_name] || ''
     @line_number = opts[:line_number] || 0
     @line_length = opts[:line_length] || 0

data/lib/nacha/record/base.rb

@@ -3,7 +3,7 @@
 require 'json'
 require 'nacha/field'
 require 'nacha/record/validations/field_validations'
-require 'byebug'
+
 module Nacha
   module Record
     class Base
@@ -29,8 +29,6 @@ module Nacha
       end
 
       class << self
-        attr_reader :nacha_record_name
-
         def nacha_field(name, inclusion:, contents:, position:)
           definition[name] = { inclusion: inclusion,
                                contents: contents,
@@ -41,7 +39,9 @@ module Nacha
 
           validations[name] ||= []
           validations[name] << validation_method
+          Nacha.add_ach_record_type(self)
         end
+
         def definition
           @definition ||= {}
         end
@@ -81,8 +81,14 @@ module Nacha
           @matcher ||=
             Regexp.new('\A' + definition.values.reverse.collect do |d|
                          if d[:contents] =~ /\AC(.+)\z/
-                           output_started = true
-                           Regexp.last_match(1)
+                           last_match = Regexp.last_match(1)
+                           if last_match =~ /\A  *\z/
+                             skipped_output = true
+                             ''
+                           else
+                             output_started = true
+                             last_match
+                           end
                          elsif d[:contents] =~ /\ANumeric\z/
                            if output_started
                              '[0-9 ]' + "{#{(d[:position] || d['position']).size}}"

data/lib/nacha/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Nacha
-  VERSION = '0.1.5'
+  VERSION = '0.1.7'
 end

data/lib/nacha.rb

@@ -7,16 +7,6 @@ require 'nacha/ach_date'
 require 'nacha/field'
 require 'nacha/numeric'
 
-Gem.find_files('nacha/record/*.rb').reject{|f| f =~ /\/spec\//}.each do |file|
-  require File.expand_path(file)
-end
-
-Gem.find_files('nacha/record/**/*.rb').reject{|f| f =~ /\/spec\//}.each do |file|
-  require File.expand_path(file)
-end
-
-require 'nacha/parser'
-
 module Nacha
   STANDARD_ENTRY_CLASS_CODES = %w[ACK ADV ARC ATX BOC CCD PPD CIE
                                   COR CTX DNE ENR IAT POP POS SHR
@@ -30,6 +20,16 @@ module Nacha
                                 48 49 55 56 82 84 86 88].freeze
 
   TRANSACTION_CODES = (CREDIT_TRANSACTION_CODES + DEBIT_TRANSACTION_CODES).freeze
+  @@ach_record_types = []
+
+  def self.add_ach_record_type(klass)
+    @@ach_record_types << klass unless @@ach_record_types.include?(klass)
+  end
+
+  def self.ach_record_types
+    @@ach_record_types
+  end
+
   class << self
     def parse(object)
       parser = Nacha::Parser.new
@@ -53,3 +53,14 @@ module Nacha
     end
   end
 end
+
+Gem.find_files('nacha/record/*.rb').reject{|f| f =~ /\/spec\//}.each do |file|
+  require File.expand_path(file)
+end
+
+Gem.find_files('nacha/record/**/*.rb').reject{|f| f =~ /\/spec\//}.each do |file|
+  require File.expand_path(file)
+end
+
+require 'nacha/parser'
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nacha
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.7
 platform: ruby
 authors:
 - David H. Wilkins