nabokov 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dd71abc02d1c0469d5514b59900199790b2e9b8b
-  data.tar.gz: 355a0707bbe1ea7196595098da5450a948868be1
+  metadata.gz: 64c97c9afb33fc642ef2ee17acd52415a7bb2d50
+  data.tar.gz: 17f19f93ace02cbc86b4c67761dcbba400641a57
 SHA512:
-  metadata.gz: dc9ce5a4b6104c0b69074553d3a72ef7f49ae69ab83dd00a7051d44cd54ef69c0642abe87d5ad9d3e4c987fb1541be7a1cb181b1ad7712313ef411d2d7fbdd1e
-  data.tar.gz: 828af0acfaa649d4713954b55d711a3c4a7fc32553ed47e79b87f5249a0b1e8ed1ee0b901243631db111d4d1b0c8851d039c83aaef7fa2a86c00ea2d7f4fec89
+  metadata.gz: f8ccd7f1de94148b73ae52b0973f5a1af9fcdf846996c059b01eea2472a564f7a01e34cec4e32bf5ae78cbfd7b06a3c9646653d0184b4dd36380424ba24e7467
+  data.tar.gz: f003bb0705b04cba895b986eeb5fce6f80313e581d12add784083bcede370cc980a672da62a38234f0604b7d18b0ba4bc8ac07f65ed159b8f698efea3ce07a66

data/.travis.yml

@@ -12,3 +12,9 @@ bundler_args: "--without documentation --path bundle"
 
 before_install:
   - gem install bundler
+  - bundle install
+
+script:
+  - bundle install
+  - bundle exec rake spec
+  - bundle exec danger --verbose

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## master
 
+## 0.1.1
+
+* Add Dangerfile
+* Fix quickwins from the codebeat report [antondomashnev]
+
 ## 0.1
 
 * The very beginning of the nabokov

data/Dangerfile

@@ -0,0 +1,23 @@
+has_app_changes = !git.modified_files.grep(/lib/).empty?
+has_test_changes = !git.modified_files.grep(/spec/).empty?
+
+if has_app_changes && !has_test_changes
+  warn("Tests were not updated")
+end
+
+if github.pr_title.length < 5
+  fail "Please provide a meaningful Pull Request title"
+end
+
+if github.pr_body.length < 5
+  fail "Please provide a summary in the Pull Request description"
+end
+
+declared_trivial = (github.pr_title + github.pr_body).include?("#trivial") || !has_app_changes
+changelog.check unless declared_trivial
+
+protected_files = ["nabokov.gemspec", "Dangerfile", "Gemfile", ".gitignore", ".travis.yml", ".rubocop.yml", "Rakefile"]
+protected_files.each do |file|
+  next if git.modified_files.grep(/#{file}/).empty?
+  warn("#{file} has been modified")
+end

data/Gemfile

@@ -1,9 +1,12 @@
 source "https://rubygems.org"
 
-gem "rspec", "~> 3.4"
 gem "claide", "~> 1.0"
 gem "cork", "~> 0.1"
-gem "rake", "~> 10.0"
 gem "git", git: "https://github.com/Antondomashnev/ruby-git.git"
 
+gem "rspec", "~> 3.4"
 gem "rubocop", "~> 0.42"
+gem "rake", "~> 10.0"
+
+gem "danger", "~> 3.0"
+gem "danger-changelog"

data/README.md

@@ -3,6 +3,8 @@ Move mobile localization process up to the next level 🚀
 
 
 [![License](http://img.shields.io/badge/license-MIT-green.svg?style=flat)](https://github.com/Antondomashnev/nabokov/blob/master/LICENSE)
+[![codebeat badge](https://codebeat.co/badges/cd388b60-f4e0-4b2d-8278-a7d2764d642d)](https://codebeat.co/projects/github-com-antondomashnev-nabokov)
+![travis badge](https://travis-ci.org/Antondomashnev/nabokov.svg?branch=master)
 
 ## Current status
 This project is on the early development stage and is *not ready for production*. The `master` branch is empty and now the current status can be checked in `develop` branch. Also readme is not ready at all and we'll be updated as soon as the first functional becomes to the `master` branch.

data/lib/nabokov/core/nabokovfile.rb

@@ -45,13 +45,8 @@ module Nabokov
     end
 
     def read_content(content_hash)
-      localizations_repo = content_hash[NabokovfileKeyes.localizations_repo]
-      self.localizations_repo_url = localizations_repo[NabokovfileKeyes.localizations_repo_url]
-      self.localizations_repo_master_branch = localizations_repo[NabokovfileKeyes.localizations_repo_master_branch].nil? ? "master" : localizations_repo[NabokovfileKeyes.localizations_repo_master_branch]
-      project_repo = content_hash[NabokovfileKeyes.project_repo]
-      self.project_localization_file_paths = project_repo[NabokovfileKeyes.project_localization_file_paths]
-      self.project_local_path = project_repo[NabokovfileKeyes.project_local_path]
-      self.localizations_repo_local_path = build_localization_local_path
+      read_localizations_repo_content(content_hash)
+      read_project_repo_content(content_hash)
     end
 
     def build_localization_local_path
@@ -62,5 +57,18 @@ module Nabokov
       nabokov_dir_name = "/.nabokov"
       home_dir + nabokov_dir_name + repo_url_organization + "/" + repo_url_name_without_extension
     end
+
+    def read_localizations_repo_content(content_hash)
+      localizations_repo = content_hash[NabokovfileKeyes.localizations_repo]
+      self.localizations_repo_url = localizations_repo[NabokovfileKeyes.localizations_repo_url]
+      self.localizations_repo_master_branch = localizations_repo[NabokovfileKeyes.localizations_repo_master_branch].nil? ? "master" : localizations_repo[NabokovfileKeyes.localizations_repo_master_branch]
+    end
+
+    def read_project_repo_content(content_hash)
+      project_repo = content_hash[NabokovfileKeyes.project_repo]
+      self.project_localization_file_paths = project_repo[NabokovfileKeyes.project_localization_file_paths]
+      self.project_local_path = project_repo[NabokovfileKeyes.project_local_path]
+      self.localizations_repo_local_path = build_localization_local_path
+    end
   end
 end

data/lib/nabokov/helpers/informator.rb

@@ -45,39 +45,42 @@ module Nabokov
 
     def ask_with_answers(question, possible_answers)
       ui.print("\n#{question}? [")
-
-      print_info = proc do
-        possible_answers.each_with_index do |answer, i|
-          the_answer = i.zero? ? answer.underline : answer
-          ui.print " " + the_answer
-          ui.print(" /") if i != possible_answers.length - 1
-        end
-        ui.print " ]\n"
-      end
-      print_info.call
-
+      print_possible_answers(possible_answers)
       answer = ""
-
       loop do
         show_prompt
-        answer = @no_waiting ? possible_answers[0].downcase : STDIN.gets.downcase.chomp
-
-        answer = "yes" if answer == "y"
-        answer = "no" if answer == "n"
-
-        # default to first answer
-        if answer == ""
-          answer = possible_answers[0].downcase
-          ui.puts "Using: " + answer.yellow
-        end
+        answer = read_answer(possible_answers)
 
         break if possible_answers.map(&:downcase).include? answer
 
         ui.print "\nPossible answers are ["
-        print_info.call
+        print_possible_answers(possible_answers)
       end
+      answer
+    end
+
+    private
 
+    def read_answer(possible_answers)
+      answer = @no_waiting ? possible_answers[0].downcase : STDIN.gets.downcase.chomp
+      answer = "yes" if answer == "y"
+      answer = "no" if answer == "n"
+
+      # default to first answer
+      if answer == ""
+        answer = possible_answers[0].downcase
+        ui.puts "Using: " + answer.yellow
+      end
       answer
     end
+
+    def print_possible_answers(possible_answers)
+      possible_answers.each_with_index do |answer, i|
+        the_answer = i.zero? ? answer.underline : answer
+        ui.print " " + the_answer
+        ui.print(" /") if i != possible_answers.length - 1
+      end
+      ui.print " ]\n"
+    end
   end
 end

data/lib/nabokov/version.rb

@@ -1,5 +1,5 @@
 module Nabokov
-  VERSION = "0.1.0".freeze
+  VERSION = "0.1.1".freeze
   DESCRIPTION = "One of the way to work on the localization - store it in the separate github repo
                  and asks localization team to update files in that repo.
                  This solution brings as well advantages but as well a disadvantages, to minimize the disadvantages

data/nabokov.gemspec

@@ -25,6 +25,8 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency "claide", "~> 1.0"
   spec.add_runtime_dependency "cork", "~> 0.1"
 
+  spec.add_development_dependency "danger", "~> 3.0"
+  spec.add_development_dependency "danger-changelog"
   spec.add_development_dependency "rubocop", "~> 0.42"
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nabokov
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Anton Domashnev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-08 00:00:00.000000000 Z
+date: 2016-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -66,6 +66,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.1'
+- !ruby/object:Gem::Dependency
+  name: danger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: danger-changelog
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -127,6 +155,7 @@ files:
 - ".rubocop.yml"
 - ".travis.yml"
 - CHANGELOG.md
+- Dangerfile
 - Gemfile
 - LICENSE
 - README.md