n2b 0.7.1 → 2.1.0

data/lib/n2b/base.rb

@@ -3,12 +3,36 @@ require_relative 'model_config'
 module N2B
   class Base
 
-    CONFIG_FILE = ENV['N2B_CONFIG_FILE'] || File.expand_path('~/.n2b/config.yml')
-    HISTORY_FILE = ENV['N2B_HISTORY_FILE'] || File.expand_path('~/.n2b/history')
+    def self.config_file
+      # Bulletproof test environment detection
+      if test_environment?
+        File.expand_path('~/.n2b_test/config.yml')
+      else
+        ENV['N2B_CONFIG_FILE'] || File.expand_path('~/.n2b/config.yml')
+      end
+    end
+
+    def self.history_file
+      if test_environment?
+        File.expand_path('~/.n2b_test/history')
+      else
+        ENV['N2B_HISTORY_FILE'] || File.expand_path('~/.n2b/history')
+      end
+    end
+
+    def self.test_environment?
+      # Multiple ways to detect test environment for maximum safety
+      ENV['RAILS_ENV'] == 'test' ||
+      ENV['RACK_ENV'] == 'test' ||
+      ENV['N2B_TEST_MODE'] == 'true' ||
+      $PROGRAM_NAME.include?('rake') ||
+      $PROGRAM_NAME.include?('test') ||
+      caller.any? { |line| line.include?('test/') || line.include?('minitest') || line.include?('rake') }
+    end
 
     def load_config
-      if File.exist?(CONFIG_FILE)
-        YAML.load_file(CONFIG_FILE)
+      if File.exist?(self.class.config_file)
+        YAML.load_file(self.class.config_file)
       else
         { }
       end
@@ -22,13 +46,19 @@ module N2B
       # Determine if it's effectively a first-time setup for core LLM details
       is_first_time_core_setup = config['llm'].nil?
 
-      if api_key.nil? || api_key == '' || config['llm'].nil? || reconfigure
+      # Check if configuration is incomplete based on provider type
+      config_incomplete = config['llm'].nil? || reconfigure ||
+                         (config['llm'] == 'vertexai' && (config['vertex_credential_file'].nil? || config['vertex_credential_file'].empty?)) ||
+                         (config['llm'] == 'ollama' && false) || # Ollama doesn't require API key, so never incomplete due to missing key
+                         (['claude', 'openai', 'gemini', 'openrouter'].include?(config['llm']) && (api_key.nil? || api_key == ''))
+
+      if config_incomplete
         puts "--- N2B Core LLM Configuration ---"
-        print "Choose a language model to use (1:claude, 2:openai, 3:gemini, 4:openrouter, 5:ollama) [current: #{config['llm']}]: "
+        print "Choose a language model to use (1:claude, 2:openai, 3:gemini (API Key), 4:openrouter, 5:ollama, 6:vertexai (Credential File)) [current: #{config['llm']}]: "
         llm_choice = $stdin.gets.chomp
         llm_choice = config['llm'] if llm_choice.empty? && !config['llm'].nil? # Keep current if input is empty
 
-        unless ['claude', 'openai', 'gemini', 'openrouter', 'ollama', '1', '2', '3', '4', '5'].include?(llm_choice)
+        unless ['claude', 'openai', 'gemini', 'openrouter', 'ollama', 'vertexai', '1', '2', '3', '4', '5', '6'].include?(llm_choice)
           puts "Invalid language model selection. Defaulting to 'claude' or previous if available."
           llm_choice = config['llm'] || 'claude' # Fallback
         end
@@ -36,10 +66,11 @@ module N2B
         selected_llm = case llm_choice
                        when '1', 'claude' then 'claude'
                        when '2', 'openai' then 'openai'
-                       when '3', 'gemini' then 'gemini'
+                       when '3', 'gemini' then 'gemini'    # This is now explicitly API Key based Gemini
                        when '4', 'openrouter' then 'openrouter'
                        when '5', 'ollama' then 'ollama'
-                       else config['llm'] || 'claude' # Should not happen due to validation
+                       when '6', 'vertexai' then 'vertexai'  # New Vertex AI (credential file)
+                       else config['llm'] || 'claude'
                        end
         config['llm'] = selected_llm
 
@@ -47,18 +78,76 @@ module N2B
           puts "\n--- Ollama Specific Configuration ---"
           puts "Ollama typically runs locally and doesn't require an API key."
 
-          # Use new model configuration system
           current_model = config['model']
-          model_choice = N2B::ModelConfig.get_model_choice(selected_llm, current_model) # Renamed to model_choice to avoid conflict
+          model_choice = N2B::ModelConfig.get_model_choice(selected_llm, current_model)
           config['model'] = model_choice
 
           current_ollama_api_url = config['ollama_api_url'] || N2M::Llm::Ollama::DEFAULT_OLLAMA_API_URI
           print "Enter Ollama API base URL [current: #{current_ollama_api_url}]: "
           ollama_api_url_input = $stdin.gets.chomp
           config['ollama_api_url'] = ollama_api_url_input.empty? ? current_ollama_api_url : ollama_api_url_input
-          config.delete('access_key') # Remove access_key if switching to ollama
-        else
-          # Configuration for API key based LLMs
+
+          config.delete('access_key')
+          config.delete('gemini_credential_file') # old key
+          config.delete('vertex_credential_file') # new key for Vertex
+
+        elsif selected_llm == 'vertexai'
+          puts "\n--- Vertex AI (Credential File) Specific Configuration ---"
+          current_vertex_credential_file = config['vertex_credential_file']
+          print "Enter your Google Cloud credential file path for Vertex AI #{current_vertex_credential_file ? '[leave blank to keep current]' : ''}: "
+          vertex_credential_file_input = $stdin.gets.chomp
+          if !vertex_credential_file_input.empty?
+            config['vertex_credential_file'] = vertex_credential_file_input
+          elsif current_vertex_credential_file
+            config['vertex_credential_file'] = current_vertex_credential_file
+          else
+            config['vertex_credential_file'] = nil
+          end
+
+          # Ask for Vertex AI region
+          current_vertex_location = config['vertex_location'] || 'us-central1'
+          puts "\nVertex AI Region Selection:"
+          puts "Common regions:"
+          puts "  1. us-central1 (Iowa, USA) [default]"
+          puts "  2. us-east1 (South Carolina, USA)"
+          puts "  3. us-west1 (Oregon, USA)"
+          puts "  4. europe-west1 (Belgium)"
+          puts "  5. europe-west4 (Netherlands)"
+          puts "  6. asia-northeast1 (Tokyo, Japan)"
+          puts "  7. asia-southeast1 (Singapore)"
+          puts "  8. custom (enter your own region)"
+          print "Choose region (1-8) or enter region name [current: #{current_vertex_location}]: "
+
+          region_choice = $stdin.gets.chomp
+          if region_choice.empty?
+            config['vertex_location'] = current_vertex_location
+          else
+            case region_choice
+            when '1' then config['vertex_location'] = 'us-central1'
+            when '2' then config['vertex_location'] = 'us-east1'
+            when '3' then config['vertex_location'] = 'us-west1'
+            when '4' then config['vertex_location'] = 'europe-west1'
+            when '5' then config['vertex_location'] = 'europe-west4'
+            when '6' then config['vertex_location'] = 'asia-northeast1'
+            when '7' then config['vertex_location'] = 'asia-southeast1'
+            when '8'
+              print "Enter custom region (e.g., europe-west2): "
+              custom_region = $stdin.gets.chomp
+              config['vertex_location'] = custom_region.empty? ? current_vertex_location : custom_region
+            else
+              # Treat as direct region input
+              config['vertex_location'] = region_choice
+            end
+          end
+
+          config.delete('access_key')
+          config.delete('ollama_api_url')
+          config.delete('gemini_credential_file') # old key
+
+          current_model = config['model']
+          model_choice = N2B::ModelConfig.get_model_choice(selected_llm, current_model)
+          config['model'] = model_choice
+        else # API Key based LLMs: claude, openai, gemini (API Key), openrouter
           puts "\n--- #{selected_llm.capitalize} Specific Configuration ---"
           current_api_key = config['access_key']
           print "Enter your #{selected_llm} API key #{ current_api_key.nil? || current_api_key.empty? ? '' : '[leave blank to keep current]' }: "
@@ -70,9 +159,12 @@ module N2B
             puts "API key is required for #{selected_llm}."
             exit 1
           end
+          config.delete('vertex_credential_file') # new key for Vertex
+          config.delete('ollama_api_url')
+          config.delete('gemini_credential_file') # old key
 
           current_model = config['model']
-          model_choice = N2B::ModelConfig.get_model_choice(selected_llm, current_model) # Renamed
+          model_choice = N2B::ModelConfig.get_model_choice(selected_llm, current_model)
           config['model'] = model_choice
 
           if selected_llm == 'openrouter'
@@ -94,26 +186,46 @@ module N2B
 
         if prompt_for_advanced
           puts "\n--- Advanced Settings ---"
-          print "Would you like to configure advanced settings (e.g., Jira integration, privacy)? (y/n) [default: n]: "
+          print "Would you like to configure advanced settings (e.g., Jira or GitHub integration, privacy)? (y/n) [default: n]: "
           choice = $stdin.gets.chomp.downcase
 
           if choice == 'y'
-            # Jira Configuration
-            puts "\n--- Jira Integration ---"
-            puts "You can generate a Jira API token here: https://support.atlassian.com/atlassian-account/docs/manage-api-tokens-for-your-atlassian-account/"
-            config['jira'] ||= {}
-            print "Jira Domain (e.g., your-company.atlassian.net) [current: #{config['jira']['domain']}]: "
-            config['jira']['domain'] = $stdin.gets.chomp.then { |val| val.empty? ? config['jira']['domain'] : val }
-
-            print "Jira Email Address [current: #{config['jira']['email']}]: "
-            config['jira']['email'] = $stdin.gets.chomp.then { |val| val.empty? ? config['jira']['email'] : val }
-
-            print "Jira API Token #{config['jira']['api_key'] ? '[leave blank to keep current]' : ''}: "
-            api_token_input = $stdin.gets.chomp
-            config['jira']['api_key'] = api_token_input if !api_token_input.empty?
-
-            print "Default Jira Project Key (optional, e.g., MYPROJ) [current: #{config['jira']['default_project']}]: "
-            config['jira']['default_project'] = $stdin.gets.chomp.then { |val| val.empty? ? config['jira']['default_project'] : val }
+            current_tracker = config['issue_tracker'] || 'none'
+            print "\nSelect issue tracker to integrate (none, jira, github) [current: #{current_tracker}]: "
+            tracker_choice = $stdin.gets.chomp.downcase
+            tracker_choice = current_tracker if tracker_choice.empty?
+            config['issue_tracker'] = tracker_choice
+
+            case tracker_choice
+            when 'jira'
+              puts "\n--- Jira Integration ---"
+              puts "You can generate a Jira API token here: https://support.atlassian.com/atlassian-account/docs/manage-api-tokens-for-your-atlassian-account/"
+              config['jira'] ||= {}
+              print "Jira Domain (e.g., your-company.atlassian.net) [current: #{config['jira']['domain']}]: "
+              config['jira']['domain'] = $stdin.gets.chomp.then { |val| val.empty? ? config['jira']['domain'] : val }
+
+              print "Jira Email Address [current: #{config['jira']['email']}]: "
+              config['jira']['email'] = $stdin.gets.chomp.then { |val| val.empty? ? config['jira']['email'] : val }
+
+              print "Jira API Token #{config['jira']['api_key'] ? '[leave blank to keep current]' : ''}: "
+              api_token_input = $stdin.gets.chomp
+              config['jira']['api_key'] = api_token_input if !api_token_input.empty?
+
+              print "Default Jira Project Key (optional, e.g., MYPROJ) [current: #{config['jira']['default_project']}]: "
+              config['jira']['default_project'] = $stdin.gets.chomp.then { |val| val.empty? ? config['jira']['default_project'] : val }
+            when 'github'
+              puts "\n--- GitHub Integration ---"
+              config['github'] ||= {}
+              print "GitHub Repository (owner/repo) [current: #{config['github']['repo']}]: "
+              config['github']['repo'] = $stdin.gets.chomp.then { |val| val.empty? ? config['github']['repo'] : val }
+
+              print "GitHub Access Token #{config['github']['access_token'] ? '[leave blank to keep current]' : ''}: "
+              token_input = $stdin.gets.chomp
+              config['github']['access_token'] = token_input if !token_input.empty?
+            else
+              config['jira'] ||= {}
+              config['github'] ||= {}
+            end
 
             # Privacy Settings
             puts "\n--- Privacy Settings ---"
@@ -132,9 +244,13 @@ module N2B
             config['append_to_shell_history'] = $stdin.gets.chomp.then { |val| val.empty? ? config['append_to_shell_history'] : (val.downcase == 'true') }
             config['privacy']['append_to_shell_history'] = config['append_to_shell_history'] # Also place under privacy for consistency
 
+            # Editor Configuration
+            prompt_for_editor_config(config)
+
           else # User chose 'n' for advanced settings
-            # Ensure Jira config is empty or defaults are cleared if user opts out of advanced
-            config['jira'] ||= {} # Ensure it exists
+            config['jira'] ||= {}
+            config['github'] ||= {}
+            config['issue_tracker'] ||= 'none'
             # If they opt out, we don't clear existing, just don't prompt.
             # If it's a fresh setup and they opt out, these will remain empty/nil.
 
@@ -148,7 +264,9 @@ module N2B
           end
         else # Not prompting for advanced (neither advanced_flow nor first_time_core_setup)
           # Ensure defaults for privacy if they don't exist from a previous config
-          config['jira'] ||= {} # Ensure Jira key exists
+          config['jira'] ||= {}
+          config['github'] ||= {}
+          config['issue_tracker'] ||= 'none'
           config['privacy'] ||= {}
           config['privacy']['send_shell_history'] = config['privacy']['send_shell_history'] || false
           config['privacy']['send_llm_history'] = config['privacy']['send_llm_history'] || true
@@ -157,6 +275,12 @@ module N2B
           config['privacy']['append_to_shell_history'] = config['append_to_shell_history']
         end
 
+        # Editor Configuration
+        config['editor'] ||= {}
+        config['editor']['command'] ||= nil # or 'nano', 'vi'
+        config['editor']['type'] ||= nil # 'text_editor' or 'diff_tool'
+        config['editor']['configured'] ||= false
+
         # Validate configuration before saving
         validation_errors = validate_config(config)
         if validation_errors.any?
@@ -165,13 +289,15 @@ module N2B
           puts "Configuration saved with warnings."
         end
 
-        puts "\nConfiguration saved to #{CONFIG_FILE}"
-        FileUtils.mkdir_p(File.dirname(CONFIG_FILE)) unless File.exist?(File.dirname(CONFIG_FILE))
-        File.write(CONFIG_FILE, config.to_yaml)
+        puts "\nConfiguration saved to #{self.class.config_file}"
+        FileUtils.mkdir_p(File.dirname(self.class.config_file)) unless File.exist?(File.dirname(self.class.config_file))
+        File.write(self.class.config_file, config.to_yaml)
       else
         # If not reconfiguring, still ensure privacy and jira keys exist with defaults if missing
         # This handles configs from before these settings were introduced
         config['jira'] ||= {}
+        config['github'] ||= {}
+        config['issue_tracker'] ||= 'none'
         config['privacy'] ||= {}
         config['privacy']['send_shell_history'] = config['privacy']['send_shell_history'] || false
         config['privacy']['send_llm_history'] = config['privacy']['send_llm_history'] || true
@@ -181,46 +307,211 @@ module N2B
         current_append_setting = config.key?('append_to_shell_history') ? config['append_to_shell_history'] : false
         config['append_to_shell_history'] = current_append_setting
         config['privacy']['append_to_shell_history'] = config['privacy']['append_to_shell_history'] || current_append_setting
+
+        # Ensure editor config is initialized if missing (for older configs)
+        config['editor'] ||= {}
+        config['editor']['command'] ||= nil
+        config['editor']['type'] ||= nil
+        config['editor']['configured'] ||= false
       end
       config
     end
 
     private
 
+    def command_exists?(command)
+      # Check for Windows or Unix-like systems for the correct command
+      null_device = RbConfig::CONFIG['host_os'] =~ /mswin|mingw|cygwin/ ? 'NUL' : '/dev/null'
+      system("which #{command} > #{null_device} 2>&1") || system("where #{command} > #{null_device} 2>&1")
+    end
+
+    def prompt_for_editor_config(config)
+      puts "\n--- Editor Configuration ---"
+      current_editor_command = config.dig('editor', 'command')
+      current_editor_type = config.dig('editor', 'type')
+      current_status = if current_editor_command
+                         "Current: #{current_editor_command} (#{current_editor_type || 'not set'})"
+                       else
+                         "Current: Not configured"
+                       end
+      puts current_status
+
+      known_editors = [
+        { name: 'nano', command: 'nano', description: 'Simple terminal editor', type: 'text_editor' },
+        { name: 'vim', command: 'vim', description: 'Powerful terminal editor', type: 'text_editor' },
+        { name: 'vi', command: 'vi', description: 'Standard Unix terminal editor', type: 'text_editor' },
+        { name: 'code', command: 'code', description: 'Visual Studio Code (requires "code" in PATH)', type: 'text_editor' },
+        { name: 'subl', command: 'subl', description: 'Sublime Text (requires "subl" in PATH)', type: 'text_editor' },
+        { name: 'meld', command: 'meld', description: 'Visual diff and merge tool', type: 'diff_tool' },
+        { name: 'kdiff3', command: 'kdiff3', description: 'Visual diff and merge tool (KDE)', type: 'diff_tool' },
+        { name: 'opendiff', command: 'opendiff', description: 'File comparison tool (macOS)', type: 'diff_tool' },
+        { name: 'vimdiff', command: 'vimdiff', description: 'Diff tool using Vim', type: 'diff_tool' }
+      ]
+
+      available_editors = known_editors.select { |editor| command_exists?(editor[:command]) }
+
+      if available_editors.empty?
+        puts "No standard editors detected automatically."
+      else
+        puts "Choose your preferred editor/diff tool:"
+        available_editors.each_with_index do |editor, index|
+          puts "#{index + 1}. #{editor[:name]} (#{editor[:description]})"
+        end
+        puts "#{available_editors.length + 1}. Custom (enter your own command)"
+        print "Enter choice (1-#{available_editors.length + 1}) or leave blank to skip: "
+      end
+
+      choice_input = $stdin.gets.chomp
+      return if choice_input.empty? && current_editor_command # Skip if already configured and user wants to skip
+
+      choice = choice_input.to_i
+
+      selected_editor = nil
+      custom_command = nil
+
+      if choice > 0 && choice <= available_editors.length
+        selected_editor = available_editors[choice - 1]
+        config['editor']['command'] = selected_editor[:command]
+        config['editor']['type'] = selected_editor[:type]
+        config['editor']['configured'] = true
+        puts "✓ Using #{selected_editor[:name]} as your editor/diff tool."
+      elsif choice == available_editors.length + 1 || (available_editors.empty? && !choice_input.empty?)
+        print "Enter custom editor command: "
+        custom_command = $stdin.gets.chomp
+        if custom_command.empty?
+          puts "No command entered. Editor configuration skipped."
+          return
+        end
+
+        print "Is this a 'text_editor' or a 'diff_tool'? (text_editor/diff_tool): "
+        custom_type = $stdin.gets.chomp.downcase
+        unless ['text_editor', 'diff_tool'].include?(custom_type)
+          puts "Invalid type. Defaulting to 'text_editor'."
+          custom_type = 'text_editor'
+        end
+        config['editor']['command'] = custom_command
+        config['editor']['type'] = custom_type
+        config['editor']['configured'] = true
+        puts "✓ Using custom command '#{custom_command}' (#{custom_type}) as your editor/diff tool."
+      else
+        puts "Invalid choice. Editor configuration skipped."
+        # Keep existing config if invalid choice, or clear if they wanted to change but failed?
+        # For now, just skipping and keeping whatever was there.
+        return
+      end
+    end
+
     def validate_config(config)
       errors = []
 
-      # Validate LLM configuration
+      # Validate LLM provider selection
       if config['llm'].nil? || config['llm'].empty?
         errors << "LLM provider not specified"
       end
 
-      # Validate model name
+      # Validate model name (existing logic can likely stay as is)
       if config['model'].nil? || config['model'].empty?
         errors << "Model not specified"
-      elsif config['model'].length < 3
+      elsif config['model'].length < 3 # Example of an existing check
         errors << "Model name '#{config['model']}' seems too short - might be invalid"
-      elsif %w[y n yes no true false].include?(config['model'].downcase)
+      elsif %w[y n yes no true false].include?(config['model'].downcase) # Example
         errors << "Model name '#{config['model']}' appears to be a boolean response rather than a model name"
       end
 
-      # Validate API key for non-Ollama providers
-      if config['llm'] != 'ollama' && (config['access_key'].nil? || config['access_key'].empty?)
-        errors << "API key missing for #{config['llm']} provider"
-      end
+      # Provider-specific validation
+      case config['llm']
+      when 'gemini' # API Key based Gemini
+        if config['access_key'].nil? || config['access_key'].empty?
+          errors << "API key missing for gemini provider"
+        end
+        if config['vertex_credential_file'] && !config['vertex_credential_file'].empty?
+          errors << "Vertex AI credential file should not be present when gemini (API Key) provider is selected"
+        end
+        # Ensure old gemini_credential_file key is also not present
+        if config['gemini_credential_file'] && !config['gemini_credential_file'].empty?
+          errors << "Old gemini_credential_file key should not be present. Use 'gemini' (API key) or 'vertexai' (credential file)."
+        end
 
-      # Validate Jira configuration if present
-      if config['jira'] && !config['jira'].empty?
-        jira_config = config['jira']
-        if jira_config['domain'] && !jira_config['domain'].empty?
-          # If domain is set, email and api_key should also be set
-          if jira_config['email'].nil? || jira_config['email'].empty?
-            errors << "Jira email missing when domain is configured"
+      when 'vertexai' # Credential File based Vertex AI
+        if config['vertex_credential_file'].nil? || config['vertex_credential_file'].empty?
+          errors << "Credential file path for Vertex AI not provided"
+        else
+          # Ensure File.exist? is only called if the path is not nil and not empty
+          unless File.exist?(config['vertex_credential_file'])
+            errors << "Credential file missing or invalid at #{config['vertex_credential_file']} for Vertex AI"
           end
-          if jira_config['api_key'].nil? || jira_config['api_key'].empty?
-            errors << "Jira API key missing when domain is configured"
+        end
+        if config['access_key'] && !config['access_key'].empty?
+          errors << "API key (access_key) should not be present when Vertex AI provider is selected"
+        end
+         # Ensure old gemini_credential_file key is also not present
+        if config['gemini_credential_file'] && !config['gemini_credential_file'].empty?
+          errors << "Old gemini_credential_file key should not be present when Vertex AI is selected."
+        end
+
+      when 'ollama'
+        # No specific key/credential validation for Ollama here, but ensure others are not present
+        if config['access_key'] && !config['access_key'].empty?
+          errors << "API key (access_key) should not be present when Ollama provider is selected"
+        end
+        if config['vertex_credential_file'] && !config['vertex_credential_file'].empty?
+          errors << "Vertex AI credential file should not be present when Ollama provider is selected"
+        end
+        if config['gemini_credential_file'] && !config['gemini_credential_file'].empty?
+          errors << "Old gemini_credential_file key should not be present when Ollama is selected."
+        end
+        # Ollama specific validations like ollama_api_url could be here if needed
+
+      when 'claude', 'openai', 'openrouter' # Other API key based providers
+        if config['access_key'].nil? || config['access_key'].empty?
+          errors << "API key missing for #{config['llm']} provider"
+        end
+        if config['vertex_credential_file'] && !config['vertex_credential_file'].empty?
+          errors << "Vertex AI credential file should not be present for #{config['llm']} provider"
+        end
+        if config['gemini_credential_file'] && !config['gemini_credential_file'].empty?
+          errors << "Old gemini_credential_file key should not be present for #{config['llm']} provider."
+        end
+      # else
+        # This case means llm is nil or an unknown provider, already handled by the first check.
+      end
+
+      # Validate editor configuration (optional, so more like warnings or info)
+      # Example: Check if command is set if configured is true
+      # if config['editor'] && config['editor']['configured'] && (config['editor']['command'].nil? || config['editor']['command'].empty?)
+      #   errors << "Editor is marked as configured, but no command is set."
+      # end
+
+      tracker = config['issue_tracker'] || 'none'
+      case tracker
+      when 'jira'
+        if config['jira'] && !config['jira'].empty?
+          jira_config = config['jira']
+          if jira_config['domain'] && !jira_config['domain'].empty?
+            if jira_config['email'].nil? || jira_config['email'].empty?
+              errors << "Jira email missing when domain is configured"
+            end
+            if jira_config['api_key'].nil? || jira_config['api_key'].empty?
+              errors << "Jira API key missing when domain is configured"
+            end
+          else
+            errors << "Jira domain missing when issue_tracker is set to 'jira'"
           end
+        else
+          errors << "Jira configuration missing when issue_tracker is set to 'jira'"
         end
+      when 'github'
+        if config['github'] && !config['github'].empty?
+          gh = config['github']
+          errors << "GitHub repository missing when issue_tracker is set to 'github'" if gh['repo'].nil? || gh['repo'].empty?
+          errors << "GitHub access token missing when issue_tracker is set to 'github'" if gh['access_token'].nil? || gh['access_token'].empty?
+        else
+          errors << "GitHub configuration missing when issue_tracker is set to 'github'"
+        end
+      when 'none'
+        # No validation needed for 'none' tracker
+      else
+        errors << "Invalid issue_tracker '#{tracker}' - must be 'jira', 'github', or 'none'"
       end
 
       errors