n1_loader 1.6.6 → 1.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f7d5587fbac0376006abf03b7beb385547b1c9206cdeea8461d9bf07b67e0df4
-  data.tar.gz: 6f94574d65b49c528a6af3e06d6d816ed78ef3cf3f6e14002249b816526cbb4a
+  metadata.gz: 35755dbc6a0ae17e636a26aaa99d903714a2e61248f60cc7a6c23f0d1ff5cbdd
+  data.tar.gz: 34ebd3c7c2d873fb42fce414c74055251ef6169df1a06ec6255a857598c8fdf7
 SHA512:
-  metadata.gz: 39d0370fee07be7e080adb22392633366da8cce0b74228c728b8647e9f7f859b4c995346bf0a8e9b477c355374b29f4f4690f089c6b6904822af3cfba88685af
-  data.tar.gz: 0245c5ba26df1d3f3508a22143ae5cb9d708c5460ef218ee2193b8cc537bf0ee6f6838357be50fe4d2d2d4c1db050e76a6176e98b3b7df4c64af4bf7b0e35e36
+  metadata.gz: b4233a0b750ccfa3e001b512a379fb5a68758c45117fdaa0b5ec9cfd1c84d344c7e261ee61927794db2246aaa6c40b9576d5a19d1e547e65f6e08eab21de903d
+  data.tar.gz: ee26e611bf87f7daf78912f01996bd7330a0dbb0d74e18a38af79b7f4869b6c43365694ef5f8597a8f1574e5cb16ff1ca4bf73421019215b29f139e4917510e9

data/CHANGELOG.md

@@ -1,3 +1,48 @@
+## [1.7.1] - 2023/07/30
+
+- Fix interface discrepancy for `N1LoaderReflection`. Thanks [Denis Talakevich](https://github.com/senid231) for suggesting it!
+
+## [1.7.0] - 2023/07/30
+
+Extend the flexibility of loading data comparison. Thanks [Nazar Matus](https://github.com/FunkyloverOne) for suggesting it! 
+
+**BREAKING CHANGES:**
+
+Loose comparison of loaded data. Before loaded data was initialized with identity comparator in mind:
+
+```ruby
+@loaded = {}.compare_by_identity
+```
+
+Now it will be:
+
+```ruby
+@loaded = {}
+```
+
+This might bring unwanted results for cases when strict comparison was wanted. 
+
+On the other hand, it gives more flexibility for many other cases, especially with isolated loader.
+For example, this will work now, when it wasn't working before.
+
+```ruby
+# ActiveRecord object
+object = Entity.first
+
+# Initialize isolated loader
+instance = loader.new([object])
+
+# This was working before because the loaded object is identical to passed object by `#object_id`
+instance.for(object)
+
+# This wasn't working before because the loaded object is not identical to passed one by `#object_id`
+# 
+# But it will be working now, because object == Entity.find(object.id)
+instance.for(Entity.find(object.id))
+```
+
+If you need strict comparison support, please feel free to open the issue or the PR.
+
 ## [1.6.6] - 2023/07/30
 
 - Fix naive check of required arguments. Thanks [Nazar Matus](https://github.com/FunkyloverOne) for the issue!

data/lib/n1_loader/active_record/associations_preloader_v5.rb

@@ -4,7 +4,7 @@ module N1Loader
   module ActiveRecord
     module Associations
       module Preloader # :nodoc:
-        N1LoaderReflection = Struct.new(:key, :loader) do
+        N1LoaderReflection = Struct.new(:name, :loader) do
           def options
             {}
           end
@@ -12,7 +12,7 @@ module N1Loader
 
         def preloaders_for_one(association, records, scope)
           grouped_records(association, records).flat_map do |reflection, klasses|
-            next N1Loader::Preloader.new(records).preload(reflection.key) if reflection.is_a?(N1LoaderReflection)
+            next N1Loader::Preloader.new(records).preload(reflection.name) if reflection.is_a?(N1LoaderReflection)
 
             klasses.map do |rhs_klass, rs|
               loader = preloader_for(reflection, rs).new(rhs_klass, rs, reflection, scope)

data/lib/n1_loader/active_record/associations_preloader_v6.rb

@@ -4,7 +4,7 @@ module N1Loader
   module ActiveRecord
     module Associations
       module Preloader # :nodoc:
-        N1LoaderReflection = Struct.new(:key, :loader) do
+        N1LoaderReflection = Struct.new(:name, :loader) do
           def options
             {}
           end
@@ -13,7 +13,7 @@ module N1Loader
         def preloaders_for_reflection(reflection, records, scope)
           return super unless reflection.is_a?(N1LoaderReflection)
 
-          N1Loader::Preloader.new(records).preload(reflection.key)
+          N1Loader::Preloader.new(records).preload(reflection.name)
         end
 
         def grouped_records(association, records, polymorphic_parent)

data/lib/n1_loader/active_record/associations_preloader_v7.rb

@@ -4,7 +4,7 @@ module N1Loader
   module ActiveRecord
     module Associations
       module Preloader # :nodoc:
-        N1LoaderReflection = Struct.new(:key, :loader) do
+        N1LoaderReflection = Struct.new(:name, :loader) do
           def options
             {}
           end
@@ -13,7 +13,7 @@ module N1Loader
         def preloaders_for_reflection(reflection, records)
           return super unless reflection.is_a?(N1LoaderReflection)
 
-          N1Loader::Preloader.new(records).preload(reflection.key)
+          N1Loader::Preloader.new(records).preload(reflection.name)
         end
 
         def grouped_records # rubocop:disable Metrics/PerceivedComplexity, Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/AbcSize

data/lib/n1_loader/core/loader.rb

@@ -106,7 +106,7 @@ module N1Loader
 
       check_arguments!
 
-      @loaded = {}.compare_by_identity
+      @loaded = {}
 
       if respond_to?(:single) && elements.size == 1
         fulfill(elements.first, single(elements.first))

data/lib/n1_loader/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module N1Loader
-  VERSION = "1.6.6"
+  VERSION = "1.7.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: n1_loader
 version: !ruby/object:Gem::Version
-  version: 1.6.6
+  version: 1.7.1
 platform: ruby
 authors:
 - Evgeniy Demin