mysql_genius 0.3.2 → 0.4.0

data/docs/superpowers/specs/2026-04-08-dashboard-first-redesign.md

@@ -1,87 +0,0 @@
-# Dashboard-First Redesign
-
-Redesign the default landing experience to lead with PgHero-style monitoring instead of the SQL query builder. Based on Reddit feedback that the current Visual Builder default makes the engine look like "another DB GUI" rather than a MySQL performance dashboard.
-
-## Changes
-
-### 1. New Dashboard Tab (default)
-
-A new tab that becomes the active tab on page load. Loads all data immediately via parallel AJAX calls to existing endpoints. Four stacked sections:
-
-**Server Summary** (reuses `server_overview` endpoint)
-- Four cards in a responsive grid: Server (version, uptime), Connections (used/max progress bar), InnoDB Buffer Pool (hit rate progress bar), Query Activity (questions/sec, slow queries count)
-
-**Top 5 Slow Queries** (reuses `slow_queries` endpoint)
-- Compact table: duration, timestamp, truncated SQL
-- "View all" link switches to Slow Queries tab
-- If Redis not configured: muted placeholder "Configure `redis_url` to monitor slow queries."
-
-**Top 5 Expensive Queries** (reuses `query_stats` endpoint with new `limit` param)
-- Compact table: query digest, calls, total time, avg time
-- Sorted by total time descending
-- "View all" link switches to Query Stats tab
-- If `performance_schema` unavailable: muted placeholder
-
-**Index Alerts** (reuses `duplicate_indexes` and `unused_indexes` endpoints)
-- Two badge cards showing counts: "X duplicate indexes", "X unused indexes"
-- Green checkmark if count is zero
-- Each badge is clickable, switches to the corresponding tab
-
-### 2. Query Explorer Tab (merged Visual Builder + SQL Query)
-
-The two existing query tabs merge into one "Query Explorer" tab with a mode toggle:
-
-- **Visual mode** -- existing visual builder UI (table selector, columns, filters, ordering)
-- **SQL mode** -- existing raw SQL textarea with AI suggestion panel
-- Small toggle buttons at top of tab to switch modes
-- Default mode: Visual
-- SQL generated by visual builder carries over when switching to SQL mode (existing behavior preserved)
-- Shared results area unchanged
-
-### 3. Tab Reorder
-
-New order:
-1. Dashboard (new, default active)
-2. Slow Queries
-3. Query Stats
-4. Server
-5. Table Sizes
-6. Unused Indexes
-7. Duplicate Indexes
-8. Query Explorer (merged)
-9. AI Tools (conditional on `@ai_enabled`)
-
-### 4. Backend Change
-
-Add `limit` parameter support to the `query_stats` action. When present, cap the result set to the given limit. The dashboard passes `limit=5`; the Query Stats tab continues to omit it for the full list.
-
-### 5. Gemspec Description Update
-
-Change description to lead with monitoring:
-> "MysqlGenius gives Rails apps a mountable performance dashboard for MySQL databases. Monitor slow queries, analyze query statistics from performance_schema, detect unused and duplicate indexes, and explore your database with optional AI-powered optimization."
-
-### 6. README Updates
-
-- Reorder screenshots section to lead with Dashboard
-- Update "Usage" section to reflect new tab order and dashboard-first experience
-- Add Dashboard screenshot placeholder
-
-## Not Changing
-
-- No new routes -- dashboard reuses existing endpoints
-- No new controller actions -- only a `limit` param added to `query_stats`
-- All existing tab partials remain intact, just reordered in the view
-- Shared results area unchanged
-- AI features unchanged
-- Authentication unchanged
-
-## Files Affected
-
-- `app/views/mysql_genius/queries/index.html.erb` -- tab bar reorder, new dashboard partial render, merge visual/sql tabs, JS changes for dashboard auto-load and query explorer toggle
-- `app/views/mysql_genius/queries/_tab_dashboard.html.erb` -- new partial
-- `app/views/mysql_genius/queries/_tab_query_explorer.html.erb` -- new partial combining visual builder and sql query content
-- `app/views/mysql_genius/queries/_tab_visual_builder.html.erb` -- removed (content moves to query explorer)
-- `app/views/mysql_genius/queries/_tab_sql_query.html.erb` -- removed (content moves to query explorer)
-- `app/controllers/concerns/mysql_genius/database_analysis.rb` -- add `limit` param to `query_stats`
-- `mysql_genius.gemspec` -- updated description
-- `README.md` -- updated screenshots order, usage section

data/lib/mysql_genius/sql_validator.rb

@@ -1,57 +0,0 @@
-# frozen_string_literal: true
-
-module MysqlGenius
-  module SqlValidator
-    FORBIDDEN_KEYWORDS = ["INSERT", "UPDATE", "DELETE", "DROP", "ALTER", "CREATE", "TRUNCATE", "GRANT", "REVOKE"].freeze
-
-    extend self
-
-    def validate(sql, blocked_tables:, connection:)
-      return "Please enter a query." if sql.nil? || sql.strip.empty?
-
-      normalized = sql.gsub(/--.*$/, "").gsub(%r{/\*.*?\*/}m, "").strip
-
-      unless normalized.match?(/\ASELECT\b/i) || normalized.match?(/\AWITH\b/i)
-        return "Only SELECT queries are allowed."
-      end
-
-      return "Access to system schemas is not allowed." if normalized.match?(/\b(information_schema|mysql|performance_schema|sys)\b/i)
-
-      FORBIDDEN_KEYWORDS.each do |keyword|
-        return "#{keyword} statements are not allowed." if normalized.match?(/\b#{keyword}\b/i)
-      end
-
-      tables_in_query = extract_table_references(normalized, connection)
-      blocked = tables_in_query & blocked_tables
-      if blocked.any?
-        return "Access denied for table(s): #{blocked.join(", ")}."
-      end
-
-      nil
-    end
-
-    def extract_table_references(sql, connection)
-      tables = []
-      sql.scan(/\bFROM\s+((?:`?\w+`?(?:\s*,\s*`?\w+`?)*)+)/i) { |m| m[0].scan(/`?(\w+)`?/) { |t| tables << t[0] } }
-      sql.scan(/\bJOIN\s+`?(\w+)`?/i) { |m| tables << m[0] }
-      sql.scan(/\b(?:INTO|UPDATE)\s+`?(\w+)`?/i) { |m| tables << m[0] }
-      tables.uniq.map(&:downcase) & connection.tables
-    end
-
-    def apply_row_limit(sql, limit)
-      if sql.match?(/\bLIMIT\s+\d+\s*,\s*\d+/i)
-        sql.gsub(/\bLIMIT\s+(\d+)\s*,\s*(\d+)/i) do
-          "LIMIT #{::Regexp.last_match(1).to_i}, #{[::Regexp.last_match(2).to_i, limit].min}"
-        end
-      elsif sql.match?(/\bLIMIT\s+\d+/i)
-        sql.gsub(/\bLIMIT\s+(\d+)/i) { "LIMIT #{[::Regexp.last_match(1).to_i, limit].min}" }
-      else
-        "#{sql.gsub(/;\s*\z/, "")} LIMIT #{limit}"
-      end
-    end
-
-    def masked_column?(column_name, patterns)
-      patterns.any? { |pattern| column_name.downcase.include?(pattern) }
-    end
-  end
-end