mysql_genius-core 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 01d397f796109a83914008b801549df18cec6c6b9363c7878f0aaa5b04b5a160
-  data.tar.gz: 4bdd6cfbee56cffd41feffcadc287ae104b5d5f71fbb2d59a4e85dbcb0da567e
+  metadata.gz: 3ff33401fa2eda90123c44ab9e7dc63f685d44a65df87cef083052f05abe2f93
+  data.tar.gz: 995386078c2ec80cbf95e3002e9cf23b6a7b51fda4a6519496600de07cae1cb9
 SHA512:
-  metadata.gz: bc74723d3f13499a57b115d857732f3061787d1b442c509ba89b690e2614522b3a921a5c39f3b52e2e420a2f0513de1dc41acb7b34613445b85e30f9c30730e6
-  data.tar.gz: ec977e844a1fd46189560c332a6d46e5b9482c2e83f9f6acd2646ae5e4eedf631847b34360f8ded330832f2ae1f0aa92f01247b168e9d33b27f2db9ac6a87e6a
+  metadata.gz: b7421f6cdac811fbadff2c9faf72b46bd513e51a5b1156c0723a228b45ecb19e8b02a0dfc1d49758deb71515b7899affbc808003ba3a224161f2f80d2a69486d
+  data.tar.gz: 5f413a66dfda47ea3bab363ccf49d10e65a1dbf0b1f4a76fa4c0df3544c04aae8282afcf629591b6cb6acbfbe7f5c48f33c444cc43bd420da5295bb994285efa

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.7.0
+
+### Added
+- `MysqlGenius::Core::Analysis::StatsHistory` — thread-safe in-memory ring buffer storing per-digest query performance snapshots. Supports `record`, `series_for`, `digests`, `clear`. Max 1440 samples per digest (24 hours at 60-second intervals).
+- `MysqlGenius::Core::Analysis::StatsCollector` — background thread that samples `performance_schema.events_statements_summary_by_digest` at a configurable interval, computes per-interval deltas, and records them into a `StatsHistory` instance. Handles server restarts (negative deltas clamped to 0) and performance_schema unavailability (stops gracefully).
+- `MysqlGenius::Core::Analysis::QueryStats` now includes `digest:` (the `DIGEST` hex hash from performance_schema) in its return value for stable URL keys.
+- `capability?(name)` template helper contract — shared templates gate Redis-backed UI via `<% if capability?(:slow_queries) %>` guards. Rails adapter returns `true` for all names; the desktop sidecar returns `true` only for `:ai`.
+- Query detail shared template (`query_detail.html.erb`) with SQL display, Explain button, stats cards, and inline SVG time-series charts.
+- Query Stats dashboard tab now renders SQL cells as clickable links to `/queries/:digest`.
+
 ## 0.6.0
 
 No functional changes in `mysql_genius-core`. Version bumped to maintain lockstep with `mysql_genius 0.6.0`, which drops Rails 5.2 support from the Rails adapter. See the root `CHANGELOG.md` for the full change list.

data/lib/mysql_genius/core/analysis/query_stats.rb

@@ -42,6 +42,7 @@ module MysqlGenius
         def build_sql(order_clause, limit)
           <<~SQL
             SELECT
+              DIGEST,
               DIGEST_TEXT,
               COUNT_STAR AS calls,
               ROUND(SUM_TIMER_WAIT / 1000000000, 1) AS total_time_ms,
@@ -77,6 +78,7 @@ module MysqlGenius
           rows_sent = (row["rows_sent"] || row["ROWS_SENT"] || 0).to_i
 
           {
+            digest: (row["DIGEST"] || row["digest"] || "").to_s,
             sql: truncate(digest, 500),
             calls: calls,
             total_time_ms: (row["total_time_ms"] || 0).to_f,

data/lib/mysql_genius/core/analysis/stats_collector.rb

@@ -0,0 +1,137 @@
+# frozen_string_literal: true
+
+module MysqlGenius
+  module Core
+    module Analysis
+      # Background sampler that periodically queries performance_schema for the
+      # top 50 digests by SUM_TIMER_WAIT, computes per-interval deltas, and
+      # records snapshots into a StatsHistory ring buffer.
+      #
+      # The +connection_provider+ is a callable (lambda/proc) that returns a
+      # Core::Connection on each invocation. This allows each adapter to supply
+      # its own connection strategy:
+      #
+      #   Rails:   -> { ActiveRecordAdapter.new(ActiveRecord::Base.connection) }
+      #   Desktop: -> { session.checkout { |c| c } }
+      class StatsCollector
+        DEFAULT_INTERVAL = 60
+        STOP_JOIN_TIMEOUT = 5
+        TOP_N = 50
+
+        def initialize(connection_provider:, history:, interval: DEFAULT_INTERVAL)
+          @connection_provider = connection_provider
+          @history = history
+          @interval = interval
+          @mutex = Mutex.new
+          @cv = ConditionVariable.new
+          @stop_signal = false
+          @running = false
+          @thread = nil
+          @previous = {}
+        end
+
+        def start
+          return self if @running
+
+          @stop_signal = false
+          @running = true
+          @thread = Thread.new { run_loop }
+          self
+        end
+
+        def stop
+          @mutex.synchronize do
+            @stop_signal = true
+            @cv.signal
+          end
+          @thread&.join(STOP_JOIN_TIMEOUT)
+          @thread = nil
+        end
+
+        def running?
+          @running
+        end
+
+        private
+
+        def run_loop
+          loop do
+            tick
+            break if wait_or_stop(@interval)
+          end
+        rescue StandardError => e
+          warn("[MysqlGenius] StatsCollector stopped: #{e.message}")
+        ensure
+          @running = false
+        end
+
+        def tick
+          connection = @connection_provider.call
+          result = connection.exec_query(build_sql(connection))
+          current = {}
+
+          result.to_hashes.each do |row|
+            digest_text = (row["DIGEST_TEXT"] || row["digest_text"]).to_s
+            next if digest_text.empty?
+
+            calls = (row["COUNT_STAR"] || row["count_star"]).to_i
+            total_time_ms = (row["total_time_ms"] || row["TOTAL_TIME_MS"] || 0).to_f
+
+            current[digest_text] = { calls: calls, total_time_ms: total_time_ms }
+
+            next unless @previous.key?(digest_text)
+
+            record_delta(digest_text, calls, total_time_ms)
+          end
+
+          @previous = current
+        end
+
+        def record_delta(digest_text, calls, total_time_ms)
+          prev = @previous[digest_text]
+          delta_calls = [calls - prev[:calls], 0].max
+          delta_total_ms = [(total_time_ms - prev[:total_time_ms]).round(1), 0.0].max
+
+          @history.record(digest_text, {
+            timestamp: Time.now.utc.strftime("%Y-%m-%dT%H:%M:%SZ"),
+            calls: delta_calls,
+            total_time_ms: delta_total_ms,
+            avg_time_ms: delta_calls.positive? ? (delta_total_ms / delta_calls).round(1) : 0.0,
+          })
+        end
+
+        def build_sql(connection)
+          <<~SQL
+            SELECT
+              DIGEST_TEXT,
+              COUNT_STAR,
+              ROUND(SUM_TIMER_WAIT / 1000000000, 1) AS total_time_ms
+            FROM performance_schema.events_statements_summary_by_digest
+            WHERE SCHEMA_NAME = #{connection.quote(connection.current_database)}
+              AND DIGEST_TEXT IS NOT NULL
+              AND DIGEST_TEXT NOT LIKE 'EXPLAIN%'
+              AND DIGEST_TEXT NOT LIKE '%`information_schema`%'
+              AND DIGEST_TEXT NOT LIKE '%`performance_schema`%'
+              AND DIGEST_TEXT NOT LIKE '%information_schema.%'
+              AND DIGEST_TEXT NOT LIKE '%performance_schema.%'
+              AND DIGEST_TEXT NOT LIKE 'SHOW %'
+              AND DIGEST_TEXT NOT LIKE 'SET STATEMENT %'
+              AND DIGEST_TEXT NOT LIKE 'SELECT VERSION ( )%'
+              AND DIGEST_TEXT NOT LIKE 'SELECT @@%'
+            ORDER BY SUM_TIMER_WAIT DESC
+            LIMIT #{TOP_N}
+          SQL
+        end
+
+        def wait_or_stop(seconds)
+          @mutex.synchronize do
+            return true if @stop_signal
+
+            @cv.wait(@mutex, seconds)
+            @stop_signal
+          end
+        end
+      end
+    end
+  end
+end

data/lib/mysql_genius/core/analysis/stats_history.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+module MysqlGenius
+  module Core
+    module Analysis
+      # Thread-safe in-memory ring buffer that stores per-digest query stats
+      # snapshots. Each digest key maps to an array of snapshots capped at
+      # +max_samples+. Oldest entries are dropped when the cap is reached.
+      class StatsHistory
+        DEFAULT_MAX_SAMPLES = 1440
+
+        def initialize(max_samples: DEFAULT_MAX_SAMPLES)
+          @max_samples = max_samples
+          @mutex = Mutex.new
+          @data = {}
+        end
+
+        def record(digest_text, snapshot)
+          @mutex.synchronize do
+            buf = (@data[digest_text] ||= [])
+            buf << snapshot
+            buf.shift if buf.length > @max_samples
+          end
+        end
+
+        def series_for(digest_text)
+          @mutex.synchronize do
+            (@data[digest_text] || []).dup
+          end
+        end
+
+        def digests
+          @mutex.synchronize { @data.keys.dup }
+        end
+
+        def clear
+          @mutex.synchronize { @data.clear }
+        end
+      end
+    end
+  end
+end

data/lib/mysql_genius/core/version.rb

@@ -2,6 +2,6 @@
 
 module MysqlGenius
   module Core
-    VERSION = "0.6.0"
+    VERSION = "0.7.0"
   end
 end

data/lib/mysql_genius/core.rb

@@ -47,6 +47,8 @@ require "mysql_genius/core/analysis/query_stats"
 require "mysql_genius/core/analysis/unused_indexes"
 require "mysql_genius/core/analysis/server_overview"
 require "mysql_genius/core/analysis/columns"
+require "mysql_genius/core/analysis/stats_history"
+require "mysql_genius/core/analysis/stats_collector"
 require "mysql_genius/core/execution_result"
 require "mysql_genius/core/query_runner/config"
 require "mysql_genius/core/query_runner"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mysql_genius-core
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Antarr Byrd
@@ -36,6 +36,8 @@ files:
 - lib/mysql_genius/core/analysis/duplicate_indexes.rb
 - lib/mysql_genius/core/analysis/query_stats.rb
 - lib/mysql_genius/core/analysis/server_overview.rb
+- lib/mysql_genius/core/analysis/stats_collector.rb
+- lib/mysql_genius/core/analysis/stats_history.rb
 - lib/mysql_genius/core/analysis/table_sizes.rb
 - lib/mysql_genius/core/analysis/unused_indexes.rb
 - lib/mysql_genius/core/column_definition.rb