mysql2 0.3.8 → 0.4.10

data/spec/mysql2/error_spec.rb

@@ -1,68 +1,81 @@
 # encoding: UTF-8
+
 require 'spec_helper'
 
-describe Mysql2::Error do
-  before(:each) do
-    @client = Mysql2::Client.new :encoding => "utf8"
+RSpec.describe Mysql2::Error do
+  let(:error) do
     begin
       @client.query("HAHAHA")
     rescue Mysql2::Error => e
-      @error = e
-    end
-
-    @client2 = Mysql2::Client.new :encoding => "big5"
-    begin
-      @client2.query("HAHAHA")
-    rescue Mysql2::Error => e
-      @error2 = e
+      error = e
     end
-  end
 
-  it "should respond to #error_number" do
-    @error.should respond_to(:error_number)
+    error
   end
 
-  it "should respond to #sql_state" do
-    @error.should respond_to(:sql_state)
-  end
+  it "responds to error_number and sql_state, with aliases" do
+    expect(error).to respond_to(:error_number)
+    expect(error).to respond_to(:sql_state)
 
-  # Mysql gem compatibility
-  it "should alias #error_number to #errno" do
-    @error.should respond_to(:errno)
+    # Mysql gem compatibility
+    expect(error).to respond_to(:errno)
+    expect(error).to respond_to(:error)
   end
 
-  it "should alias #message to #error" do
-    @error.should respond_to(:error)
-  end
+  context 'encoding' do
+    let(:valid_utf8) { '造字' }
+    let(:error) do
+      begin
+        @client.query(valid_utf8)
+      rescue Mysql2::Error => e
+        e
+      end
+    end
 
-  if RUBY_VERSION =~ /1.9/
-    it "#message encoding should match the connection's encoding, or Encoding.default_internal if set" do
-      if Encoding.default_internal.nil?
-        @error.message.encoding.should eql(@client.encoding)
-        @error2.message.encoding.should eql(@client2.encoding)
-      else
-        @error.message.encoding.should eql(Encoding.default_internal)
-        @error2.message.encoding.should eql(Encoding.default_internal)
+    let(:invalid_utf8) { ["e5c67d1f"].pack('H*').force_encoding(Encoding::UTF_8) }
+    let(:bad_err) do
+      begin
+        @client.query(invalid_utf8)
+      rescue Mysql2::Error => e
+        e
       end
     end
 
-    it "#error encoding should match the connection's encoding, or Encoding.default_internal if set" do
-      if Encoding.default_internal.nil?
-        @error.error.encoding.should eql(@client.encoding)
-        @error2.error.encoding.should eql(@client2.encoding)
-      else
-        @error.error.encoding.should eql(Encoding.default_internal)
-        @error2.error.encoding.should eql(Encoding.default_internal)
+    before do
+      pending('String#encoding is not defined') unless String.public_method_defined?(:encoding)
+
+      # sanity check
+      expect(valid_utf8.encoding).to eql(Encoding::UTF_8)
+      expect(valid_utf8).to be_valid_encoding
+
+      expect(invalid_utf8.encoding).to eql(Encoding::UTF_8)
+      expect(invalid_utf8).to_not be_valid_encoding
+    end
+
+    it "returns error messages as UTF-8 by default" do
+      with_internal_encoding nil do
+        expect(error.message.encoding).to eql(Encoding::UTF_8)
+        expect(error.message).to be_valid_encoding
+
+        expect(bad_err.message.encoding).to eql(Encoding::UTF_8)
+        expect(bad_err.message).to be_valid_encoding
+
+        expect(bad_err.message).to include("??}\u001F")
       end
     end
 
-    it "#sql_state encoding should match the connection's encoding, or Encoding.default_internal if set" do
-      if Encoding.default_internal.nil?
-        @error.sql_state.encoding.should eql(@client.encoding)
-        @error2.sql_state.encoding.should eql(@client2.encoding)
-      else
-        @error.sql_state.encoding.should eql(Encoding.default_internal)
-        @error2.sql_state.encoding.should eql(Encoding.default_internal)
+    it "returns sql state as ASCII" do
+      expect(error.sql_state.encoding).to eql(Encoding::US_ASCII)
+      expect(error.sql_state).to be_valid_encoding
+    end
+
+    it "returns error messages and sql state in Encoding.default_internal if set" do
+      with_internal_encoding Encoding::UTF_16LE do
+        expect(error.message.encoding).to eql(Encoding.default_internal)
+        expect(error.message).to be_valid_encoding
+
+        expect(bad_err.message.encoding).to eql(Encoding.default_internal)
+        expect(bad_err.message).to be_valid_encoding
       end
     end
   end