mysigner 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 790229a2d6e74282e878e2e11915fff8bd6a92ddf2c6185b479cdfa0530acfe3
-  data.tar.gz: f46b5ddba8fa60fb7af5bc5adaee409e487d8301edc65d7085f32532821384ad
+  metadata.gz: 81a959dbc7121c7d7a05af1428691e2e569924c5aa5312a586b11ea0d828997a
+  data.tar.gz: d888bb57fc3f8f61abe40dca59be684b9b5eaac913229b783750888de1ef1eb9
 SHA512:
-  metadata.gz: cd9c61b8ebb297f5f41f3b8e05d1a45a5d7250192767bb61993b4f58dcc1fb26516caf6bbe1b7191c5ead52a69c8602f10d4b722402558c20a95ab72512f262b
-  data.tar.gz: 81f5fb58194248d0a7aaba6db9e80b8685f838902f298418a882fe9639c11d751be29c32bd6406211da62e28ede6b60663e04f8f8ff27691d2b9a14a455f5c44
+  metadata.gz: d8765bed9b010e211949014c301bab4bbd05f28da40874ec7d018b2be4c457a9eedd5bea7b00d750e346ee04ef3290cb5416826ebedd3f5615f2dd4fd919fc25
+  data.tar.gz: e1e0ea6c6a1809dc3287a4972a685d07ce91bb64cacd8f2605d2300926e68b1646e03e9ae74e97ac7b37d7b91767164cf0520e05cee0039a3f010da112513b26

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mysigner (0.1.6)
+    mysigner (0.1.7)
       base64 (~> 0.2)
       faraday (~> 2.14)
       faraday-retry (~> 2.2)

data/lib/mysigner/cli/build_commands.rb

@@ -928,7 +928,7 @@ module Mysigner
                 # if the user left it implicit (which `ship android` currently
                 # doesn't allow — track is required — but kept here for
                 # symmetry with submit_android and future-proofing).
-                effective_track = track.presence || android_defaults&.dig('default_track') || 'internal'
+                effective_track = (track && !track.empty? ? track : nil) || android_defaults&.dig('default_track') || 'internal'
 
                 status = android_defaults&.dig('default_status')
                 user_fraction = android_defaults&.dig('default_user_fraction')
@@ -1558,8 +1558,8 @@ module Mysigner
 
               bundle_id = options[:bundle_id] || parser.bundle_id(target_name, options[:configuration])
 
-              # Validate bundle ID format if overridden
-              if options[:bundle_id]
+              # Validate bundle ID format if overridden (skip empty to let executor handle)
+              if options[:bundle_id] && !options[:bundle_id].empty?
                 if bundle_id =~ /\$\(|\$\{/
                   error "Bundle ID cannot contain variables: #{bundle_id}"
                   exit 1

data/lib/mysigner/upload/app_store_automation.rb

@@ -13,10 +13,9 @@ module Mysigner
       def initialize(client:, organization_id:, opts: {})
         @client = client
         @organization_id = organization_id
-        # Proper boolean coercion — `!x.nil?` evaluates to `true` for `false`,
-        # which previously caused `wait: false` / `no_submit: false` to be
-        # treated as `true`. Use `!!` to get the actual boolean semantics.
-        @wait_enabled = opts.key?(:wait) ? !opts[:wait].nil? : true
+        # Proper boolean coercion — must distinguish between `false` (an
+        # explicit user intent to disable) and an unset key (default applies).
+        @wait_enabled = opts.key?(:wait) ? to_bool(opts[:wait]) : true
 
         poll = opts[:poll_interval] || opts[:poll_seconds]
         poll = poll.to_i if poll
@@ -26,13 +25,13 @@ module Mysigner
         timeout = timeout.to_i if timeout
         @timeout = timeout&.positive? ? timeout : DEFAULT_WAIT_TIMEOUT
 
-        @no_submit = !opts[:no_submit].nil?
+        @no_submit = to_bool(opts[:no_submit])
 
         # Whether to submit by default when NEITHER cli_defaults nor CLI
         # overrides specify `auto_submit`. `ship`/`submit` pass true (it's
         # the user's explicit intent). Dashboard `cli_defaults.auto_submit`
         # still wins if set — we only fall back to this when silent.
-        @default_submit = opts.key?(:default_submit) ? !opts[:default_submit].nil? : false
+        @default_submit = opts.key?(:default_submit) ? to_bool(opts[:default_submit]) : false
 
         @now = opts[:now]
       end
@@ -105,6 +104,10 @@ module Mysigner
 
       private
 
+      def to_bool(value)
+        value ? true : false
+      end
+
       def ensure_app(bundle_id)
         response = @client.get(
           "/api/v1/organizations/#{@organization_id}/apple_apps",

data/lib/mysigner/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Mysigner
-  VERSION = '0.1.6'
+  VERSION = '0.1.7'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mysigner
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Jurgen Leka