mysigner 0.1.1 → 0.1.3

data/lib/mysigner/export/exporter.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+
+require 'English'
 require 'fileutils'
 require 'tmpdir'
 
@@ -9,31 +12,27 @@ module Mysigner
       def initialize(archive_path, output_dir: nil)
         @archive_path = File.expand_path(archive_path)
         @output_dir = output_dir || File.dirname(@archive_path)
-        
+
         validate_archive!
       end
 
       def export!(method: :appstore, team_id: nil, signing_style: 'automatic')
         say_exporting(method)
-        
+
         # Generate export options plist
         options_plist = generate_export_options(method, team_id, signing_style)
-        
+
         begin
           # Run xcodebuild -exportArchive
           success = execute_export(options_plist)
-          
-          unless success
-            raise ExportError, "Export failed. Check output above for errors."
-          end
-          
+
+          raise ExportError, 'Export failed. Check output above for errors.' unless success
+
           # Find the generated .ipa file
           ipa_path = find_ipa_file
-          
-          unless ipa_path
-            raise ExportError, "Export reported success but .ipa file not found in: #{@output_dir}"
-          end
-          
+
+          raise ExportError, "Export reported success but .ipa file not found in: #{@output_dir}" unless ipa_path
+
           ipa_path
         ensure
           # Clean up temp plist
@@ -44,42 +43,40 @@ module Mysigner
       private
 
       def validate_archive!
-        unless File.exist?(@archive_path)
-          raise ExportError, "Archive not found: #{@archive_path}"
-        end
-        
-        unless File.directory?(@archive_path) && @archive_path.end_with?('.xcarchive')
-          raise ExportError, "Invalid archive: #{@archive_path} (must be a .xcarchive directory)"
-        end
+        raise ExportError, "Archive not found: #{@archive_path}" unless File.exist?(@archive_path)
+
+        return if File.directory?(@archive_path) && @archive_path.end_with?('.xcarchive')
+
+        raise ExportError, "Invalid archive: #{@archive_path} (must be a .xcarchive directory)"
       end
 
       def generate_export_options(method, team_id, signing_style)
         require 'plist'
-        
+
         options = {
           'method' => export_method_string(method),
           'uploadBitcode' => false,
           'uploadSymbols' => false,
           'compileBitcode' => false
         }
-        
+
         # Add team ID if provided
         options['teamID'] = team_id if team_id
-        
+
         # Signing style
         if signing_style.to_s.downcase == 'manual'
           options['signingStyle'] = 'manual'
-          # Note: For manual signing, we'd need to specify provisioningProfiles
+          # NOTE: For manual signing, we'd need to specify provisioningProfiles
           # But since the archive was already signed during build, we can often omit this
         else
           options['signingStyle'] = 'automatic'
           options['signingCertificate'] = 'Apple Distribution'
         end
-        
+
         # Create temp plist file
         plist_path = File.join(Dir.tmpdir, "exportOptions-#{Time.now.to_i}.plist")
         File.write(plist_path, options.to_plist)
-        
+
         plist_path
       end
 
@@ -100,7 +97,7 @@ module Mysigner
 
       def execute_export(options_plist)
         FileUtils.mkdir_p(@output_dir)
-        puts ""
+        puts ''
 
         cmd = [
           'xcodebuild',
@@ -112,39 +109,38 @@ module Mysigner
         ].join(' ')
 
         # Run command and capture output
-        IO.popen(cmd, err: [:child, :out]) do |io|
+        IO.popen(cmd, err: %i[child out]) do |io|
           io.each_line do |line|
             next if line.strip.empty?
-            
+
             # Show errors and warnings
             if line.include?('error:') || line.include?('warning:')
               puts line
             # Show progress markers
-            elsif line.include?('Exporting') || line.include?('Processing') || 
+            elsif line.include?('Exporting') || line.include?('Processing') ||
                   line.include?('Validating')
               print '.'
             end
           end
         end
 
-        puts "" # New line after dots
-        
-        $?.success?
+        puts '' # New line after dots
+
+        $CHILD_STATUS.success?
       end
 
       def find_ipa_file
         # Look for .ipa files in output directory
         ipa_files = Dir.glob(File.join(@output_dir, '*.ipa'))
-        
+
         # Return the most recently created one
         ipa_files.max_by { |f| File.mtime(f) }
       end
 
       def say_exporting(method)
         puts "📦 Exporting archive for #{method}..."
-        puts ""
+        puts ''
       end
     end
   end
 end
-

data/lib/mysigner/signing/certificate_checker.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'open3'
 require 'time'
 
@@ -42,23 +44,21 @@ module Mysigner
         cmd = 'security find-identity -v -p codesigning'
         stdout, stderr, status = Open3.capture3(cmd)
 
-        unless status.success?
-          raise CheckError, "Failed to query certificates: #{stderr}"
-        end
+        raise CheckError, "Failed to query certificates: #{stderr}" unless status.success?
 
         certificates = []
-        
+
         # Parse output: "  1) HASH \"Certificate Name\""
         stdout.each_line do |line|
           next unless line =~ /\d+\)\s+([A-F0-9]+)\s+"([^"]+)"/
-          
-          hash = $1
-          name = $2
-          
+
+          hash = ::Regexp.last_match(1)
+          name = ::Regexp.last_match(2)
+
           # Get certificate details
           details = get_certificate_details(name)
           next unless details
-          
+
           certificates << {
             hash: hash,
             name: name,
@@ -76,12 +76,10 @@ module Mysigner
       def get_certificate_details(name)
         # Get certificate in PEM format by name
         cmd = "security find-certificate -c \"#{name}\" -p"
-        stdout, stderr, status = Open3.capture3(cmd)
+        stdout, _, status = Open3.capture3(cmd)
 
         # If not found, return nil
-        if !status.success? || stdout.empty?
-          return nil
-        end
+        return nil if !status.success? || stdout.empty?
 
         # Save to temp file and use openssl to read expiry
         require 'tempfile'
@@ -92,12 +90,12 @@ module Mysigner
 
           # Get expiry date using openssl
           cmd = "openssl x509 -in #{temp.path} -noout -enddate"
-          out, err, stat = Open3.capture3(cmd)
+          out, _, stat = Open3.capture3(cmd)
 
           if stat.success? && out =~ /notAfter=(.+)/
-            expiry_str = $1.strip
+            expiry_str = ::Regexp.last_match(1).strip
             expires_at = Time.parse(expiry_str)
-            days_until_expiry = ((expires_at - Time.now) / 86400).to_i
+            days_until_expiry = ((expires_at - Time.now) / 86_400).to_i
 
             return {
               expires_at: expires_at,
@@ -113,11 +111,9 @@ module Mysigner
 
       def extract_team_id(name)
         # Team ID is usually in parentheses at the end
-        if name =~ /\(([A-Z0-9]{10})\)$/
-          $1
-        else
-          nil
-        end
+        return unless name =~ /\(([A-Z0-9]{10})\)$/
+
+        ::Regexp.last_match(1)
       end
 
       def determine_cert_type(name)
@@ -134,7 +130,7 @@ module Mysigner
       end
 
       def determine_status(days_until_expiry)
-        if days_until_expiry < 0
+        if days_until_expiry.negative?
           STATUS_EXPIRED
         elsif days_until_expiry < 30
           STATUS_EXPIRING_SOON
@@ -145,4 +141,3 @@ module Mysigner
     end
   end
 end
-

data/lib/mysigner/signing/keystore_manager.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+
+require 'English'
 require 'fileutils'
 require 'base64'
 
@@ -44,21 +47,19 @@ module Mysigner
         # Get keystore details
         keystores = list
         keystore = keystores.find { |k| k['id'].to_s == keystore_id.to_s }
-        
-        unless keystore
-          raise KeystoreNotFoundError, "Keystore with ID #{keystore_id} not found"
-        end
+
+        raise KeystoreNotFoundError, "Keystore with ID #{keystore_id} not found" unless keystore
 
         # Download the keystore file
         download_url = "/api/v1/organizations/#{@organization_id}/android_keystores/#{keystore_id}/download"
-        
+
         conn = build_download_connection
         response = conn.get(download_url)
-        
+
         unless response.success?
           error_msg = begin
             JSON.parse(response.body)['message']
-          rescue
+          rescue StandardError
             "HTTP #{response.status}"
           end
           raise DownloadError, "Failed to download keystore: #{error_msg}"
@@ -67,9 +68,9 @@ module Mysigner
         # Save to local file
         filename = "#{keystore['name'].gsub(/[^a-zA-Z0-9_.-]/, '_')}.jks"
         local_path = File.join(KEYSTORES_DIR, filename)
-        
+
         File.binwrite(local_path, response.body)
-        File.chmod(0600, local_path)  # Secure permissions
+        File.chmod(0o600, local_path) # Secure permissions
 
         {
           path: local_path,
@@ -83,10 +84,8 @@ module Mysigner
       def get_or_download(keystore_id)
         keystores = list
         keystore = keystores.find { |k| k['id'].to_s == keystore_id.to_s }
-        
-        unless keystore
-          raise KeystoreNotFoundError, "Keystore with ID #{keystore_id} not found"
-        end
+
+        raise KeystoreNotFoundError, "Keystore with ID #{keystore_id} not found" unless keystore
 
         # Check if already cached locally
         filename = "#{keystore['name'].gsub(/[^a-zA-Z0-9_.-]/, '_')}.jks"
@@ -109,10 +108,9 @@ module Mysigner
       end
 
       # Upload a keystore to API
-      def upload(name:, keystore_path:, keystore_password:, key_alias:, key_password: nil, android_app_id: nil, active: true)
-        unless File.exist?(keystore_path)
-          raise KeystoreError, "Keystore file not found: #{keystore_path}"
-        end
+      def upload(name:, keystore_path:, keystore_password:, key_alias:, key_password: nil, android_app_id: nil,
+                 active: true)
+        raise KeystoreError, "Keystore file not found: #{keystore_path}" unless File.exist?(keystore_path)
 
         # Read and encode keystore
         keystore_content = File.binread(keystore_path)
@@ -141,14 +139,18 @@ module Mysigner
       # Delete a keystore
       def delete(keystore_id)
         @client.delete("/api/v1/organizations/#{@organization_id}/android_keystores/#{keystore_id}")
-        
+
         # Also remove local cached file
-        keystores = list rescue []
+        keystores = begin
+          list
+        rescue StandardError
+          []
+        end
         keystore = keystores.find { |k| k['id'].to_s == keystore_id.to_s }
         if keystore
           filename = "#{keystore['name'].gsub(/[^a-zA-Z0-9_.-]/, '_')}.jks"
           local_path = File.join(KEYSTORES_DIR, filename)
-          File.delete(local_path) if File.exist?(local_path)
+          FileUtils.rm_f(local_path)
         end
 
         true
@@ -187,26 +189,18 @@ module Mysigner
         return nil unless system('which keytool > /dev/null 2>&1')
 
         output = `keytool -list -v -keystore #{shell_escape(keystore_path)} -storepass #{shell_escape(password)} 2>&1`
-        return nil unless $?.success?
+        return nil unless $CHILD_STATUS.success?
 
         # Parse output
         info = {}
-        
-        if output =~ /Alias name: (.+)/
-          info[:aliases] = output.scan(/Alias name: (.+)/).flatten
-        end
-        
-        if output =~ /Valid from: .+ until: (.+)/
-          info[:expires] = $1
-        end
-        
-        if output =~ /SHA256: (.+)/
-          info[:sha256] = $1.strip
-        end
-        
-        if output =~ /SHA1: (.+)/
-          info[:sha1] = $1.strip
-        end
+
+        info[:aliases] = output.scan(/Alias name: (.+)/).flatten if output =~ /Alias name: (.+)/
+
+        info[:expires] = ::Regexp.last_match(1) if output =~ /Valid from: .+ until: (.+)/
+
+        info[:sha256] = ::Regexp.last_match(1).strip if output =~ /SHA256: (.+)/
+
+        info[:sha1] = ::Regexp.last_match(1).strip if output =~ /SHA1: (.+)/
 
         info
       end
@@ -215,7 +209,7 @@ module Mysigner
 
       def ensure_keystores_dir
         FileUtils.mkdir_p(KEYSTORES_DIR)
-        File.chmod(0700, KEYSTORES_DIR)  # Secure permissions
+        File.chmod(0o700, KEYSTORES_DIR) # Secure permissions
       end
 
       def build_download_connection
@@ -232,7 +226,8 @@ module Mysigner
 
       def shell_escape(str)
         return "''" if str.nil? || str.empty?
-        "'" + str.gsub("'", "'\\''") + "'"
+
+        "'#{str.gsub("'", "'\\''")}'"
       end
     end
   end

data/lib/mysigner/signing/validator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Mysigner
   module Signing
     class Validator
@@ -19,20 +21,20 @@ module Mysigner
         team_id = @team_id_override || @parser.team_id(@target_name, @configuration)
         if team_id.nil? || team_id.empty?
           result[:errors] << "No development team set for target '#{@target_name}'"
-          result[:errors] << ""
-          result[:errors] << "Fix Option 1: Add team to My Signer"
-          result[:errors] << "  1. Open https://mysigner.dev"
-          result[:errors] << "  2. Go to Settings → App Store Connect"
-          result[:errors] << "  3. Add your Team ID"
-          result[:errors] << "  4. Run: mysigner build (team will auto-fetch)"
-          result[:errors] << ""
-          result[:errors] << "Fix Option 2: Pass team via CLI"
-          result[:errors] << "  mysigner build --team YOUR_TEAM_ID"
-          result[:errors] << ""
-          result[:errors] << "Fix Option 3: Set in Xcode"
-          result[:errors] << "  Open Xcode → Select target → Signing & Capabilities → Select a team"
-          result[:errors] << ""
-          result[:errors] << "Find your team ID at: https://developer.apple.com/account/#!/membership/"
+          result[:errors] << ''
+          result[:errors] << 'Fix Option 1: Add team to My Signer'
+          result[:errors] << '  1. Open https://mysigner.dev'
+          result[:errors] << '  2. Go to Settings → App Store Connect'
+          result[:errors] << '  3. Add your Team ID'
+          result[:errors] << '  4. Run: mysigner build (team will auto-fetch)'
+          result[:errors] << ''
+          result[:errors] << 'Fix Option 2: Pass team via CLI'
+          result[:errors] << '  mysigner build --team YOUR_TEAM_ID'
+          result[:errors] << ''
+          result[:errors] << 'Fix Option 3: Set in Xcode'
+          result[:errors] << '  Open Xcode → Select target → Signing & Capabilities → Select a team'
+          result[:errors] << ''
+          result[:errors] << 'Find your team ID at: https://developer.apple.com/account/#!/membership/'
           result[:valid] = false
         elsif @team_id_override && @parser.team_id(@target_name, @configuration).nil?
           result[:warnings] << "Using team from My Signer: #{@team_id_override}"
@@ -42,15 +44,13 @@ module Mysigner
 
         # Check 2: Code signing style
         signing_style = @parser.code_sign_style(@target_name, @configuration)
-        if signing_style.nil?
-          result[:warnings] << "Code signing style not explicitly set (will use Xcode default)"
-        end
+        result[:warnings] << 'Code signing style not explicitly set (will use Xcode default)' if signing_style.nil?
 
         # Check 3: Bundle ID
         bundle_id = @parser.bundle_id(@target_name, @configuration)
         if bundle_id.nil? || bundle_id.empty? || bundle_id.include?('$(')
           result[:errors] << "Bundle ID not set or contains variables: #{bundle_id}"
-          result[:errors] << "Fix: Open Xcode → Select target → General → Bundle Identifier"
+          result[:errors] << 'Fix: Open Xcode → Select target → General → Bundle Identifier'
           result[:valid] = false
         end
 
@@ -79,22 +79,22 @@ module Mysigner
         result = validate
 
         if result[:warnings].any?
-          puts ""
-          puts "⚠️  Warnings:"
+          puts ''
+          puts '⚠️  Warnings:'
           result[:warnings].each { |w| puts "  • #{w}" }
         end
 
         if result[:errors].any?
-          puts ""
-          puts "❌ Validation Failed:"
-          puts ""
+          puts ''
+          puts '❌ Validation Failed:'
+          puts ''
           result[:errors].each { |e| puts "  • #{e}" }
-          puts ""
-          raise ValidationError, "Pre-build validation failed. Fix the errors above and try again."
+          puts ''
+          raise ValidationError, 'Pre-build validation failed. Fix the errors above and try again.'
         end
 
-        puts "✓ Pre-build validation passed" if result[:warnings].empty?
-        puts "" if result[:warnings].any?
+        puts '✓ Pre-build validation passed' if result[:warnings].empty?
+        puts '' if result[:warnings].any?
       end
 
       private
@@ -104,19 +104,17 @@ module Mysigner
 
         # Check for valid iOS distribution certificates in keychain
         output = `security find-identity -v -p codesigning 2>&1`
-        
+
         if output.include?('0 valid identities found')
-          result[:errors] << "No code signing certificates found in keychain"
-          result[:errors] << "Fix: Install your distribution certificate (.p12 file)"
+          result[:errors] << 'No code signing certificates found in keychain'
+          result[:errors] << 'Fix: Install your distribution certificate (.p12 file)'
         else
           # Count valid certificates
           cert_count = output.scan(/\d+\)\s+[A-F0-9]+/).count
           result[:warnings] << "Found #{cert_count} code signing certificate(s) in keychain"
-          
+
           # Check for expired certificates
-          if output.include?('CSSMERR')
-            result[:warnings] << "Some certificates may be invalid or expired"
-          end
+          result[:warnings] << 'Some certificates may be invalid or expired' if output.include?('CSSMERR')
         end
 
         result
@@ -127,18 +125,18 @@ module Mysigner
 
         # Check provisioning profile directory
         profiles_dir = File.expand_path('~/Library/MobileDevice/Provisioning Profiles')
-        
+
         unless Dir.exist?(profiles_dir)
-          result[:warnings] << "No provisioning profiles directory found"
-          result[:warnings] << "Profiles will be downloaded automatically if using automatic signing"
+          result[:warnings] << 'No provisioning profiles directory found'
+          result[:warnings] << 'Profiles will be downloaded automatically if using automatic signing'
           return result
         end
 
         profiles = Dir.glob("#{profiles_dir}/*.mobileprovision")
-        
+
         if profiles.empty?
-          result[:warnings] << "No provisioning profiles found"
-          result[:warnings] << "Profiles will be downloaded automatically if using automatic signing"
+          result[:warnings] << 'No provisioning profiles found'
+          result[:warnings] << 'Profiles will be downloaded automatically if using automatic signing'
         else
           result[:warnings] << "Found #{profiles.count} provisioning profile(s) installed"
         end