myronmarston-factory_data_preloader 0.4.1 → 0.4.2

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :major: 0
 :minor: 4
-:patch: 1
+:patch: 2

data/lib/factory_data_preloader/factory_data.rb

@@ -3,6 +3,7 @@ require 'ostruct'
 module FactoryDataPreloader
   class PreloaderAlreadyDefinedError < StandardError; end
   class PreloadedRecordNotFound < StandardError; end
+  class DefinedPreloaderNotRunError < StandardError; end
 
   class FactoryData
     @@preloaded_cache = nil
@@ -80,6 +81,10 @@ module FactoryDataPreloader
       private
 
       def get_record(type, model_class, key)
+        if @@preloaded_cache[type].nil?
+          raise DefinedPreloaderNotRunError, "The :#{type} preloader has never been run.  Did you forget to add the 'preload_factory_data :#{type}' declaration to your test case?  You'll need this at the top of your test case class if you want to use the factory data defined by this preloader."
+        end
+
         @@single_test_cache[type] ||= {}
         @@single_test_cache[type][key] ||= begin
           record = model_class.find_by_id(@@preloaded_cache[type][key])

data/test/factory_data_test.rb

@@ -1,36 +1,36 @@
 require File.dirname(__FILE__) + '/test_helper'
 
-class FactoryDataTest < Test::Unit::TestCase  
+class FactoryDataTest < Test::Unit::TestCase
   def setup
     FactoryDataPreloader.reset!
   end
-  
+
   context 'Calling FactoryData.preload(:users)' do
     setup do
       FactoryData.preload(:users) do |data|
         data[:thom] = User.create(:first_name => 'Thom', :last_name => 'York')
       end
     end
-    
+
     should_not_change 'User.count'
     should_change "FactoryData.methods.include?('users')", :from => false, :to => true
-    
+
     should 'not allow it to be called again' do
       assert_raise FactoryDataPreloader::PreloaderAlreadyDefinedError do
         FactoryData.preload(:users)
       end
     end
-    
+
     context 'when there was a previous user record in the database' do
       setup { User.create(:first_name => 'Barack', :last_name => 'Obama') }
-      
+
       context 'and calling FactoryData.delete_preload_data!' do
         setup { FactoryData.delete_preload_data! }
         should_change 'User.count', :to => 0
-        
+
         context 'and there is another record in the database' do
           setup { User.create(:first_name => 'George', :last_name => 'Bush') }
-          
+
           context 'and FactoryData.delete_preload_data! is called again' do
             setup { FactoryData.delete_preload_data! }
             should_not_change 'User.count'
@@ -38,36 +38,36 @@ class FactoryDataTest < Test::Unit::TestCase
         end
       end
     end
-    
+
     context 'and later calling FactoryData.preload_data!' do
       setup { FactoryData.preload_data! }
-      
+
       should_change 'User.count', :by => 1
-      
+
       context 'and later calling FactoryData.users(key)' do
         setup { @user = FactoryData.users(:thom) }
-        
+
         should 'retrieve the correct user' do
           assert_equal 'Thom', @user.first_name
           assert_equal 'York', @user.last_name
           assert !@user.new_record?
         end
-        
+
         should 'raise the appropriate error for a non-existant key' do
           assert_raise FactoryDataPreloader::PreloadedRecordNotFound do
             FactoryData.users(:not_a_user)
           end
         end
-        
+
         should 'cache the record so as not to use User.find more than necessary' do
           User.expects(:find).never
           user2 = FactoryData.users(:thom)
           assert_equal @user.object_id, user2.object_id
         end
-        
+
         context 'and later calling FactoryData.reset_cache!' do
           setup { FactoryData.reset_cache! }
-          
+
           should 'reload the record from the database the next time FactoryData.users(key) is called' do
             User.expects(:find).once.returns(@user)
             FactoryData.users(:thom)
@@ -76,42 +76,42 @@ class FactoryDataTest < Test::Unit::TestCase
       end
     end
   end
-  
+
   context 'Preloading a record that has not been saved' do
     setup do
       @unsaved_user = User.new(:first_name => 'George', :last_name => 'Washington')
       assert @unsaved_user.new_record?
-      
+
       FactoryData.preload(:users) do |data|
         data[:george] = @unsaved_user
       end
     end
-    
+
     should 'save the record wen preload_data! is called' do
       FactoryData.preload_data!
       assert !@unsaved_user.new_record?
     end
   end
-  
+
   context 'Preloading a record that cannot be saved to the database' do
     setup do
       @invalid_user = User.new(:first_name => 'Bob')
       assert !@invalid_user.valid?
-      
+
       FactoryData.preload(:users) do |data|
         data[:bob] = @invalid_user
       end
     end
-    
+
     should 'print an appropriate error message when preload_data! is called' do
       out, err = OutputCapturer.capture do
         FactoryData.preload_data!
       end
-      
+
       assert_match /Error preloading factory data\.\s+User :bob could not be saved\.\s+Errors:\s+last_name can't be blank/im, out
     end
   end
-  
+
   context 'Preloading with an explicit :model_class option' do
     setup do
       FactoryData.preload(:posts, :model_class => User) do |data|
@@ -119,36 +119,46 @@ class FactoryDataTest < Test::Unit::TestCase
       end
       FactoryData.preload_data!
     end
-    
+
     should 'use the passed model_class rather than inferring the class from the symbol' do
       assert_equal User, FactoryData.posts(:george).class
     end
   end
-  
+
   context 'Preloading multiple record types, with dependencies' do
     setup do
       FactoryData.preload(:comments, :depends_on => [:users, :posts]) do |data|
         data[:woohoo] = FactoryData.users(:john).comments.create(:post => FactoryData.posts(:tour), :comment => "I can't wait!")
       end
-      
+
       FactoryData.preload(:posts, :depends_on => :users) do |data|
         data[:tour] = FactoryData.users(:thom).posts.create(:title => 'Tour!', :body => 'Radiohead will tour soon.')
       end
-      
+
       FactoryData.preload(:users) do |data|
         data[:thom] = User.create(:first_name => 'Thom', :last_name => 'York')
         data[:john] = User.create(:first_name => 'John', :last_name => 'Doe')
       end
-      
+    end
+
+    should "raise the appropriate error when a developer tries to access a record that wasn't preloaded" do
+      FactoryDataPreloader.preload_all = false
+      FactoryDataPreloader.preload_types << :users
       FactoryData.preload_data!
+
+      assert FactoryData.users(:thom)
+      assert_raise FactoryDataPreloader::DefinedPreloaderNotRunError do
+        FactoryData.posts(:tour)
+      end
     end
-    
+
     should 'preload them in the proper order, allowing you to use the dependencies' do
+      FactoryData.preload_data!
       assert_equal 'Thom', FactoryData.users(:thom).first_name
       assert_equal 'John', FactoryData.users(:john).first_name
-      
+
       assert_equal FactoryData.users(:thom), FactoryData.posts(:tour).user
-      
+
       assert_equal FactoryData.users(:john), FactoryData.comments(:woohoo).user
       assert_equal FactoryData.posts(:tour), FactoryData.comments(:woohoo).post
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: myronmarston-factory_data_preloader
 version: !ruby/object:Gem::Version 
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors: 
 - Myron Marston