mynyml-rack-accept-media-types 0.5.1 → 0.6

data/Rakefile

@@ -22,7 +22,7 @@ end
 
 spec = Gem::Specification.new do |s|
   s.name            = 'rack-accept-media-types'
-  s.version         = '0.5.1'
+  s.version         = '0.6'
   s.summary         = "Rack convenience middleware for simplified handling of Accept header."
   s.description     = "Rack convenience middleware for simplified handling of Accept header."
   s.author          = "Martin Aumont"

data/examples.rb

@@ -36,3 +36,21 @@ example do
   types.prefered
   #=> "application/xml"
 end
+
+# no accept header means client accepts all types (rfc2616-sec14.1)
+env = {'HTTP_ACCEPT' => nil}
+example do
+  types = Rack::AcceptMediaTypes.new(env['HTTP_ACCEPT'])
+  #=> ["*/*"]
+  types.prefered
+  #=> "*/*"
+end
+
+# to avoid getting a wildcard media-range, pass an empty string instead
+env = {'HTTP_ACCEPT' => nil}
+example do
+  types = Rack::AcceptMediaTypes.new(env['HTTP_ACCEPT'] || '')
+  #=> []
+  types.prefered
+  #=> nil
+end

data/lib/rack/accept_media_types.rb

@@ -30,8 +30,19 @@ module Rack
   #
   class AcceptMediaTypes < Array
 
+    #--
+    # NOTE
+    # Reason for special handling of nil accept header:
+    #
+    # "If no Accept header field is present, then it is assumed that the client
+    # accepts all media types."
+    #
     def initialize(header)
-      replace(order(header.split(',')))
+      if header.nil?
+        replace(['*/*'])
+      else
+        replace(order(header.split(',')))
+      end
     end
 
     # The client's prefered media type.

data/rack-accept-media-types.gemspec

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rack-accept-media-types
 version: !ruby/object:Gem::Version 
-  version: 0.5.1
+  version: "0.6"
 platform: ruby
 authors: 
 - Martin Aumont
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-06-06 00:00:00 -04:00
+date: 2009-06-08 00:00:00 -04:00
 default_executable: 
 dependencies: []
 

data/test/test_accept_media_types.rb

@@ -53,6 +53,21 @@ class AcceptMediaTypesTest < Test::Unit::TestCase
     header = 'text/html;q=0.5;token=value,text/plain'
     assert_equal %w( text/plain text/html ), Accept.new(header)
   end
+
+  test "nil accept header" do
+    header = nil
+    assert_equal %w( */* ), Accept.new(header)
+  end
+
+  test "empty accept header" do
+    header = ''
+    assert_equal [], Accept.new(header)
+  end
+
+  test "all accepted types are invalid" do
+    header = 'text/html;q=2,application/xml;q=0'
+    assert_equal [], Accept.new(header)
+  end
 end
 
 __END__

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: mynyml-rack-accept-media-types
 version: !ruby/object:Gem::Version 
-  version: 0.5.1
+  version: "0.6"
 platform: ruby
 authors: 
 - Martin Aumont
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-06-05 21:00:00 -07:00
+date: 2009-06-07 21:00:00 -07:00
 default_executable: 
 dependencies: []