myinfo 0.1.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9c42852df0d1859a05e3b6626cc2abb19945cc2072d5cf2313bacc09ce15eb0b
-  data.tar.gz: 10b5b50b6882dad300511581299872d330df87b3d2df66734af3391406562ead
+  metadata.gz: f4f99857f69be28ab49c3407d0c1d048863fcd7a10716130dc94a0966ec1e27c
+  data.tar.gz: 849a140d5d9d89e8021734daaf77105cf06abc23a6b2f0ba01710e9e8459aa7a
 SHA512:
-  metadata.gz: dbee0afc819ced257f4392c0983c787e72347e9248cff74e3d1ff4885314005adc744fb4f14c04e5dff6e35da58aa80df7db74e440600636bc0b6cb727cfca80
-  data.tar.gz: be29694339f25994661aafa7d2c581ee94a0179d3b66c4db123ccc71a3fc8b51a925dd21a662c3fd9bc44f12d62fea052c736d7c3c1957ff9dab06bbae7cd952
+  metadata.gz: bc61a48e588d2316fbb3fcbb36e92cc2f3f2e81fd82ad7330445ad18d7f4fcb86aff4cc48f63dc5cd862261a277aabafff878354032167762152da9872085830
+  data.tar.gz: 2c223679d8acddebf56821af5423e7f795e791617d6daf47189087ec7be62b0bac6ee7d52d0f19b77dbed3a0ece2627b897e4aedffb428fe1d536ac8e8f3ab1f

data/README.md

@@ -15,7 +15,7 @@
     config.app_id = ''
     config.client_id = ''
     config.client_secret = ''
-    config.base_url = 'test.api.myinfo.gov.sg' # don't set https://
+    config.base_url = 'test.api.myinfo.gov.sg'
     config.redirect_uri = 'https://localhost:3001/callback'
     config.public_facing = true
     config.private_key = File.read(Rails.root.join('private_key_location'))
@@ -55,7 +55,7 @@ result = MyInfo::V3::Person.call(access_token: response.data) if response.succes
     config.app_id = ''
     config.client_id = ''
     config.client_secret = ''
-    config.base_url = 'test.api.myinfo.gov.sg' # don't set https://
+    config.base_url = 'test.api.myinfo.gov.sg'
     config.redirect_uri = 'https://localhost:3001/callback'
     config.singpass_eservice_id = 'MYINFO-CONSENTPLATFORM'
     config.private_key = File.read(Rails.root.join('private_key_location'))

data/lib/myinfo.rb

@@ -29,9 +29,10 @@ module MyInfo
 
   # Configuration to set various properties needed to use MyInfo
   class Configuration
-    attr_accessor :singpass_eservice_id, :app_id, :base_url, :client_id, :proxy,
-                  :private_key, :public_cert, :client_secret, :redirect_uri
+    attr_accessor :singpass_eservice_id, :app_id, :client_id, :proxy, :private_key, :public_cert, :client_secret,
+                  :redirect_uri
 
+    attr_reader :base_url
     attr_writer :public_facing, :sandbox
 
     def initialize
@@ -40,6 +41,10 @@ module MyInfo
       @proxy = { address: nil, port: nil }
     end
 
+    def base_url=(url)
+      @base_url = url.sub('https://', '').split('/').first
+    end
+
     def base_url_with_protocol
       "https://#{base_url}"
     end

data/lib/myinfo/v3/api.rb

@@ -17,6 +17,16 @@ module MyInfo
         raise NotImplementedError, 'abstract'
       end
 
+      def slug
+        ''
+      end
+
+      def call
+        yield
+      rescue StandardError => e
+        Response.new(success: false, data: e)
+      end
+
       def http_method
         'GET'
       end
@@ -50,6 +60,8 @@ module MyInfo
         else
           Response.new(success: false, data: "#{response.code} - #{response.body}")
         end
+      rescue StandardError => e
+        Response.new(success: false, data: e)
       end
 
       protected
@@ -63,7 +75,6 @@ module MyInfo
       end
 
       def decode_jws(jws)
-        # TODO: verify signature
         JWT.decode(jws, public_key, true, algorithm: 'RS256').first
       end
 

data/lib/myinfo/v3/person.rb

@@ -14,11 +14,13 @@ module MyInfo
       end
 
       def call
-        headers = header(params: params, access_token: access_token)
-        endpoint_url = "/#{slug}?#{params.to_query}"
+        super do
+          headers = header(params: params, access_token: access_token)
+          endpoint_url = "/#{slug}?#{params.to_query}"
 
-        response = http.request_get(endpoint_url, headers)
-        parse_response(response)
+          response = http.request_get(endpoint_url, headers)
+          parse_response(response)
+        end
       end
 
       def slug

data/lib/myinfo/v3/person_basic.rb

@@ -15,11 +15,13 @@ module MyInfo
       end
 
       def call
-        headers = header(params: params)
-        endpoint_url = "/#{slug}?#{params.to_query}"
+        super do
+          headers = header(params: params)
+          endpoint_url = "/#{slug}?#{params.to_query}"
 
-        response = http.request_get(endpoint_url, headers)
-        parse_response(response)
+          response = http.request_get(endpoint_url, headers)
+          parse_response(response)
+        end
       end
 
       def slug

data/lib/myinfo/v3/response.rb

@@ -4,11 +4,22 @@ module MyInfo
   module V3
     # Simple response wrapper
     class Response
-      attr_accessor :success, :data
+      attr_reader :data
 
       def initialize(success:, data:)
         @success = success
-        @data = data
+
+        if data.is_a?(StandardError)
+          @data = data.message
+          @exception = true
+        else
+          @data = data
+          @exception = false
+        end
+      end
+
+      def exception?
+        @exception
       end
 
       def success?

data/lib/myinfo/v3/token.rb

@@ -12,10 +12,12 @@ module MyInfo
       end
 
       def call
-        headers = header(params: params).merge({ 'Content-Type' => 'application/x-www-form-urlencoded' })
-        response = http.request_post("/#{slug}", params.to_param, headers)
+        super do
+          headers = header(params: params).merge({ 'Content-Type' => 'application/x-www-form-urlencoded' })
+          response = http.request_post("/#{slug}", params.to_param, headers)
 
-        parse_response(response)
+          parse_response(response)
+        end
       end
 
       def http_method

data/lib/myinfo/version.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+module MyInfo
+  module Version
+    WRAPPER_VERSION = '0.5.1'
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: myinfo
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Lim Yao Jie
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-01-27 00:00:00.000000000 Z
+date: 2020-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jwe
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: 6.1.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: 6.1.3
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -137,7 +137,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.11'
 description: Rails wrapper for MyInfo API
-email: limyaojie93@gmail.com
+email: lim_yao_jie@tech.gov.sg
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -153,7 +153,8 @@ files:
 - lib/myinfo/v3/person_basic.rb
 - lib/myinfo/v3/response.rb
 - lib/myinfo/v3/token.rb
-homepage: https://rubygems.org/gems/myinfo
+- lib/myinfo/version.rb
+homepage: https://github.com/GovTechSG/myinfo-rails
 licenses:
 - MIT
 metadata: {}
@@ -172,8 +173,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.1.2
 signing_key:
 specification_version: 4
-summary: MyInfo gem
+summary: Rails wrapper for MyInfo API
 test_files: []