myimdb 0.4.8 → 0.4.9

data/VERSION

@@ -1 +1 @@
-0.4.2
+0.4.9

data/lib/myimdb.rb

@@ -1,14 +1,20 @@
-require 'rubygems'
-require 'httparty'
-require 'nokogiri'
-require 'open-uri'
+require "rubygems"
+require "httparty"
+require "nokogiri"
+require "open-uri"
 
-require 'myimdb/search'
-require 'myimdb/scraper'
+require "#{File.dirname(__FILE__)}/myimdb/search"
+require "#{File.dirname(__FILE__)}/myimdb/scraper"
 
 class ImdbMovie
   def self.search(movie_name)
-    search_result = Myimdb::Search::Base.search(movie_name, :restrict_to=> 'imdb.com')[0]
+    search_result = Myimdb::Search::Base.search(movie_name, :restrict_to=> "imdb.com")[0]
     Myimdb::Scraper::Imdb.new(search_result[:url]) if search_result
   end
+end
+
+class String
+  def blank?
+    self.nil? || self.size == 0
+  end
 end

data/lib/myimdb/scraper.rb

@@ -1,6 +1,6 @@
-require 'myimdb/scraper/string_extensions'
-require 'myimdb/scraper/base'
-require 'myimdb/scraper/imdb'
-require 'myimdb/scraper/metacritic'
-require 'myimdb/scraper/rotten_tomatoes'
-require 'myimdb/scraper/freebase'
+require "#{File.dirname(__FILE__)}/scraper/string_extensions"
+require "#{File.dirname(__FILE__)}/scraper/base"
+require "#{File.dirname(__FILE__)}/scraper/imdb"
+require "#{File.dirname(__FILE__)}/scraper/metacritic"
+require "#{File.dirname(__FILE__)}/scraper/rotten_tomatoes"
+require "#{File.dirname(__FILE__)}/scraper/freebase"

data/lib/myimdb/scraper/imdb.rb

@@ -22,7 +22,7 @@ module Myimdb
       end
 
       def rating
-        document.css(".star-box .rating-rating").inner_text.strip.split('/').first.to_f
+        document.css(".star-box-details span[itemprop='ratingValue']").inner_text.strip.to_f
       end
 
       def votes

data/lib/myimdb/search.rb

@@ -1,4 +1,4 @@
-require 'httparty'
-require 'myimdb/search/base'
-require 'myimdb/search/google'
-require 'myimdb/search/bing'
+require "httparty"
+require "#{File.dirname(__FILE__)}/search/base"
+require "#{File.dirname(__FILE__)}/search/google"
+require "#{File.dirname(__FILE__)}/search/bing"

data/myimdb.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{myimdb}
-  s.version = "0.4.8"
+  s.version = "0.4.9"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Gaurav"]
@@ -36,8 +36,9 @@ Gem::Specification.new do |s|
      "lib/myimdb/search/bing.rb",
      "lib/myimdb/search/google.rb",
      "myimdb.gemspec",
-     "test/helper.rb",
-     "test/test_myimdb.rb"
+     "test/test_myimdb.rb",
+     "test/test_google.rb",
+     "test/test_bing.rb"
   ]
   s.homepage = %q{http://github.com/gauravs/myimdb}
   s.rdoc_options = ["--charset=UTF-8"]
@@ -46,8 +47,9 @@ Gem::Specification.new do |s|
   s.rubygems_version = %q{1.3.5}
   s.summary = %q{Utility gem for fetching movie details.}
   s.test_files = [
-    "test/helper.rb",
-     "test/test_myimdb.rb"
+    "test/test_myimdb.rb",
+    "test/test_google.rb",
+    "test/test_bing.rb"
   ]
 
   if s.respond_to? :specification_version then

data/test/test_bing.rb

@@ -0,0 +1,32 @@
+require "test/unit"
+require "#{File.dirname(__FILE__)}/../lib/myimdb"
+
+class TestBing < Test::Unit::TestCase
+
+  def setup
+    ## Nothing really
+  end
+
+  def teardown
+    ## Nothing really
+  end
+
+  def search(movie_name)
+    Myimdb::Search::Bing.search(movie_name, :restrict_to=> "imdb.com")
+  end
+
+  def test_search_movie
+    search_result = search("The Dark Knight")
+
+    assert_equal(search_result.first[:url], "http://www.imdb.com/title/tt0468569/")
+    assert_equal(search_result.first[:title], "The Dark Knight (2008) - IMDb")
+  end
+
+  def test_misspellings
+    search_result = search("The Dark Night")
+
+    assert_equal(search_result.first[:url], "http://www.imdb.com/title/tt0468569/")
+    assert_equal(search_result.first[:title], "The Dark Knight (2008) - IMDb")
+  end
+
+end

data/test/test_google.rb

@@ -0,0 +1,26 @@
+require "test/unit"
+require "#{File.dirname(__FILE__)}/../lib/myimdb"
+
+class TestGoogle < Test::Unit::TestCase
+
+  def setup
+    ## Nothing really
+  end
+
+  def teardown
+    ## Nothing really
+  end
+
+  def search(movie_name)
+    Myimdb::Search::Bing.search(movie_name, :restrict_to=> "imdb.com")
+  end
+
+
+  def test_search_movie
+    search_result = search("The Dark Knight")
+
+    assert_equal(search_result.first[:url], "http://www.imdb.com/title/tt0468569/")
+    assert_equal(search_result.first[:title], "The Dark Knight (2008) - IMDb")
+  end
+
+end

data/test/test_myimdb.rb

@@ -1,7 +1,59 @@
-require 'helper'
+require "test/unit"
+require "#{File.dirname(__FILE__)}/../lib/myimdb"
 
 class TestMyimdb < Test::Unit::TestCase
-  should "probably rename this file and start testing for real" do
-    flunk "hey buddy, you should probably rename this file and start testing for real"
+
+  def setup
+    @movie_name = 'the dark kinght'
+    @movie = ImdbMovie.search(@movie_name)
+  end
+
+  def teardown
+    ## Nothing really
+  end
+
+  def test_url
+    assert_equal(@movie.instance_variable_get('@url'), "http://www.imdb.com/title/tt0468569/")
+  end
+
+  def test_director
+    assert_equal(@movie.directors.first, "Christopher Nolan")
+  end
+
+  def test_writers
+    assert_equal(@movie.writers.first, "Jonathan Nolan")
+  end
+
+  def test_rating
+    assert_equal(@movie.rating, 8.9)
+  end
+
+  def test_votes
+    assert_operator(@movie.votes, :>, 725600)
   end
-end
+
+  def test_genres
+    assert_equal(@movie.genres.first, "Action")
+  end
+
+  def test_tagline
+    assert_match(/Why So Serious|I Believe In Harvey Dent/, @movie.tagline)
+  end
+
+  def test_plot
+    assert_match("Batman raises the stakes in his war on crime", @movie.plot, )
+  end
+
+  def test_year
+    assert_equal(@movie.year, 2008)
+  end
+
+  def test_release_date
+    assert_operator(@movie.release_date, :>, Date.parse('1-1-2008'))
+  end
+
+  def test_image
+    assert_match(/\.jpg$/, @movie.image)
+  end
+
+end

metadata

@@ -1,66 +1,48 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: myimdb
-version: !ruby/object:Gem::Version 
-  hash: 31
-  prerelease: false
-  segments: 
-  - 0
-  - 4
-  - 8
-  version: 0.4.8
+version: !ruby/object:Gem::Version
+  version: 0.4.9
+  prerelease: 
 platform: ruby
-authors: 
+authors:
 - Gaurav
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2010-12-16 00:00:00 -08:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2010-12-16 00:00:00.000000000Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: httparty
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &70363402315680 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 5
-        segments: 
-        - 0
-        - 4
-        - 5
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
         version: 0.4.5
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: nokogiri
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: *70363402315680
+- !ruby/object:Gem::Dependency
+  name: nokogiri
+  requirement: &70363402315160 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 29
-        segments: 
-        - 1
-        - 3
-        - 3
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
         version: 1.3.3
   type: :runtime
-  version_requirements: *id002
+  prerelease: false
+  version_requirements: *70363402315160
 description: 
 email: gaurav.qwe@gmail.com
-executables: 
+executables:
 - myimdb
 - myimdb-catalogue
 extensions: []
-
-extra_rdoc_files: 
+extra_rdoc_files:
 - LICENSE
 - README.rdoc
-files: 
+files:
 - LICENSE
 - README.rdoc
 - Rakefile
@@ -80,42 +62,35 @@ files:
 - lib/myimdb/search/bing.rb
 - lib/myimdb/search/google.rb
 - myimdb.gemspec
-- test/helper.rb
 - test/test_myimdb.rb
-has_rdoc: true
+- test/test_google.rb
+- test/test_bing.rb
 homepage: http://github.com/gauravs/myimdb
 licenses: []
-
 post_install_message: 
-rdoc_options: 
+rdoc_options:
 - --charset=UTF-8
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: myimdb
-rubygems_version: 1.3.7
+rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
 summary: Utility gem for fetching movie details.
-test_files: 
-- test/helper.rb
+test_files:
 - test/test_myimdb.rb
+- test/test_google.rb
+- test/test_bing.rb

data/test/helper.rb

@@ -1,10 +0,0 @@
-require 'rubygems'
-require 'test/unit'
-require 'shoulda'
-
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-require 'myimdb'
-
-class Test::Unit::TestCase
-end