myfinance 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d1eefa221205c3ed3d67d74d90c709f80dca6f4c
-  data.tar.gz: a4910d9b8d7af6d4c0f439a1f4a028557937b2cd
+  metadata.gz: fd16eafab7c1a94cdb638ad2e9efa9c942029289
+  data.tar.gz: b71308b1b0e4cd9629698d185cbd9ae7a70d242d
 SHA512:
-  metadata.gz: 38adecf14ed9cb00370f632ad44479be2f87b24147a91da63cc08e0c0843d9366c2dbaf9e0a0266adb726d957d1cb251faa37f632ee2b075ea57f46fc5fa0414
-  data.tar.gz: d55d18de0c4a758f2d2b5057e20f03483824fb3050251f423b31f97e5f688474133c84fb5af261469104f0ba80037de14d340bd6d88670e39afd0ce6905ce341
+  metadata.gz: c186bac4b437d5a1ace502f62985389aa0637cf9614886bc7805e5d6fc619f979e7c41e5810a63d2d113bb240b2ca3d2a88f4310aad64dd4a8b588ad882be856
+  data.tar.gz: 9eba0d8098e7be11dd9e2694d2f2e32a2c626987885437f41fdaad42b016d43bb4a4aa1a463f38fa3f856f471ac57d3106b163b35fede4d60d1a5261acfa140c

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## v1.2.0
+### Endpoints improvements
+- The `#find_all` method of all endpoints that support filtering can now receive parameters to refine the results and paginate
+### Deprecations
+- No longer supports `#find_by`. Use `#find_all` instead, passing filters as a hash if needed.
+### Fixes
+- Params encoding set to Rack
+
+## v1.1.0
+
+### New Endpoints
+- Add endpoint Deposit Accounts filtering
+- Add endpoint Entities filtering
+
 ## v1.0.0
 
 ### New Endpoints

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    myfinance (1.1.0)
+    myfinance (1.2.0)
       mime-types (~> 2.99)
       multi_json (~> 1.11)
       typhoeus (~> 0.8)

data/README.md

@@ -97,18 +97,6 @@ client = Myfinance.client("YOUR_TOKEN_HERE")
       <code>client.entities.find</code>
     </td>
   </tr>
-  <tr>
-    <td><code>GET</code></td>
-    <td>
-      <a href="https://app.myfinance.com.br/docs/api/entities#get_show" target="_blank">
-        /entities
-      </a>
-    </td>
-    <td>
-      <code>client.entities.find_by</code>
-    </td>
-  </tr>
-
 </table>
 
 #### [FinancialTransactions](https://app.myfinance.com.br/docs/api/financial_transactions)
@@ -515,17 +503,6 @@ client = Myfinance.client("YOUR_TOKEN_HERE")
       <code>client.deposit_accounts.find</code>
     </td>
   </tr>
-  <tr>
-    <td><code>GET</code></td>
-    <td>
-      <a href="https://app.myfinance.com.br/docs/api/deposit_accounts#get_show" target="_blank">
-        /entities/:entity_id/deposit_accounts
-      </a>
-    </td>
-    <td>
-      <code>client.deposit_accounts.find_by</code>
-    </td>
-  </tr>
   <tr>
     <td><code>POST</code></td>
     <td>
@@ -656,17 +633,6 @@ client = Myfinance.client("YOUR_TOKEN_HERE")
       <code>client.classification_centers.find</code>
     </td>
   </tr>
-  <tr>
-    <td><code>GET</code></td>
-    <td>
-      <a href="https://app.myfinance.com.br/docs/api/classification_centers#get_show" target="_blank">
-        /classification_centers
-      </a>
-    </td>
-    <td>
-      <code>client.classification_centers.find_by</code>
-    </td>
-  </tr>
   <tr>
     <td><code>POST</code></td>
     <td>
@@ -721,17 +687,6 @@ client = Myfinance.client("YOUR_TOKEN_HERE")
       <code>client.people.find_all</code>
     </td>
   </tr>
-  <tr>
-    <td><code>GET</code></td>
-    <td>
-      <a href="https://app.myfinance.com.br/docs/api/people" target="_blank">
-        /people
-      </a>
-    </td>
-    <td>
-      <code>client.people.find_by</code>
-    </td>
-  </tr>
   <tr>
     <td><code>GET</code></td>
     <td>

data/lib/myfinance/request.rb

@@ -24,7 +24,8 @@ module Myfinance
         params:           args[:params],
         body:             body,
         headers:          headers,
-        accept_encoding:  "gzip"
+        accept_encoding:  "gzip",
+        params_encoding: :rack
       }.reject { |_k,v| v.nil? }
     end
 

data/lib/myfinance/resources/base.rb

@@ -10,6 +10,18 @@ module Myfinance
 
       private
 
+      def build_search_endpoint(params)
+        query_string = query(params).join("&")
+        URI.encode("#{endpoint}?#{query_string}")
+      end
+
+      def query(params)
+        page = params.delete(:page)         
+        query = params.map { |key, value| "search[#{key}]=#{value}" }
+        query << "page=#{page}" if page
+        query
+      end
+
       def respond_with_collection(response)
         collection_klass = Myfinance::Entities.const_get("#{entity_klass_name}Collection")
         collection_klass.build(response)

data/lib/myfinance/resources/category.rb

@@ -15,8 +15,10 @@ module Myfinance
       #
       #   Documentation: https://sandbox.myfinance.com.br/docs/api/categories#get_index
       #
-      def find_all
-        http.get("/categories", body: {}) do |response|
+      def find_all(params = {})
+        search_endpoint = build_search_endpoint(params)
+
+        http.get(search_endpoint) do |response|
           respond_with_collection(response)
         end
       end
@@ -35,22 +37,6 @@ module Myfinance
         end
       end
 
-      #
-      # Find a category by attributes
-      #
-      # [API]
-      #   Method: <tt>GET /categories/:id</tt>
-      #
-      #   Documentation: https://sandbox.myfinance.com.br/docs/api/categories#get_show
-      #
-      def find_by(params = {})
-        path = params.map { |k, v| "search[#{k}]=#{v}" }.join("&")
-
-        http.get(URI.encode("/categories?#{path}"), body: {}) do |response|
-          respond_with_collection(response)
-        end
-      end
-
       #
       # Creates a category
       #
@@ -92,6 +78,12 @@ module Myfinance
           respond_with_object response, "category"
         end
       end
+
+      private
+
+      def endpoint
+        "/categories"
+      end
     end
   end
 end

data/lib/myfinance/resources/classification_center.rb

@@ -8,15 +8,17 @@ module Myfinance
     #
     class ClassificationCenter < Base
       #
-      # List all classification centers
+      # List all classification centers, supplying optional params for refinement
       #
       # [API]
       #   Method: <tt>GET /classification_centers</tt>
       #
       #   Documentation: https://app.myfinance.com.br/docs/api/classification_centers#get_index
       #
-      def find_all
-        http.get("/classification_centers", body: {}) do |response|
+      def find_all(params = {})
+        search_endpoint = build_search_endpoint(params)
+
+        http.get(search_endpoint) do |response|
           respond_with_collection(response)
         end
       end
@@ -34,24 +36,6 @@ module Myfinance
           respond_with_object response, "classification_center"
         end
       end
-
-      #
-      # Find classification centers by attributtes
-      #
-      # [API]
-      #   Method: <tt>GET /classification_centers</tt>
-      #
-      #   Documentation: https://app.myfinance.com.br/docs/api/classification_centers
-      #
-      def find_by(params)
-        values = params.map { |k,v| "search[#{k}]=#{v}" }.join("&")
-        http.get(
-          URI.encode("/classification_centers?#{values}"), body: {}
-        ) do |response|
-          respond_with_collection(response)
-        end
-      end
-
       #
       # Creates a classification center
       #
@@ -98,6 +82,12 @@ module Myfinance
           respond_with_object response, "classification_center"
         end
       end
+
+      private
+
+      def endpoint
+        "/classification_centers"
+      end
     end
   end
 end

data/lib/myfinance/resources/deposit_account.rb

@@ -8,15 +8,17 @@ module Myfinance
     #
     class DepositAccount < Base
       #
-      # List all deposit accounts of entity
+      # List all deposit accounts of entity with optional filters for refinement
       #
       # [API]
       #   Method: <tt>GET /entities/:entity_id/deposit_accounts</tt>
       #
       #   Documentation: https://app.myfinance.com.br/docs/api/deposit_accounts#get_index
       #
-      def find_all(entity_id)
-        http.get("/entities/#{entity_id}/deposit_accounts", body: {}) do |response|
+      def find_all(entity_id, params = {})
+        search_endpoint = build_search_endpoint(entity_id, params)
+
+        http.get(search_endpoint) do |response|
           respond_with_collection(response)
         end
       end
@@ -35,15 +37,6 @@ module Myfinance
         end
       end
 
-      def find_by(entity_id, params = {})
-        sanitized_params = search_params(params) 
-        endpoint = encode_endpoint(entity_id, sanitized_params)
-
-        http.get(endpoint, body: {}) do |response|
-          respond_with_collection(response)
-        end
-      end
-
       #
       # Creates a deposit account of entity
       #
@@ -88,12 +81,15 @@ module Myfinance
 
       private
 
-      def search_params(params)
-        params.map { |key, value| "search[#{key}]=#{value}" }.join("&")
+      def build_search_endpoint(entity_id, params)
+        query_string = query(params).join("&")
+        deposit_endpoint = endpoint(entity_id)
+
+        URI.encode("#{deposit_endpoint}?#{query_string}")
       end
 
-      def encode_endpoint(entity_id, path)
-        URI.encode("/entities/#{entity_id}/deposit_accounts?#{path}")
+      def endpoint(entity_id)
+        "/entities/#{entity_id}/deposit_accounts"
       end
     end
   end

data/lib/myfinance/resources/entity.rb

@@ -15,8 +15,10 @@ module Myfinance
       #
       #   Documentation: https://app.myfinance.com.br/docs/api/entities#get_index
       #
-      def find_all
-        http.get('/entities', body: {}) do |response|
+      def find_all(params = {})
+        search_endpoint = build_search_endpoint(params)
+
+        http.get(search_endpoint) do |response|
           respond_with_collection(response)
         end
       end
@@ -35,23 +37,10 @@ module Myfinance
         end
       end
 
-      def find_by(params = {})
-        sanitized_params = search_params(params)
-        endpoint = encode_endpoint(sanitized_params)
-
-        http.get(endpoint, body: {}) do |response|
-          respond_with_collection(response)
-        end
-      end
-
       private
 
-      def search_params(params)
-        params.map { |key, value| "search[#{key}]=#{value}" }.join("&")
-      end
-
-      def encode_endpoint(path)
-        URI.encode("/entities?#{path}")
+      def endpoint
+        "/entities"
       end
     end
   end

data/lib/myfinance/resources/person.rb

@@ -8,35 +8,22 @@ module Myfinance
     #
     class Person < Base
       #
-      # List all people
+      # List all people with optional filters for refinement
       #
       # [API]
       #   Method: <tt>GET /people</tt>
       #
       #   Documentation: https://app.myfinance.com.br/docs/api/people#get_index
       #
-      def find_all
-        http.get("/people", body: {}) do |response|
-          respond_with_collection(response)
-        end
-      end
-
-      #
-      # Find people by attributtes
-      #
-      # [API]
-      #   Method: <tt>GET /people</tt>
-      #
-      #   Documentation: https://app.myfinance.com.br/docs/api/people#get_index
-      #
-      def find_by(params)
-        values = params.map { |k,v| "search[#{k}]=#{v}" }.join("&")
+      def find_all(params = {})
+        search_endpoint = build_search_endpoint(params)
 
-        http.get(URI.encode("/people?#{values}"), body: {}) do |response|
+        http.get(search_endpoint) do |response|
           respond_with_collection(response)
         end
       end
 
+      
       #
       # Show a person
       #
@@ -92,6 +79,12 @@ module Myfinance
           respond_with_object response, "person"
         end
       end
+
+      private
+
+      def endpoint
+        "/people"
+      end
     end
   end
 end

data/lib/myfinance/version.rb

@@ -1,3 +1,3 @@
 module Myfinance
-  VERSION = "1.1.0"
+  VERSION = "1.2.0"
 end

data/spec/lib/myfinance/request_spec.rb

@@ -5,7 +5,7 @@ describe Myfinance::Request do
     subject { described_class.new({ method: 'post', params: {}, url: Myfinance.configuration.url, user_agent: 'My Test User-Agent', token: 'my-auth-hash' }) }
 
     it "does a request using Typhoeus::Request" do
-      expect(Typhoeus::Request).to receive(:new).with("https://sandbox.myfinance.com.br", { method: "post", params: {}, headers: { "Accept" => "application/json", "Content-Type" => "application/json", "User-Agent" => "My Test User-Agent", "Authorization" => "Basic bXktYXV0aC1oYXNoOlg=" }, accept_encoding: "gzip" }).and_return(double(run: true, response: true))
+      expect(Typhoeus::Request).to receive(:new).with("https://sandbox.myfinance.com.br", { method: "post", params: {}, headers: { "Accept" => "application/json", "Content-Type" => "application/json", "User-Agent" => "My Test User-Agent", "Authorization" => "Basic bXktYXV0aC1oYXNoOlg=" }, accept_encoding: "gzip", params_encoding: :rack }).and_return(double(run: true, response: true))
       subject.run
     end
 
@@ -30,7 +30,7 @@ describe Myfinance::Request do
       subject { described_class.new({ method: 'post', params: {}, url: Myfinance.configuration.url, user_agent: 'My Test User-Agent', token: 'my-auth-hash', account_id: "" }) }
 
       it "does not add ACCOUNT_ID on headers" do
-        expect(Typhoeus::Request).to receive(:new).with("https://sandbox.myfinance.com.br", { method: "post", params: {}, headers: { "Accept" => "application/json", "Content-Type" => "application/json", "User-Agent" => "My Test User-Agent", "Authorization" => "Basic bXktYXV0aC1oYXNoOlg=" }, accept_encoding: "gzip" }).and_return(double(run: true, response: true))
+        expect(Typhoeus::Request).to receive(:new).with("https://sandbox.myfinance.com.br", { method: "post", params: {}, headers: { "Accept" => "application/json", "Content-Type" => "application/json", "User-Agent" => "My Test User-Agent", "Authorization" => "Basic bXktYXV0aC1oYXNoOlg=" }, accept_encoding: "gzip", params_encoding: :rack }).and_return(double(run: true, response: true))
         subject.run
       end
     end
@@ -39,7 +39,7 @@ describe Myfinance::Request do
       subject { described_class.new({ method: 'post', params: {}, url: Myfinance.configuration.url, user_agent: 'My Test User-Agent', token: 'my-auth-hash', account_id: nil }) }
 
       it "does not add ACCOUNT_ID on headers" do
-        expect(Typhoeus::Request).to receive(:new).with("https://sandbox.myfinance.com.br", { method: "post", params: {}, headers: { "Accept" => "application/json", "Content-Type" => "application/json", "User-Agent" => "My Test User-Agent", "Authorization" => "Basic bXktYXV0aC1oYXNoOlg=" }, accept_encoding: "gzip" }).and_return(double(run: true, response: true))
+        expect(Typhoeus::Request).to receive(:new).with("https://sandbox.myfinance.com.br", { method: "post", params: {}, headers: { "Accept" => "application/json", "Content-Type" => "application/json", "User-Agent" => "My Test User-Agent", "Authorization" => "Basic bXktYXV0aC1oYXNoOlg=" }, accept_encoding: "gzip", params_encoding: :rack }).and_return(double(run: true, response: true))
         subject.run
       end
     end
@@ -48,7 +48,7 @@ describe Myfinance::Request do
       subject { described_class.new({ method: 'post', params: {}, url: Myfinance.configuration.url, user_agent: 'My Test User-Agent', token: 'my-auth-hash', account_id: 12 }) }
 
       it "does not add ACCOUNT_ID on headers" do
-        expect(Typhoeus::Request).to receive(:new).with("https://sandbox.myfinance.com.br", { method: "post", params: {}, headers: { "Accept" => "application/json", "Content-Type" => "application/json", "User-Agent" => "My Test User-Agent", "Authorization" => "Basic bXktYXV0aC1oYXNoOlg=", "ACCOUNT_ID" => 12 }, accept_encoding: "gzip" }).and_return(double(run: true, response: true))
+        expect(Typhoeus::Request).to receive(:new).with("https://sandbox.myfinance.com.br", { method: "post", params: {}, headers: { "Accept" => "application/json", "Content-Type" => "application/json", "User-Agent" => "My Test User-Agent", "Authorization" => "Basic bXktYXV0aC1oYXNoOlg=", "ACCOUNT_ID" => 12 }, accept_encoding: "gzip", params_encoding: :rack }).and_return(double(run: true, response: true))
         subject.run
       end
     end

data/spec/lib/myfinance/resources/category_spec.rb

@@ -10,83 +10,73 @@ describe Myfinance::Resources::Category, vcr: true do
       it "show all categories successfully" do
         expect(subject.class).to eq(Myfinance::Entities::CategoryCollection)
         expect(subject.collection.first.class).to eq(entity_klass)
-        expect(subject.collection.first.full_name).to eq("Alimentação")
+        expect(subject.collection.first.full_name).to eq("Moradia / Água e Esgoto")
       end
     end
 
-    context "when not found" do
-      let(:client) { Myfinance.client("") }
+    it "find categories by attributes" do
+      params = { name: "Alimentação" }
+      result = client.categories.find_all(params)
 
-      it "raises Myfinance::RequestError with 401 status code" do
-        expect {
-          client.categories.find_all
-        }.to raise_error(Myfinance::RequestError) do |error|
-          expect(error.code).to eql(401)
-        end
+      expect(result).to be_a(Myfinance::Entities::CategoryCollection)
+      expect(result.collection.first).to be_a(entity_klass)
+      expect(result.collection.first.name).to eql("Alimentação")
+    end
+  end
+
+  context "when error" do
+    let(:client) { Myfinance.client("") }
+
+    it "raises Myfinance::RequestError with 401 status code" do
+      expect { client.categories.find_all({}) }.to raise_error(Myfinance::RequestError) do |error|
+        expect(error.code).to eql(401)
+      end
+    end
+  end
+
+  context "when not found" do
+    let(:client) { Myfinance.client("") }
+
+    it "raises Myfinance::RequestError with 401 status code" do
+      expect { client.categories.find_all }.to raise_error(Myfinance::RequestError) do |error|
+        expect(error.code).to eql(401)
       end
     end
   end
 
   describe "#find" do
     context "with success" do
-      subject { client.categories.find(532314) }
+      subject { client.categories.find(532323) }
 
       it "returns a category successfully" do
         expect(subject.class).to eql(entity_klass)
-        expect(subject.id).to eql(532314)
+        expect(subject.id).to eql(532323)
       end
     end
 
     context "with error" do
       it "raises Myfinance::RequestError with 404 status code" do
-        expect {
-          client.categories.find(88888888)
-        }.to raise_error(Myfinance::RequestError) do |error|
+        expect { client.categories.find(88888888) }.to raise_error(Myfinance::RequestError) do |error|
           expect(error.code).to eql(404)
         end
       end
     end
   end
 
-  describe "#find_by" do
-    context "when success" do
-      it "find categories by attributes" do
-        result = client.categories.find_by({ name: "Alimentação" })
-        expect(result).to be_a(Myfinance::Entities::CategoryCollection)
-        expect(result.collection.first).to be_a(entity_klass)
-        expect(result.collection.first.name).to eql("Alimentação")
-      end
-    end
-
-    context "when error" do
-      let(:client) { Myfinance.client("") }
-
-      it "raises Myfinance::RequestError with 401 status code" do
-        expect {
-          client.categories.find_by({})
-        }.to raise_error(Myfinance::RequestError) do |error|
-          expect(error.code).to eql(401)
-        end
-      end
-    end
-  end
-
   describe "#create" do
-    let(:params) { { name: "Category 1" } }
+    let(:params) { { name: "Categoria 42 do Marvin" } }
 
     context "with success" do
       it "creates a category successfully" do
         result = client.categories.create(params)
         expect(result).to be_a(entity_klass)
-        expect(result.name).to eql("Category 1")
+        expect(result.name).to eql("Categoria 42 do Marvin")
       end
     end
 
     context "with error" do
       it "raises Myfinance::RequestError with 422 status code" do
-        expect {
-          client.categories.create({})
-        }.to raise_error(Myfinance::RequestError) do |error|
+        expect { client.categories.create({}) }.to raise_error(Myfinance::RequestError) do |error|
           expect(error.code).to eql(422)
         end
       end
@@ -96,17 +86,13 @@ describe Myfinance::Resources::Category, vcr: true do
   describe "#update" do
     context "with success" do
       it "updates a category successfully" do
-        expect(
-          client.categories.update(548083, { name: "Category updated" })
-        ).to be_a(entity_klass)
+        expect(client.categories.update(548083, { name: "Category updated" })).to be_a(entity_klass)
       end
     end
 
     context "with error" do
       it "raises Myfinance::RequestError with 404 status code" do
-        expect {
-          client.categories.update(88888888, {})
-        }.to raise_error(Myfinance::RequestError) do |error|
+        expect { client.categories.update(88888888, {}) }.to raise_error(Myfinance::RequestError) do |error|
           expect(error.code).to eql(404)
         end
       end
@@ -122,15 +108,13 @@ describe Myfinance::Resources::Category, vcr: true do
   describe "#destroy" do
     context "with success" do
       it "destroy a category successfully" do
-        expect(client.categories.destroy(532314)).to be_truthy
+        expect(client.categories.destroy(532350)).to be_truthy
       end
     end
 
     context "with error" do
       it "raises Myfinance::RequestError with 404 status code" do
-        expect {
-          client.categories.destroy(88888888)
-        }.to raise_error(Myfinance::RequestError) do |error|
+        expect { client.categories.destroy(88888888) }.to raise_error(Myfinance::RequestError) do |error|
           expect(error.code).to eql(404)
         end
       end

data/spec/lib/myfinance/resources/classification_center_spec.rb

@@ -2,6 +2,7 @@ require "spec_helper"
 
 describe Myfinance::Resources::ClassificationCenter, vcr: true do
   let(:entity_klass) { Myfinance::Entities::ClassificationCenter }
+  let(:page) { 2 }
 
   let(:entity_collection) do
     Myfinance::Entities::ClassificationCenterCollection
@@ -16,6 +17,46 @@ describe Myfinance::Resources::ClassificationCenter, vcr: true do
         expect(subject.collection.first).to be_a(entity_klass)
         expect(subject.collection.first.name).to eq("Centro de Custo Tal")
       end
+
+      context "with params" do
+        let(:params) { { entity_id_equals: 3798 } }
+
+        it "find by name successfully" do
+          params[:name_equals] = "Centro de Custo Tal"
+          outcome = client.classification_centers.find_all(params)
+
+          expect(outcome).to be_a(entity_collection)
+          expect(outcome.collection.first).to be_a(entity_klass)
+          expect(outcome.collection.first.name).to eq("Centro de Custo Tal")
+        end
+
+        it "find with special characters" do
+          params[:name_equals] = "Socialização 2"
+          outcome = client.classification_centers.find_all(params)
+
+          expect(outcome).to be_a(entity_collection)
+          expect(outcome.collection.first).to be_a(entity_klass)
+          expect(outcome.collection.first.name).to eq("Socialização 2")
+        end
+
+        it "returns a empty classification center successfully" do
+          params[:name_equals] = "Any"
+          outcome = client.classification_centers.find_all(params)
+
+          expect(outcome).to be_a(entity_collection)
+          expect(outcome.collection.first).to be_falsy
+        end
+      end
+
+      context "when paging" do
+        let(:search_params) { { page: page, entity_id_equals: 3798, name_contains: "Centro" } }
+        subject { client.classification_centers.find_all(search_params) }
+
+        it "returns paginated url" do
+          url = subject.response.request.base_url
+          expect(url).to include("page=#{page}")
+        end
+      end
     end
 
     context "when error" do
@@ -52,36 +93,6 @@ describe Myfinance::Resources::ClassificationCenter, vcr: true do
     end
   end
 
-  describe "#find_by" do
-    context "when success" do
-      it "find a classification centers by name successfully" do
-        result = client.classification_centers.find_by(
-          { entity_id_equals: 3798, name_equals: "Centro de Custo Tal" }
-        )
-        expect(result).to be_a(entity_collection)
-        expect(result.collection.first).to be_a(entity_klass)
-        expect(result.collection.first.name).to eq("Centro de Custo Tal")
-      end
-
-      it "find a classification centers with special characters" do
-        result = client.classification_centers.find_by(
-          { entity_id_equals: 3798, name_equals: "Socialização 2" }
-        )
-        expect(result).to be_a(entity_collection)
-        expect(result.collection.first).to be_a(entity_klass)
-        expect(result.collection.first.name).to eq("Socialização 2")
-      end
-
-      it "returns a empty classification center successfully" do
-        result = client.classification_centers.find_by(
-          { entity_id_equals: 3798, name_equals: "Any" }
-        )
-        expect(result).to be_a(entity_collection)
-        expect(result.collection.first).to be_falsy
-      end
-    end
-  end
-
   describe "#create" do
     context "when success" do
       let(:params) do

data/spec/lib/myfinance/resources/deposit_account_spec.rb

@@ -12,7 +12,32 @@ describe Myfinance::Resources::DepositAccount, vcr: true do
         subject.build
         expect(subject).to be_a(Myfinance::Entities::DepositAccountCollection)
         expect(subject.collection.first).to be_a(entity_klass)
-        expect(subject.collection.first.name).to eq("Carteira")
+        expect(subject.collection.first.name).to eq("Caixa Grande")
+      end
+
+      context "with params" do
+        subject { client.deposit_accounts.find_all(entity_id, name: "Carteira") }
+      end
+
+      it "returns a collection of DepositAccounts" do
+        expect(subject).to be_a(Myfinance::Entities::DepositAccountCollection)
+      end
+
+      it "returns matched DepositAccount" do
+        da = subject.collection.first
+        expect(da.name).to eq("Caixa Grande")
+      end
+
+      it "does not match other DepositAccounts" do
+        expect(subject.collection.size).to eq(3)
+      end
+
+      context "when not found" do
+        subject { client.deposit_accounts.find_all(entity_id, name: "NAO_EXISTE_ESSA_DEPOSIT_ACCOUNT_42") }
+
+        it "returns an empty collection" do
+          expect(subject.collection).to be_empty
+        end
       end
     end
 
@@ -49,33 +74,6 @@ describe Myfinance::Resources::DepositAccount, vcr: true do
     end
   end
 
-  describe "#find_by" do
-    context "when succesful"  do
-      subject { client.deposit_accounts.find_by(entity_id, name: "Carteira") }
-
-      it "returns a collection of DepositAccounts" do
-        expect(subject).to be_a(Myfinance::Entities::DepositAccountCollection)
-      end
-
-      it "returns matched DepositAccount" do
-        da = subject.collection.first
-        expect(da.name).to eq("Carteira")
-      end
-
-      it "does not match other DepositAccounts" do
-        expect(subject.collection.size).to eq(1)
-      end
-
-      context "when not found"  do
-        subject { client.deposit_accounts.find_by(entity_id, name: "NAO_EXISTE_ESSA_DEPOSIT_ACCOUNT_42") }
-
-        it "returns an empty collection" do
-          expect(subject.collection).to be_empty
-        end
-      end
-    end
-  end
-
   describe "#create" do
     context "when success" do
       let(:params) do

data/spec/lib/myfinance/resources/entity_spec.rb

@@ -18,7 +18,31 @@ describe Myfinance::Resources::Entity do
         expect(subject.collection.first.federation_subscription_number).to eq("")
         expect(subject.collection.first.imported_from_sync_at).to be_nil
         expect(subject.collection.first.updated_at).to eq(DateTime.parse("2015-07-29T14:30:36-03:00"))
-        expect(subject.collection.count).to eq(1)
+        expect(subject.collection.count).to eq(2)
+      end
+    end
+
+    context "with params" do
+      let(:params) { { name_contains: "Minhas" } }
+      subject { client.entities.find_all(params) }
+
+      it "returns a collection of Entities" do
+        expect(subject).to be_a(Myfinance::Entities::EntityCollection)
+      end
+
+      it "returns Entity that matches search params" do
+        entity = subject.collection.first
+
+        expect(entity.id).to eq(3798)
+        expect(entity.name).to eq("Minhas Finanças")
+      end
+    end
+
+    context "when not found" do
+      subject { client.entities.find_all(name: "ENTIDADE_QUE_NAO_EXISTE_42") }
+
+      it "returns an empty collection" do
+        expect(subject.collection).to be_empty
       end
     end
 
@@ -60,29 +84,4 @@ describe Myfinance::Resources::Entity do
       end
     end
   end
-
-  describe "#find_by", vcr: true do
-    context "when successful" do
-      subject { client.entities.find_by(name_contains: "Minhas") }
-
-      it "returns a collection of Entities" do
-        expect(subject).to be_a(Myfinance::Entities::EntityCollection)
-      end
-
-      it "returns Entity that matches search params" do
-        entity = subject.collection.first
-
-        expect(entity.id).to eq(3798)
-        expect(entity.name).to eq("Minhas Finanças")
-      end
-    end
-
-    context "when not found" do
-      subject { client.entities.find_by(name: "ENTIDADE_QUE_NAO_EXISTE_42") }
-
-      it "returns an empty colleciton" do
-        expect(subject.collection).to be_empty
-      end
-    end
-  end
 end

data/spec/lib/myfinance/resources/person_spec.rb

@@ -10,57 +10,49 @@ describe Myfinance::Resources::Person, vcr: true do
       it "show all people successfully" do
         expect(subject).to be_a(Myfinance::Entities::PersonCollection)
         expect(subject.collection.first).to be_a(entity_klass)
-        expect(subject.collection.first.name).to eq("Myfreecomm")
+        expect(subject.collection.first.name).to eq("João das neves")
       end
-    end
-
-    context "when not found" do
-      let(:client) { Myfinance.client("") }
 
-      it "raises Myfinance::RequestError with 401 status code" do
-        expect {
-          client.people.find_all
-        }.to raise_error(Myfinance::RequestError) do |error|
-          expect(error.code).to eq(401)
+      context "with params" do
+        it "find people by attributte name_equals" do
+          result = client.people.find_all( name_equals: "Myfreecomm", person_type_in: "JuridicalPerson")
+          expect(result).to be_a(Myfinance::Entities::PersonCollection)
+          expect(result.collection.first.name).to eq("Myfreecomm")
         end
-      end
-    end
-  end
-
-  describe "#find_by" do
-    context "with success" do
-      it "find people by attributte name_equals" do
-        result = client.people.find_by(
-          { name_equals: "Myfreecomm", person_type_in: "JuridicalPerson" }
-        )
-        expect(result).to be_a(Myfinance::Entities::PersonCollection)
-        expect(result.collection.first.name).to eq("Myfreecomm")
-      end
 
-      it "find people by attributte name_equals with special characters" do
-        result = client.people.find_by({ name_equals: "João das neves"})
-        expect(result).to be_a(Myfinance::Entities::PersonCollection)
-        expect(result.collection.first.name).to eq("João das neves")
-      end
+        it "find people by attributte with special characters" do
+          result = client.people.find_all(name_equals: "João das neves")
+          expect(result).to be_a(Myfinance::Entities::PersonCollection)
+          expect(result.collection.first.name).to eq("João das neves")
+        end
 
-      it "find people by attributte federation_subscription_number_equals" do
-        result = client.people.find_by(
-          { federation_subscription_number_equals: "42.308.611/0001-41" }
-        )
-        expect(result).to be_a(Myfinance::Entities::PersonCollection)
-        expect(result.collection.first.name).to eq("Myfreecomm")
+        it "find people by attributte federation_subscription_number_equals" do
+          result = client.people.find_all(
+            { federation_subscription_number_equals: "42.308.611/0001-41" }
+          )
+          expect(result).to be_a(Myfinance::Entities::PersonCollection)
+          expect(result.collection.first.name).to eq("Myfreecomm")
+        end
+        context "with error" do
+          let(:client) { Myfinance.client("") }
+
+          it "raises Myfinance::RequestError with 401 status code" do
+            params = { name_equals: "Myfreecomm" }
+            expect { client.people.find_all(params) }.to raise_error(Myfinance::RequestError) do |error|
+              expect(error.code).to eq(401)
+            end
+          end
+        end
       end
     end
+  end
 
-    context "with error" do
-      let(:client) { Myfinance.client("") }
+  context "when not found" do
+    let(:client) { Myfinance.client("") }
 
-      it "raises Myfinance::RequestError with 401 status code" do
-        expect {
-          client.people.find_by({ name_equals: "Myfreecomm" })
-        }.to raise_error(Myfinance::RequestError) do |error|
-          expect(error.code).to eq(401)
-        end
+    it "raises Myfinance::RequestError with 401 status code" do
+      expect { client.people.find_all }.to raise_error(Myfinance::RequestError) do |error|
+        expect(error.code).to eq(401)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: myfinance
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Eduardo Hertz
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-27 00:00:00.000000000 Z
+date: 2017-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: typhoeus
@@ -376,7 +376,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: A Ruby client for the Myfinance REST API