myfinance 0.7.0 → 1.0.0

data/spec/lib/myfinance/resources/financial_transaction_spec.rb

@@ -4,24 +4,49 @@ describe Myfinance::Resources::FinancialTransaction, vcr: true do
   let(:da_id) { 14268 }
   let(:ent_id) { 3798 }
   let(:ft_id) { 1663920 }
+  let(:page) { 2 }
   let(:financial_transactions) { client.financial_transactions }
   let(:params) { { amount: 68.5, occurred_at: "2011-07-15", type: "Debit" } }
   let(:request_error) { Myfinance::RequestError }
 
   describe "#find_all" do
     context "when successful" do
-      subject { client.financial_transactions.find_all(ent_id, da_id) }
       before :each do
         subject.build
       end
 
+      subject { client.financial_transactions.find_all(ent_id, da_id, page) }
+
       it "returns a 200 OK response code" do
         expect(subject.response.code).to eq(200)
       end
 
-      it "return collection of FinancialTransactions" do
+      it "returns URL with next page" do
+        url = subject.response.request.base_url
+        expect(url).to include("?page=#{page}")
+      end
+
+      it "returns collection of FinancialTransactions" do
         expect(subject).to be_a(Myfinance::Entities::FinancialTransactionCollection)
       end
+
+      context "without pagination" do
+        subject { client.financial_transactions.find_all(ent_id, da_id) }
+
+        it "returns a 200 OK response code" do
+          expect(subject.response.code).to eq(200)
+        end
+
+        it "returns collection of FinancialTransactions" do
+          expect(subject).to be_a(Myfinance::Entities::FinancialTransactionCollection)
+        end
+
+        it "does not return URL for next page" do
+          url = subject.response.request.base_url
+          expect(url).not_to include("?page=#{page}")
+        end
+
+      end
     end
 
     context "when supplying invalid IDs" do

data/spec/lib/myfinance/resources/payable_account_spec.rb

@@ -2,6 +2,82 @@ require "spec_helper"
 
 describe Myfinance::Resources::PayableAccount do
   let(:entity_id) { 3798 }
+  let(:pa_id) { 1235663 }
+  let(:page) { 2 }
+  let(:url) { subject.response.request.base_url }
+  let(:request_error) { Myfinance::RequestError }
+
+  describe "#find_all", vcr: true do
+    before :each do
+      subject.build
+    end
+    context "with pagination" do
+      subject { client.payable_accounts.find_all(entity_id, page) }
+
+      it "returns 200 OK response code" do
+        expect(subject.response.code).to eq(200)
+      end
+
+      it "returns a PayableAccount collection" do
+        expect(subject).to be_a(Myfinance::Entities::PayableAccountCollection)
+      end
+
+      it "returns a paginated URL" do
+        expect(url).to include("?page=#{page}")
+      end
+
+      context "with invalid page" do
+        subject { client.payable_accounts.find_all(entity_id, 42424242) }
+
+        it "returns empty collection" do
+          expect(subject.collection).to be_empty
+        end
+      end
+    end
+
+    context "without pagination" do
+      subject { client.payable_accounts.find_all(entity_id) }
+
+      it "returns 200 OK response code" do
+        expect(subject.response.code).to eq(200)
+      end
+
+      it "returns a PayableAccount collection" do
+        expect(subject).to be_a(Myfinance::Entities::PayableAccountCollection)
+      end
+
+      it "returns a paginated URL" do
+        expect(url).not_to include("?page=#{page}")
+      end
+
+      context "with invalid entity id" do
+        it "raises 404 not found error" do
+          expect { client.payable_accounts.find_all(nil) }.to raise_error(request_error) do |e|
+            expect(e.code).to eq(404)
+            expect(e.message).to eq("Not Found")
+          end
+        end
+      end
+    end
+  end
+
+  describe "#find", vcr: true do
+    subject { client.payable_accounts.find(entity_id, pa_id) }
+
+    it "returns a PayableAccount" do
+      expect(subject).to be_a(Myfinance::Entities::PayableAccount)
+    end
+
+    context "with invalid ID" do
+      subject { client.payable_accounts.find(nil, nil) }
+
+      it "raises 404 not found error" do
+        expect { subject }.to raise_error(request_error) do |e|
+          expect(e.code).to eq(404)
+        end
+      end
+    end
+  end
 
   describe "#create", vcr: true do
     let(:params) { { due_date: '2015-08-15', amount: 150.99 } }
@@ -61,26 +137,28 @@ describe Myfinance::Resources::PayableAccount do
     context "when any data is invalid" do
       let(:params) { { due_date: '', amount: 150.99 } }
 
-      it "raises Myfinance::RequestError" do
-        expect { subject }.to raise_error(Myfinance::RequestError)
+      it "raises request_error" do
+        expect { subject }.to raise_error(request_error)
       end
 
       it "adds information on request error object" do
-        expect(Myfinance::RequestError).to receive(:new).with(code: 422, message: "", body: { "competency_month" => ["não pode ser vazio"], "due_date" => ["não é uma data válida"] }).and_call_original
-        expect { subject }.to raise_error(Myfinance::RequestError)
+        body = { "competency_month" => ["não pode ser vazio"], "due_date" => ["não é uma data válida"] }
+        expect(request_error).to receive(:new).with(code: 422, message: "", body: body).and_call_original
+        expect { subject }.to raise_error(request_error)
       end
     end
 
     context "when entity does not exist" do
       subject { client.payable_accounts.create(555, params) }
 
-      it "raises Myfinance::RequestError" do
-        expect { subject }.to raise_error(Myfinance::RequestError)
+      it "raises request_error" do
+        expect { subject }.to raise_error(request_error)
       end
 
       it "adds information on request error object" do
-        expect(Myfinance::RequestError).to receive(:new).with(code: 403, message: "Forbidden", body: {"error" => "Você não tem permissão para acessar este recurso." }).and_call_original
-        expect { subject }.to raise_error(Myfinance::RequestError)
+        body = {"error" => "Você não tem permissão para acessar este recurso." }
+        expect(request_error).to receive(:new).with(code: 403, message: "Forbidden", body: body).and_call_original
+        expect { subject }.to raise_error(request_error)
       end
     end
   end
@@ -106,7 +184,7 @@ describe Myfinance::Resources::PayableAccount do
       let(:params) { { total_amount: nil, occurred_at: '2015-08-05', amount: 150.99 } }
 
       it "raises request error" do
-        expect { subject }.to raise_error(Myfinance::RequestError)
+        expect { subject }.to raise_error(request_error)
       end
     end
   end
@@ -127,7 +205,7 @@ describe Myfinance::Resources::PayableAccount do
   end
 
   describe "#update", vcr: true do
-    subject { client.payable_accounts.update(1235050, entity_id, { amount: 100.00 }) }
+    subject { client.payable_accounts.update(entity_id, 1235050, { amount: 100.00 }) }
 
     context "when payable account exists" do
       it "returns true" do
@@ -136,16 +214,16 @@ describe Myfinance::Resources::PayableAccount do
     end
 
     context "when payable account does not exist" do
-      subject { client.payable_accounts.update(9999999, entity_id, { amount: 100.00 }) }
+      subject { client.payable_accounts.update(entity_id, 9999999, { amount: 100.00 }) }
 
       it "raises request error" do
-        expect { subject }.to raise_error(Myfinance::RequestError)
+        expect { subject }.to raise_error(request_error)
       end
     end
   end
 
   describe "#destroy", vcr: true do
-    subject { client.payable_accounts.destroy(1215631, entity_id) }
+    subject { client.payable_accounts.destroy(entity_id, 1215631) }
 
     context "when payable account exists" do
       it "returns true" do
@@ -154,10 +232,48 @@ describe Myfinance::Resources::PayableAccount do
     end
 
     context "when payable account does not exist" do
-      subject { client.payable_accounts.destroy(1215631099, entity_id) }
+      subject { client.payable_accounts.destroy(entity_id, 1215631099) }
 
       it "raises request error" do
-        expect { subject }.to raise_error(Myfinance::RequestError)
+        expect { subject }.to raise_error(request_error)
+      end
+    end
+  end
+
+  describe "#destroy_recurrence", vcr: true do
+    let(:params) { { due_date: "2015-08-15", amount: 150.99, create_as_recurrent: "annual" } }
+    let(:new_pa) { client.payable_accounts.create(entity_id, params) }
+
+    before :each do
+      client.payable_accounts.destroy_recurrence(entity_id, new_pa.id)
+    end
+
+    it "does not find recurrent payable accounts" do
+      expect { client.payable_accounts.find(entity_id, new_pa.id) }.to raise_error(request_error) do |e|
+        expect(e.code).to eq(404)
+        expect(e.message).to eq("Not Found")
+      end
+
+      expect { client.payable_accounts.find(entity_id, new_pa.id + 1) }.to raise_error(request_error) do |e|
+        expect(e.code).to eq(404)
+        expect(e.message).to eq("Not Found")
+      end
+    end
+  end
+
+  describe "#destroy_many", vcr: true do
+    let(:params) { { due_date: "2015-08-15", amount: 150.99 } }
+    let(:new_pa) { client.payable_accounts.create(entity_id, params) }
+    let(:new_pa2) { client.payable_accounts.create(entity_id, params) }
+
+    before :each do
+      client.payable_accounts.destroy_many(entity_id, [new_pa.id, new_pa2.id])
+    end
+
+    it "does not find created PayableAccount" do
+      expect { client.payable_accounts.find(entity_id, new_pa.id) }.to raise_error(request_error) do |e|
+        expect(e.code).to eq(404)
+        expect(e.message).to eq("Not Found")
       end
     end
   end

data/spec/lib/myfinance/resources/person_spec.rb

@@ -29,12 +29,24 @@ describe Myfinance::Resources::Person, vcr: true do
 
   describe "#find_by" do
     context "with success" do
-      let(:params) do
-        { name_equals: "Myfreecomm", person_type_in: "JuridicalPerson" }
+      it "find people by attributte name_equals" do
+        result = client.people.find_by(
+          { name_equals: "Myfreecomm", person_type_in: "JuridicalPerson" }
+        )
+        expect(result).to be_a(Myfinance::Entities::PersonCollection)
+        expect(result.collection.first.name).to eq("Myfreecomm")
+      end
+
+      it "find people by attributte name_equals with special characters" do
+        result = client.people.find_by({ name_equals: "João das neves"})
+        expect(result).to be_a(Myfinance::Entities::PersonCollection)
+        expect(result.collection.first.name).to eq("João das neves")
       end
 
-      it "find people by attributte" do
-        result = client.people.find_by(params)
+      it "find people by attributte federation_subscription_number_equals" do
+        result = client.people.find_by(
+          { federation_subscription_number_equals: "42.308.611/0001-41" }
+        )
         expect(result).to be_a(Myfinance::Entities::PersonCollection)
         expect(result.collection.first.name).to eq("Myfreecomm")
       end

data/spec/lib/myfinance/resources/receivable_account_spec.rb

@@ -2,6 +2,83 @@ require "spec_helper"
 
 describe Myfinance::Resources::ReceivableAccount do
   let(:entity_id) { 3798 }
+  let(:ra_id) { 1320786 }
+  let(:page) { 2 }
+  let(:url) { subject.response.request.base_url }
+  let(:request_error) { Myfinance::RequestError }
+
+  describe "#find_all", vcr: true do
+    before :each do
+      subject.build
+    end
+    
+    context "with pagination" do
+      subject { client.receivable_accounts.find_all(entity_id, page) }
+
+      it "returns 200 OK response code" do
+        expect(subject.response.code).to eq(200)
+      end
+
+      it "returns a ReceivableAccount collection" do
+        expect(subject).to be_a(Myfinance::Entities::ReceivableAccountCollection)
+      end
+
+      it "returns a paginated URL" do
+        expect(url).to include("?page=#{page}")
+      end
+
+      context "with invalid page" do
+        subject { client.receivable_accounts.find_all(entity_id, 42424242) }
+
+        it "returns empty collection" do
+          expect(subject.collection).to be_empty
+        end
+      end
+    end
+
+    context "without pagination" do
+      subject { client.receivable_accounts.find_all(entity_id) }
+
+      it "returns 200 OK response code" do
+        expect(subject.response.code).to eq(200)
+      end
+
+      it "returns a ReceivableAccount collection" do
+        expect(subject).to be_a(Myfinance::Entities::ReceivableAccountCollection)
+      end
+
+      it "returns a paginated URL" do
+        expect(url).not_to include("?page=#{page}")
+      end
+
+      context "with invalid entity id" do
+        it "raises 404 not found error" do
+          expect { client.receivable_accounts.find_all(nil) }.to raise_error(request_error) do |e|
+            expect(e.code).to eq(404)
+            expect(e.message).to eq("Not Found")
+          end
+        end
+      end
+    end
+  end
+
+  describe "#find", vcr: true do
+    subject { client.receivable_accounts.find(entity_id, ra_id) }
+
+    it "returns a ReceivableAccount" do
+      expect(subject).to be_a(Myfinance::Entities::ReceivableAccount)
+    end
+
+    context "with invalid ID" do
+      subject { client.receivable_accounts.find(nil, nil) }
+
+      it "raises 404 not found error" do
+        expect { subject }.to raise_error(request_error) do |e|
+          expect(e.code).to eq(404)
+        end
+      end
+    end
+  end
 
   describe "#create", vcr: true do
     let(:params) { { due_date: '2015-08-15', amount: 150.99 } }
@@ -61,26 +138,28 @@ describe Myfinance::Resources::ReceivableAccount do
     context "when any data is invalid" do
       let(:params) { { due_date: '', amount: 150.99 } }
 
-      it "raises Myfinance::RequestError" do
-        expect { subject }.to raise_error(Myfinance::RequestError)
+      it "raises request_error" do
+        expect { subject }.to raise_error(request_error)
       end
 
       it "adds information on request error object" do
-        expect(Myfinance::RequestError).to receive(:new).with(code: 422, message: "", body: { "competency_month" => ["não pode ser vazio"], "due_date" => ["não é uma data válida"] }).and_call_original
-        expect { subject }.to raise_error(Myfinance::RequestError)
+        body = { "competency_month" => ["não pode ser vazio"], "due_date" => ["não é uma data válida"] }
+        expect(request_error).to receive(:new).with(code: 422, message: "", body: body).and_call_original
+        expect { subject }.to raise_error(request_error)
       end
     end
 
     context "when entity does not exist" do
       subject { client.receivable_accounts.create(555, params) }
 
-      it "raises Myfinance::RequestError" do
-        expect { subject }.to raise_error(Myfinance::RequestError)
+      it "raises request_error" do
+        expect { subject }.to raise_error(request_error)
       end
 
       it "adds information on request error object" do
-        expect(Myfinance::RequestError).to receive(:new).with(code: 403, message: "Forbidden", body: { "error" => "Você não tem permissão para acessar este recurso." }).and_call_original
-        expect { subject }.to raise_error(Myfinance::RequestError)
+        body = { "error" => "Você não tem permissão para acessar este recurso." }
+        expect(request_error).to receive(:new).with(code: 403, message: "Forbidden", body: body).and_call_original
+        expect { subject }.to raise_error(request_error)
       end
     end
   end
@@ -106,7 +185,7 @@ describe Myfinance::Resources::ReceivableAccount do
       let(:params) { { total_amount: nil, occurred_at: '2015-08-05', amount: 150.99 } }
 
       it "raises request error" do
-        expect { subject }.to raise_error(Myfinance::RequestError)
+        expect { subject }.to raise_error(request_error)
       end
     end
   end
@@ -127,7 +206,7 @@ describe Myfinance::Resources::ReceivableAccount do
   end
 
   describe "#update", vcr: true do
-    subject { client.receivable_accounts.update(1235051, entity_id, { amount: 100.00 }) }
+    subject { client.receivable_accounts.update(entity_id, 1235051, amount: 100.00) }
 
     context "when payable account exists" do
       it "returns true" do
@@ -136,16 +215,16 @@ describe Myfinance::Resources::ReceivableAccount do
     end
 
     context "when payable account does not exist" do
-      subject { client.receivable_accounts.update(9999999, entity_id, { amount: 100.00 }) }
+      subject { client.receivable_accounts.update(entity_id, 9999999, amount: 100.00) }
 
       it "raises request error" do
-        expect { subject }.to raise_error(Myfinance::RequestError)
+        expect { subject }.to raise_error(request_error)
       end
     end
   end
 
   describe "#destroy", vcr: true do
-    subject { client.receivable_accounts.destroy(1215634, entity_id) }
+    subject { client.receivable_accounts.destroy(entity_id, 1215634) }
 
     context "when receivable account exists" do
       it "returns true" do
@@ -154,10 +233,48 @@ describe Myfinance::Resources::ReceivableAccount do
     end
 
     context "when receivable account does not exist" do
-      subject { client.receivable_accounts.destroy(1215631099, entity_id) }
+      subject { client.receivable_accounts.destroy(entity_id, 1215631099) }
 
       it "raises request error" do
-        expect { subject }.to raise_error(Myfinance::RequestError)
+        expect { subject }.to raise_error(request_error)
+      end
+    end
+  end
+
+  describe "#destroy_recurrence", vcr: true do
+    let(:params) { { due_date: "2015-08-15", amount: 150.99, create_as_recurrent: "annual" } }
+    let(:new_ra) { client.receivable_accounts.create(entity_id, params) }
+
+    before :each do
+      client.receivable_accounts.destroy_recurrence(entity_id, new_ra.id)
+    end
+
+    it "does not find recurrent receivable accounts" do
+      expect { client.receivable_accounts.find(entity_id, new_ra.id) }.to raise_error(request_error) do |e|
+        expect(e.code).to eq(404)
+        expect(e.message).to eq("Not Found")
+      end
+
+      expect { client.receivable_accounts.find(entity_id, new_ra.id + 1) }.to raise_error(request_error) do |e|
+        expect(e.code).to eq(404)
+        expect(e.message).to eq("Not Found")
+      end
+    end
+  end
+
+  describe "#destroy_many", vcr: true do
+    let(:params) { { due_date: "2015-08-15", amount: 150.99 } }
+    let(:new_ra) { client.receivable_accounts.create(entity_id, params) }
+    let(:new_ra2) { client.receivable_accounts.create(entity_id, params) }
+
+    before :each do
+      client.receivable_accounts.destroy_many(entity_id, [new_ra.id, new_ra2.id])
+    end
+
+    it "does not find created ReceivableAccount" do
+      expect { client.receivable_accounts.find(entity_id, new_ra.id) }.to raise_error(request_error) do |e|
+        expect(e.code).to eq(404)
+        expect(e.message).to eq("Not Found")
       end
     end
   end