my_john_deere_api 0.8.2 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 242077415772b4bb77b74351f3f98a50f5f4c593e12677ec500a2fb2dc13dced
-  data.tar.gz: bd92b88d075ccd0cf741011426c27ce594b6021ead50f98c05e4426f53f614cd
+  metadata.gz: 41fea97474f3ff4ef830cfdd646087d1fa57e693f0da95075639da8c0ca83adf
+  data.tar.gz: 24afb45536681d94ddbd90d560090b4864e3bb4b839824a6247634eeb33641c4
 SHA512:
-  metadata.gz: e6e5d1d1240261d1d987053f365ed1299f9c1b9d64b8194f19d4d95c155fceebd79b2bae1e039e7f755d831b40a34b461575a2c64267e257408d76d73deb4b00
-  data.tar.gz: f0df1ab91d6fd93a74636a555bacc5ebca37ae1a8723c88884bf03f0244eb2a4576b26b2f112a3cd093ad602abedbd3ce54c0696cc82ce51ae688645ec66db4e
+  metadata.gz: ab7e7b57cd96c8e8bcc895e5ea275ac1afd56659b9bf74bb3f848acb15e4a5c7c77f1d979508ad606e0cb55ddefc8d30aa2748bfd9364f82149674572d1bcf5c
+  data.tar.gz: 0a5fb27c9d4206ecaad1b80e037d37d229dcd4be26cd3b8b3ed19937ce561e3d2b79bb0ed5edfb5e1c724dae4301556d3486d486bf2aef90cd49f2902e8de50f

data/lib/my_john_deere_api/authorize.rb

@@ -2,7 +2,7 @@ class MyJohnDeereApi::Authorize
   attr_reader :api_key, :api_secret,
     :request_token, :request_secret,
     :access_token, :access_secret,
-    :environment
+    :environment, :options
 
   DEFAULTS = {
     environment: :production
@@ -15,7 +15,7 @@ class MyJohnDeereApi::Authorize
   # on behalf of a user.
 
   def initialize(api_key, api_secret, options = {})
-    options = DEFAULTS.merge(options)
+    @options = DEFAULTS.merge(options)
 
     @api_key = api_key
     @api_secret = api_secret
@@ -29,11 +29,13 @@ class MyJohnDeereApi::Authorize
   def authorize_url
     return @authorize_url if defined?(@authorize_url)
 
-    requester = consumer.get_request_token
+    request_options = options.slice(:oauth_callback)
+
+    requester = consumer.get_request_token(request_options)
     @request_token = requester.token
     @request_secret = requester.secret
 
-    @authorize_url = requester.authorize_url
+    @authorize_url = requester.authorize_url(request_options)
   end
 
   ##

data/lib/my_john_deere_api/request/create/base.rb

@@ -59,13 +59,6 @@ module MyJohnDeereApi
       @is_valid = errors.empty?
     end
 
-    ##
-    # Run validations unique to a given model. This should be overridden
-    # by children where needed.
-
-    def validate_attributes
-    end
-
     ##
     # Raises an error if the record is invalid. Passes the errors hash
     # to the error, in order to build a useful message string.
@@ -76,6 +69,13 @@ module MyJohnDeereApi
 
     private
 
+    ##
+    # Run validations unique to a given model. This should be overridden
+    # by children where needed.
+
+    def validate_attributes
+    end
+
     ##
     # Convert inputs into working attributes. This allows us to auto-create
     # some attributes from others, or set defaults, on a class-by-class basis.

data/lib/my_john_deere_api/version.rb

@@ -1,3 +1,3 @@
 module MyJohnDeereApi
-  VERSION='0.8.2'
+  VERSION='0.9.0'
 end

data/test/lib/my_john_deere_api/request/collection/asset_locations_test.rb

@@ -12,6 +12,9 @@ describe 'MyJohnDeereApi::Request::Collection::AssetLocations' do
   let(:client) { JD::Client.new(API_KEY, API_SECRET, environment: :sandbox, access: [ACCESS_TOKEN, ACCESS_SECRET]) }
   let(:accessor) { VCR.use_cassette('catalog') { client.send(:accessor) } }
   let(:collection) { JD::Request::Collection::AssetLocations.new(accessor, asset: asset_id) }
+  let(:object) { collection }
+
+  inherits_from JD::Request::Collection::Base
 
   describe '#initialize(access_token)' do
     it 'accepts an access token' do

data/test/lib/my_john_deere_api/request/collection/assets_test.rb

@@ -12,6 +12,9 @@ describe 'MyJohnDeereApi::Request::Collection::Assets' do
   let(:client) { JD::Client.new(API_KEY, API_SECRET, environment: :sandbox, access: [ACCESS_TOKEN, ACCESS_SECRET]) }
   let(:accessor) { VCR.use_cassette('catalog') { client.send(:accessor) } }
   let(:collection) { JD::Request::Collection::Assets.new(accessor, organization: organization_id) }
+  let(:object) { collection }
+
+  inherits_from JD::Request::Collection::Base
 
   describe '#initialize(access_token)' do
     it 'accepts an access token' do

data/test/lib/my_john_deere_api/request/collection/fields_test.rb

@@ -12,6 +12,9 @@ describe 'MyJohnDeereApi::Request::Collection::Fields' do
   let(:client) { JD::Client.new(API_KEY, API_SECRET, environment: :sandbox, access: [ACCESS_TOKEN, ACCESS_SECRET]) }
   let(:accessor) { VCR.use_cassette('catalog') { client.send(:accessor) } }
   let(:collection) { JD::Request::Collection::Fields.new(accessor, organization: organization_id) }
+  let(:object) { collection }
+
+  inherits_from JD::Request::Collection::Base
 
   describe '#initialize(access_token)' do
     it 'accepts an access token' do

data/test/lib/my_john_deere_api/request/collection/flags_test.rb

@@ -18,6 +18,9 @@ describe 'MyJohnDeereApi::Request::Collection::Flags' do
   let(:client) { JD::Client.new(API_KEY, API_SECRET, environment: :sandbox, access: [ACCESS_TOKEN, ACCESS_SECRET]) }
   let(:accessor) { VCR.use_cassette('catalog') { client.send(:accessor) } }
   let(:collection) { JD::Request::Collection::Flags.new(accessor, organization: organization_id, field: field_id) }
+  let(:object) { collection }
+
+  inherits_from JD::Request::Collection::Base
 
   describe '#initialize(access_token)' do
     it 'accepts an access token' do

data/test/lib/my_john_deere_api/request/collection/organizations_test.rb

@@ -6,6 +6,9 @@ describe 'MyJohnDeereApi::Request::Collection::Organizations' do
   let(:client) { JD::Client.new(API_KEY, API_SECRET, environment: :sandbox, access: [ACCESS_TOKEN, ACCESS_SECRET]) }
   let(:accessor) { VCR.use_cassette('catalog') { client.send(:accessor) } }
   let(:collection) { JD::Request::Collection::Organizations.new(accessor) }
+  let(:object) { collection }
+
+  inherits_from JD::Request::Collection::Base
 
   describe '#initialize(access_token)' do
     it 'accepts an access token' do

data/test/lib/my_john_deere_api/request/create/asset_location_test.rb

@@ -49,10 +49,12 @@ describe 'MyJohnDeereApi::Request::Create::AssetLocation' do
 
   let(:attributes) { valid_attributes }
 
+  let(:object) { JD::Request::Create::AssetLocation.new(accessor, attributes) }
+
+  inherits_from MyJohnDeereApi::Request::Create::Base
+
   describe '#initialize(access_token, attributes)' do
     it 'accepts an accessor and attributes' do
-      object = JD::Request::Create::AssetLocation.new(accessor, attributes)
-
       assert_equal accessor, object.accessor
       assert_equal attributes, object.attributes
     end
@@ -70,8 +72,6 @@ describe 'MyJohnDeereApi::Request::Create::AssetLocation' do
         measurement_data: measurement_data
       }
 
-      object = JD::Request::Create::AssetLocation.new(accessor, attributes)
-
       assert_equal geometry.to_json, object.attributes[:geometry]
     end
 
@@ -88,8 +88,6 @@ describe 'MyJohnDeereApi::Request::Create::AssetLocation' do
 
   describe '#valid?' do
     it 'returns true when all required attributes are present' do
-      object = JD::Request::Create::AssetLocation.new(accessor, attributes)
-
       assert object.valid?
       assert_empty object.errors
     end
@@ -161,7 +159,6 @@ describe 'MyJohnDeereApi::Request::Create::AssetLocation' do
 
   describe '#request_body' do
     it 'properly forms the request body' do
-      object = JD::Request::Create::AssetLocation.new(accessor, attributes)
       body = object.send(:request_body)
 
       assert_kind_of Array, body
@@ -173,7 +170,6 @@ describe 'MyJohnDeereApi::Request::Create::AssetLocation' do
 
   describe '#request' do
     it 'makes the request' do
-      object = JD::Request::Create::AssetLocation.new(accessor, attributes)
       VCR.use_cassette('post_asset_locations') { object.request }
 
       assert_kind_of Net::HTTPCreated, object.response
@@ -182,7 +178,6 @@ describe 'MyJohnDeereApi::Request::Create::AssetLocation' do
 
   describe '#object' do
     it 'returns the asset location model instance' do
-      object = JD::Request::Create::AssetLocation.new(accessor, attributes)
       result = VCR.use_cassette('post_asset_locations') { object.object }
 
       assert_kind_of JD::Model::AssetLocation, result

data/test/lib/my_john_deere_api/request/create/asset_test.rb

@@ -27,12 +27,14 @@ describe 'MyJohnDeereApi::Request::Create::Asset' do
     }
   end
 
+  let(:object) { JD::Request::Create::Asset.new(accessor, attributes) }
+
   let(:attributes) { valid_attributes }
 
+  inherits_from MyJohnDeereApi::Request::Create::Base
+
   describe '#initialize(access_token, attributes)' do
     it 'accepts an accessor and attributes' do
-      object = JD::Request::Create::Asset.new(accessor, attributes)
-
       assert_equal accessor, object.accessor
       assert_equal attributes, object.attributes
     end
@@ -45,8 +47,6 @@ describe 'MyJohnDeereApi::Request::Create::Asset' do
 
   describe '#valid?' do
     it 'returns true when all required attributes are present' do
-      object = JD::Request::Create::Asset.new(accessor, attributes)
-
       assert object.valid?
       assert_empty object.errors
     end
@@ -173,7 +173,6 @@ describe 'MyJohnDeereApi::Request::Create::Asset' do
 
   describe '#request' do
     it 'makes the request' do
-      object = JD::Request::Create::Asset.new(accessor, attributes)
       VCR.use_cassette('post_assets') { object.request }
 
       assert_kind_of Net::HTTPCreated, object.response

data/test/support/helper.rb

@@ -20,4 +20,23 @@ SECRET_PATTERN = /^[0-9A-Za-z\-+=\/]+$/
 VCR.configure do |config|
   config.cassette_library_dir = 'test/support/vcr'
   config.hook_into :webmock
+end
+
+class Minitest::Spec
+  class << self
+    def inherits_from klass
+      it "inherits from #{klass}" do
+        public_methods = Hash.new([]).merge({
+          JD::Request::Create::Base => [:request, :object, :valid?, :validate!],
+          JD::Request::Collection::Base => [:each, :all, :count],
+        })
+
+        assert_kind_of klass, object
+
+        public_methods[klass].each do |method_name|
+          assert object.respond_to?(method_name)
+        end
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: my_john_deere_api
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.9.0
 platform: ruby
 authors:
 - Jaime. Bellmyer