mxfinfo 0.1.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: bea22e2b021d9cd49ac2f9296bb7915f61f6b1f8
-  data.tar.gz: 79a38848422cdb2d3b355b7c6e2673bbb9c4580c
+SHA256:
+  metadata.gz: 02dfbb1d51b34eb830c65cc5f8068eb44ab047d5a535c8fd05cd04d93561135a
+  data.tar.gz: fa00b4bb2687ebc8eb773885836af6f741a39dbeefe508f535a9beaafe8a257f
 SHA512:
-  metadata.gz: abc8197ebd32a392eae07a623916898fce01c30c5fea0ce277b5d4d895ebbb6c17aaf8b8de6f432b2e2ad99abce804cb4c7dd20a8893638afb68038a8a5696e0
-  data.tar.gz: e34a0ef19c405937d2a48d9bd316c2cd657af9311a8400dd0baff92b29e2f4d34645268f687bf8eec5755d93a26258007a58a0e4b8a83ffb5d0d96b36b3a0adf
+  metadata.gz: 232728e4a48514ddd27b9d1393ed1ad5a49c1631461b2b1b0027b2f8c4d4482e347939175b19045cf70c4b3a67046146bff697251f0c4ce418fdc51b6d0b8ea5
+  data.tar.gz: 439c58c2617f48e3bccc37a6211b17970471dc6ce6dbe634e30dcf0ce5b652ca556834c9994a5e39f4ff9cbb408ca6f181095a47e867f744f22da8416cf8af70

data/.gitignore

@@ -15,6 +15,7 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+.clangd
 
 # YARD artifacts
 .yardoc

data/compile_commands.json

@@ -0,0 +1,52 @@
+[
+    {
+        "arguments": [
+            "gcc",
+            "-c",
+            "-I.",
+            "-I/home/steved/.rbenv/versions/2.5.8/include/ruby-2.5.0/x86_64-linux",
+            "-I/home/steved/.rbenv/versions/2.5.8/include/ruby-2.5.0/ruby/backward",
+            "-I/home/steved/.rbenv/versions/2.5.8/include/ruby-2.5.0",
+            "-I../../../../ext/mxfinfo",
+            "-I/opt/environments/strawberry/include/libMXF-1.0",
+            "--std=gnu99",
+            "-D_GNU_SOURCE",
+            "-Wall",
+            "-I/home/steved/.rbenv/versions/2.5.8/include",
+            "-fPIC",
+            "-O3",
+            "-ggdb3",
+            "-fPIC",
+            "-o",
+            "avid_mxf_info.o",
+            "../../../../ext/mxfinfo/avid_mxf_info.c"
+        ],
+        "directory": "/home/steved/Documents/projective/github/mxfinfo/tmp/x86_64-linux/mxfinfo/2.5.8",
+        "file": "../../../../ext/mxfinfo/avid_mxf_info.c"
+    },
+    {
+        "arguments": [
+            "gcc",
+            "-c",
+            "-I.",
+            "-I/home/steved/.rbenv/versions/2.5.8/include/ruby-2.5.0/x86_64-linux",
+            "-I/home/steved/.rbenv/versions/2.5.8/include/ruby-2.5.0/ruby/backward",
+            "-I/home/steved/.rbenv/versions/2.5.8/include/ruby-2.5.0",
+            "-I../../../../ext/mxfinfo",
+            "-I/opt/environments/strawberry/include/libMXF-1.0",
+            "--std=gnu99",
+            "-D_GNU_SOURCE",
+            "-Wall",
+            "-I/home/steved/.rbenv/versions/2.5.8/include",
+            "-fPIC",
+            "-O3",
+            "-ggdb3",
+            "-fPIC",
+            "-o",
+            "mxfinfo.o",
+            "../../../../ext/mxfinfo/mxfinfo.c"
+        ],
+        "directory": "/home/steved/Documents/projective/github/mxfinfo/tmp/x86_64-linux/mxfinfo/2.5.8",
+        "file": "../../../../ext/mxfinfo/mxfinfo.c"
+    }
+]

data/ext/mxfinfo/mxfinfo.c

@@ -9,13 +9,12 @@ static
 VALUE rb_time_from_mxf_timestamp(mxfTimestamp *ts)
 {
 	/*
-	 * NOTE: This is probably not thread-safe, since struct tm*
-	 * returned by localtime is shared static.
+	 * NOTE: This is probably not thread-safe, since struct tm* returned by localtime is shared static.
 	 */
 	time_t t;
 	time(&t);
 	struct tm *tmts;
-	tmts = localtime(&t);
+	tmts = gmtime(&t);
 
 	tmts->tm_year = (int) ts->year - 1900;
 	tmts->tm_mon = (int) ts->month - 1;
@@ -23,6 +22,7 @@ VALUE rb_time_from_mxf_timestamp(mxfTimestamp *ts)
 	tmts->tm_hour = (int) ts->hour;
 	tmts->tm_min = (int) ts->min;
 	tmts->tm_sec = (int) ts->sec;
+  tmts->tm_isdst = -1;
 
   return rb_time_new(mktime(tmts), ts->qmsec);
 }
@@ -74,8 +74,12 @@ VALUE rb_str_from_label(const unsigned char *lbl, int len)
   {                                                                         \
     AvidMXFInfo *info;                                                      \
     Data_Get_Struct(self, AvidMXFInfo, info);                               \
-    return rb_rational_new(INT2FIX((info-> attr ).numerator),               \
-      INT2FIX((info-> attr ).denominator));                                 \
+    if((info->attr).denominator == 0) {                                     \
+      return Qnil;                                                          \
+    } else {                                                                \
+      return rb_rational_new(INT2FIX((info-> attr ).numerator),             \
+        INT2FIX((info-> attr ).denominator));                               \
+    }                                                                       \
   }
 
 #define CIO_INT_GETTER(name, attr) CIO_GENERIC_GETTER(INT2FIX, name, attr)
@@ -86,6 +90,9 @@ VALUE rb_str_from_label(const unsigned char *lbl, int len)
 
 VALUE m_mxfinfo = Qnil;
 VALUE c_infoobject = Qnil;
+VALUE c_error = Qnil;
+VALUE c_eNotOpAtom = Qnil;
+VALUE c_eNotReadable = Qnil;
 
 static
 void cio_free(void *ptr) {
@@ -106,7 +113,7 @@ void* ami_read_info_without_gvl(void* ptr)
   return NULL;
 }
 
-static 
+static
 VALUE cio_new(VALUE class, VALUE path)
 {
   Check_Type(path, T_STRING);
@@ -129,22 +136,22 @@ VALUE cio_new(VALUE class, VALUE path)
     switch(params.result)
     {
             case -2:
-              rb_raise(rb_eIOError, "Failed to open file.");
+              rb_raise(c_eNotReadable, "Failed to open file.");
                 break;
             case -3:
-              rb_raise(rb_eIOError, "Failed to read header partition.");
+              rb_raise(c_eNotReadable, "Failed to read header partition.");
                 break;
             case -4:
-              rb_raise(rb_eStandardError, "File is not OP-Atom.");
+              rb_raise(c_eNotOpAtom, "File is not OP-Atom.");
                 break;
             case -1:
             default:
-              rb_raise(rb_eStandardError, "Failed to read info.");
+              rb_raise(c_eNotReadable, "Failed to read info.");
                 break;
     }
 
     return Qnil;
-  } 
+  }
   else
   {
     VALUE tdata = Data_Wrap_Struct(class, 0, cio_free, info);
@@ -205,7 +212,7 @@ VALUE cio_get_material_package_uid(VALUE self)
   unsigned char *uid = (unsigned char*) &info->materialPackageUID;
 
   VALUE ary = rb_ary_new2(32);
-  for(unsigned int i = 0; i < 32; i++) 
+  for(unsigned int i = 0; i < 32; i++)
   {
     rb_ary_store(ary, i, CHR2FIX(uid[i]));
   }
@@ -238,7 +245,7 @@ VALUE cio_get_aspect_ratio(VALUE self)
   if(info->isVideo && info->aspectRatio.denominator != 0)
   {
     return rb_rational_new(INT2FIX(info->aspectRatio.numerator),
-      INT2FIX(info->aspectRatio.denominator)); 
+      INT2FIX(info->aspectRatio.denominator));
   }
   else
   {
@@ -286,12 +293,16 @@ VALUE cio_get_clip_track_string(VALUE self)
 
 void Init_mxfinfo()
 {
-  m_mxfinfo = rb_define_module("MXFInfo");	
+  m_mxfinfo = rb_define_module("MXFInfo");
+
+  c_error = rb_define_class_under(m_mxfinfo, "Error", rb_eStandardError);
+  c_eNotOpAtom = rb_define_class_under(c_error, "NotOpAtom", c_error);
+  c_eNotReadable = rb_define_class_under(c_error, "NotReadable", c_error);
 
 	c_infoobject = rb_define_class_under(m_mxfinfo, "InfoObject", rb_cObject);
   rb_define_singleton_method(c_infoobject, "new", cio_new, 1);
-	
-  rb_define_method(c_infoobject, "clip_name", cio_get_clip_name, 0);
+
+  rb_define_method(c_infoobject, "_clip_name", cio_get_clip_name, 0);
   rb_define_method(c_infoobject, "project_name", cio_get_project_name, 0);
   rb_define_method(c_infoobject, "clip_created", cio_get_clip_created, 0);
   rb_define_method(c_infoobject, "project_edit_rate", cio_get_project_edit_rate, 0);
@@ -302,7 +313,7 @@ void Init_mxfinfo()
   /* int numUserComments */
   /* AvidTaggedValue *materialPackageAttributes */
   /* int numMaterialPackageAttributes */
-  
+
   rb_define_method(c_infoobject, "num_video_tracks", cio_get_num_video_tracks, 0);
   rb_define_method(c_infoobject, "num_audio_tracks", cio_get_num_audio_tracks, 0);
   rb_define_method(c_infoobject, "tracks_string", cio_get_tracks_string, 0);

data/lib/mxfinfo.rb

@@ -15,7 +15,7 @@ module MXFInfo
 
   class InfoObject
     alias_method :videotracks, :num_video_tracks
-    alias_method :v_tracks, :num_video_tracks 
+    alias_method :v_tracks, :num_video_tracks
     alias_method :video_tracks, :num_video_tracks
     alias_method :audiotracks, :num_audio_tracks
     alias_method :audio_tracks, :num_audio_tracks
@@ -32,5 +32,9 @@ module MXFInfo
     def render_file?
       physical_package_name == "Precompute Source Mob"
     end
+
+    def clip_name
+      _clip_name&.force_encoding('UTF-8')
+    end
   end
 end

data/lib/mxfinfo/version.rb

@@ -1,4 +1,3 @@
 module MXFInfo
-  VERSION = '0.1.1'
+  VERSION = '0.2.2'.freeze
 end
-

data/mxfinfo.gemspec

@@ -1,14 +1,14 @@
-require File.expand_path('../lib/mxfinfo/version', __FILE__)
+require File.expand_path('lib/mxfinfo/version', __dir__)
 
 Gem::Specification.new do |gem|
   gem.authors       = ['Steve Dierker', 'Malte Rohde']
-  gem.email         = ['technology@flavoursys.com']
-  gem.description   = %q{MXFinfo is a gem that wraps avidmxfinfo from libmxf in a native ruby extension.}
-  gem.summary       = %q{MXFinfo is a gem that wraps avidmxfinfo from libmxf in a native ruby extension.}
-  gem.homepage      = 'http://github.com/flavoursys/mxfinfo'
+  gem.email         = ['technology@projective.io']
+  gem.description   = 'MXFinfo is a gem that wraps avidmxfinfo from libmxf in a native ruby extension.'
+  gem.summary       = 'MXFinfo is a gem that wraps avidmxfinfo from libmxf in a native ruby extension.'
+  gem.homepage      = 'http://github.com/projectivetech/mxfinfo'
 
-  gem.files         = `git ls-files`.split($\)
-  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
+  gem.files         = `git ls-files`.split($OUTPUT_RECORD_SEPARATOR)
+  gem.executables   = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.extensions    = ['ext/mxfinfo/extconf.rb']
   gem.name          = 'mxfinfo'
@@ -18,8 +18,7 @@ Gem::Specification.new do |gem|
 
   gem.required_ruby_version = '>= 1.9.3'
 
+  gem.add_development_dependency 'rake-compiler', '~> 1.0'
   gem.add_development_dependency 'rspec', '~> 3'
-  gem.add_development_dependency 'rspec-its', '1.2.0'
-  gem.add_development_dependency 'rake-compiler', '~> 0.9'
+  gem.add_development_dependency 'rspec-its', '1.3.0'
 end
-

data/spec/info_object_spec.rb

@@ -1,29 +1,30 @@
 require 'spec_helper'
+require 'time'
 
 describe 'MXFInfo::InfoObject' do
-  context 'when created from an valid MXF file' do
+  context 'with a valid MXF file' do
     subject do
-      MXFInfo.scan File.expand_path('../fixtures/IMG_0395.MOV.A14DC7130D.mxf', __FILE__)
+      MXFInfo.scan File.expand_path('fixtures/IMG_0395.MOV.A14DC7130D.mxf', __dir__)
     end
 
     its(:project_name) { should eq('Ballerinas_zippy') }
     its(:clip_name) { should eq('IMG_0395.MOV') }
     its(:clip_created_at) { should eq(Time.parse('2011-05-08 22:02:53.000')) }
-    its(:project_edit_rate) { should eq((25/1)) }
+    its(:project_edit_rate) { should eq((25 / 1)) }
     its(:clip_duration) { should eq(287) }
-    its(:clip_edit_rate) { should eq((25/1)) }
+    its(:clip_edit_rate) { should eq((25 / 1)) }
     its(:video_tracks) { should eq(1) }
     its(:audio_tracks) { should eq(1) }
     its(:clip_track_string) { should eq('V1 A1') }
     its(:essence_type) { should eq('PCM') }
     its(:essence_label) { should eq('060e2b34040101010d01030102060200') }
     its(:track_number) { should eq(1) }
-    its(:edit_rate) { should eq((48000/1)) }
-    its(:track_duration) { should eq(551040) }
-    its(:segment_duration) { should eq(551040) }
+    its(:edit_rate) { should eq((48_000 / 1)) }
+    its(:track_duration) { should eq(551_040) }
+    its(:segment_duration) { should eq(551_040) }
     its(:segment_offset) { should eq(0) }
     its(:start_timecode) { should eq(0) }
-    its(:audio_sampling_rate) { should eq((48000/1)) }
+    its(:audio_sampling_rate) { should eq((48_000 / 1)) }
     its(:quantization_bits) { should eq(16) }
     its(:channel_count) { should eq(1) }
     its(:material_package_uid) { should eq('060a2b340101010101010f00130000004dc7130d05831a0a060e2b347f7f2a80') }

data/spec/mxfinfo_spec.rb

@@ -20,7 +20,11 @@ describe 'MXFInfo' do
       it 'should return an InfoObject instance' do
         expect(MXFInfo.scan File.expand_path('../fixtures/IMG_0395.MOV.A14DC7130D.mxf', __FILE__)).to be_a(MXFInfo::InfoObject)
       end
-    end 
+
+      it 'should return an UTF-8 clip_name' do
+        expect(MXFInfo.scan(File.expand_path('../fixtures/IMG_0395.MOV.A14DC7130D.mxf', __FILE__)).clip_name.encoding).to eq(Encoding::UTF_8)
+      end
+    end
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mxfinfo
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Steve Dierker
@@ -9,54 +9,54 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-10 00:00:00.000000000 Z
+date: 2021-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake-compiler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: rspec-its
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '3'
 - !ruby/object:Gem::Dependency
-  name: rake-compiler
+  name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: 1.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: 1.3.0
 description: MXFinfo is a gem that wraps avidmxfinfo from libmxf in a native ruby
   extension.
 email:
-- technology@flavoursys.com
+- technology@projective.io
 executables: []
 extensions:
 - ext/mxfinfo/extconf.rb
@@ -67,6 +67,7 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- compile_commands.json
 - ext/mxfinfo/avid_mxf_info.c
 - ext/mxfinfo/avid_mxf_info.h
 - ext/mxfinfo/extconf.rb
@@ -79,7 +80,7 @@ files:
 - spec/info_object_spec.rb
 - spec/mxfinfo_spec.rb
 - spec/spec_helper.rb
-homepage: http://github.com/flavoursys/mxfinfo
+homepage: http://github.com/projectivetech/mxfinfo
 licenses:
 - MIT
 metadata: {}
@@ -98,8 +99,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 3.2.5
 signing_key: 
 specification_version: 4
 summary: MXFinfo is a gem that wraps avidmxfinfo from libmxf in a native ruby extension.