mvnizer 0.0.1 → 0.0.2

data/spec/commands/new_project_spec.rb

@@ -0,0 +1,69 @@
+require 'spec_helper'
+
+
+module Mvnizer
+  module Command
+    describe NewProject do
+      let(:options) { { name: "foobar", group_id: "com.example", version: "1.0.0", type: "jar" } }
+      let(:project) { Mvnizer::Project.new(nil, "foobar", nil, nil) }
+
+      let(:generator) { double("generator") }
+      let(:coordinate_parser) { double("coordinate_parser") } 
+      let(:dir_creator) { double("dir_creator") }
+      subject { Mvnizer::Command::NewProject.new(generator, dir_creator, coordinate_parser) }
+
+      before do
+        FakeFS.activate!
+        FileUtils.mkdir_p("foobar")
+      end
+
+      it "reads the configuration" do
+        generator.should_receive(:generate)
+        coordinate_parser.should_receive(:parse).and_return(project)
+        dir_creator.should_receive(:create)
+        subject.should_receive(:conf).with(options).and_return(options)
+
+        subject.run(options)
+      end
+
+      it "creates a project from the provided coordinates" do
+        o = { name: "foobar"}
+
+        subject.should_receive(:conf).with(o).and_return(options)
+        generator.should_receive(:generate)
+        dir_creator.should_receive(:create)
+
+        p = Mvnizer::Project.new("group", "foobar", "version", "type")
+        coordinate_parser.should_receive(:parse).with("foobar").and_return(p)
+
+        subject.run(o)
+      end
+
+      it "creates the project directory" do
+        subject.should_receive(:conf).with(options).and_return(options)
+        coordinate_parser.should_receive(:parse).and_return(project)
+        generator.should_receive(:generate)
+        dir_creator.should_receive(:create).with("foobar/src/main/java", "foobar/src/test/java")
+
+        subject.run(options)
+      end
+
+      it "generates the pom file" do
+        p = Mvnizer::Project.new("com.example", "foobar", "1.0.0-SNAPSHOT", "war")
+
+        subject.should_receive(:conf).with(options).and_return(options)
+        coordinate_parser.should_receive(:parse).and_return(p)
+        generator.should_receive(:generate).with(p)
+        dir_creator.should_receive(:create)
+        subject.run(options)
+
+        File.exists?("foobar/pom.xml").should be_true
+      end
+
+      after do 
+        FileUtils.rm_rf("foobar")
+        FakeFS.deactivate!
+      end
+    end
+  end
+end

data/spec/commands/new_war_project_spec.rb

@@ -0,0 +1,63 @@
+require 'spec_helper'
+require 'mvnizer/commands/new_war_project'
+
+module Mvnizer
+  module Command
+    describe NewWarProject do
+
+      let(:project) { Mvnizer::Project.new(nil, "foobar", nil, nil) }
+      let(:generator) { double("generator") }
+      let(:coordinate_parser) { double("coordinate_parser") } 
+      let(:dir_creator) { double("dir_creator") }
+
+      subject { Mvnizer::Command::NewWarProject.new(generator, dir_creator, coordinate_parser) }
+
+      before do
+        $run = false
+        class NewProject
+          alias old_run run
+          def run(options)
+            $run = true
+          end
+        end
+
+        subject.instance_variable_set(:@project, project)
+        FakeFS.activate!
+        FileUtils.mkdir_p("foobar")
+
+        templates_dir = File.join(File.dirname(__FILE__), '..', '..', 'lib', 'mvnizer', 'templates')
+        FileUtils.mkdir_p(templates_dir)
+        FileUtils.touch(File.join(templates_dir, "web.xml.erb"))
+      end
+
+      it "creates a basic project" do
+        options = {}
+        dir_creator.should_receive(:create)
+        subject.run(options)
+        $run.should be_true
+      end
+
+      it "creates the webapp directory" do
+        options = {name: "foobar"}
+        dir_creator.should_receive(:create).with("foobar/src/main/webapp/WEB-INF")
+        subject.run(options)
+      end
+
+      it "generates the web.xml file" do
+        options = {name: "foobar"}
+        dir_creator.should_receive(:create)
+
+        subject.run(options)
+        File.exists?("foobar/src/main/webapp/WEB-INF/web.xml").should be_true
+      end
+
+      after do
+        FileUtils.rm_rf("foobar")
+        FakeFS.deactivate!
+        class NewProject
+          alias run old_run
+        end
+      end
+    end
+  end
+end

data/spec/commands/project_factory_spec.rb

@@ -0,0 +1,21 @@
+# encoding: utf-8
+require 'spec_helper'
+
+module Mvnizer
+  module Command
+    describe ProjectFactory do
+      it "returns an instance of NewProject when passing jar" do
+        ProjectFactory.create("jar").should be_a(NewProject)
+        ProjectFactory.create("jar").should_not be_a(NewWarProject)
+      end
+
+      it "returns an instance of NewWarProject when passing war" do
+        ProjectFactory.create("war").should be_a(NewWarProject)
+      end
+
+      it "throws an error when unknown type is passed" do
+        lambda { ProjectFactory.create("foo") }.should raise_error(ArgumentError, "Don’t know how to create foo.")
+      end
+    end
+  end
+end

data/spec/configuration_spec.rb

@@ -1,28 +1,28 @@
-require 'spec_helper'
-
-describe Mvnizer::Configuration do
-  include Mvnizer::Configuration
-  let (:conf_path) { File.join(File.dirname(__FILE__), '..', 'conf', 'default.yml') }
-
-  it "loads configuration from default.yml" do
-      YAML.should_receive(:load_file).with(be_same_path_as(conf_path)).and_return({ foo: "bar" })
-    
-    config = conf(Hash.new)
-    config[:foo].should == "bar"
-  end
-
-  it "should replace default values" do
-      YAML.should_receive(:load_file).with(be_same_path_as(conf_path)).and_return({ foo: "bar" })
-    
-    config = conf({ foo: "qux", baz: "buz" })
-    config[:foo].should == "qux"
-    config[:baz].should == "buz"
-  end
-
-  it "should symbolize configuration keys" do
-    YAML.should_receive(:load_file).with(be_same_path_as(conf_path)).and_return({ "foo" => "bar" })
-
-    config = conf(Hash.new)
-    config[:foo].should == "bar"
-  end
-end
+require 'spec_helper'
+
+describe Mvnizer::Configuration do
+  include Mvnizer::Configuration
+  let (:conf_path) { File.join(File.dirname(__FILE__), '..', 'conf', 'default.yml') }
+
+  it "loads configuration from default.yml" do
+      YAML.should_receive(:load_file).with(be_same_path_as(conf_path)).and_return({ foo: "bar" })
+    
+    config = conf(Hash.new)
+    config[:foo].should == "bar"
+  end
+
+  it "should replace default values" do
+      YAML.should_receive(:load_file).with(be_same_path_as(conf_path)).and_return({ foo: "bar" })
+    
+    config = conf({ foo: "qux", baz: "buz" })
+    config[:foo].should == "qux"
+    config[:baz].should == "buz"
+  end
+
+  it "should symbolize configuration keys" do
+    YAML.should_receive(:load_file).with(be_same_path_as(conf_path)).and_return({ "foo" => "bar" })
+
+    config = conf(Hash.new)
+    config[:foo].should == "bar"
+  end
+end

data/spec/coordinate_parser_spec.rb

@@ -0,0 +1,69 @@
+require 'spec_helper'
+
+describe Mvnizer::CoordinateParser do
+  subject { Mvnizer::CoordinateParser.new }
+
+  it "can read the project name" do
+    project = subject.parse("name")
+    project.artifact_id.should == "name"
+  end
+
+  it "can read the group and artifact ids" do
+    project = subject.parse("com.example:name")
+    project.artifact_id.should == "name"
+    project.group_id.should == "com.example"
+  end
+
+  it "can read the group and artifact ids and version and type" do
+    project = subject.parse("com.example:name:1.0.0-rc2:war")
+    project.artifact_id.should == "name"
+    project.group_id.should == "com.example"  
+    project.version.should == "1.0.0-rc2"
+    project.type.should == "war"
+  end
+
+  it "can read the group and artifact ids and version" do
+    project = subject.parse("com.example:name:1.0.0-rc2")
+    project.artifact_id.should == "name"
+    project.group_id.should == "com.example"  
+    project.version.should == "1.0.0-rc2"
+  end
+
+  it "can read the artifact id and version" do
+    project = subject.parse("name:1.0.0-SNAPSHOT")
+    project.artifact_id.should == "name"
+    project.version.should == "1.0.0-SNAPSHOT"
+  end
+
+  it "can read the artifact id and type" do
+    project = subject.parse("name:jar")
+    project.artifact_id.should == "name"
+    project.type.should == "jar"
+  end
+
+  it "can read the artifact id, version and type" do
+    project = subject.parse("name:1.0.0-rc2:war")
+    project.artifact_id.should == "name"
+    project.version.should == "1.0.0-rc2"
+    project.type.should == "war"
+  end
+
+  it "can parse the scope" do
+    project = subject.parse_scoped_coordinates("name:1.0.0-rc2:war:runtime")
+    project.artifact_id.should == "name"
+    project.scope.should == "runtime"
+
+    project = subject.parse_scoped_coordinates("com.weblogism:name:1.0.0-rc2:jar:runtime")
+    project.artifact_id.should == "name"
+    project.scope.should == "runtime"
+  end
+
+  it "can parse the junit dependency" do
+    project = subject.parse_scoped_coordinates("junit:junit:4.10:jar:test")
+    project.group_id.should == "junit"
+    project.artifact_id.should == "junit"
+    project.version.should == "4.10"
+    project.type.should == "jar"
+    project.scope.should == "test"
+  end
+end

data/spec/dir_creator_spec.rb

@@ -1,17 +1,17 @@
-require 'spec_helper'
-require 'fileutils'
-
-describe Mvnizer::DirCreator do
-  subject { Mvnizer::DirCreator.new }
-  # Make use of fakefs explicit by using activate! / deactivate!
-  before { FakeFS.activate! }
-
-  it "creates a list of directories" do
-    subject.create("/tmp/blah/blah", "/tmp/foo/bar")
-    Dir.exists?("/tmp/blah/blah").should == true
-    Dir.exists?("/tmp/foo/bar").should == true
-  end
-
-  after { FakeFS.deactivate! }
-#  after { ["/tmp/blah", "/tmp/foo"].each { |d| FileUtils.rm_rf(d) } }
-end
+require 'spec_helper'
+require 'fileutils'
+
+describe Mvnizer::DirCreator do
+  subject { Mvnizer::DirCreator.new }
+  # Make use of fakefs explicit by using activate! / deactivate!
+  before { FakeFS.activate! }
+
+  it "creates a list of directories" do
+    subject.create("/tmp/blah/blah", "/tmp/foo/bar")
+    Dir.exists?("/tmp/blah/blah").should == true
+    Dir.exists?("/tmp/foo/bar").should == true
+  end
+
+  after { FakeFS.deactivate! }
+#  after { ["/tmp/blah", "/tmp/foo"].each { |d| FileUtils.rm_rf(d) } }
+end

data/spec/generator_spec.rb

@@ -1,19 +1,46 @@
-require 'spec_helper'
-require 'nokogiri'
-
-describe Mvnizer::PomGenerator do
-  subject { Mvnizer::PomGenerator.new }
-
-  it "generates a pom" do
-    options = { group_id: "test", version: "1.0.0-SNAPSHOT", name: "mvnizer" }
-    output = subject.generate(options)
-
-    # TODO: Ain't that a bit overkill for test?
-    doc = Nokogiri::XML(output)
-    doc.remove_namespaces!
-    doc.xpath("/project/groupId").first.text().should == "test"
-    doc.xpath("/project/artifactId").first.text().should == "mvnizer"
-    doc.xpath("/project/version").first.text().should == "1.0.0-SNAPSHOT"
-    doc.xpath("/project/name").first.text().should == "mvnizer"
-  end
-end
+require 'spec_helper'
+require 'nokogiri'
+
+# TODO Refactor when dealing with packaging-specific tasks.
+module Mvnizer
+  describe PomGenerator do
+
+    let (:project) { Mvnizer::Project.new("test", "mvnizer", "1.0.0-SNAPSHOT", "jar")}
+    subject { Mvnizer::PomGenerator.new }
+
+    it "generates a pom" do
+      output = subject.generate(project)
+
+      # TODO: Ain't that a bit overkill for test?
+      doc = Nokogiri::XML(output)
+      doc.remove_namespaces!
+      doc.xpath("/project/groupId").first.text().should == "test"
+      doc.xpath("/project/artifactId").first.text().should == "mvnizer"
+      doc.xpath("/project/version").first.text().should == "1.0.0-SNAPSHOT"
+      doc.xpath("/project/name").first.text().should == "mvnizer"
+      doc.xpath("/project/packaging").first.should be_nil
+    end
+
+    it "adds the packaging when the type is not jar" do
+      project = Mvnizer::Project.new("test", "mvnizer", "1.0.0", "war")
+      output = subject.generate(project)
+
+      doc = Nokogiri::XML(output)
+      doc.remove_namespaces!
+      doc.xpath("/project/packaging").first.text().should == "war"
+    end
+
+    it "adds the dependencies" do
+      dependency = Mvnizer::Project.new("junit", "junit", "4.8.2", "jar", [], "test")
+      project.add_dependency(dependency)
+      output = subject.generate(project)
+
+      doc = Nokogiri::XML(output)
+      doc.remove_namespaces!
+      doc.xpath("/project/dependencies/dependency/groupId").first.text().should == "junit"
+      doc.xpath("/project/dependencies/dependency/artifactId").first.text().should == "junit"
+      doc.xpath("/project/dependencies/dependency/version").first.text().should == "4.8.2"
+      doc.xpath("/project/dependencies/dependency/scope").first.text().should == "test"
+    end
+  end
+end

data/spec/mvnize_spec.rb

@@ -1,37 +1,51 @@
-require 'spec_helper'
-
-describe Mvnizer::Mvnize do
-  let(:generator) { double("generator") }
-  subject { Mvnizer::Mvnize.new(generator) }
-
-  before { FakeFS.activate! }
-
-  it "reads the configuration" do
-    options = { name: "foobar" }
-    generator.should_receive(:generate)
-    subject.should_receive(:conf).with(options).and_return(options)
-
-    subject.run(options)
-  end
-
-  it "creates the project directory" do
-    options = { name: "foobar" }
-    subject.should_receive(:conf).with(options).and_return(options)
-    generator.should_receive(:generate)
-    subject.run(options)
-
-    File.exists?("foobar/src/main/java").should be_true
-    File.exists?("foobar/src/test/java").should be_true
-  end
-
-  it "generates the pom file" do
-    options = { name: "foobar" }
-    subject.should_receive(:conf).with(options).and_return(options)
-    generator.should_receive(:generate).with(options)
-    subject.run(options)
-
-    File.exists?("foobar/pom.xml").should be_true
-  end
-
-  after { FakeFS.deactivate! }
-end
+require 'spec_helper'
+
+module Mvnizer
+  describe Mvnize do
+
+    let (:new_project) { double("new_project") }
+    subject { Mvnizer::Mvnize.new }
+
+    it "chooses what command to run depending on the options" do
+      options = {name: "quxbaz", command: "new"}
+      Command::ProjectFactory.should_receive(:create).and_return(new_project)
+      new_project.should_receive(:run).with(options)
+      subject.run(options)
+    end
+
+    it "throws an error when no name is given" do
+      lambda { subject.run(Hash.new) }.should raise_error(ArgumentError, "Please give a name to the project.")
+    end
+
+    it "displays a success message when done" do
+      Command::ProjectFactory.should_receive(:create).and_return(new_project)
+      new_project.should_receive(:run)
+# For some obscure reason, this does not work:
+#      $stdout.should_receive(:write).with("Project created successfully.")
+# It fails properly when message is incorrect:
+#   #<IO:0x774d4142> received :write with unexpected arguments
+#         expected: ("success")
+#              got: ("Project created successfully.")
+# But throws an error when the message is correct:
+# undefined method `write' for #<IO:fd 1>
+# So instead, I have to resort to adding an `out` instance variable in Mvnize:
+      string_io = StringIO.new
+      subject.out = string_io
+
+      subject.run(name: "quxbaz", command: "new")
+      string_io.string.should match(/success/i)
+    end
+
+    it "performs war tasks if name ends with :war" do
+      options = {name: "quxbaz:war", command: "new"}
+      Command::ProjectFactory.should_receive(:create).with("war").and_return(new_project)
+      new_project.should_receive(:run).with(options)
+      subject.run(options)
+    end
+    
+    it "throws an error if the command to run is not valid" do
+      lambda { subject.run(name: "quxbaz", command: "foobar") }.should raise_error(ArgumentError, "foobar is not a valid command.")
+    end
+
+  end
+end

data/spec/spec_helper.rb

@@ -1,11 +1,11 @@
-$:.unshift File.join(File.dirname(__FILE__), '..', 'lib')
-require 'mvnizer'
-require 'rspec/mocks'
-require 'rspec/expectations'
-require 'fakefs/safe'
-
-RSpec::Matchers.define :be_same_path_as do |expected|
-  match do |actual|
-    Pathname.new(expected).cleanpath == Pathname.new(actual).cleanpath
-  end
-end
+$:.unshift File.join(File.dirname(__FILE__), '..', 'lib')
+require 'mvnizer'
+require 'rspec/mocks'
+require 'rspec/expectations'
+require 'fakefs/safe'
+
+RSpec::Matchers.define :be_same_path_as do |expected|
+  match do |actual|
+    Pathname.new(expected).cleanpath == Pathname.new(actual).cleanpath
+  end
+end

metadata

@@ -2,14 +2,14 @@
 name: mvnizer
 version: !ruby/object:Gem::Version
   prerelease:
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Sébastien Le Callonnec
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2012-09-13 00:00:00.000000000 Z
+date: 2012-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -106,18 +106,34 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- TODO.md
 - bin/mvnizer
 - conf/default.yml
 - lib/mvnizer.rb
+- lib/mvnizer/commands.rb
+- lib/mvnizer/commands/new_project.rb
+- lib/mvnizer/commands/new_war_project.rb
+- lib/mvnizer/commands/project_factory.rb
 - lib/mvnizer/configuration.rb
+- lib/mvnizer/coordinate_parser.rb
 - lib/mvnizer/dir_creator.rb
+- lib/mvnizer/erb_helper.rb
 - lib/mvnizer/mvnize.rb
 - lib/mvnizer/pom_generator.rb
 - lib/mvnizer/project.rb
+- lib/mvnizer/templates/_dependency.xml.erb
 - lib/mvnizer/templates/pom.xml.erb
+- lib/mvnizer/templates/web.xml.erb
 - lib/mvnizer/version.rb
 - mvnizer.gemspec
+- ragel/coordinate.rb
+- ragel/coordinate.rl
+- ragel/test_coord.rb
+- spec/commands/new_project_spec.rb
+- spec/commands/new_war_project_spec.rb
+- spec/commands/project_factory_spec.rb
 - spec/configuration_spec.rb
+- spec/coordinate_parser_spec.rb
 - spec/dir_creator_spec.rb
 - spec/generator_spec.rb
 - spec/mvnize_spec.rb
@@ -133,11 +149,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
-      version: !binary |-
-        MA==
       segments:
       - 0
       hash: 2
+      version: !binary |-
+        MA==
   none: false
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: