mutations 0.7.1 → 0.7.2

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+0.7.2
+-----------
+
+- Bug fix: discards_empty broke on non-strings. Fix that.
+
 0.7.1
 -----------
 

data/lib/mutations/boolean_filter.rb

@@ -13,6 +13,9 @@ module Mutations
         return [nil, nil] if options[:nils]
         return [nil, :nils]
       end
+      
+      # Now check if it's empty:
+      return [data, :empty] if data == ""
 
       # If data is true or false, we win.
       return [data, nil] if data == true || data == false

data/lib/mutations/date_filter.rb

@@ -13,6 +13,9 @@ module Mutations
         return [nil, nil] if options[:nils]
         return [nil, :nils]
       end
+      
+      # Now check if it's empty:
+      return [data, :empty] if data == ""
 
       if data.is_a?(Date) # Date and DateTime
         actual_date = data

data/lib/mutations/file_filter.rb

@@ -13,6 +13,9 @@ module Mutations
         return [nil, nil] if options[:nils]
         return [nil, :nils]
       end
+      
+      # Now check if it's empty:
+      return [data, :empty] if data == ""
 
       # Ensure the data responds to each of the methods
       methods = [:read, :size]

data/lib/mutations/float_filter.rb

@@ -13,6 +13,9 @@ module Mutations
         return [nil, nil] if options[:nils]
         return [nil, :nils]
       end
+      
+      # Now check if it's empty:
+      return [data, :empty] if data == ""
 
       # Ensure it's the correct data type (Float)
       if !data.is_a?(Float)

data/lib/mutations/integer_filter.rb

@@ -1,10 +1,10 @@
 module Mutations
   class IntegerFilter < AdditionalFilter
     @default_options = {
-      :nils => false,       # true allows an explicit nil to be valid. Overrides any other options
-      :min => nil,          # lowest value, inclusive
-      :max => nil,          # highest value, inclusive
-      :in => nil            # Can be an array like %w(3 4 5)
+      :nils => false,          # true allows an explicit nil to be valid. Overrides any other options
+      :min => nil,             # lowest value, inclusive
+      :max => nil,             # highest value, inclusive
+      :in => nil,              # Can be an array like %w(3 4 5)
     }
 
     def filter(data)
@@ -14,6 +14,9 @@ module Mutations
         return [nil, nil] if options[:nils]
         return [nil, :nils]
       end
+      
+      # Now check if it's empty:
+      return [data, :empty] if data == ""
 
       # Ensure it's the correct data type (Fixnum)
       if !data.is_a?(Fixnum)

data/lib/mutations/version.rb

@@ -1,3 +1,3 @@
 module Mutations
-  VERSION = "0.7.1"
+  VERSION = "0.7.2"
 end

data/spec/boolean_filter_spec.rb

@@ -43,10 +43,16 @@ describe "Mutations::BooleanFilter" do
       assert_equal nil, errors
     end
   end
+  
+  it "considers empty strings to be empty" do
+    f = Mutations::BooleanFilter.new
+    filtered, errors = f.filter("")
+    assert_equal :empty, errors
+  end
 
   it "considers other string to be invalid" do
     f = Mutations::BooleanFilter.new
-    ["", "truely", "2"].each do |str|
+    ["truely", "2"].each do |str|
       filtered, errors = f.filter(str)
       assert_equal str, filtered
       assert_equal :boolean, errors

data/spec/date_filter_spec.rb

@@ -126,6 +126,12 @@ describe "Mutations::DateFilter" do
     assert_equal nil, filtered
     assert_equal :nils, errors
   end
+  
+  it "considers empty strings to be empty" do
+    f = Mutations::DateFilter.new
+    filtered, errors = f.filter("")
+    assert_equal :empty, errors
+  end
 
   it "allows the use of nil when specified" do
     f = Mutations::DateFilter.new(:nils => true)

data/spec/file_filter_spec.rb

@@ -60,6 +60,12 @@ describe "Mutations::FileFilter" do
     assert_equal nil, filtered
     assert_equal nil, errors
   end
+  
+  it "considers empty strings to be empty" do
+    f = Mutations::FileFilter.new
+    filtered, errors = f.filter("")
+    assert_equal :empty, errors
+  end
 
   it "should allow small files" do
     file = StringIO.new("bob")

data/spec/float_filter_spec.rb

@@ -65,6 +65,12 @@ describe "Mutations::FloatFilter" do
     assert_equal nil, filtered
     assert_equal nil, errors
   end
+  
+  it "considers empty strings to be empty" do
+    f = Mutations::FloatFilter.new
+    filtered, errors = f.filter("")
+    assert_equal :empty, errors
+  end
 
   it "considers low numbers invalid" do
     f = Mutations::FloatFilter.new(:min => 10)

data/spec/integer_filter_spec.rb

@@ -44,6 +44,12 @@ describe "Mutations::IntegerFilter" do
     assert_equal nil, filtered
     assert_equal nil, errors
   end
+  
+  it "considers empty strings to be empty" do
+    f = Mutations::IntegerFilter.new
+    filtered, errors = f.filter("")
+    assert_equal :empty, errors
+  end
 
   it "considers low numbers invalid" do
     f = Mutations::IntegerFilter.new(:min => 10)

metadata

@@ -1,32 +1,32 @@
 --- !ruby/object:Gem::Specification
 name: mutations
 version: !ruby/object:Gem::Version
-  version: 0.7.1
   prerelease: 
+  version: 0.7.2
 platform: ruby
 authors:
 - Jonathan Novak
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-26 00:00:00.000000000 Z
+date: 2013-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
-  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+  prerelease: false
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -36,29 +36,29 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '4'
   type: :development
-  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '4'
+  prerelease: false
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
-  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+  prerelease: false
 description: Compose your business logic into commands that sanitize and validate
   input.
 email: jnovak@gmail.com
@@ -120,18 +120,18 @@ require_paths:
 required_ruby_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Compose your business logic into commands that sanitize and validate input.