mutant 0.9.2 → 0.9.7

data/lib/mutant/license/subscription/opensource.rb

@@ -53,7 +53,7 @@ module Mutant
           world
             .capture_stdout(%w[git remote --verbose])
             .fmap(&method(:parse_remotes))
-            .apply(&method(:check_subscription))
+            .bind(&method(:check_subscription))
         end
 
       private

data/lib/mutant/meta.rb

@@ -10,14 +10,12 @@ module Mutant
     # Mutation example
     class Example
 
-      # rubocop:disable MutableConstant
+      # rubocop:disable Style/MutableConstant
       ALL = []
 
       # Add example
       #
       # @return [undefined]
-      #
-      # rubocop:disable Performance/Caller
       def self.add(*types, &block)
         file = caller.first.split(':in', 2).first
         ALL << DSL.call(file, Set.new(types), block)

data/lib/mutant/meta/example/verification.rb

@@ -61,7 +61,7 @@ module Mutant
         def invalid_syntax
           mutations.reject do |mutation|
             ::Parser::CurrentRuby.parse(mutation.source)
-          rescue ::Parser::SyntaxError # rubocop:disable Lint/HandleExceptions
+          rescue ::Parser::SyntaxError # rubocop:disable Lint/SuppressedException
           end
         end
         memoize :invalid_syntax

data/lib/mutant/mutator/node/generic.rb

@@ -12,30 +12,52 @@ module Mutant
           __LINE__
           alias
           arg_expr
+          array_pattern
+          array_pattern_with_tail
           back_ref
           blockarg
           blockarg_expr
+          case_match
           complex
+          const_pattern
+          def_e
+          defs_e
           eflipflop
           empty
+          empty_else
           ensure
+          find_pattern
           for
+          forward_arg
+          forward_args
+          forwarded_args
+          hash_pattern
           ident
+          if_guard
           iflipflop
+          in_match
+          in_pattern
           kwnilarg
           kwrestarg
           kwsplat
+          match_alt
+          match_as
+          match_nil_pattern
+          match_rest
+          match_var
           match_with_lvasgn
-          meth_ref
+          match_with_trailing_comma
           module
+          mrasgn
           numargs
           numblock
-          numparam
           objc_kwarg
           objc_restarg
           objc_varargs
+          pin
           postexe
           preexe
+          rasgn
           rational
           redo
           restarg
@@ -45,6 +67,7 @@ module Mutant
           sclass
           shadowarg
           undef
+          unless_guard
           until_post
           while_post
           xstr

data/lib/mutant/mutator/node/send.rb

@@ -5,7 +5,7 @@ module Mutant
     class Node
 
       # Namespace for send mutators
-      # rubocop:disable ClassLength
+      # rubocop:disable Metrics/ClassLength
       class Send < self
         include AST::Types
 

data/lib/mutant/parallel.rb

@@ -52,7 +52,7 @@ module Mutant
     # @param [Class] klass
     # @param [Config] config
     #
-    # @return [Mutant::Variable]
+    # @return [Variable]
     #
     # ignore :reek:LongParameterList
     def self.shared(klass, config, **attributes)

data/lib/mutant/reporter/cli/format.rb

@@ -5,7 +5,7 @@ module Mutant
     class CLI
       # CLI output format
       #
-      # rubocop:disable FormatString
+      # rubocop:disable Style/FormatString
       class Format
         include AbstractType, Concord.new(:tty)
 

data/lib/mutant/transform.rb

@@ -263,7 +263,7 @@ module Mutant
         PRIMITIVE
           .apply(input)
           .lmap(&method(:lift_error))
-          .apply(&method(:run))
+          .bind(&method(:run))
       end
 
     private
@@ -351,8 +351,8 @@ module Mutant
         PRIMITIVE
           .apply(input)
           .lmap(&method(:lift_error))
-          .apply(&method(:reject_keys))
-          .apply(&method(:transform))
+          .bind(&method(:reject_keys))
+          .bind(&method(:transform))
       end
 
     private
@@ -363,7 +363,7 @@ module Mutant
       #
       # @return [Either<Error, Hash>]
       def transform(input)
-        transform_required(input).apply do |required|
+        transform_required(input).bind do |required|
           transform_optional(input).fmap(&required.method(:merge))
         end
       end
@@ -503,7 +503,8 @@ module Mutant
       #
       # @return [Either<Error, Object>]
       def apply(input)
-        Either.wrap_error(error_class) { block.call(input) }
+        Either
+          .wrap_error(error_class) { block.call(input) }
           .lmap { |exception| error(input: input, message: exception.to_s) }
       end
     end # Exception

data/lib/mutant/version.rb

@@ -2,5 +2,5 @@
 
 module Mutant
   # Current mutant version
-  VERSION = '0.9.2'
+  VERSION = '0.9.7'
 end # Mutant

data/lib/mutant/warnings.rb

@@ -55,7 +55,7 @@ module Mutant
   # For that reason we do have to use the original method capture to dispatch
   # in disabled state.
   #
-  # :reek:ignore RepeatedConditional
+  # ignore :reek:RepeatedConditional
   class Warnings
     # Error raised when warning capture is used recursively
     class RecursiveUseError < RuntimeError; end

data/lib/mutant/zombifier.rb

@@ -17,7 +17,9 @@ module Mutant
 
     include AST::Sexp
 
+    # rubocop:disable Lint/InheritException
     LoadError = Class.new(::LoadError)
+    # rubocop:enable Lint/InheritException
 
     # Initialize object
     #

data/mutant.gemspec

@@ -7,8 +7,8 @@ Gem::Specification.new do |gem|
   gem.version     = Mutant::VERSION.dup
   gem.authors     = ['Markus Schirp']
   gem.email       = ['mbj@schirp-dso.com']
-  gem.description = 'Mutation testing for ruby'
-  gem.summary     = 'Mutation testing tool for ruby under MRI and Rubinius'
+  gem.description = 'Mutation Testing for Ruby.'
+  gem.summary     = ''
   gem.homepage    = 'https://github.com/mbj/mutant'
   gem.license     = 'Nonstandard'
 
@@ -21,20 +21,21 @@ Gem::Specification.new do |gem|
   gem.extra_rdoc_files = %w[LICENSE]
   gem.executables      = %w[mutant]
 
-  gem.add_runtime_dependency('abstract_type',  '~> 0.0.7')
-  gem.add_runtime_dependency('adamantium',     '~> 0.2.0')
-  gem.add_runtime_dependency('anima',          '~> 0.3.1')
-  gem.add_runtime_dependency('ast',            '~> 2.2')
-  gem.add_runtime_dependency('concord',        '~> 0.1.5')
-  gem.add_runtime_dependency('diff-lcs',       '~> 1.3')
-  gem.add_runtime_dependency('equalizer',      '~> 0.0.9')
-  gem.add_runtime_dependency('ice_nine',       '~> 0.11.1')
-  gem.add_runtime_dependency('memoizable',     '~> 0.4.2')
-  gem.add_runtime_dependency('mutant-license', '~> 0.1.0')
-  gem.add_runtime_dependency('parser',         '~> 2.6.5')
-  gem.add_runtime_dependency('procto',         '~> 0.0.2')
-  gem.add_runtime_dependency('unparser',       '~> 0.4.5')
+  gem.add_runtime_dependency('abstract_type', '~> 0.0.7')
+  gem.add_runtime_dependency('adamantium',    '~> 0.2.0')
+  gem.add_runtime_dependency('anima',         '~> 0.3.1')
+  gem.add_runtime_dependency('ast',           '~> 2.2')
+  gem.add_runtime_dependency('concord',       '~> 0.1.5')
+  gem.add_runtime_dependency('diff-lcs',      '= 1.3')
+  gem.add_runtime_dependency('equalizer',     '~> 0.0.9')
+  gem.add_runtime_dependency('ice_nine',      '~> 0.11.1')
+  gem.add_runtime_dependency('memoizable',    '~> 0.4.2')
+  gem.add_runtime_dependency('mprelude',      '~> 0.1.0')
+  gem.add_runtime_dependency('parser',        '~> 2.7.1')
+  gem.add_runtime_dependency('procto',        '~> 0.0.2')
+  gem.add_runtime_dependency('unparser',      '~> 0.4.6')
+  gem.add_runtime_dependency('variable',      '~> 0.0.1')
 
-  gem.add_development_dependency('devtools', '~> 0.1.23')
+  gem.add_development_dependency('devtools', '~> 0.1.25')
   gem.add_development_dependency('parallel', '~> 1.3')
 end

data/spec/integrations.yml

@@ -2,13 +2,14 @@
 - name: rubyspec
   namespace: Rubyspec
   repo_uri: 'https://github.com/ruby/rubyspec.git'
-  repo_ref: 'origin/master'
+  repo_ref: 249a36c2e9fcddbb208a0d618d05f6bd9a64fd17
   integration: mspec
   mutation_coverage: false
   mutation_generation: true
   exclude:
     - command_line/fixtures/bad_syntax.rb
     - command_line/fixtures/freeze_flag_required_diff_enc.rb
+    - core/file/stat_spec.rb
     - core/kernel/shared/sprintf_encoding.rb
     - core/module/fixtures/autoload_empty.rb
     - core/module/fixtures/autoload_never_set.rb
@@ -26,6 +27,7 @@
     - language/predefined/fixtures/data_only.rb
     - language/source_encoding_spec.rb
     - library/base64/decode64_spec.rb
+    - library/cgi/escapeHTML_spec.rb
     - security/cve_2010_1330_spec.rb
 - name: regexp_parser
   namespace: Regexp

data/spec/support/corpus.rb

@@ -10,7 +10,7 @@ module MutantSpec
 
   # Namespace module for corpus testing
   #
-  # rubocop:disable MethodLength
+  # rubocop:disable Metrics/MethodLength
   module Corpus
     TMP                 = ROOT.join('tmp').freeze
     EXCLUDE_GLOB_FORMAT = '{%s}'
@@ -22,7 +22,7 @@ module MutantSpec
     private_constant(*constants(false))
 
     # Project under corpus test
-    # rubocop:disable ClassLength
+    # rubocop:disable Metrics/ClassLength
     class Project
       MUTEX = Mutex.new
 
@@ -259,7 +259,7 @@ module MutantSpec
       #
       # @param [Array<String>] arguments
       #
-      # rubocop:disable GuardClause - guard clause without else does not make sense
+      # rubocop:disable Style/GuardClause - guard clause without else does not make sense
       def system(arguments)
         return if Kernel.system(*arguments)
 

data/spec/support/ruby_vm.rb

@@ -26,8 +26,7 @@ module MutantSpec
         super(DEFAULTS.merge(attributes))
       end
 
-      # rubocop:disable Naming/UncommunicativeMethodParamName
-      def handle(vm, observation)
+      def handle(vm, observation) # rubocop:disable Naming/MethodParameterName
         unless match?(observation)
           fail "Unexpected event observation: #{observation.inspect}, expected #{inspect}"
         end

data/spec/support/shared_context.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# rubocop:disable ModuleLength
+# rubocop:disable Metrics/ModuleLength
 module SharedContext
   # Prepend an anonymous module with the new `with` method
   #
@@ -25,8 +25,8 @@ module SharedContext
     end
   end
 
-  # rubocop:disable MethodLength
-  # rubocop:disable AbcSize
+  # rubocop:disable Metrics/MethodLength
+  # rubocop:disable Metrics/AbcSize
   def setup_shared_context
     let(:mutation_a)      { Mutant::Mutation::Evil.new(subject_a, mutation_a_node)   }
     let(:mutation_a_node) { s(:false)                                                }

data/spec/support/xspec.rb

@@ -93,7 +93,7 @@ module XSpec
   class MessageExpectation
     include Anima.new(:receiver, :selector, :arguments, :reaction)
 
-    # rubocop:disable ParameterLists
+    # rubocop:disable Metrics/ParameterLists
     def self.parse(receiver:, selector:, arguments: [], reaction: nil)
       new(
         receiver:  receiver,
@@ -152,7 +152,7 @@ module XSpec
       expectations.empty? or fail "unconsumed expectations:\n#{expectations.map(&:inspect).join("\n")}"
     end
 
-    # rubocop:disable MethodLength
+    # rubocop:disable Metrics/MethodLength
     def self.verify(rspec_context, expectations)
       verifier = new(expectations)
 

data/spec/unit/mutant/license_spec.rb

@@ -6,11 +6,13 @@ RSpec.describe Mutant::License do
   end
 
   let(:gem)              { class_double(Gem, loaded_specs: loaded_specs) }
+  let(:gem_method)       { instance_double(Method)                       }
   let(:gem_path)         { '/path/to/mutant-license'                     }
   let(:gem_pathname)     { instance_double(Pathname)                     }
   let(:json)             { class_double(JSON)                            }
   let(:kernel)           { class_double(Kernel)                          }
   let(:license_pathname) { instance_double(Pathname)                     }
+  let(:load_json)        { true                                          }
   let(:loaded_specs)     { { 'mutant-license' => spec }                  }
   let(:path)             { instance_double(Pathname)                     }
   let(:pathname)         { class_double(Pathname)                        }
@@ -26,15 +28,17 @@ RSpec.describe Mutant::License do
   let(:world) do
     instance_double(
       Mutant::World,
-      gem:      gem,
-      json:     json,
-      kernel:   kernel,
-      pathname: pathname,
-      stderr:   stderr
+      gem:        gem,
+      gem_method: gem_method,
+      json:       json,
+      kernel:     kernel,
+      pathname:   pathname,
+      stderr:     stderr
     )
   end
 
   before do
+    allow(gem_method).to receive_messages(call: undefined)
     allow(gem_pathname).to receive_messages(join: license_pathname)
     allow(json).to receive_messages(load: license_json)
     allow(kernel).to receive_messages(sleep: undefined)
@@ -66,6 +70,18 @@ RSpec.describe Mutant::License do
     it 'performs IO in expected sequence' do
       expect(apply).to eql(Mutant::Either::Right.new(true))
 
+      expect(gem_method)
+        .to have_received(:call)
+        .with('mutant-license', '~> 0.1.0')
+        .ordered
+
+      if load_json
+        expect(json)
+          .to have_received(:load)
+          .with(license_pathname)
+          .ordered
+      end
+
       expect(stderr)
         .to have_received(:puts)
         .with(expected)
@@ -73,12 +89,22 @@ RSpec.describe Mutant::License do
 
       expect(stderr)
         .to have_received(:puts)
-        .with('Soft fail, continuing in 10 seconds')
+        .with('[Mutant-License-Error]: Soft fail, continuing in 40 seconds')
+        .ordered
+
+      expect(stderr)
+        .to have_received(:puts)
+        .with('[Mutant-License-Error]: Next major version will enforce the license')
+        .ordered
+
+      expect(stderr)
+        .to have_received(:puts)
+        .with('[Mutant-License-Error]: See https://github.com/mbj/mutant#licensing')
         .ordered
 
       expect(kernel)
         .to have_received(:sleep)
-        .with(10)
+        .with(40)
         .ordered
     end
   end
@@ -253,5 +279,15 @@ RSpec.describe Mutant::License do
         [none]
       MESSAGE
     end
+
+    context 'when mutant-license gem cannot be loaded' do
+      let(:load_json) { false }
+
+      before do
+        allow(gem_method).to receive(:call).and_raise(Gem::LoadError, 'test-error')
+      end
+
+      it_fails_with_message '[Mutant-License-Error]: test-error'
+    end
   end
 end

data/spec/unit/mutant/parallel/driver_spec.rb

@@ -16,15 +16,15 @@ RSpec.describe Mutant::Parallel::Driver do
   end
 
   let(:var_active_jobs) do
-    instance_double(Mutant::Variable::IVar, 'active jobs')
+    instance_double(Variable::IVar, 'active jobs')
   end
 
   let(:var_final) do
-    instance_double(Mutant::Variable::IVar, 'final')
+    instance_double(Variable::IVar, 'final')
   end
 
   let(:var_sink) do
-    instance_double(Mutant::Variable::IVar, 'sink')
+    instance_double(Variable::IVar, 'sink')
   end
 
   subject do
@@ -64,7 +64,7 @@ RSpec.describe Mutant::Parallel::Driver do
           receiver:  var_final,
           selector:  :take_timeout,
           arguments: [timeout],
-          reaction:  { return: Mutant::Variable.const_get(:Result)::Timeout.new }
+          reaction:  { return: Variable.const_get(:Result)::Timeout.new }
         },
         {
           receiver: var_active_jobs,