mutant 0.9.2 → 0.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0b6a747b9980b4450831809ea2a799652f93dbd5be93ffe2a9ad25df314dddff
-  data.tar.gz: 2b72a0f6af97d24ab2191665e9be7d5975394348cc2b077d2f5efcb27fb38a89
+  metadata.gz: 88d8955c5d10cb6d884c519e2e9472affa627ab71377f73bd0746f8e27aea1d5
+  data.tar.gz: e4d07470181a24861d61e5f90a107fdcdc6da4f959392bf25c8bf6c8ce1e3628
 SHA512:
-  metadata.gz: f104307508a7c296b1b69f245394d0eef7f1991669a35b603aa8e4c21f5d9c205f509de519ae314e450c9cd57a879807d9b1778d84c822902fdafe9c68f8731a
-  data.tar.gz: a57dd99f21bfc48fa3a40f2fae04c8005f32c5615bc4509d30fafbc6f047c29a27b3eafa5f1de6329b9cb1b822a5fa72ee8ff8c8957b4bb45727204daa4ff56f
+  metadata.gz: 6906c7b02d2979d2f666735266a1c7220d75b6af35457ff54b021b3cf5306c1c4b94688eacfb685c46ee554353f91d6a78f6ac999e7535981f162e4b9d312a65
+  data.tar.gz: '059b7da0f47093ec1a7416fd1c3492f3eb01ccd3741796ff4f97ddbf597d2fd37c102c2bacfd5268204115efb6fc428088225d18785e22febfb49ba0d625710c'

data/Changelog.md

@@ -1,3 +1,9 @@
+# v0.9.3 2020-01-03
+
+* Change to soft dependency on mutant-license.
+  Rationale its fine to bundle mutant if not used.
+  This can easily happen on transitive dependencies.
+
 # v0.9.2 2020-01-02
 
 * Upgrade to parser ~> 2.6.5

data/Gemfile.lock

@@ -37,7 +37,7 @@ GIT
 PATH
   remote: .
   specs:
-    mutant (0.9.1)
+    mutant (0.9.3)
       abstract_type (~> 0.0.7)
       adamantium (~> 0.2.0)
       anima (~> 0.3.1)
@@ -47,7 +47,6 @@ PATH
       equalizer (~> 0.0.9)
       ice_nine (~> 0.11.1)
       memoizable (~> 0.4.2)
-      mutant-license (~> 0.1.0)
       parser (~> 2.6.5)
       procto (~> 0.0.2)
       unparser (~> 0.4.5)

data/lib/mutant.rb

@@ -22,8 +22,6 @@ require 'stringio'
 require 'unparser'
 require 'yaml'
 
-gem 'mutant-license'
-
 # This setting is done to make errors within the parallel
 # reporter / execution visible in the main thread.
 Thread.abort_on_exception = true
@@ -198,6 +196,7 @@ module Mutant
   WORLD = World.new(
     condition_variable: ConditionVariable,
     gem:                Gem,
+    gem_method:         method(:gem),
     io:                 IO,
     json:               JSON,
     kernel:             Kernel,

data/lib/mutant/config.rb

@@ -6,6 +6,7 @@ module Mutant
     include Adamantium::Flat, Anima.new(
       :condition_variable,
       :gem,
+      :gem_method,
       :io,
       :json,
       :kernel,

data/lib/mutant/license.rb

@@ -2,31 +2,58 @@
 
 module Mutant
   module License
+    NAME    = 'mutant-license'
+    VERSION = '~> 0.1.0'
+    SLEEP   = 20
+
+    UNLICENSED =
+      IceNine.deep_freeze(
+        [
+          "Soft fail, continuing in #{SLEEP} seconds",
+          'Next major version will enforce the license',
+          'See https://github.com/mbj/mutant#licensing'
+        ]
+      )
+
     def self.apply(world)
       soft_fail(world, license_result(world))
     end
 
     def self.license_result(world)
-      Subscription.from_json(world.json.load(license_path(world))).apply(world)
+      load_mutant_license(world)
+        .fmap { license_path(world) }
+        .fmap { |path| Subscription.from_json(world.json.load(path)) }
+        .apply { |sub| sub.apply(world) }
     end
     private_class_method :license_result
 
-    def self.soft_fail(world, license_result)
-      license_result.lmap do |message|
+    # ignore :reek:NestedIterators
+    def self.soft_fail(world, result)
+      result.lmap do |message|
         stderr = world.stderr
         stderr.puts(message)
-        stderr.puts('Soft fail, continuing in 10 seconds')
-        world.kernel.sleep(10)
+        UNLICENSED.each { |line| stderr.puts(unlicensed(line)) }
+        world.kernel.sleep(SLEEP)
       end
 
       Either::Right.new(true)
     end
     private_class_method :soft_fail
 
+    def self.load_mutant_license(world)
+      Either
+        .wrap_error(LoadError) { world.gem_method.call(NAME, VERSION) }
+        .lmap(&method(:unlicensed))
+    end
+
+    def self.unlicensed(message)
+      "[Mutant-License-Error]: #{message}"
+    end
+
     def self.license_path(world)
       world
         .pathname
-        .new(world.gem.loaded_specs.fetch('mutant-license').full_gem_path)
+        .new(world.gem.loaded_specs.fetch(NAME).full_gem_path)
         .join('license.json')
     end
     private_class_method :license_path

data/lib/mutant/version.rb

@@ -2,5 +2,5 @@
 
 module Mutant
   # Current mutant version
-  VERSION = '0.9.2'
+  VERSION = '0.9.3'
 end # Mutant

data/lib/mutant/warnings.rb

@@ -55,7 +55,7 @@ module Mutant
   # For that reason we do have to use the original method capture to dispatch
   # in disabled state.
   #
-  # :reek:ignore RepeatedConditional
+  # ignore :reek:RepeatedConditional
   class Warnings
     # Error raised when warning capture is used recursively
     class RecursiveUseError < RuntimeError; end

data/mutant.gemspec

@@ -7,8 +7,8 @@ Gem::Specification.new do |gem|
   gem.version     = Mutant::VERSION.dup
   gem.authors     = ['Markus Schirp']
   gem.email       = ['mbj@schirp-dso.com']
-  gem.description = 'Mutation testing for ruby'
-  gem.summary     = 'Mutation testing tool for ruby under MRI and Rubinius'
+  gem.description = 'Mutation Testing for Ruby.'
+  gem.summary     = ''
   gem.homepage    = 'https://github.com/mbj/mutant'
   gem.license     = 'Nonstandard'
 
@@ -30,7 +30,6 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency('equalizer',      '~> 0.0.9')
   gem.add_runtime_dependency('ice_nine',       '~> 0.11.1')
   gem.add_runtime_dependency('memoizable',     '~> 0.4.2')
-  gem.add_runtime_dependency('mutant-license', '~> 0.1.0')
   gem.add_runtime_dependency('parser',         '~> 2.6.5')
   gem.add_runtime_dependency('procto',         '~> 0.0.2')
   gem.add_runtime_dependency('unparser',       '~> 0.4.5')

data/spec/unit/mutant/license_spec.rb

@@ -6,11 +6,13 @@ RSpec.describe Mutant::License do
   end
 
   let(:gem)              { class_double(Gem, loaded_specs: loaded_specs) }
+  let(:gem_method)       { instance_double(Method)                       }
   let(:gem_path)         { '/path/to/mutant-license'                     }
   let(:gem_pathname)     { instance_double(Pathname)                     }
   let(:json)             { class_double(JSON)                            }
   let(:kernel)           { class_double(Kernel)                          }
   let(:license_pathname) { instance_double(Pathname)                     }
+  let(:load_json)        { true                                          }
   let(:loaded_specs)     { { 'mutant-license' => spec }                  }
   let(:path)             { instance_double(Pathname)                     }
   let(:pathname)         { class_double(Pathname)                        }
@@ -26,15 +28,17 @@ RSpec.describe Mutant::License do
   let(:world) do
     instance_double(
       Mutant::World,
-      gem:      gem,
-      json:     json,
-      kernel:   kernel,
-      pathname: pathname,
-      stderr:   stderr
+      gem:        gem,
+      gem_method: gem_method,
+      json:       json,
+      kernel:     kernel,
+      pathname:   pathname,
+      stderr:     stderr
     )
   end
 
   before do
+    allow(gem_method).to receive_messages(call: undefined)
     allow(gem_pathname).to receive_messages(join: license_pathname)
     allow(json).to receive_messages(load: license_json)
     allow(kernel).to receive_messages(sleep: undefined)
@@ -66,6 +70,18 @@ RSpec.describe Mutant::License do
     it 'performs IO in expected sequence' do
       expect(apply).to eql(Mutant::Either::Right.new(true))
 
+      expect(gem_method)
+        .to have_received(:call)
+        .with('mutant-license', '~> 0.1.0')
+        .ordered
+
+      if load_json
+        expect(json)
+          .to have_received(:load)
+          .with(license_pathname)
+          .ordered
+      end
+
       expect(stderr)
         .to have_received(:puts)
         .with(expected)
@@ -73,12 +89,22 @@ RSpec.describe Mutant::License do
 
       expect(stderr)
         .to have_received(:puts)
-        .with('Soft fail, continuing in 10 seconds')
+        .with('[Mutant-License-Error]: Soft fail, continuing in 20 seconds')
+        .ordered
+
+      expect(stderr)
+        .to have_received(:puts)
+        .with('[Mutant-License-Error]: Next major version will enforce the license')
+        .ordered
+
+      expect(stderr)
+        .to have_received(:puts)
+        .with('[Mutant-License-Error]: See https://github.com/mbj/mutant#licensing')
         .ordered
 
       expect(kernel)
         .to have_received(:sleep)
-        .with(10)
+        .with(20)
         .ordered
     end
   end
@@ -253,5 +279,15 @@ RSpec.describe Mutant::License do
         [none]
       MESSAGE
     end
+
+    context 'when mutant-license gem cannot be loaded' do
+      let(:load_json) { false }
+
+      before do
+        allow(gem_method).to receive(:call).and_raise(Gem::LoadError, 'test-error')
+      end
+
+      it_fails_with_message '[Mutant-License-Error]: test-error'
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mutant
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.9.3
 platform: ruby
 authors:
 - Markus Schirp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-02 00:00:00.000000000 Z
+date: 2020-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: abstract_type
@@ -136,20 +136,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.4.2
-- !ruby/object:Gem::Dependency
-  name: mutant-license
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.1.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.1.0
 - !ruby/object:Gem::Dependency
   name: parser
   requirement: !ruby/object:Gem::Requirement
@@ -220,7 +206,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
-description: Mutation testing for ruby
+description: Mutation Testing for Ruby.
 email:
 - mbj@schirp-dso.com
 executables:
@@ -630,7 +616,7 @@ requirements: []
 rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
-summary: Mutation testing tool for ruby under MRI and Rubinius
+summary: ''
 test_files:
 - spec/integration/mutant/corpus_spec.rb
 - spec/integration/mutant/isolation/fork_spec.rb