mutant 0.8.22 → 0.8.23

data/spec/unit/mutant/isolation/none_spec.rb

@@ -4,15 +4,20 @@ RSpec.describe Mutant::Isolation::None do
   describe '.call' do
     let(:object) { described_class.new }
 
-    it 'return block value' do
-      expect(object.call { :foo }).to be(:foo)
+    context 'without exception' do
+      it 'returns success result' do
+        expect(object.call { :foo })
+          .to eql(Mutant::Isolation::Result::Success.new(:foo))
+      end
     end
 
-    it 'wraps *all* exceptions' do
-      expect { object.call { fail 'foo' } }.to raise_error(
-        Mutant::Isolation::Error,
-        'foo'
-      )
+    context 'with exception' do
+      let(:exception) { RuntimeError.new('foo') }
+
+      it 'returns error result' do
+        expect(object.call { fail exception })
+          .to eql(Mutant::Isolation::Result::Exception.new(exception))
+      end
     end
   end
 end

data/spec/unit/mutant/isolation/result_spec.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+RSpec.describe Mutant::Isolation::Result do
+  describe '#success?' do
+    let(:value) { double('Object') }
+
+    def apply
+      effective_class.new(value).success?
+    end
+
+    context 'on success instance' do
+      let(:effective_class) { described_class::Success }
+
+      it 'returns true' do
+        expect(apply).to be(true)
+      end
+    end
+
+    context 'on error instance' do
+      let(:effective_class) { described_class::Exception }
+
+      it 'returns false' do
+        expect(apply).to be(false)
+      end
+    end
+  end
+
+  describe 'add_error' do
+    let(:other)  { described_class::Success.new(object) }
+    let(:value)  { double('Object')                     }
+    let(:object) { described_class::Success.new(value)  }
+
+    def apply
+      object.add_error(other)
+    end
+
+    it 'returns chain instance' do
+      expect(apply).to eql(described_class::ErrorChain.new(other, object))
+    end
+  end
+end

data/spec/unit/mutant/loader_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Mutant::Loader, '.call' do
     described_class.call(
       binding: binding,
       kernel:  kernel,
-      node:    node,
+      source:  source,
       subject: mutation_subject
     )
   end
@@ -27,10 +27,6 @@ RSpec.describe Mutant::Loader, '.call' do
   end
 
   it 'performs expected kernel interaction' do
-    expect(Unparser).to receive(:unparse)
-      .with(node)
-      .and_return(source)
-
     expect(kernel).to receive(:eval)
       .with(
         source,

data/spec/unit/mutant/mutation_spec.rb

@@ -26,8 +26,9 @@ RSpec.describe Mutant::Mutation do
   describe '#insert' do
     subject { object.insert(kernel) }
 
-    let(:root_node) { s(:foo)                 }
-    let(:kernel)    { instance_double(Kernel) }
+    let(:expected_source) { '1'                     }
+    let(:kernel)          { instance_double(Kernel) }
+    let(:root_node)       { s(:int, 1)              }
 
     before do
       expect(context).to receive(:root)
@@ -43,7 +44,7 @@ RSpec.describe Mutant::Mutation do
         .with(
           binding: TOPLEVEL_BINDING,
           kernel:  kernel,
-          node:    root_node,
+          source:  expected_source,
           subject: mutation_subject
         )
         .and_return(Mutant::Loader)

data/spec/unit/mutant/reporter/cli/printer/isolation_result_spec.rb

@@ -0,0 +1,124 @@
+# frozen_string_literal: true
+
+RSpec.describe Mutant::Reporter::CLI::Printer::IsolationResult do
+  setup_shared_context
+
+  describe '.call' do
+    context 'on sucessful isolation' do
+      let(:reportable) do
+        Mutant::Isolation::Result::Success.new(mutation_a_test_result)
+      end
+
+      it_reports <<~'STR'
+        - 1 @ runtime: 1.0
+          - test-a
+        Test Output:
+        mutation a test result output
+      STR
+    end
+
+    context 'on exception isolation error' do
+      let(:exception) do
+        Class.new(RuntimeError) do
+          def inspect
+            '<TestException>'
+          end
+
+          def backtrace
+            %w[first last]
+          end
+        end.new('foo')
+      end
+
+      let(:reportable) do
+        Mutant::Isolation::Result::Exception.new(exception)
+      end
+
+      it_reports <<~'STR'
+        Killing the mutation resulted in an integration error.
+        This is the case when the tests selected for the current mutation
+        did not produce a test result, but instead an exception was raised.
+
+        This may point to the following problems:
+        * Bug in mutant
+        * Bug in the ruby interpreter
+        * Bug in your test suite
+        * Bug in your test suite under concurrency
+
+        The following exception was raised:
+
+        ```
+        <TestException>
+        first
+        last
+        ```
+      STR
+    end
+
+    context 'on fork isolation error' do
+      let(:reportable) do
+        Mutant::Isolation::Fork::ForkError.new
+      end
+
+      it_reports <<~'STR'
+        Forking the child process to isolate the mutation in failed.
+        This meant that either the RubyVM or your OS was under too much
+        pressure to add another child process.
+
+        Possible solutions are:
+        * Reduce concurrency
+        * Reduce locks
+      STR
+    end
+
+    context 'on child isolation error' do
+      let(:reportable) do
+        Mutant::Isolation::Fork::ChildError.new(
+          instance_double(
+            Process::Status,
+            'unsuccessful status'
+          )
+        )
+      end
+
+      it_reports <<~'STR'
+        Killfork exited nonzero. Its result (if any) was ignored:
+        #<InstanceDouble(Process::Status) "unsuccessful status">
+      STR
+    end
+
+    context 'on child isolation error' do
+      let(:fork_error) do
+        Mutant::Isolation::Fork::ForkError.new
+      end
+
+      let(:child_error) do
+        Mutant::Isolation::Fork::ChildError.new(
+          instance_double(
+            Process::Status,
+            'unsuccessful status'
+          )
+        )
+      end
+
+      let(:reportable) do
+        Mutant::Isolation::Result::ErrorChain.new(
+          fork_error,
+          child_error
+        )
+      end
+
+      it_reports <<~'STR'
+        Forking the child process to isolate the mutation in failed.
+        This meant that either the RubyVM or your OS was under too much
+        pressure to add another child process.
+
+        Possible solutions are:
+        * Reduce concurrency
+        * Reduce locks
+        Killfork exited nonzero. Its result (if any) was ignored:
+        #<InstanceDouble(Process::Status) "unsuccessful status">
+      STR
+    end
+  end
+end

data/spec/unit/mutant/reporter/cli/printer/mutation_result_spec.rb

@@ -6,7 +6,27 @@ RSpec.describe Mutant::Reporter::CLI::Printer::MutationResult do
   let(:reportable) { mutation_a_result }
 
   describe '.call' do
-    context 'failed kill' do
+    context 'isolation problem' do
+      let(:status) do
+        instance_double(Process::Status)
+      end
+
+      let(:mutation_a_isolation_result) do
+        Mutant::Isolation::Fork::ChildError.new(status)
+      end
+
+      it_reports(<<~'REPORT')
+        evil:subject-a:d27d2
+        @@ -1,2 +1,2 @@
+        -true
+        +false
+        Killfork exited nonzero. Its result (if any) was ignored:
+        #<InstanceDouble(Process::Status) (anonymous)>
+        -----------------------
+      REPORT
+    end
+
+    context 'unsucessful result' do
       with(:mutation_a_test_result) { { passed: true } }
 
       context 'on evil mutation' do
@@ -80,11 +100,6 @@ RSpec.describe Mutant::Reporter::CLI::Printer::MutationResult do
           s(:true)
           Unparsed Source:
           true
-          Test Result:
-          - 1 @ runtime: 1.0
-            - test-a
-          Test Output:
-          mutation a test result output
           -----------------------
         REPORT
       end
@@ -101,11 +116,6 @@ RSpec.describe Mutant::Reporter::CLI::Printer::MutationResult do
           ---- Noop failure -----
           No code was inserted. And the test did NOT PASS.
           This is typically a problem of your specs not passing unmutated.
-          Test Result:
-          - 1 @ runtime: 1.0
-            - test-a
-          Test Output:
-          mutation a test result output
           -----------------------
         REPORT
       end

data/spec/unit/mutant/result/env_spec.rb

@@ -5,13 +5,16 @@ RSpec.describe Mutant::Result::Env do
     described_class.new(
       runtime:         instance_double(Float),
       env:             env,
-      subject_results: [subject_result]
+      subject_results: subject_results
     )
   end
 
+  let(:subject_results) { [subject_result] }
+
   let(:env) do
     instance_double(
       Mutant::Env,
+      config:    instance_double(Mutant::Config, fail_fast: fail_fast),
       subjects:  [instance_double(Mutant::Subject)],
       mutations: [instance_double(Mutant::Mutation)]
     )
@@ -22,12 +25,14 @@ RSpec.describe Mutant::Result::Env do
       Mutant::Result::Subject,
       amount_mutation_results: results,
       amount_mutations_killed: killed,
-      success?:                true
+      success?:                subject_success?
     )
   end
 
-  let(:results) { 1 }
-  let(:killed)  { 0 }
+  let(:fail_fast)        { false }
+  let(:killed)           { 0     }
+  let(:results)          { 1     }
+  let(:subject_success?) { true }
 
   describe '#success?' do
     subject { object.success? }
@@ -81,4 +86,46 @@ RSpec.describe Mutant::Result::Env do
 
     it { should eql(1) }
   end
+
+  describe '#stop?' do
+    subject { object.stop? }
+
+    context 'without fail fast' do
+      context 'on empty subjects' do
+        let(:subject_results) { [] }
+
+        it { should be(false) }
+      end
+
+      context 'on failed subject' do
+        let(:subject_success?) { false }
+
+        it { should be(false) }
+      end
+
+      context 'on successful subject' do
+        it { should be(false) }
+      end
+    end
+
+    context 'with fail fast' do
+      let(:fail_fast) { true }
+
+      context 'on empty subjects' do
+        let(:subject_results) { [] }
+
+        it { should be(false) }
+      end
+
+      context 'on failed subject' do
+        let(:subject_success?) { false }
+
+        it { should be(true) }
+      end
+
+      context 'on successful subject' do
+        it { should be(false) }
+      end
+    end
+  end
 end

data/spec/unit/mutant/result/mutation_spec.rb

@@ -3,8 +3,9 @@
 RSpec.describe Mutant::Result::Mutation do
   let(:object) do
     described_class.new(
-      mutation:    mutation,
-      test_result: test_result
+      isolation_result: isolation_result,
+      mutation:         mutation,
+      runtime:          2.0
     )
   end
 
@@ -17,23 +18,53 @@ RSpec.describe Mutant::Result::Mutation do
     )
   end
 
+  let(:isolation_result) do
+    Mutant::Isolation::Result::Success.new(test_result)
+  end
+
+  shared_examples_for 'unsuccessful isolation' do
+    let(:isolation_result) do
+      Mutant::Isolation::Result::Exception.new(RuntimeError.new('foo'))
+    end
+  end
+
+  describe '#killtime' do
+    subject { object.killtime }
+
+    context 'if isolation is successful' do
+      it { should eql(1.0) }
+    end
+
+    context 'if isolation is not successful' do
+      include_context 'unsuccessful isolation'
+
+      it { should eql(0.0) }
+    end
+  end
+
   describe '#runtime' do
     subject { object.runtime }
 
-    it { should eql(1.0) }
+    it { should eql(2.0) }
   end
 
   describe '#success?' do
     subject { object.success? }
 
-    let(:result) { double('result boolean') }
+    context 'if isolation is successful' do
+      before do
+        expect(mutation.class).to receive(:success?)
+          .with(test_result)
+          .and_return(true)
+      end
 
-    before do
-      expect(mutation.class).to receive(:success?)
-        .with(test_result)
-        .and_return(result)
+      it { should be(true) }
     end
 
-    it { should be(result) }
+    context 'if isolation is not successful' do
+      include_context 'unsuccessful isolation'
+
+      it { should be(false) }
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mutant
 version: !ruby/object:Gem::Version
-  version: 0.8.22
+  version: 0.8.23
 platform: ruby
 authors:
 - Markus Schirp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-04 00:00:00.000000000 Z
+date: 2018-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: abstract_type
@@ -412,6 +412,7 @@ files:
 - lib/mutant/reporter/cli/printer/config.rb
 - lib/mutant/reporter/cli/printer/env_progress.rb
 - lib/mutant/reporter/cli/printer/env_result.rb
+- lib/mutant/reporter/cli/printer/isolation_result.rb
 - lib/mutant/reporter/cli/printer/mutation_progress_result.rb
 - lib/mutant/reporter/cli/printer/mutation_result.rb
 - lib/mutant/reporter/cli/printer/status.rb
@@ -570,6 +571,7 @@ files:
 - spec/unit/mutant/integration_spec.rb
 - spec/unit/mutant/isolation/fork_spec.rb
 - spec/unit/mutant/isolation/none_spec.rb
+- spec/unit/mutant/isolation/result_spec.rb
 - spec/unit/mutant/loader_spec.rb
 - spec/unit/mutant/matcher/chain_spec.rb
 - spec/unit/mutant/matcher/compiler/subject_prefix_spec.rb
@@ -600,6 +602,7 @@ files:
 - spec/unit/mutant/reporter/cli/printer/config_spec.rb
 - spec/unit/mutant/reporter/cli/printer/env_progress_spec.rb
 - spec/unit/mutant/reporter/cli/printer/env_result_spec.rb
+- spec/unit/mutant/reporter/cli/printer/isolation_result_spec.rb
 - spec/unit/mutant/reporter/cli/printer/mutation_progress_result_spec.rb
 - spec/unit/mutant/reporter/cli/printer/mutation_result_spec.rb
 - spec/unit/mutant/reporter/cli/printer/status_progressive_spec.rb
@@ -659,7 +662,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.0.beta2
 signing_key: 
 specification_version: 4
 summary: Mutation testing tool for ruby under MRI and Rubinius
@@ -704,6 +707,7 @@ test_files:
 - spec/unit/mutant/integration_spec.rb
 - spec/unit/mutant/isolation/fork_spec.rb
 - spec/unit/mutant/isolation/none_spec.rb
+- spec/unit/mutant/isolation/result_spec.rb
 - spec/unit/mutant/loader_spec.rb
 - spec/unit/mutant/matcher/chain_spec.rb
 - spec/unit/mutant/matcher/compiler/subject_prefix_spec.rb
@@ -734,6 +738,7 @@ test_files:
 - spec/unit/mutant/reporter/cli/printer/config_spec.rb
 - spec/unit/mutant/reporter/cli/printer/env_progress_spec.rb
 - spec/unit/mutant/reporter/cli/printer/env_result_spec.rb
+- spec/unit/mutant/reporter/cli/printer/isolation_result_spec.rb
 - spec/unit/mutant/reporter/cli/printer/mutation_progress_result_spec.rb
 - spec/unit/mutant/reporter/cli/printer/mutation_result_spec.rb
 - spec/unit/mutant/reporter/cli/printer/status_progressive_spec.rb