mutant 0.8.20 → 0.8.21

data/mutant.gemspec

@@ -36,9 +36,8 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency('parser',        '~> 2.5.1')
   gem.add_runtime_dependency('procto',        '~> 0.0.2')
   gem.add_runtime_dependency('regexp_parser', '~> 1.2')
-  gem.add_runtime_dependency('unparser',      '~> 0.3.0')
+  gem.add_runtime_dependency('unparser',      '~> 0.4.1')
 
-  gem.add_development_dependency('bundler',  '~> 1.10')
-  gem.add_development_dependency('devtools', '~> 0.1.21')
+  gem.add_development_dependency('devtools', '~> 0.1.22')
   gem.add_development_dependency('parallel', '~> 1.3')
 end

data/spec/spec_helper.rb

@@ -44,7 +44,7 @@ module ParserHelper
   end
 
   def parse(string)
-    Unparser::Preprocessor.run(Parser::CurrentRuby.parse(string))
+    Unparser::Preprocessor.run(Unparser.parse(string))
   end
 
   def parse_expression(string)

data/spec/support/corpus.rb

@@ -87,7 +87,7 @@ module MutantSpec
           in_processes: parallel_processes
         }
 
-        total = Parallel.map(effective_ruby_paths, options, &method(:count_mutations_and_check_errors))
+        total = Parallel.map(effective_ruby_paths, options, &method(:check_generation))
           .inject(DEFAULT_MUTATION_COUNT, :+)
 
         took = Mutant::Timer.now - start
@@ -129,33 +129,49 @@ module MutantSpec
       # @param path [Pathname] path responsible for exception
       #
       # @return [Integer] mutations generated
-      def count_mutations_and_check_errors(path)
+      def check_generation(path)
         relative_path = path.relative_path_from(repo_path)
 
-        count = count_mutations(path)
+        node = Parser::CurrentRuby.parse(path.read)
+        fail "Cannot parse: #{path}" unless node
+
+        mutations = Mutant::Mutator.mutate(node)
+
+        mutations.each do |mutation|
+          check_generation_invariants(node, mutation)
+        end
 
         expected_errors.assert_success(relative_path)
 
-        count
+        mutations.length
       rescue Exception => exception # rubocop:disable Lint/RescueException
         expected_errors.assert_error(relative_path, exception)
 
         DEFAULT_MUTATION_COUNT
       end
 
-      # Count mutations generated for provided source file
+      # Check generation invariants
       #
-      # @param path [Pathname] path to a source file
+      # @param [Parser::AST::Node] original
+      # @param [Parser::AST::Node] mutation
       #
-      # @raise [Exception] any error specified by integrations.yml
+      # @return [undefined]
       #
-      # @return [Integer] number of mutations generated
-      def count_mutations(path)
-        node = Parser::CurrentRuby.parse(path.read)
+      # @raise [Exception]
+      def check_generation_invariants(original, mutation)
+        return unless ENV['MUTANT_CORPUS_EXPENSIVE']
+
+        original_source = Unparser.unparse(original)
+        mutation_source = Unparser.unparse(mutation)
 
-        return DEFAULT_MUTATION_COUNT unless node
+        Mutant::Diff.build(original_source, mutation_source) and return
 
-        Mutant::Mutator.mutate(node).length
+        fail Mutant::Reporter::CLI::NO_DIFF_MESSAGE % [
+          original_source,
+          original.inspect,
+          mutation_source,
+          mutation.inspect
+        ]
       end
 
       # Install mutant

data/spec/unit/mutant/ast/meta/send/proc_predicate_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe Mutant::AST::Meta::Send, '#proc?' do
   subject { described_class.new(node).proc? }
 
   shared_context 'proc send' do |source|
-    let(:node) { Parser::CurrentRuby.parse(source).children.first }
+    let(:node) { Unparser.parse(source).children.first }
   end
 
   shared_examples 'proc definition' do |*args|

data/spec/unit/mutant/ast/meta/send/receiver_possible_top_level_const_predicate_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe Mutant::AST::Meta::Send, '#receiver_possible_top_level_const?' do
   subject { described_class.new(node).receiver_possible_top_level_const? }
 
   def parse(source)
-    Parser::CurrentRuby.parse(source)
+    Unparser.parse(source)
   end
 
   context 'when implicit top level const' do

data/spec/unit/mutant/ast/meta/send_spec.rb

@@ -4,24 +4,22 @@ RSpec.describe Mutant::AST::Meta::Send do
   let(:object) { described_class.new(node) }
 
   def parse(source)
-    Parser::CurrentRuby.parse(source)
+    Unparser.parse(source)
   end
 
   let(:method_call)            { parse('foo.bar(baz)')  }
   let(:attribute_read)         { parse('foo.bar')       }
-  let(:index_assignment)       { parse('foo[0] = bar')  }
   let(:attribute_assignment)   { parse('foo.bar = baz') }
   let(:binary_method_operator) { parse('foo == bar')    }
 
   class Expectation
-    include Adamantium, Anima.new(:name, :assignment, :attribute_assignment, :index_assignment, :binary_method_operator)
+    include Adamantium, Anima.new(:name, :attribute_assignment, :binary_method_operator)
 
     ALL = [
-      [:method_call,            false, false, false, false],
-      [:attribute_read,         false, false, false, false],
-      [:index_assignment,       true,  false, true,  false],
-      [:attribute_assignment,   true,  true,  false, false],
-      [:binary_method_operator, false, false, false, true]
+      [:method_call,            false, false],
+      [:attribute_read,         false, false],
+      [:attribute_assignment,   true,  false],
+      [:binary_method_operator, false, true]
     ].map do |values|
       new(Hash[anima.attribute_names.zip(values)])
     end.freeze

data/spec/unit/mutant/meta/example/dsl_spec.rb

@@ -2,19 +2,19 @@
 
 RSpec.describe Mutant::Meta::Example::DSL do
   describe '.call' do
-    subject { described_class.call(file, type, block) }
+    subject { described_class.call(file, types, block) }
 
-    let(:file)     { 'foo.rb'  }
-    let(:node)     { s(:false) }
-    let(:type)     { node.type }
-    let(:expected) { []        }
+    let(:file)     { 'foo.rb'             }
+    let(:node)     { s(:false)            }
+    let(:types)    { Set.new([node.type]) }
+    let(:expected) { []                   }
 
     let(:expected_example) do
       Mutant::Meta::Example.new(
-        file:      file,
-        node:      node,
-        node_type: type,
-        expected:  expected
+        file:     file,
+        node:     node,
+        types:    types,
+        expected: expected
       )
     end
 

data/spec/unit/mutant/meta/example/verification_spec.rb

@@ -5,10 +5,10 @@ RSpec.describe Mutant::Meta::Example::Verification do
 
   let(:example) do
     Mutant::Meta::Example.new(
-      file:      'foo.rb',
-      node:      s(:true),
-      node_type: :true,
-      expected:  expected_nodes
+      file:     'foo.rb',
+      node:     s(:true),
+      types:    [:true],
+      expected: expected_nodes
     )
   end
 
@@ -75,6 +75,7 @@ RSpec.describe Mutant::Meta::Example::Verification do
           - node: s(:nil)
             source: nil
           unexpected: []
+          invalid_syntax: []
           no_diff: []
         REPORT
       end
@@ -95,6 +96,7 @@ RSpec.describe Mutant::Meta::Example::Verification do
             source: 'false'
           - node: s(:nil)
             source: nil
+          invalid_syntax: []
           no_diff: []
         REPORT
       end
@@ -112,11 +114,41 @@ RSpec.describe Mutant::Meta::Example::Verification do
           original_source: 'true'
           missing: []
           unexpected: []
+          invalid_syntax: []
           no_diff:
           - node: s(:true)
             source: 'true'
         REPORT
       end
     end
+
+    context 'when the generated node is invalid syntax after unparsed' do
+      let(:invalid_node) do
+        s(:op_asgn, s(:send, s(:self), :at, s(:int, 1)), :+, s(:int, 1))
+      end
+
+      let(:expected_nodes)  { [invalid_node] }
+      let(:generated_nodes) { [invalid_node] }
+
+      specify do
+        should eql(<<~'REPORT')
+          ---
+          file: foo.rb
+          original_ast: s(:true)
+          original_source: 'true'
+          missing: []
+          unexpected: []
+          invalid_syntax:
+          - node: |-
+              s(:op_asgn,
+                s(:send,
+                  s(:self), :at,
+                  s(:int, 1)), :+,
+                s(:int, 1))
+            source: self.at(1) += 1
+          no_diff: []
+        REPORT
+      end
+    end
   end
 end

data/spec/unit/mutant/meta/example_spec.rb

@@ -3,10 +3,10 @@
 RSpec.describe Mutant::Meta::Example do
   let(:object) do
     described_class.new(
-      file:      file,
-      node:      node,
-      node_type: node.type,
-      expected:  mutation_nodes
+      file:     file,
+      node:     node,
+      types:    [node.type],
+      expected: mutation_nodes
     )
   end
 

data/spec/unit/mutant/mutator/node_spec.rb

@@ -1,15 +1,20 @@
 # frozen_string_literal: true
 
-Mutant::Meta::Example::ALL.each.group_by(&:node_type).each do |type, examples|
-  RSpec.describe Mutant::Mutator::REGISTRY.lookup(type) do
-    toplevel_nodes = examples.map { |example| example.node.type }.uniq
+aggregate = Hash.new { |hash, key| hash[key] = [] }
 
-    it "generates the correct mutations on #{toplevel_nodes} toplevel examples" do
+Mutant::Meta::Example::ALL
+  .each_with_object(aggregate) do |example, agg|
+    example.types.each do |type|
+      agg[Mutant::Mutator::REGISTRY.lookup(type)] << example
+    end
+  end
+
+aggregate.each do |mutator, examples|
+  RSpec.describe mutator do
+    it 'generates expected mutations' do
       examples.each do |example|
         verification = example.verification
-        unless verification.success?
-          fail verification.error_report
-        end
+        fail verification.error_report unless verification.success?
       end
     end
   end

data/spec/unit/mutant/reporter/cli/printer/mutation_result_spec.rb

@@ -48,7 +48,9 @@ RSpec.describe Mutant::Reporter::CLI::Printer::MutationResult do
           it_reports(<<~REPORT)
             evil:subject-a:a5bc7
             --- Internal failure ---
-            BUG: Mutation NOT resulted in exactly one diff hunk. Please report a reproduction!
+            BUG: A generted mutation did not result in exactly one diff hunk!
+            This is an invariant violation by the mutation generation engine.
+            Please report a reproduction to https://github.com/mbj/mutant
             Original unparsed source:
             super
             Original AST:

data/spec/unit/mutant/subject_spec.rb

@@ -19,7 +19,7 @@ RSpec.describe Mutant::Subject do
   let(:object) { class_under_test.new(context, node) }
 
   let(:node) do
-    Parser::CurrentRuby.parse(<<-RUBY)
+    Unparser.parse(<<-RUBY)
       def foo
       end
     RUBY

data/spec/unit/mutant/zombifier_spec.rb

@@ -80,7 +80,7 @@ RSpec.describe Mutant::Zombifier do
   let(:file_entries) do
     {
       'a/project.rb' => { file: true, contents: 'module Project; end' },
-      'b/bar.rb' =>     { file: true, contents: 'module Bar; end'     }
+      'b/bar.rb'     => { file: true, contents: 'module Bar; end'     }
     }
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mutant
 version: !ruby/object:Gem::Version
-  version: 0.8.20
+  version: 0.8.21
 platform: ruby
 authors:
 - Markus Schirp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-27 00:00:00.000000000 Z
+date: 2018-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: abstract_type
@@ -198,42 +198,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: 0.4.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.0
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.10'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.10'
+        version: 0.4.1
 - !ruby/object:Gem::Dependency
   name: devtools
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.21
+        version: 0.1.22
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.21
+        version: 0.1.22
 - !ruby/object:Gem::Dependency
   name: parallel
   requirement: !ruby/object:Gem::Requirement
@@ -272,8 +258,6 @@ files:
 - Rakefile
 - bin/mutant
 - config/devtools.yml
-- config/flay.yml
-- config/flog.yml
 - config/reek.yml
 - config/rubocop.yml
 - config/triage.yml
@@ -367,6 +351,7 @@ files:
 - lib/mutant/mutator/node/dsym.rb
 - lib/mutant/mutator/node/generic.rb
 - lib/mutant/mutator/node/if.rb
+- lib/mutant/mutator/node/index.rb
 - lib/mutant/mutator/node/kwbegin.rb
 - lib/mutant/mutator/node/literal.rb
 - lib/mutant/mutator/node/literal/array.rb
@@ -390,6 +375,7 @@ files:
 - lib/mutant/mutator/node/nthref.rb
 - lib/mutant/mutator/node/op_asgn.rb
 - lib/mutant/mutator/node/or_asgn.rb
+- lib/mutant/mutator/node/procarg_zero.rb
 - lib/mutant/mutator/node/regexp.rb
 - lib/mutant/mutator/node/regexp/alternation_meta.rb
 - lib/mutant/mutator/node/regexp/capture_group.rb
@@ -405,7 +391,6 @@ files:
 - lib/mutant/mutator/node/send/attribute_assignment.rb
 - lib/mutant/mutator/node/send/binary.rb
 - lib/mutant/mutator/node/send/conditional.rb
-- lib/mutant/mutator/node/send/index.rb
 - lib/mutant/mutator/node/splat.rb
 - lib/mutant/mutator/node/super.rb
 - lib/mutant/mutator/node/when.rb
@@ -483,12 +468,15 @@ files:
 - meta/gvasgn.rb
 - meta/hash.rb
 - meta/if.rb
+- meta/index.rb
+- meta/indexasgn.rb
 - meta/int.rb
 - meta/ivar.rb
 - meta/ivasgn.rb
 - meta/kwarg.rb
 - meta/kwbegin.rb
 - meta/kwoptarg.rb
+- meta/lambda.rb
 - meta/lvar.rb
 - meta/lvasgn.rb
 - meta/masgn.rb
@@ -671,7 +659,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Mutation testing tool for ruby under MRI and Rubinius

data/config/flay.yml

@@ -1,3 +0,0 @@
----
-threshold: 16
-total_score: 1395

data/config/flog.yml

@@ -1,2 +0,0 @@
----
-threshold: 27.7