mutant 0.8.0 → 0.8.1

data/lib/mutant/version.rb

@@ -1,4 +1,4 @@
 module Mutant
-  # The current mutant version
-  VERSION = '0.8.0'.freeze
+  # Current mutant version
+  VERSION = '0.8.1'.freeze
 end # Mutant

data/lib/mutant/warning_filter.rb

@@ -12,28 +12,25 @@ module Mutant
     # @return [undefined]
     #
     # @api private
-    #
     def initialize(target)
       @target   = target
       @warnings = []
     end
 
-    # Return filtered warnings
+    # Warnings captured by filter
     #
     # @return [Array<String>]
     #
     # @api private
-    #
     attr_reader :warnings
 
-    # Return target
+    # Target stream to capture warnings on
     #
     # @return [#write] target
     #
     # @return [undefined]
     #
     # @api private
-    #
     attr_reader :target
     protected :target
 
@@ -44,7 +41,6 @@ module Mutant
     # @return [self]
     #
     # @api private
-    #
     def write(message)
       if WARNING_PATTERN =~ message
         warnings << message
@@ -60,7 +56,6 @@ module Mutant
     # @return [Array<String>]
     #
     # @api private
-    #
     def self.use
       original = $stderr
       $stderr = filter = new(original)

data/lib/mutant/zombifier.rb

@@ -22,13 +22,17 @@ module Mutant
     # @return [undefined]
     #
     # @api private
-    #
     def initialize(*)
       super
       @includes = %r{\A#{Regexp.union(includes)}(?:/.*)?\z}
       @zombified = Set.new
     end
 
+    # Call zombifier
+    #
+    # @return [self]
+    #
+    # @api private
     def self.call(*args)
       new(*args).__send__(:call)
       self
@@ -41,7 +45,6 @@ module Mutant
     # @return [undefined]
     #
     # @api private
-    #
     def call
       @original = require_highjack.call(method(:require))
       require(root_require)
@@ -52,7 +55,6 @@ module Mutant
     # @param [String]
     #
     # @api private
-    #
     def include?(logical_name)
       !@zombified.include?(logical_name) && @includes =~ logical_name
     end
@@ -64,7 +66,6 @@ module Mutant
     # @return [undefined]
     #
     # @api private
-    #
     def require(logical_name)
       logical_name = logical_name.to_s
       @original.call(logical_name)
@@ -83,7 +84,6 @@ module Mutant
     #   otherwise
     #
     # @api private
-    #
     def find(logical_name)
       file_name = "#{logical_name}.rb"
 
@@ -104,9 +104,6 @@ module Mutant
     # @return [undefined]
     #
     # @api private
-    #
-    # rubocop:disable Lint/Eval
-    #
     def zombify(source_path)
       kernel.eval(
         Unparser.unparse(namespaced_node(source_path)),
@@ -115,14 +112,13 @@ module Mutant
       )
     end
 
-    # Return namespaced root
+    # Namespaced root node
     #
     # @param [Symbol] namespace
     #
     # @return [Parser::AST::Node]
     #
     # @api private
-    #
     def namespaced_node(source_path)
       s(:module, s(:const, nil, namespace), Parser::CurrentRuby.parse(source_path.read))
     end

data/meta/send.rb

@@ -367,6 +367,8 @@ Mutant::Meta::Example.add do
   mutation '1'
   mutation 'foo'
   mutation 'foo[]'
+  mutation 'foo.at(1)'
+  mutation 'foo.fetch(1)'
   mutation 'self[1]'
   mutation 'foo[0]'
   mutation 'foo[2]'
@@ -380,6 +382,8 @@ Mutant::Meta::Example.add do
 
   singleton_mutations
   mutation 'self.foo'
+  mutation 'self.foo.at()'
+  mutation 'self.foo.fetch()'
   mutation 'self[]'
   mutation 'foo[]'
 end
@@ -391,6 +395,8 @@ Mutant::Meta::Example.add do
   mutation 'self[self]'
   mutation 'self[nil]'
   mutation 'self[]'
+  mutation 'self.at(foo)'
+  mutation 'self.fetch(foo)'
   mutation 'foo'
 end
 
@@ -400,6 +406,8 @@ Mutant::Meta::Example.add do
   singleton_mutations
   mutation 'foo'
   mutation 'foo[]'
+  mutation 'foo.at(*bar)'
+  mutation 'foo.fetch(*bar)'
   mutation 'foo[nil]'
   mutation 'foo[self]'
   mutation 'foo[bar]'

data/spec/spec_helper.rb

@@ -35,7 +35,7 @@ require 'test_app'
 module Fixtures
   TEST_CONFIG = Mutant::Config::DEFAULT.update(reporter: Mutant::Reporter::Trace.new)
   TEST_CACHE  = Mutant::Cache.new
-  TEST_ENV    = Mutant::Env::Bootstrap.call(TEST_CONFIG, TEST_CACHE)
+  TEST_ENV    = Mutant::Env::Bootstrap.(TEST_CONFIG, TEST_CACHE)
 end # Fixtures
 
 module ParserHelper
@@ -46,6 +46,10 @@ module ParserHelper
   def parse(string)
     Unparser::Preprocessor.run(Parser::CurrentRuby.parse(string))
   end
+
+  def parse_expression(string)
+    Mutant::Config::DEFAULT.expression_parser.(string)
+  end
 end
 
 module MessageHelper

data/spec/support/corpus.rb

@@ -31,6 +31,7 @@ module MutantSpec
       #
       # @raise [Exception]
       #
+      # @api private
       def verify_mutation_coverage
         checkout
         Dir.chdir(repo_path) do
@@ -60,6 +61,7 @@ module MutantSpec
       #
       # rubocop:disable AbcSize
       #
+      # @api private
       def verify_mutation_generation
         checkout
         start = Time.now
@@ -99,7 +101,6 @@ module MutantSpec
       # @return [self]
       #
       # @api private
-      #
       def checkout
         return self if noinstall?
         TMP.mkdir unless TMP.directory?
@@ -126,7 +127,6 @@ module MutantSpec
       # @return [undefined]
       #
       # @api private
-      #
       def install_mutant
         return if noinstall?
         relative = ROOT.relative_path_from(repo_path)
@@ -142,12 +142,11 @@ module MutantSpec
       # Not in the docs. Number from chatting with their support.
       CIRCLE_CI_CONTAINER_PROCESSES = 2
 
-      # Return number of parallel processes to use
+      # Number of parallel processes to use
       #
       # @return [Fixnum]
       #
       # @api private
-      #
       def parallel_processes
         if ENV['CI']
           Mutant::Config::DEFAULT.jobs
@@ -156,12 +155,11 @@ module MutantSpec
         end
       end
 
-      # Return repository path
+      # Repository path
       #
       # @return [Pathname]
       #
       # @api private
-      #
       def repo_path
         TMP.join(name)
       end
@@ -171,7 +169,6 @@ module MutantSpec
       # @return [Boolean]
       #
       # @api private
-      #
       def noinstall?
         ENV.key?('NOINSTALL')
       end
@@ -208,13 +205,12 @@ module MutantSpec
       # @param [Array<String>] arguments
       #
       # @api private
-      #
       def system(arguments)
         return if Kernel.system(*arguments)
         if block_given?
           yield
         else
-          fail 'System command failed!'
+          fail "System command failed!: #{arguments.join(' ')}"
         end
       end
 

data/spec/support/rb_bug.rb

@@ -10,7 +10,6 @@ module RbBug
   # @return [undefined]
   #
   # @api private
-  #
   def self.call
     rb_bug('%s', :string, 'test bug')
   end

data/spec/support/rspec.rb

@@ -6,7 +6,6 @@ module Rspec
   #   returns the value of block
   #
   # @api private
-  #
   def self.nest
     original_world, original_configuration =
       ::RSpec.instance_variable_get(:@world),

data/spec/support/ruby_vm.rb

@@ -2,8 +2,6 @@ module MutantSpec
   # Not a real VM, just kidding. It connects the require / eval triggers
   # require semantics Zombifier relies on in a way we can avoid having to
   # mock around everywhere to test every detail.
-  #
-  # rubocop:disable LineLength
   class RubyVM
     include Concord.new(:expected_events)
 

data/spec/unit/mutant/ast/meta/send_spec.rb

@@ -0,0 +1,42 @@
+RSpec.describe Mutant::AST::Meta::Send do
+  let(:object) { described_class.new(node) }
+
+  def parse(source)
+    Parser::CurrentRuby.parse(source)
+  end
+
+  let(:method_call)            { parse('foo.bar(baz)')  }
+  let(:attribute_read)         { parse('foo.bar')       }
+  let(:index_assignment)       { parse('foo[0] = bar')  }
+  let(:attribute_assignment)   { parse('foo.bar = baz') }
+  let(:binary_method_operator) { parse('foo == bar')    }
+
+  class Expectation
+    include Adamantium, Anima.new(:name, :assignment, :attribute_assignment, :index_assignment, :binary_method_operator)
+
+    ALL = [
+      [:method_call,            false, false, false, false],
+      [:attribute_read,         false, false, false, false],
+      [:index_assignment,       true,  false, true,  false],
+      [:attribute_assignment,   true,  true,  false, false],
+      [:binary_method_operator, false, false, false, true]
+    ].map do |values|
+      new(Hash[anima.attribute_names.zip(values)])
+    end.freeze
+  end
+
+  # Rspec should have a build in for this kind of "n-dimensional assertion with context"
+  (Expectation.anima.attribute_names - %i[name]).each do |name|
+    describe "##{name}?" do
+      subject { object.public_send(:"#{name}?") }
+
+      Expectation::ALL.each do |expectation|
+        context "on #{expectation.name}" do
+          let(:node) { public_send(expectation.name) }
+
+          it { should be(expectation.public_send(name)) }
+        end
+      end
+    end
+  end
+end

data/spec/unit/mutant/ast/named_children_spec.rb

@@ -0,0 +1,51 @@
+RSpec.describe Mutant::AST::NamedChildren do
+  describe '.included' do
+    let(:klass) do
+      Class.new do
+        include Mutant::AST::NamedChildren, Concord.new(:node)
+
+        children :foo, :bar
+      end
+    end
+
+    let(:instance) { klass.new(node) }
+
+    let(:node_foo) { s(:foo) }
+    let(:node_bar) { s(:bar) }
+    let(:node_baz) { s(:baz) }
+
+    let(:node) { s(:node, node_foo, node_bar, node_baz) }
+
+    describe 'generated methods' do
+      describe '#remaining_children' do
+        it 'returns remaining unnamed children' do
+          expect(instance.remaining_children).to eql([node_baz])
+        end
+      end
+
+      describe '#remaining_children_indices' do
+        it 'returns remaining unnamed children indices' do
+          expect(instance.remaining_children_indices).to eql([2])
+        end
+      end
+
+      describe '#remaining_children_with_index' do
+        it 'returns remaining unnamed children indices' do
+          expect(instance.remaining_children_with_index).to eql([[node_baz, 2]])
+        end
+      end
+
+      describe '#foo' do
+        it 'returns named child foo' do
+          expect(instance.foo).to be(node_foo)
+        end
+      end
+
+      describe '#bar' do
+        it 'returns named child bar' do
+          expect(instance.bar).to be(node_bar)
+        end
+      end
+    end
+  end
+end

data/spec/unit/mutant/ast/sexp_spec.rb

@@ -0,0 +1,36 @@
+RSpec.describe Mutant::AST::Sexp do
+  let(:object) do
+    Class.new do
+      include Mutant::AST::Sexp
+
+      public :n_not
+      public :s
+    end.new
+  end
+
+  describe '#n_not' do
+    subject { object.n_not(node) }
+
+    let(:node) { s(:true) }
+
+    it 'returns negated ast' do
+      expect(subject).to eql(s(:send, s(:true), :!))
+    end
+  end
+
+  describe '#s' do
+    subject { object.s(*arguments) }
+
+    context 'with single argument' do
+      let(:arguments) { %i[foo] }
+
+      it { should eql(Parser::AST::Node.new(:foo)) }
+    end
+
+    context 'with single multiple arguments' do
+      let(:arguments) { %i[foo bar baz] }
+
+      it { should eql(Parser::AST::Node.new(:foo, %i[bar baz])) }
+    end
+  end
+end

data/spec/unit/mutant/ast_spec.rb

@@ -19,6 +19,14 @@ RSpec.describe Mutant::AST do
       it { should eql([]) }
     end
 
+    context 'when called without block' do
+      let(:block) { nil }
+
+      it 'raises error' do
+        expect { subject }.to raise_error(ArgumentError, 'block expected')
+      end
+    end
+
     context 'when one node matches' do
       let(:block) { ->(node) { node.equal?(child_a) } }
 

data/spec/unit/mutant/cli_spec.rb

@@ -1,20 +1,20 @@
-RSpec.shared_examples_for 'an invalid cli run' do
-  it 'raises error' do
-    expect do
-      subject
-    end.to raise_error(Mutant::CLI::Error, expected_message)
-  end
-end
-
-RSpec.shared_examples_for 'a cli parser' do
-  it { expect(subject.config.integration).to eql(expected_integration)       }
-  it { expect(subject.config.reporter).to eql(expected_reporter)             }
-  it { expect(subject.config.matcher).to eql(expected_matcher_config) }
-end
-
 RSpec.describe Mutant::CLI do
   let(:object) { described_class }
 
+  shared_examples_for 'an invalid cli run' do
+    it 'raises error' do
+      expect do
+        subject
+      end.to raise_error(Mutant::CLI::Error, expected_message)
+    end
+  end
+
+  shared_examples_for 'a cli parser' do
+    it { expect(subject.config.integration).to eql(expected_integration) }
+    it { expect(subject.config.reporter).to eql(expected_reporter)       }
+    it { expect(subject.config.matcher).to eql(expected_matcher_config)  }
+  end
+
   describe '.run' do
     subject { object.run(arguments) }
 
@@ -67,13 +67,13 @@ RSpec.describe Mutant::CLI do
 
     # Defaults
     let(:expected_filter)         { Morpher.evaluator(s(:true))      }
-    let(:expected_integration)    { Mutant::Integration::Null.new    }
+    let(:expected_integration)    { Mutant::Integration::Null        }
     let(:expected_reporter)       { Mutant::Config::DEFAULT.reporter }
     let(:expected_matcher_config) { default_matcher_config           }
 
     let(:default_matcher_config) do
       Mutant::Matcher::Config::DEFAULT
-        .update(match_expressions: expressions.map(&Mutant::Expression.method(:parse)))
+        .update(match_expressions: expressions.map(&method(:parse_expression)))
     end
 
     let(:flags)       { []           }
@@ -127,7 +127,8 @@ Environment:
 Options:
         --expected-coverage COVERAGE Fail unless COVERAGE is not reached exactly, parsed via Rational()
         --use INTEGRATION            Use INTEGRATION to kill mutations
-        --ignore-subject PATTERN     Ignore subjects that match PATTERN
+        --ignore-subject EXPRESSION  Ignore subjects that match EXPRESSION as prefix
+        --since REVISION             Only select subjects touched since REVISION
         --fail-fast                  Fail fast
         --version                    Print mutants version
     -d, --debug                      Enable debugging output
@@ -152,7 +153,7 @@ Options:
 
         it_should_behave_like 'a cli parser'
 
-        let(:expected_integration) { Mutant::Integration::Rspec.new }
+        let(:expected_integration) { Mutant::Integration::Rspec }
       end
 
       context 'when integration does NOT exist' do
@@ -230,11 +231,25 @@ Options:
       end
     end
 
+    context 'with --since flag' do
+      let(:flags) { %w[--since master] }
+
+      let(:expected_matcher_config) do
+        default_matcher_config.update(
+          subject_filters: [
+            Mutant::Repository::SubjectFilter.new(Mutant::Repository::Diff.new('HEAD', 'master'))
+          ]
+        )
+      end
+
+      it_should_behave_like 'a cli parser'
+    end
+
     context 'with subject-ignore flag' do
       let(:flags) { %w[--ignore-subject Foo::Bar] }
 
       let(:expected_matcher_config) do
-        default_matcher_config.update(subject_ignores: [Mutant::Expression.parse('Foo::Bar')])
+        default_matcher_config.update(ignore_expressions: [parse_expression('Foo::Bar')])
       end
 
       it_should_behave_like 'a cli parser'