mutant 0.7.3 → 0.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8ac2711065200d50b919a3e0856632db7dc1fa0f
-  data.tar.gz: 251207d0d61bb193bb431efd2f4ef4fb771bde09
+  metadata.gz: 064e05498cecb534a1466bfe3ff858ff0487acf3
+  data.tar.gz: 585a00d32574fdabf20943a96d4ee48c6ec9408f
 SHA512:
-  metadata.gz: ddbdc1636dd452296e90a2ccc2ccbe29910782e95bfb3560d21b93501ec499cfa0b5d0fbb722a650ec57edd021cbbfc0afdbc6ca1f434c7f33069575e3343efd
-  data.tar.gz: 5f371e23cc9676661cb58ae10cd78bce3176a1fe23e01d741a6b0833eb3d3e908f7bfecd93032ac6ed84ac3dd1c962d725156b731e9c6b4480a657d450012033
+  metadata.gz: 97ffbc8174e5027a924037359084af1f49bf9fe8c14f8408ba25b28444a9822d145f59c8d90255c27fabfe744d6b609db12cf3e201fa460c955fca5c7e60ecbb
+  data.tar.gz: 2d0bdcd5a5c974d6a9504cd6f8bbfa6b45bdef56526ce054cded8b98f1e53071063afe05e7a72cf68bee9752ba7b24be827365d28390985658ba099023f0009b

data/.rubocop.yml

@@ -5,4 +5,6 @@ AllCops:
     - 'Gemfile.devtools'
     - 'vendor/**/*'
     - 'tmp/**/*'
+    - 'test_app/**/*'
     - 'benchmarks/**/*'
+    - 'bin/mutant'

data/.travis.yml

@@ -1,10 +1,11 @@
+sudo: false
 language: ruby
 script: "bundle exec rake ci"
 env:
   - TRAVIS=true
 rvm:
-  - 2.0.0
-  - 2.1.4
+  - '2.0'
+  - '2.1'
   - rbx-2
 matrix:
   allow_failures:

data/Changelog.md

@@ -1,6 +1,11 @@
+# v0.7.4 2014-12-22
+
+* Fix rspec example visibility on duplicate metadata examples
+* Add naked if/else body emitter
+
 # v0.7.3 2014-12-09
 
-* Fix communication between workers and killworks to work for all binaries.
+* Fix communication between workers and killforks to work for all binaries.
 
 # v0.7.2 2014-12-08
 
@@ -15,7 +20,7 @@
 
 * Use homegrown actor based parallelization
 * Fix redundant spec execution in rspec integration
-* Add mutation from #send to #__send__ (the canonical form).
+* Add mutation from `#send` to `#__send__` (the canonical form).
 
 # v0.6.7 2014-11-17
 

data/Gemfile

@@ -5,4 +5,3 @@ source 'https://rubygems.org'
 gemspec name: 'mutant'
 
 gem 'devtools', git: 'https://github.com/rom-rb/devtools.git'
-eval_gemfile 'Gemfile.devtools'

data/Gemfile.devtools

@@ -1,65 +1,37 @@
-# encoding: utf-8
-
 group :development do
-  gem 'rake',       '~> 10.3.2'
-  gem 'rspec',      '~> 3.1.0'
-  gem 'rspec-its',  '~> 1.0.1'
-  gem 'yard',       '~> 0.8.7.4'
-
   platform :rbx do
     gem 'rubysl-singleton', '~> 2.0.0'
-    gem 'rubinius-coverage', '~> 2.0.1'
   end
 end
 
-group :yard do
-  gem 'kramdown', '~> 1.3.3'
-end
-
 group :guard do
-  gem 'guard',         '~> 2.6.1'
-  gem 'guard-bundler', '~> 2.0.0'
-  gem 'guard-rspec',   '~> 4.2.9'
-  gem 'guard-rubocop', '~> 1.1.0'
+  gem 'guard',         '~> 2.10.3'
+  gem 'guard-bundler', '~> 2.1.0'
+  gem 'guard-rspec',   '~> 4.5.0'
+  gem 'guard-rubocop', '~> 1.2.0'
 
   # file system change event handling
-  gem 'listen',     '~> 2.7.7'
+  gem 'listen',     '~> 2.8.4'
   gem 'rb-fchange', '~> 0.0.6', require: false
   gem 'rb-fsevent', '~> 0.9.4', require: false
   gem 'rb-inotify', '~> 0.9.5', require: false
 
   # notification handling
-  gem 'libnotify',               '~> 0.8.3', require: false
+  gem 'libnotify',               '~> 0.9.0', require: false
   gem 'rb-notifu',               '~> 0.0.4', require: false
-  gem 'terminal-notifier-guard', '~> 1.5.3', require: false
+  gem 'terminal-notifier-guard', '~> 1.6.4', require: false
 end
 
 group :metrics do
-  gem 'coveralls', '~> 0.7.0'
-  gem 'flay',      '~> 2.5.0'
-  gem 'flog',      '~> 4.2.1'
-  gem 'reek',      '~> 1.3.7'
-  gem 'rubocop',   '~> 0.26.0'
-  gem 'simplecov', '~> 0.7.1'
-  gem 'yardstick', '~> 0.9.9'
-
-  platforms :ruby_19, :ruby_20 do
-    gem 'yard-spellcheck', '~> 0.1.5'
-  end
-
   platform :rbx do
     gem 'json',               '~> 1.8.1'
-    gem 'racc',               '~> 1.4.11'
-    gem 'rubysl-logger',      '~> 2.0.0'
+    gem 'racc',               '~> 1.4.12'
+    gem 'rubysl-logger',      '~> 2.1.0'
     gem 'rubysl-open-uri',    '~> 2.0.0'
     gem 'rubysl-prettyprint', '~> 2.0.3'
   end
 end
 
-group :benchmarks do
-  gem 'rbench', '~> 0.2.3'
-end
-
 platform :jruby do
   group :jruby do
     gem 'jruby-openssl', '~> 0.9.4'

data/README.md

@@ -13,7 +13,7 @@ Mutant is a mutation testing tool for Ruby.
 The idea is that if code can be changed and your tests do not notice, either that code isn't being covered
 or it does not have a speced side effect.
 
-Mutant supports MRI and RBX 1.9, 2.0 and 2.1, while support for JRuby is planned.
+Mutant supports MRI and RBX 2.0 and 2.1, while support for JRuby is planned.
 It should also work under any Ruby engine that supports POSIX-fork(2) semantics.
 
 Mutant uses a pure Ruby [parser](https://github.com/whitequark/parser) and an [unparser](https://github.com/mbj/unparser)

data/circle.yml

@@ -1,7 +1,7 @@
 ---
 machine:
   ruby:
-    version: 2.1.4
+    version: '2.1'
 test:
   override:
     - bundle exec rake ci

data/config/flay.yml

@@ -1,3 +1,3 @@
 ---
 threshold: 18
-total_score: 1200
+total_score: 1198

data/config/reek.yml

@@ -23,21 +23,7 @@ DuplicateMethodCall:
   max_calls: 1
   allow_calls: []
 FeatureEnvy:
-  enabled: true
-  exclude:
-  - Mutant::Env#scope_name
-  - Mutant::Diff#minimized_hunks
-  - Mutant::Integration::Rspec#parse_example
-  - Mutant::Matcher::Method::Instance#match?
-  - Mutant::Matcher::Method::Singleton#receiver?
-  - Mutant::Mutator::Node#children_indices
-  - Mutant::Meta::Example::Verification#format_mutation # False positive, its a utility
-  - Mutant::Reporter::CLI#subject_results
-  - Mutant::Runner#finish
-  - Mutant::Runner::Master#stop_worker
-  - Mutant::Runner::Worker#run_mutation
-  - Mutant::Runner::Worker#handle
-  - Mutant::Subject#source_lines
+  enabled: false
 IrresponsibleModule:
   enabled: true
   exclude: []
@@ -62,6 +48,7 @@ NestedIterators:
   - Mutant::RequireHighjack#infect
   - Mutant::RequireHighjack#disinfect
   - Mutant::Subject#tests
+  - Mutant::Parallel::Master#run
   - Parser::Lexer#self.new
   max_allowed_nesting: 1
   ignore_iterators: []
@@ -72,14 +59,12 @@ RepeatedConditional:
   exclude:
   - Mutant::Mutator
   - Mutant::Meta::Example::DSL
-  - Mutant::Runner::Master
   max_ifs: 1
 TooManyInstanceVariables:
   enabled: true
   exclude:
   - Mutant::Mutator # 4 vars
-  - Mutant::Runner::Master # 4 vars
-  - Mutant::Runner::Scheduler # 4 vars
+  - Mutant::Parallel::Master # 4 vars
   max_instance_variables: 3
 TooManyMethods:
   enabled: true
@@ -87,6 +72,7 @@ TooManyMethods:
   - Mutant::CLI
   - Mutant::Mutator::Node
   - Mutant::Meta::Example::Verification
+  - Mutant::Parallel::Master
   max_methods: 10
 TooManyStatements:
   enabled: true
@@ -94,9 +80,10 @@ TooManyStatements:
   - Mutant::Isolation::Fork#self.call
   - Mutant::Reporter::CLI::Printer::EnvProgress#run
   - Mutant::Reporter::CLI::Printer::Config#run
-  - Mutant::Runner#initialize
   - Mutant::Zombifier::File#self.find
   - Mutant::CLI#add_environment_options
+  - Mutant::CLI#add_debug_options
+  - Mutant::Runner#run_driver
   max_statements: 7
 UncommunicativeMethodName:
   enabled: true

data/config/rubocop.yml

@@ -1,18 +1,5 @@
 inherit_from: ../.rubocop.yml
 
-# General note about rubocop.
-# It does NOT allow to silence a specific rule violation.
-# For that reason I sometimes have to disable a whole cop where
-# I just tried to whitelist a specific occurrence.
-
-
-AllCops:
-  Include:
-    - '../**/*.rake'
-    - 'Gemfile'
-    - 'Gemfile.triage'
-    - 'mutant.gemspec'
-
 # Avoid parameter lists longer than five parameters.
 ParameterLists:
   Max: 3
@@ -30,51 +17,29 @@ CollectionMethods:
     find:     'detect'
     find_all: 'select'
 
-# Use square brackets for literal Array objects
-PercentLiteralDelimiters:
-  PreferredDelimiters:
-    '%':  ()
-    '%i': '[]'
-    '%q': ()
-    '%Q': ()
-    '%r': '{}'
-    '%s': ()
-    '%w': '[]'
-    '%W': '[]'
-    '%x': ()
-
-MethodLength:
-  CountComments: false
-  Max: 17 # TODO: Bring down to 10
-
-RegexpLiteral: # I do not agree %r(\A) is more readable than /\A/
+# Do not force public/protected/private keyword to be indented at the same
+# level as the def keyword. My personal preference is to outdent these keywords
+# because I think when scanning code it makes it easier to identify the
+# sections of code and visually separate them. When the keyword is at the same
+# level I think it sort of blends in with the def keywords and makes it harder
+# to scan the code and see where the sections are.
+AccessModifierIndentation:
   Enabled: false
 
-Eval:
-  Enabled: false # Mutant must use Kernel#eval to inject mutated source
-
 # Limit line length
 LineLength:
-  Max: 124  # TODO: lower to 79
+  Max: 120
 
 # Disable documentation checking until a class needs to be documented once
 Documentation:
   Enabled: false
 
-# Do not favor modifier if/unless usage when you have a single-line body
-IfUnlessModifier:
-  Enabled: false
-
-# Mutant needs to define methods like def bar; end in specs
-Semicolon:
-  Enabled: false
-
-# Mutant needs to define multiple methods on same line in specs
-EmptyLineBetweenDefs:
+# Do not always use &&/|| instead of and/or.
+AndOr:
   Enabled: false
 
-# Mutant needs to define singleton methods like Foo.bar in specs
-ClassMethods:
+# Do not favor modifier if/unless usage when you have a single-line body
+IfUnlessModifier:
   Enabled: false
 
 # Allow case equality operator (in limited use within the specs)
@@ -89,33 +54,63 @@ ConstantName:
 TrivialAccessors:
   Enabled: false
 
-# And also have a different opinion here
-AndOr:
+# Allow empty lines around class body
+EmptyLinesAroundClassBody:
   Enabled: false
 
-# I like my raise
-SignalException:
+# Allow empty lines around module body
+EmptyLinesAroundModuleBody:
   Enabled: false
 
-# I need to chain optparse builder, else it is more ugly
-MultilineBlockChain:
+# Allow empty lines around block body
+EmptyLinesAroundBlockBody:
   Enabled: false
 
-ClassLength:
-  Max: 119
+# Allow multiple line operations to not require indentation
+MultilineOperationIndentation:
+  Enabled: false
 
-# I align private keywords with class body
-IndentationWidth:
+# Prefer String#% over Kernel#sprintf
+FormatString:
   Enabled: false
 
-# I like to have an empty line before closing the currently opened body
-EmptyLinesAroundBody:
+# Use square brackets for literal Array objects
+PercentLiteralDelimiters:
+  PreferredDelimiters:
+    '%':  '{}'
+    '%i': '[]'
+    '%q': ()
+    '%Q': ()
+    '%r': '{}'
+    '%s': ()
+    '%w': '[]'
+    '%W': '[]'
+    '%x': ()
+
+# Align if/else blocks with the variable assignment
+EndAlignment:
+  AlignWith: variable
+
+# Do not always align parameters when it is easier to read
+AlignParameters:
+  Exclude:
+    - spec/**/*_spec.rb
+
+# Prefer #kind_of? over #is_a?
+ClassCheck:
+  EnforcedStyle: kind_of?
+
+# Do not prefer double quotes to be used when %q or %Q is more appropriate
+UnneededPercentQ:
   Enabled: false
 
-# I test this style for a while
+# Allow a maximum ABC score
+Metrics/AbcSize:
+  Max: 18.00
+
+# Do not prefer lambda.call(...) over lambda.(...)
 LambdaCall:
   Enabled: false
 
-# I like my style more
-AccessModifierIndentation:
-  Enabled: false
+Style/RegexpLiteral:
+  MaxSlashes: 0

data/lib/mutant.rb

@@ -74,6 +74,8 @@ module Mutant
   #
   # @api private
   #
+  # rubocop:disable MethodLength
+  #
   def self.singleton_subclass_instance(name, superclass, &block)
     klass = Class.new(superclass) do
       def inspect
@@ -105,6 +107,10 @@ require 'mutant/actor/receiver'
 require 'mutant/actor/sender'
 require 'mutant/actor/mailbox'
 require 'mutant/actor/env'
+require 'mutant/parallel'
+require 'mutant/parallel/master'
+require 'mutant/parallel/worker'
+require 'mutant/parallel/source'
 require 'mutant/cache'
 require 'mutant/delegator'
 require 'mutant/warning_filter'
@@ -200,9 +206,7 @@ require 'mutant/cli'
 require 'mutant/color'
 require 'mutant/diff'
 require 'mutant/runner'
-require 'mutant/runner/scheduler'
-require 'mutant/runner/master'
-require 'mutant/runner/worker'
+require 'mutant/runner/sink'
 require 'mutant/result'
 require 'mutant/reporter'
 require 'mutant/reporter/null'
@@ -230,7 +234,7 @@ module Mutant
       isolation:         Mutant::Isolation::Fork,
       reporter:          Reporter::CLI.build($stdout),
       zombie:            false,
-      jobs:              Mutant.ci? ? CI_DEFAULT_PROCESSOR_COUNT : Parallel.processor_count,
+      jobs:              Mutant.ci? ? CI_DEFAULT_PROCESSOR_COUNT : ::Parallel.processor_count,
       actor_env:         Mutant::Actor::Env.new(Thread),
       expected_coverage: 100.0
     )

data/lib/mutant/ast.rb

@@ -15,7 +15,7 @@ module Mutant
     # @api private
     #
     def self.walk(node, stack, &block)
-      raise ArgumentError, 'block expected' unless block_given?
+      fail ArgumentError, 'block expected' unless block_given?
 
       block.call(node, stack)
       node.children.grep(Parser::AST::Node).each do |child|

data/lib/mutant/cli.rb

@@ -74,7 +74,7 @@ module Mutant
 
       parse_match_expressions(opts.parse!(arguments))
     rescue OptionParser::ParseError => error
-      fail(Error, error.message, error.backtrace)
+      raise(Error, error.message, error.backtrace)
     end
 
     # Parse matchers
@@ -101,6 +101,8 @@ module Mutant
     #
     # @api private
     #
+    # rubocop:disable MethodLength
+    #
     def add_environment_options(opts)
       opts.separator('Environment:')
       opts.on('--zombie', 'Run mutant zombified') do
@@ -129,7 +131,7 @@ module Mutant
       require "mutant/integration/#{name}"
       update(integration: Integration.lookup(name))
     rescue LoadError
-      fail Error, "Could not load integration #{name.inspect} (you may want to try installing the gem mutant-#{name})"
+      raise Error, "Could not load integration #{name.inspect} (you may want to try installing the gem mutant-#{name})"
     end
 
     # Add options
@@ -146,7 +148,8 @@ module Mutant
 
       opts.on('--score COVERAGE', 'Fail unless COVERAGE is not reached exactly') do |coverage|
         update(expected_coverage: Float(coverage))
-      end.on('--use STRATEGY', 'Use STRATEGY for killing mutations', &method(:setup_integration))
+      end
+      opts.on('--use STRATEGY', 'Use STRATEGY for killing mutations', &method(:setup_integration))
     end
 
     # Add filter options
@@ -177,12 +180,15 @@ module Mutant
     def add_debug_options(opts)
       opts.on('--fail-fast', 'Fail fast') do
         update(fail_fast: true)
-      end.on('--version', 'Print mutants version') do
+      end
+      opts.on('--version', 'Print mutants version') do
         puts("mutant-#{Mutant::VERSION}")
         Kernel.exit(EXIT_SUCCESS)
-      end.on('-d', '--debug', 'Enable debugging output') do
+      end
+      opts.on('-d', '--debug', 'Enable debugging output') do
         update(debug: true)
-      end.on_tail('-h', '--help', 'Show this message') do
+      end
+      opts.on_tail('-h', '--help', 'Show this message') do
         puts(opts.to_s)
         Kernel.exit(EXIT_SUCCESS)
       end