mutant 0.5.12 → 0.5.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 297b2cebef213ce23d17e2ab0c3d27077863d433
-  data.tar.gz: f31250e07dc3d7702c4d43b5428fc54e9b076c36
+  metadata.gz: 8160ffea0145b855d07b355672ae647b2d52af24
+  data.tar.gz: cf9f75291454ad37e97a9607b2913830bd4f27d9
 SHA512:
-  metadata.gz: afddc1bb04782a26096e271114d2e3142c24bb68bf49fcd610614ecca0c395956925351eb8e88b0c5d35f6fc2640b8331a41364ae028785475fbcf36cdd5a011
-  data.tar.gz: 527d4038e21573b97c1fff670cca72e79724c69e2b720352df9d9e8a236ccd742b51d0757b817d963911b7cdadbcbe680d4fc8347fed5802c49fb6f3b69b9b94
+  metadata.gz: eaf8c1d4bcfdcdbf85e9e6b444922325e39d461c0512b506c2b7b405c5e1d575924ef35ecfa2d312cbffbe401f7cc2ae90d6a8d09ab2a3a9807266fd64e3a874
+  data.tar.gz: 728a4bd10328e93ed519c4ad6b67ac9d24f3f125d277ebc52aeb76bd7b9f31e9525c64ca2c9329cf16601aa036366e68f2f31a4b3b47f69de63f510b6fc0e877

data/Changelog.md

@@ -1,3 +1,13 @@
+# v0.5.13 2014-05-23
+
+Changes:
+
+* Imporve reporting of isolation problems
+* Centralize test selection
+* Report selected tests
+* Report rspec output on noop failures
+* Silence warnings on methods without source location
+
 # v0.5.12 2014-05-09
 
 Changes:

data/circle.yml

@@ -1,7 +1,7 @@
 ---
 machine:
   ruby:
-    version: 2.0.0
+    version: 2.1.2
 test:
   override:
     - bundle exec rake ci

data/config/flay.yml

@@ -1,3 +1,3 @@
 ---
 threshold: 18
-total_score: 832
+total_score: 799

data/config/flog.yml

@@ -1,2 +1,2 @@
 ---
-threshold: 29.3
+threshold: 29.6

data/config/mutant.yml

@@ -1,7 +1,7 @@
 name: mutant
 namespace: Mutant
 zombify: true
-expect_coverage: 61.83
+expect_coverage: 62.08
 ignore_subjects:
 # Mutation causes infinite runtime
 - Mutant::Runner.lookup
@@ -10,6 +10,5 @@ ignore_subjects:
 - Mutant::Reporter*
 - Mutant::CLI*
 - Mutant.singleton_subclass_instance
-- Mutant.symbolset
 # Executing this has undefined behavior with the zombifier
 - Mutant.zombify

data/config/reek.yml

@@ -40,6 +40,7 @@ LongParameterList:
   enabled: true
   exclude:
   - Mutant::Matcher::Method::Instance#self.build?
+  - Mutant::Runner#self.run
   max_params: 2
 LongYieldList:
   enabled: true
@@ -51,9 +52,11 @@ NestedIterators:
   - Mutant#self.singleton_subclass_instance
   - Mutant::CLI#parse
   - Mutant::Mutator::Util::Array::Element#dispatch
-  - Mutant::Reporter::CLI::Printer::Config::Runner#generic_stats
+  - Mutant::Reporter::CLI::Report::Config#generic_stats
   - Mutant::RequireHighjack#infect
   - Mutant::RequireHighjack#desinfect
+  - Mutant::Reporter::CLI::Registry#included
+  - Mutant::Strategy#tests
   - Parser::Lexer#self.new
   max_allowed_nesting: 1
   ignore_iterators: []
@@ -63,6 +66,7 @@ RepeatedConditional:
   enabled: true
   exclude:
   - Mutant::Mutator
+  - Mutant::Rspec::Strategy
   - Mutant::Reporter::CLI
   max_ifs: 1
 TooManyInstanceVariables:
@@ -84,12 +88,16 @@ TooManyStatements:
   enabled: true
   exclude:
   - Mutant#self.singleton_subclass_instance
+  - Mutant#self.isolate
   - Mutant::Rspec::Killer#run
   - Mutant::Reporter::CLI#colorized_diff
-  - Mutant::Reporter::CLI::Printer::Config::Runner#run
-  - Mutant::Runner#dispatch
+  - Mutant::Reporter::CLI::Report::Config#run
+  - Mutant::Runner#visit_collection
   - Mutant::Zombifier::File#self.find
   - Mutant::RequireHighjack#infect
+  - Mutant::Reporter::CLI::Registry#included
+  - Mutant::Rspec::Strategy#new_reporter
+  - Mutant::Rspec::Strategy#run
   # How mutant does CLI parsing is shit
   - Mutant::CLI#parse
   - Mutant::CLI#initialize
@@ -139,6 +147,7 @@ UtilityFunction:
   - Mutant::Mutation::Neutral#success?
   - Mutant::NodeHelpers#s
   - Mutant::Rspec::Strategy#configuration
+  - Mutant::Rspec::Strategy#example_groups
   - Mutant::Rspec::Strategy#options
   - Mutant::Rspec::Strategy#world
   - Mutant::Rspec::Strategy#rspec2

data/config/rubocop.yml

@@ -99,6 +99,10 @@ IndentationWidth:
 EmptyLinesAroundBody:
   Enabled: false
 
+# I test this style for a while
+LambdaCall:
+  Enabled: false
+
 # I like my style more
 AccessModifierIndentation:
   Enabled: false

data/lib/mutant.rb

@@ -5,7 +5,6 @@ require 'set'
 require 'adamantium'
 require 'ice_nine'
 require 'abstract_type'
-require 'securerandom'
 require 'equalizer'
 require 'digest/sha1'
 require 'inflecto'
@@ -38,18 +37,42 @@ module Mutant
     self
   end
 
-  # Return a frozen set of symbols from string enumerable
+  IsolationError = Class.new(RuntimeError)
+
+  # Call block in isolation
   #
-  # @param [Enumerable<String>]
+  # This isolation implements the fork strategy.
+  # Future strategies will probably use a process pool that can
+  # handle multiple mutation kills, in-isolation at once.
   #
-  # @return [Set<Symbol>]
+  # @return [Object]
   #
   # @api private
   #
-  def self.symbolset(strings)
-    strings.map(&:to_sym).to_set.freeze
+  def self.isolate(&block)
+    reader, writer = IO.pipe
+
+    pid = fork do
+      reader.close
+      writer.write(Marshal.dump(block.call))
+    end
+
+    writer.close
+
+    begin
+      data = Marshal.load(reader.read)
+    rescue ArgumentError
+      raise IsolationError, 'Childprocess wrote un-unmarshallable data'
+    end
+
+    status = Process.waitpid2(pid).last
+
+    unless status.exitstatus.zero?
+      raise IsolationError, "Childprocess exited with nonzero exit status: #{status.exitstatus}"
+    end
+
+    data
   end
-  private_class_method :symbolset
 
   # Define instance of subclassed superclass as constant
   #
@@ -79,11 +102,11 @@ end # Mutant
 
 require 'mutant/version'
 require 'mutant/cache'
+require 'mutant/delegator'
 require 'mutant/node_helpers'
 require 'mutant/warning_filter'
 require 'mutant/warning_expectation'
 require 'mutant/constants'
-require 'mutant/random'
 require 'mutant/walker'
 require 'mutant/require_highjack'
 require 'mutant/mutator'
@@ -164,27 +187,33 @@ require 'mutant/matcher/scope'
 require 'mutant/matcher/filter'
 require 'mutant/matcher/null'
 require 'mutant/killer'
-require 'mutant/killer/static'
-require 'mutant/killer/forking'
-require 'mutant/killer/forked'
+require 'mutant/test'
 require 'mutant/strategy'
 require 'mutant/runner'
 require 'mutant/runner/config'
 require 'mutant/runner/subject'
 require 'mutant/runner/mutation'
+require 'mutant/runner/killer'
 require 'mutant/cli'
 require 'mutant/cli/classifier'
 require 'mutant/cli/classifier/namespace'
 require 'mutant/cli/classifier/method'
 require 'mutant/color'
-require 'mutant/differ'
+require 'mutant/diff'
 require 'mutant/reporter'
 require 'mutant/reporter/null'
+require 'mutant/reporter/trace'
 require 'mutant/reporter/cli'
+require 'mutant/reporter/cli/registry'
 require 'mutant/reporter/cli/printer'
-require 'mutant/reporter/cli/printer/config'
-require 'mutant/reporter/cli/printer/subject'
-require 'mutant/reporter/cli/printer/killer'
-require 'mutant/reporter/cli/printer/mutation'
+require 'mutant/reporter/cli/report'
+require 'mutant/reporter/cli/report/config'
+require 'mutant/reporter/cli/report/subject'
+require 'mutant/reporter/cli/report/mutation'
+require 'mutant/reporter/cli/progress'
+require 'mutant/reporter/cli/progress/config'
+require 'mutant/reporter/cli/progress/subject'
+require 'mutant/reporter/cli/progress/mutation'
+require 'mutant/reporter/cli/progress/noop'
 require 'mutant/zombifier'
 require 'mutant/zombifier/file'

data/lib/mutant/constants.rb

@@ -2,23 +2,23 @@
 
 module Mutant
 
+  symbolset = ->(strings) { strings.map(&:to_sym).to_set.freeze }
+
   # Set of nodes that cannot be on the LHS of an assignment
-  NOT_ASSIGNABLE = symbolset %w(
-    int float str dstr class module self
-  )
+  NOT_ASSIGNABLE = symbolset.(%w(int float str dstr class module self))
 
   # Set of op-assign types
-  OP_ASSIGN              = symbolset %w(or_asgn and_asgn op_asgn)
+  OP_ASSIGN              = symbolset.call(%w(or_asgn and_asgn op_asgn))
   # Set of node types that are not valid when emitted standalone
-  NOT_STANDALONE         = symbolset %w( splat restarg block_pass)
-  INDEX_OPERATORS        = symbolset %w([] []=)
-  UNARY_METHOD_OPERATORS = symbolset %w(~@ +@ -@ !)
+  NOT_STANDALONE         = symbolset.(%w( splat restarg block_pass))
+  INDEX_OPERATORS        = symbolset.(%w([] []=))
+  UNARY_METHOD_OPERATORS = symbolset.(%w(~@ +@ -@ !))
 
   # Operators ruby implementeds as methods
-  METHOD_OPERATORS = symbolset %w(
+  METHOD_OPERATORS = symbolset.(%w(
     <=> === []= [] <= >= == !~ != =~ <<
     >> ** * % / | ^ & < > + - ~@ +@ -@ !
-  )
+  ))
 
   BINARY_METHOD_OPERATORS = (
     METHOD_OPERATORS - (INDEX_OPERATORS + UNARY_METHOD_OPERATORS)
@@ -32,10 +32,10 @@ module Mutant
   #
   # not - 1.8 only, mutant does not support 1.8
   #
-  NODE_BLACKLIST = symbolset %w(not)
+  NODE_BLACKLIST = symbolset.(%w(not))
 
   # Nodes that are NOT generated by parser but used by mutant / unparser.
-  NODE_EXTRA = symbolset %w(empty)
+  NODE_EXTRA = symbolset.(%w(empty))
 
   NODE_TYPES = ((Parser::Meta::NODE_TYPES + NODE_EXTRA) - NODE_BLACKLIST).to_set.freeze
 

data/lib/mutant/delegator.rb

@@ -0,0 +1,50 @@
+module Mutant
+  module Delegator
+    module ClassMethods
+
+    private
+
+      # Create delegators to object
+      #
+      # @return [undefined]
+      #
+      # @api private
+      #
+      def delegate(*names)
+        names.each do |name|
+          define_delegator(name)
+        end
+      end
+
+      # Create delegator to object
+      #
+      # @param [Symbol] name
+      #
+      # @return [undefined]
+      #
+      # @api private
+      #
+      def define_delegator(name)
+        define_method(name) do
+          object.public_send(name)
+        end
+        private name
+      end
+
+    end # ClassMethods
+
+    # Hook called when module is included
+    #
+    # @param [Class,Module] host
+    #
+    # @api private
+    #
+    def self.included(host)
+      super
+      host.class_eval do
+        extend ClassMethods
+      end
+    end
+
+  end # Delegator
+end # Mutant

data/lib/mutant/{differ.rb → diff.rb}

@@ -2,7 +2,7 @@
 
 module Mutant
   # Class to create diffs from source code
-  class Differ
+  class Diff
     include Adamantium::Flat, Concord.new(:old, :new)
 
     # Return source diff
@@ -20,7 +20,7 @@ module Mutant
       when 0
         nil
       when 1
-        Diff::LCS::Hunk.new(old, new, diffs.first, max_length, 0)
+        ::Diff::LCS::Hunk.new(old, new, diffs.first, max_length, 0)
           .diff(:unified) << "\n"
       else
         $stderr.puts(
@@ -55,7 +55,7 @@ module Mutant
     # @param [String] old
     # @param [String] new
     #
-    # @return [Differ]
+    # @return [Diff]
     #
     # @api private
     #
@@ -85,7 +85,7 @@ module Mutant
     # @api private
     #
     def diffs
-      Diff::LCS.diff(old, new)
+      ::Diff::LCS.diff(old, new)
     end
     memoize :diffs
 
@@ -118,5 +118,5 @@ module Mutant
       end.format(line)
     end
 
-  end # Differ
+  end # Diff
 end # Mutant

data/lib/mutant/killer.rb

@@ -1,123 +1,46 @@
 # encoding: utf-8
 
 module Mutant
-  # Abstract base class for mutant killers
+  # Mutation killer
   class Killer
-    include Adamantium::Flat, AbstractType
-    include Equalizer.new(:strategy, :mutation, :killed?)
+    include Adamantium::Flat, Anima.new(:test, :mutation)
 
-    # Return strategy
-    #
-    # @return [Strategy]
-    #
-    # @api private
-    #
-    attr_reader :strategy
-
-    # Return mutation to kill
-    #
-    # @return [Mutation]
-    #
-    # @api private
-    #
-    attr_reader :mutation
-
-    # Initialize killer object
-    #
-    # @param [Strategy] strategy
-    # @param [Mutation] mutation
-    #
-    # @return [undefined]
-    #
-    # @api private
-    #
-    def initialize(strategy, mutation)
-      @strategy, @mutation = strategy, mutation
-      @killed = run
-    end
-
-    # Test for kill failure
-    #
-    # @return [true]
-    #   when killer succeeded
-    #
-    # @return [false]
-    #   otherwise
-    #
-    # @api private
-    #
-    def success?
-      mutation.success?(self)
-    end
-    memoize :success?
-
-    # Test if mutant was killed
-    #
-    # @return [true]
-    #   if mutant was killed
-    #
-    # @return [false]
-    #   otherwise
-    #
-    # @api private
-    #
-    def killed?
-      @killed
-    end
-
-    # Return mutated source
-    #
-    # @return [String]
-    #
-    # @api private
-    #
-    def mutation_source
-      mutation.source
-    end
+    # Report object for kill results
+    class Report
+      include Anima.new(
+        :killer,
+        :test_report
+      )
 
-  private
+      # Test if kill was successful
+      #
+      # @return [Boolean]
+      #
+      # @api private
+      #
+      def success?
+        killer.mutation.should_fail?.equal?(test_report.failed?)
+      end
 
-    # Return subject
-    #
-    # @return [Subject]
-    #
-    # @api private
-    #
-    def subject
-      mutation.subject
-    end
+    end # Report
 
-    # Run killer
+    # Return killer report
     #
-    # @return [true]
-    #   when mutant was killed
-    #
-    # @return [false]
-    #   otherwise
+    # @return [Killer::Report]
     #
     # @api private
     #
-    abstract_method :run
-
-    # Null killer that never kills a mutation
-    class Null < self
-
-    private
-
-      # Run killer
-      #
-      # @return [true]
-      #   when mutant was killed
-      #
-      # @return [false]
-      #   otherwise
-      #
-      # @api private
-      #
-      def run
-        false
+    def run
+      test_report = Mutant.isolate do
+        mutation.insert
+        test.run
       end
 
+      Report.new(
+        killer:      self,
+        test_report: test_report.update(test: test)
+      )
     end
+
   end # Killer
 end # Mutant