mutant 0.3.0.beta21 → 0.3.0.beta22

data/lib/mutant/cli/classifier.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   class CLI
     # A classifier for input strings
@@ -6,13 +8,19 @@ module Mutant
 
       include Equalizer.new(:identifier)
 
-      SCOPE_NAME_PATTERN  = /[A-Za-z][A-Za-z_0-9]*/.freeze
-      OPERATOR_PATTERN    = Regexp.union(*OPERATOR_METHODS.map(&:to_s)).freeze
-      METHOD_NAME_PATTERN = /([_A-Za-z][A-Za-z0-9_]*[!?=]?|#{OPERATOR_PATTERN})/.freeze
-      SCOPE_PATTERN       = /(?:::)?#{SCOPE_NAME_PATTERN}(?:::#{SCOPE_NAME_PATTERN})*/.freeze
-      CBASE_PATTERN       = /\A::/.freeze
-      SCOPE_OPERATOR      = '::'.freeze
-      SINGLETON_PATTERN   = %r(\A(#{SCOPE_PATTERN})\z).freeze
+      SCOPE_NAME_PATTERN = /[A-Za-z][A-Za-z\d_]*/.freeze
+      SCOPE_OPERATOR     = '::'.freeze
+      CBASE_PATTERN      = /\A#{SCOPE_OPERATOR}/.freeze
+
+      METHOD_NAME_PATTERN = Regexp.union(
+        /[A-Za-z_][A-Za-z\d_]*[!?=]?/,
+        *OPERATOR_METHODS.map(&:to_s)
+      ).freeze
+
+      SCOPE_PATTERN = /
+        (?:#{SCOPE_OPERATOR})?#{SCOPE_NAME_PATTERN}
+        (?:#{SCOPE_OPERATOR}#{SCOPE_NAME_PATTERN})*
+      /x.freeze
 
       REGISTRY = []
 
@@ -36,9 +44,12 @@ module Mutant
       # @api private
       #
       def self.constant_lookup(location)
-        location.gsub(CBASE_PATTERN, EMPTY_STRING).split(SCOPE_OPERATOR).inject(Object) do |parent, name|
-          parent.const_get(name)
-        end
+        location
+          .sub(CBASE_PATTERN, EMPTY_STRING)
+          .split(SCOPE_OPERATOR)
+          .reduce(Object) do |parent, name|
+            parent.const_get(name, nil)
+          end
       end
 
       # Return matchers for input
@@ -119,6 +130,7 @@ module Mutant
       # @api private
       #
       abstract_method :matcher
+      private         :matcher
 
     end # Classifier
   end # CLI

data/lib/mutant/cli/classifier/method.rb

@@ -1,22 +1,33 @@
+# encoding: utf-8
+
 module Mutant
   class CLI
     class Classifier
+
       # Explicit method classifier
       class Method < self
         register
 
         TABLE = {
           '.' => Matcher::Methods::Singleton,
-          '#' => Matcher::Methods::Instance
+          '#' => Matcher::Methods::Instance,
         }.freeze
 
-        REGEXP = %r(\A(#{SCOPE_PATTERN})([.#])(#{METHOD_NAME_PATTERN}\z)).freeze
+        REGEXP = /
+          \A
+            (#{SCOPE_PATTERN})
+            ([.#])
+            (#{METHOD_NAME_PATTERN})
+          \z
+        /x.freeze
 
         # Positions of captured regexp groups
         SCOPE_NAME_POSITION   = 1
         SCOPE_SYMBOL_POSITION = 2
         METHOD_NAME_POSITION  = 3
 
+      private
+
         # Return method matcher
         #
         # @return [Matcher::Method]
@@ -28,18 +39,6 @@ module Mutant
         end
         memoize :matcher
 
-        # Return identification
-        #
-        # @return [String]
-        #
-        # @api private
-        #
-        def identification
-          match.to_s
-        end
-
-      private
-
         # Return method
         #
         # @return [Method, UnboundMethod]
@@ -49,7 +48,7 @@ module Mutant
         def method
           methods_matcher.methods.detect do |method|
             method.name == method_name
-          end or raise("Cannot find method #{identification}")
+          end or raise NameError, "Cannot find method #{identifier}"
         end
         memoize :method, :freezer => :noop
 

data/lib/mutant/cli/classifier/namespace.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   class CLI
     class Classifier
@@ -29,15 +31,17 @@ module Mutant
 
         # Recursive namespace classifier
         class Recursive < self
-          REGEXP = %r(\A(#{SCOPE_PATTERN})\*\z).freeze
+          REGEXP  = /\A(#{SCOPE_PATTERN})\*\z/.freeze
           MATCHER = Matcher::Namespace
+
           register
         end # Recursive
 
         # Recursive namespace classifier
         class Flat < self
-          REGEXP = %r(\A(#{SCOPE_PATTERN})\z).freeze
+          REGEXP  = /\A(#{SCOPE_PATTERN})\z/.freeze
           MATCHER = Matcher::Scope
+
           register
         end # Flat
 

data/lib/mutant/cli/classifier/scope.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   class CLI
     class Classifier
@@ -5,7 +7,7 @@ module Mutant
       # Scope classifier
       class Scope < self
 
-        REGEXP = %r(\A(#{SCOPE_PATTERN})\z).freeze
+        REGEXP = /\A(#{SCOPE_PATTERN})\z/.freeze
 
       private
 

data/lib/mutant/color.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   # Class to colorize strings
   class Color
@@ -27,7 +29,8 @@ module Mutant
       "\e[#{@code}m#{text}\e[0m"
     end
 
-    NONE = Class.new(self) do
+    Mutant.singleton_subclass_instance('NONE', self) do
+
       # Format null color
       #
       # @param [String] text
@@ -49,13 +52,14 @@ module Mutant
       #
       # @api private
       #
-      def initialize(*)
+      def initialize
       end
 
-    end.new.freeze
+    end
 
     RED   = Color.new(31)
     GREEN = Color.new(32)
     BLUE  = Color.new(34)
+
   end # Color
 end # Mutant

data/lib/mutant/config.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   # The configuration of a mutator run
   class Config

data/lib/mutant/constants.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
 
   METHOD_POSTFIX_EXPANSIONS = {
@@ -17,8 +19,7 @@ module Mutant
   ].to_set.freeze
 
   # Set of node types that are not valid when emitted standalone
-  NOT_STANDALONE = [ :splat, :block_pass ].to_set.freeze
-
+  NOT_STANDALONE = [:splat, :restarg, :block_pass].to_set.freeze
 
   OPERATOR_EXPANSIONS = {
     :<=>  => :spaceship_operator,
@@ -50,7 +51,7 @@ module Mutant
     :'!'  => :negation_operator
   }.freeze
 
-  INDEX_OPERATORS = [ :[], :[]= ].freeze
+  INDEX_OPERATORS = [:[], :[]=].freeze
 
   UNARY_METHOD_OPERATORS = [
     :~@, :+@, :-@, :'!'
@@ -78,7 +79,7 @@ module Mutant
     :xstr, :def, :defs, :case, :when, :ivar, :lvar, :cvar, :gvar,
     :back_ref, :const, :nth_ref, :class, :sclass, :yield,
     :match_with_lvasgn, :match_current_line, :irange, :erange,
-    :or_asgn, :kwbegin, :and_asgn
+    :or_asgn, :kwbegin, :and_asgn, :while
   ].to_set.freeze
 
 end # Mutant

data/lib/mutant/context.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   # An abstract context where mutations can be appied to.
   class Context

data/lib/mutant/context/scope.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   class Context
     # Scope context for mutation (Class or Module)
@@ -12,7 +14,7 @@ module Mutant
       # @api private
       #
       def root(node)
-        nesting.reverse.inject(node) do |current, scope|
+        nesting.reverse.reduce(node) do |current, scope|
           self.class.wrap(scope, current)
         end
       end

data/lib/mutant/differ.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   # Class to create diffs from source code
   class Differ
@@ -19,10 +21,16 @@ module Mutant
       when 0
         nil
       when 1
-        output = Diff::LCS::Hunk.new(old, new, diffs.first, max_length, 0).diff(:unified)
+        output =
+          Diff::LCS::Hunk.new(
+            old, new, diffs.first, max_length, 0
+          ).diff(:unified)
         output << "\n"
       else
-        $stderr.puts 'Mutation resulted in more than one diff, should not happen! PLS report a bug!'
+        $stderr.puts(
+          'Mutation resulted in more than one diff, should not happen! ' +
+          'PLS report a bug!'
+        )
         nil
       end
     end

data/lib/mutant/killer.rb

@@ -1,7 +1,10 @@
+# encoding: utf-8
+
 module Mutant
   # Abstract base class for mutant killers
   class Killer
-    include Adamantium::Flat, AbstractType, Equalizer.new(:strategy, :mutation, :killed?)
+    include Adamantium::Flat, AbstractType
+    include Equalizer.new(:strategy, :mutation, :killed?)
 
     # Return strategy
     #

data/lib/mutant/killer/forked.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   class Killer
 

data/lib/mutant/killer/forking.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   class Killer
 

data/lib/mutant/killer/rspec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   class Killer
     # Runner for rspec tests
@@ -19,8 +21,22 @@ module Mutant
         mutation.insert
         # TODO: replace with real streams from configuration
         require 'stringio'
-        null = StringIO.new
-        !::RSpec::Core::Runner.run(command_line_arguments, null, null).zero?
+        # Note: We assume interesting output from a failed rspec run is stderr.
+        rspec_err = StringIO.new
+
+        exit_code = ::RSpec::Core::Runner.run(cli_arguments, nil, rspec_err)
+
+        killed = !exit_code.zero?
+
+        if killed and mutation.should_survive?
+          rspec_err.rewind
+
+          puts "#{mutation.class} test failed."
+          puts 'RSpec stderr:'
+          puts rspec_err.read
+        end
+
+        killed
       end
 
       # Return command line arguments
@@ -29,7 +45,7 @@ module Mutant
       #
       # @api private
       #
-      def command_line_arguments
+      def cli_arguments
         %W(
           --fail-fast
         ) + strategy.spec_files(mutation.subject)

data/lib/mutant/killer/static.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   class Killer
     # Abstract base class for killer with static result

data/lib/mutant/loader.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   # Base class for code loaders
   class Loader
@@ -40,7 +42,12 @@ module Mutant
       # @api private
       #
       def run
-        eval(source, TOPLEVEL_BINDING, @subject.source_path.to_s, @subject.source_line)
+        eval(
+          source,
+          TOPLEVEL_BINDING,
+          @subject.source_path.to_s,
+          @subject.source_line
+        )
       end
 
       # Return source

data/lib/mutant/matcher.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   # Abstract matcher to find subjects to mutate
   class Matcher

data/lib/mutant/matcher/chain.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   class Matcher
     # A chain of matchers

data/lib/mutant/matcher/method.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   class Matcher
     # Matcher for subjects that are a specific method
@@ -6,7 +8,8 @@ module Mutant
 
       # Methods within rbx kernel directory are precompiled and their source
       # cannot be accessed via reading source location
-      BLACKLIST = %r(\A#{Regexp.union('kernel/', '(eval)')}).freeze
+      SKIP_METHODS = %w[kernel/ (eval)].freeze
+      BLACKLIST    = /\A#{Regexp.union(*SKIP_METHODS)}/.freeze
 
       # Enumerate matches
       #
@@ -25,7 +28,12 @@ module Mutant
           if subject
             yield subject
           else
-            $stderr.puts "Cannot find definition of: #{identification} in #{source_location.join(':')}"
+            message = sprintf(
+              'Cannot find definition of: %s in %s',
+              identification,
+              source_location.join(':')
+            )
+            $stderr.puts(message)
           end
         end
 
@@ -47,7 +55,11 @@ module Mutant
       def skip?
         location = source_location
         if location.nil? or BLACKLIST.match(location.first)
-          $stderr.puts "#{method.inspect} does not have valid source location so mutant is unable to emit matcher"
+          message = sprintf(
+            '%s does not have valid source location unable to emit matcher',
+            method.inspect
+          )
+          $stderr.puts(message)
           return true
         end
 

data/lib/mutant/matcher/method/finder.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   class Matcher
     class Method

data/lib/mutant/matcher/method/instance.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module Mutant
   class Matcher
     class Method
@@ -16,7 +18,8 @@ module Mutant
         # @api private
         #
         def self.build(cache, scope, method)
-          if scope.ancestors.include?(::Adamantium) and scope.memoized?(method.name)
+          name = method.name
+          if scope.ancestors.include?(::Adamantium) and scope.memoized?(name)
             return Memoized.new(cache, scope, method)
           end
           super