music_metadata_score 0.0.1 → 0.0.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ODhjMzM4ODU3YTFjOWU1NmExNjA4YWQ5YWFhNzU2MDllMjgwYzA1Nw==
+    MmI2MWM0YTY1ZGViNzc4ZmNhYTk0ZDYyYzNiM2JlYWVjNTlhOWE5ZA==
   data.tar.gz: !binary |-
-    NjcyYzU4YTA5NmI3Y2RmYmQwY2IzNjk2MzMwNWFkZGVkOTVmYzZmNw==
+    ZWZjMTM2OGFhMGRkMGNlMWQyMGQ4YjMyNjIzZDdjNTEyYjE5ZTFiNg==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    Y2MyMTAxMzAyMDY1YWJiNjdlNTQ3YWMzZGNiYTYzYWVhZmNkMGY5ZDNmNGUz
-    MzNhNTY5OWMwZDgwMTQzMjIyMjEwYTJmYzQ2YTRiODdkNjZmMDM5Mzc1ZWU3
-    MWVhMjc3NzRkMDk4NGZlYzgyNGFjM2FjOTA1OTc5YWIwMTgyZDM=
+    YmQ2Y2IzYWY0NjgyMjdiOTVkMjc5MGU1NTBkNGI5MGE0ZTc5NmM0YTg3MWI0
+    NDhlMWQwZmVhYTAxNjNlMTI1MGNiYzNhOTljZjM2YzE3MjBkNWI3MTRiNzk4
+    ZDAzOWNiYWU5MTllNmRiOGVhMGRkMDM5MWUzMDg3NDEzYWIxYWI=
   data.tar.gz: !binary |-
-    ZWMzZWRmNjg3YzA3ZjFiZDM0ZDRmMjNiYjY5MjRjNzRjY2RiMDVhMzE5ZjJi
-    NGQyYjA1ZjMwMmQyNDE4MGJkNTUyM2YwNWY1NGFlNjc4MTFlMzgyY2NkNzI3
-    OTUxMTczY2Y4NWY5YmI2NGVhODYzMDRlYTA4ODZmODE0ZmUwMWU=
+    NzhiZGMyOWIwNDA1MTk5MWRjNGVhNGVmYWQxZjQyNTUxMmM0ZWI3MzkyYmY3
+    MGU3NjUzMDViOWRmNTBiY2NkMjFhZTAwZGE5NTAxOWRlOTViOTRmMzliOWZi
+    NjJmMzcwYmM0NGQ1YmMyZGVhMzEzZTA4ZDNiM2IxMGY1OTk2ZWI=

data/lib/music_metadata_score/score.rb

@@ -1,5 +1,4 @@
 class Score
-	# Errors
 	
 	# Product level scores
 	def self.product_score(metadata)
@@ -178,7 +177,7 @@ class Score
 		corrected_metadata = Score.product_fields_corrected(metadata)
 		metadata.each do |m|
 			error = Score.missing_or_corrected(m[0].to_s, m[1], corrected_metadata[m[0]])
-			array << error if error
+			array << "Product " + error if error
 		end
 		array
 	end
@@ -205,14 +204,26 @@ class Score
 	end
 	
 	def self.missing_or_corrected(field, original, corrected)
-		if original && original != "" && original != [] || original == false
-			if original == corrected || corrected == ''
+		field = Score.format_field_name(field)
+		is_or_are = Score.is_or_are(field)
+			if original && original != "" && original != [] || original == false
+				if original == corrected || corrected == ''
+					nil
+				else
+					"#{field} #{is_or_are} incorrect. It should be #{corrected}"
+				end
+			elsif field == 'Version' || field == 'Featuring Artists'
 				nil
 			else
-				"#{Score.format_field_name(field)} is incorrect. It should be #{corrected}"
+				"#{field} #{is_or_are} missing"
 			end
+	end
+	
+	def self.is_or_are(field)
+		if field[field.length - 1].downcase == 's'
+			'are'
 		else
-			"#{Score.format_field_name(field)} is missing"
+			'is'
 		end
 	end
 	

data/lib/music_metadata_score/version.rb

@@ -1,3 +1,3 @@
 module MusicMetadataScore
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: music_metadata_score
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - tomallen400
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-18 00:00:00.000000000 Z
+date: 2013-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler