music-utils 0.5.0 → 0.5.1

data/CHANGELOG.md

@@ -1,17 +1,33 @@
-## 0.0.1 (March 23, 2011)
+## 0.5.1 (April 27, 2011)
 
 Features:
 
-  - First commit
-  
+  - Fixed compound intervals quality error
+
+
+## 0.5.0 (April 26, 2011)
+
+Features:
+
+  - Added short notation method
+
+
+## 0.4.0 (April 26, 2011)
+
+Features:
+
+  - Added support for notes alterations
+
+
 ## 0.3.20 (April 26, 2011)
 
 Features:
 
   - Added support to full diatonic scale in quality method
-  
-## 0.4.0 (April 26, 2011)
+
+
+## 0.0.1 (March 23, 2011)
 
 Features:
 
-  - Added support for notes alterations
+  - First commit

data/README.md

@@ -11,18 +11,25 @@ Simple intervals:
   * Interval.new('do', 'mi', 0).semitone  #=> 4 (semi-tones)
   * Interval.new('do', 'mi', 0).quality   #=> M (major)
   * Interval.new('do#', 'mi', 0).quality  #=> m (minor)
-  * Interval.new('do#', 'mi', 0).short    #=> m3 (minor 3th)
 
 Compound intervals:
   
   * Interval.new('do', 'mi', 1).number    #=> 10 (10th)
   * Interval.new('do', 'mi', 1).semitone  #=> 16 (semi-tones)
   * Interval.new('do', 'mi', 1).quality   #=> M (major)
+  * Interval.new('dob', 'mi#', 1).quality #=> AA (augmented plus)
+
+Short Notation:
+
+  * Interval.new('do', 're', 0).short     #=> M2
+  * Interval.new('do', 're', 1).short     #=> M9
+  * Interval.new('do#', 'mi', 0).short    #=> m3
+  * Interval.new('do#', 'mi', 1).short    #=> m10
 
 To Do
 -----
   * Add more rspec examples
-  * Fix compound intervals quality error
+  * Add validations (notes, alterations, etc) 
 
 Copyright
 ---------

data/lib/interval.rb

@@ -93,7 +93,9 @@ class Interval
   
   # Returns the quality of the interval
   def quality
-    QUALITIES[number][semitone]
+    s = ( @step > 0 and semitone - (12 * @step) ) || semitone
+    n = ( @step > 0 and number - (7 * @step) ) || number
+    QUALITIES[n][s]
   end
 
   # Returns the class interval in the short notation

data/music-utils.gemspec

@@ -2,9 +2,9 @@
 Gem::Specification.new do |s|
   # Basic Info
   s.name          = 'music-utils'
-  s.version       = '0.5.0'
+  s.version       = '0.5.1'
   s.summary       = 'music-utils'
-  s.description   = 'Utils for music'
+  s.description   = 'Utils for music. At the moment only one class to classify intervals.'
   s.platform      = Gem::Platform::RUBY
   s.authors       = ['Jorge Luis Pérez']
   s.email         = ['jorgeluis700@gmail.com']

data/spec/interval_spec.rb

@@ -57,15 +57,26 @@ describe Interval do
       i.quality.should == 'm'
     end
 
-    it "quality of interval dob-mi# should be AA" do
-      i = Interval.new('dob', 'mi#', 0)
-      i.quality.should == 'AA'
+    it "quality of interval do#-mi should be m" do
+      i = Interval.new('do#', 'mi', 0)
+      i.quality.should == 'm'
     end
-  
+
     it "quality of interval do-do should be P" do
       i = Interval.new('do', 'do', 0)
       i.quality.should == 'P'
     end
+
+    it "quality of compound interval dob-mi# should be AA" do
+      i = Interval.new('dob', 'mi#', 1)
+      i.quality.should == 'AA'
+    end
+  
+    it "quality of compound interval do-mi should be M" do
+      i = Interval.new('do', 'mi', 1)
+      i.quality.should == 'M'
+    end
+
   end
   
   context "Short Notation" do
@@ -74,10 +85,21 @@ describe Interval do
       i.short.should == 'M2'
     end
 
-    it "the short notation of do-re interval should be m3" do
+    it "the short notation of do-re compound interval should be M9" do
+      i = Interval.new('do', 're', 1)
+      i.short.should == 'M9'
+    end
+
+    it "the short notation of do#-mi interval should be m3" do
       i = Interval.new('do#', 'mi', 0)
       i.short.should == 'm3'
     end
+  
+    it "the short notation of do#-mi compound interval should be m10" do
+      i = Interval.new('do#', 'mi', 1)
+      i.short.should == 'm10'
+    end
+
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: music-utils
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2011-04-27 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &79625800 !ruby/object:Gem::Requirement
+  requirement: &23354172 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,8 +21,8 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *79625800
-description: Utils for music
+  version_requirements: *23354172
+description: Utils for music. At the moment only one class to classify intervals.
 email:
 - jorgeluis700@gmail.com
 executables: []
@@ -54,7 +54,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 557011027
+      hash: -794356655
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: